From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "jerinj@marvell.com" <jerinj@marvell.com>,
"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: nd <nd@arm.com>, "thomas@monjalon.net" <thomas@monjalon.net>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
"stable@dpdk.org" <stable@dpdk.org>, nd <nd@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] config: fix meson build failure on ThunderX2
Date: Mon, 15 Jul 2019 16:04:59 +0000 [thread overview]
Message-ID: <VE1PR08MB5149A2887B30B5107FA05C0998CF0@VE1PR08MB5149.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <BYAPR18MB2424062D38BB9799073CDF8FC8CF0@BYAPR18MB2424.namprd18.prod.outlook.com>
> >
> > > > Jerin, any reason for not enabling LSE on ThunderX2?
> > >
> > > LSE is enabled when -mcpu=thunderx2t99 selected.
> > >
> > > $ aarch64-linux-gnu-gcc -mcpu=thunderx2t99 -dM -E - </dev/null |
> > > grep __ARM_FEATURE_ATOMICS #define __ARM_FEATURE_ATOMICS 1
> >
> > This does not work with older GCC versions [1]. They need LSE enabled
> > explicitly.
> >
> > [1] https://godbolt.org/z/2nmASR
>
> Looks like, you have selected "armv8-a+crc" not "armv8.1-a+crc" in the godbolt.
> It comes properly with armv8.1-a+crc. Please check.
Yes, works fine. Thanks.
>
> >
> > >
> > > >
> > > > >
> > > > > Acked-by: Jerin Jacob <jerinj@marvell.com>
next prev parent reply other threads:[~2019-07-15 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 11:20 Jerin Jacob Kollanukkaran
2019-07-12 16:39 ` Honnappa Nagarahalli
2019-07-15 3:57 ` Jerin Jacob Kollanukkaran
2019-07-15 14:24 ` Honnappa Nagarahalli
2019-07-15 14:34 ` Jerin Jacob Kollanukkaran
2019-07-15 16:04 ` Honnappa Nagarahalli [this message]
2019-07-15 22:20 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2019-07-12 9:58 [dpdk-dev] " Gavin Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB5149A2887B30B5107FA05C0998CF0@VE1PR08MB5149.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Gavin.Hu@arm.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=pbhagavatula@marvell.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).