From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20067.outbound.protection.outlook.com [40.107.2.67]) by dpdk.org (Postfix) with ESMTP id E7F1111C5; Mon, 13 May 2019 21:26:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6asTzoXvKqozct6r0F652UwgsS/VCrvu1hbQzHXMjAk=; b=qNnDAsV4fhM3lpYdA7JS1Dm/AjCAlb69C//GI3EG3H9fb2cQ2kCBmXUJy0L92BdNf7xgWfGk6D/4CcpTV9R9ySw93GHvEBwD7e78FVzuPiDSm+dOYsJnpS45Ce+w2HYAw7AdDZX+Ku1liwai99mTsfcVSbZpazrsFNoY0vafh1o= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB5213.eurprd08.prod.outlook.com (10.255.159.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1878.22; Mon, 13 May 2019 19:26:55 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::f580:2129:8aa6:b534]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::f580:2129:8aa6:b534%4]) with mapi id 15.20.1878.024; Mon, 13 May 2019 19:26:55 +0000 From: Honnappa Nagarahalli To: "yskoh@mellanox.com" , "jerinj@marvell.com" , "thomas@monjalon.net" CC: "dev@dpdk.org" , "bruce.richardson@intel.com" , "pbhagavatula@marvell.com" , "shahafs@mellanox.com" , "Gavin Hu (Arm Technology China)" , "stable@dpdk.org" , Dharmik Thakkar , Honnappa Nagarahalli , nd , nd Thread-Topic: [PATCH v3] build: disable armv8 crypto extension Thread-Index: AQHVBRl9ds4mIXxa20+1HjbMG4xT6aZpeTJA Date: Mon, 13 May 2019 19:26:55 +0000 Message-ID: References: <20190502015806.41497-1-yskoh@mellanox.com> <20190507211140.43569-1-yskoh@mellanox.com> In-Reply-To: <20190507211140.43569-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1748f3e3-c6b9-47be-643d-08d6d7d8f5b1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB5213; x-ms-traffictypediagnostic: VE1PR08MB5213: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0036736630 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(396003)(366004)(346002)(376002)(39860400002)(189003)(199004)(6116002)(6436002)(52536014)(316002)(55016002)(229853002)(3846002)(9686003)(14454004)(256004)(14444005)(478600001)(2501003)(5660300002)(2906002)(25786009)(33656002)(53936002)(68736007)(72206003)(7736002)(71190400001)(99286004)(66476007)(476003)(2201001)(73956011)(4326008)(66946007)(54906003)(81166006)(486006)(66446008)(66556008)(110136005)(6506007)(64756008)(71200400001)(8676002)(8936002)(86362001)(81156014)(76116006)(6246003)(7696005)(76176011)(446003)(66066001)(11346002)(26005)(102836004)(305945005)(186003)(74316002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB5213; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 3/czvOtYI/vccaaP937sErlqx6fsrFGseBYgApv6Nf8KA/vg5R8NI1voY5KCWcLBX2lvo1d65y8qGCJehB8meGreI3YkD9cOKiK9ygnd5tTxKFusiupiRn26S7xnfyJCh9Z3zaxzaV9VJIaMcvJgS4WuU3wibDomjDT8Z0j6LARqLpqHQWnl/rw3GwjpmfSHuzQdTjr+IMNAfBz2R/xSHeMGFkd3ZolZ0B1EGXvJPONoHHzNQpUayPR4bKbNOqFJE0MVnkaerXqR8+p2YnWOtyuSeTF07PrFuHabPl1+c8efHxxz1ldZSpXiDLiKWOzaMdxWnZXso1zjJbdrKDvu1i+mgp2NuSAzLNSSN7/INl2SwKXQs+JiZy9ptLMUpi7vgSTFMSJfFbUoEwHHRDWacBT9SpTVjNvG4EqGyTF0N00= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1748f3e3-c6b9-47be-643d-08d6d7d8f5b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2019 19:26:55.2903 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5213 Subject: Re: [dpdk-dev] [PATCH v3] build: disable armv8 crypto extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 May 2019 19:26:57 -0000 >=20 > Per armv8 crypto extension support, make build always enable it by defaul= t as > long as compiler supports the feature while meson build only enables it f= or > 'default' machine of generic armv8 architecture. >=20 > It is known that not all the armv8 platforms have the crypto extension. F= or > example, Mellanox BlueField has a variant which doesn't have it. If crypt= o > enabled binary runs on such a platform, rte_eal_init() fails. >=20 > '+crypto' flag currently implies only '+aes' and '+sha2' and enabling it = will > generate the crypto instructions only when crypto intrinsics are used. > For the devices supporting 8.2 crypto or newer, compiler could generate s= uch > instructions beyond intrinsics or asm code. For example, compiler can gen= erate > 3-way exclusive OR instructions if sha3 is supported. However, it has to = be > enabled by adding '+sha3' as of today. >=20 > In DPDK, armv8 cryptodev is the only one which requires the crypto suppor= t. > As it even uses external library of Marvell which is compiled out of DPDK= with > crypto support and there's run-time check for required cpuflags, crypto > support can be disabled in DPDK. >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Yongseok Koh > Acked-by: Jerin Jacob > Tested-by: Dharmik Thakkar > --- >=20 > v3: > * announce removal of the flag in release note >=20 > v2: > * disable crypto support instead of having a build config >=20 > config/arm/meson.build | 2 +- > doc/guides/rel_notes/release_19_05.rst | 2 ++ > mk/machine/armv8a/rte.vars.mk | 2 +- > 3 files changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/config/arm/meson.build b/config/arm/meson.build index > 7fa6ed3105..abc8cf346c 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -74,7 +74,7 @@ flags_octeontx2_extra =3D [ > ['RTE_USE_C11_MEM_MODEL', true]] >=20 > machine_args_generic =3D [ > - ['default', ['-march=3Darmv8-a+crc+crypto']], > + ['default', ['-march=3Darmv8-a+crc']], > ['native', ['-march=3Dnative']], > ['0xd03', ['-mcpu=3Dcortex-a53']], > ['0xd04', ['-mcpu=3Dcortex-a35']], > diff --git a/doc/guides/rel_notes/release_19_05.rst > b/doc/guides/rel_notes/release_19_05.rst > index 5044ac7df1..0d35f25094 100644 > --- a/doc/guides/rel_notes/release_19_05.rst > +++ b/doc/guides/rel_notes/release_19_05.rst > @@ -234,6 +234,8 @@ Removed Items > Also, make sure to start the actual text at the margin. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > +* build: armv8 crypto extension is disabled. > + >=20 > API Changes > ----------- > diff --git a/mk/machine/armv8a/rte.vars.mk > b/mk/machine/armv8a/rte.vars.mk index 8252efbb7b..5e3ffc3adf 100644 > --- a/mk/machine/armv8a/rte.vars.mk > +++ b/mk/machine/armv8a/rte.vars.mk > @@ -28,4 +28,4 @@ > # CPU_LDFLAGS =3D > # CPU_ASFLAGS =3D >=20 > -MACHINE_CFLAGS +=3D -march=3Darmv8-a+crc+crypto > +MACHINE_CFLAGS +=3D -march=3Darmv8-a+crc > -- > 2.21.0 Reviewed-by: Honnappa Nagarahalli From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 14603A00E6 for ; Mon, 13 May 2019 21:26:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B8122BCE; Mon, 13 May 2019 21:26:58 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20067.outbound.protection.outlook.com [40.107.2.67]) by dpdk.org (Postfix) with ESMTP id E7F1111C5; Mon, 13 May 2019 21:26:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6asTzoXvKqozct6r0F652UwgsS/VCrvu1hbQzHXMjAk=; b=qNnDAsV4fhM3lpYdA7JS1Dm/AjCAlb69C//GI3EG3H9fb2cQ2kCBmXUJy0L92BdNf7xgWfGk6D/4CcpTV9R9ySw93GHvEBwD7e78FVzuPiDSm+dOYsJnpS45Ce+w2HYAw7AdDZX+Ku1liwai99mTsfcVSbZpazrsFNoY0vafh1o= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB5213.eurprd08.prod.outlook.com (10.255.159.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1878.22; Mon, 13 May 2019 19:26:55 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::f580:2129:8aa6:b534]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::f580:2129:8aa6:b534%4]) with mapi id 15.20.1878.024; Mon, 13 May 2019 19:26:55 +0000 From: Honnappa Nagarahalli To: "yskoh@mellanox.com" , "jerinj@marvell.com" , "thomas@monjalon.net" CC: "dev@dpdk.org" , "bruce.richardson@intel.com" , "pbhagavatula@marvell.com" , "shahafs@mellanox.com" , "Gavin Hu (Arm Technology China)" , "stable@dpdk.org" , Dharmik Thakkar , Honnappa Nagarahalli , nd , nd Thread-Topic: [PATCH v3] build: disable armv8 crypto extension Thread-Index: AQHVBRl9ds4mIXxa20+1HjbMG4xT6aZpeTJA Date: Mon, 13 May 2019 19:26:55 +0000 Message-ID: References: <20190502015806.41497-1-yskoh@mellanox.com> <20190507211140.43569-1-yskoh@mellanox.com> In-Reply-To: <20190507211140.43569-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1748f3e3-c6b9-47be-643d-08d6d7d8f5b1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB5213; x-ms-traffictypediagnostic: VE1PR08MB5213: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0036736630 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(396003)(366004)(346002)(376002)(39860400002)(189003)(199004)(6116002)(6436002)(52536014)(316002)(55016002)(229853002)(3846002)(9686003)(14454004)(256004)(14444005)(478600001)(2501003)(5660300002)(2906002)(25786009)(33656002)(53936002)(68736007)(72206003)(7736002)(71190400001)(99286004)(66476007)(476003)(2201001)(73956011)(4326008)(66946007)(54906003)(81166006)(486006)(66446008)(66556008)(110136005)(6506007)(64756008)(71200400001)(8676002)(8936002)(86362001)(81156014)(76116006)(6246003)(7696005)(76176011)(446003)(66066001)(11346002)(26005)(102836004)(305945005)(186003)(74316002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB5213; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 3/czvOtYI/vccaaP937sErlqx6fsrFGseBYgApv6Nf8KA/vg5R8NI1voY5KCWcLBX2lvo1d65y8qGCJehB8meGreI3YkD9cOKiK9ygnd5tTxKFusiupiRn26S7xnfyJCh9Z3zaxzaV9VJIaMcvJgS4WuU3wibDomjDT8Z0j6LARqLpqHQWnl/rw3GwjpmfSHuzQdTjr+IMNAfBz2R/xSHeMGFkd3ZolZ0B1EGXvJPONoHHzNQpUayPR4bKbNOqFJE0MVnkaerXqR8+p2YnWOtyuSeTF07PrFuHabPl1+c8efHxxz1ldZSpXiDLiKWOzaMdxWnZXso1zjJbdrKDvu1i+mgp2NuSAzLNSSN7/INl2SwKXQs+JiZy9ptLMUpi7vgSTFMSJfFbUoEwHHRDWacBT9SpTVjNvG4EqGyTF0N00= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1748f3e3-c6b9-47be-643d-08d6d7d8f5b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2019 19:26:55.2903 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5213 Subject: Re: [dpdk-dev] [PATCH v3] build: disable armv8 crypto extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190513192655.HEi00ViubTvJDnNcE_YEnDwDi6YEYVcqmCwzMDxNics@z> >=20 > Per armv8 crypto extension support, make build always enable it by defaul= t as > long as compiler supports the feature while meson build only enables it f= or > 'default' machine of generic armv8 architecture. >=20 > It is known that not all the armv8 platforms have the crypto extension. F= or > example, Mellanox BlueField has a variant which doesn't have it. If crypt= o > enabled binary runs on such a platform, rte_eal_init() fails. >=20 > '+crypto' flag currently implies only '+aes' and '+sha2' and enabling it = will > generate the crypto instructions only when crypto intrinsics are used. > For the devices supporting 8.2 crypto or newer, compiler could generate s= uch > instructions beyond intrinsics or asm code. For example, compiler can gen= erate > 3-way exclusive OR instructions if sha3 is supported. However, it has to = be > enabled by adding '+sha3' as of today. >=20 > In DPDK, armv8 cryptodev is the only one which requires the crypto suppor= t. > As it even uses external library of Marvell which is compiled out of DPDK= with > crypto support and there's run-time check for required cpuflags, crypto > support can be disabled in DPDK. >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Yongseok Koh > Acked-by: Jerin Jacob > Tested-by: Dharmik Thakkar > --- >=20 > v3: > * announce removal of the flag in release note >=20 > v2: > * disable crypto support instead of having a build config >=20 > config/arm/meson.build | 2 +- > doc/guides/rel_notes/release_19_05.rst | 2 ++ > mk/machine/armv8a/rte.vars.mk | 2 +- > 3 files changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/config/arm/meson.build b/config/arm/meson.build index > 7fa6ed3105..abc8cf346c 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -74,7 +74,7 @@ flags_octeontx2_extra =3D [ > ['RTE_USE_C11_MEM_MODEL', true]] >=20 > machine_args_generic =3D [ > - ['default', ['-march=3Darmv8-a+crc+crypto']], > + ['default', ['-march=3Darmv8-a+crc']], > ['native', ['-march=3Dnative']], > ['0xd03', ['-mcpu=3Dcortex-a53']], > ['0xd04', ['-mcpu=3Dcortex-a35']], > diff --git a/doc/guides/rel_notes/release_19_05.rst > b/doc/guides/rel_notes/release_19_05.rst > index 5044ac7df1..0d35f25094 100644 > --- a/doc/guides/rel_notes/release_19_05.rst > +++ b/doc/guides/rel_notes/release_19_05.rst > @@ -234,6 +234,8 @@ Removed Items > Also, make sure to start the actual text at the margin. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > +* build: armv8 crypto extension is disabled. > + >=20 > API Changes > ----------- > diff --git a/mk/machine/armv8a/rte.vars.mk > b/mk/machine/armv8a/rte.vars.mk index 8252efbb7b..5e3ffc3adf 100644 > --- a/mk/machine/armv8a/rte.vars.mk > +++ b/mk/machine/armv8a/rte.vars.mk > @@ -28,4 +28,4 @@ > # CPU_LDFLAGS =3D > # CPU_ASFLAGS =3D >=20 > -MACHINE_CFLAGS +=3D -march=3Darmv8-a+crc+crypto > +MACHINE_CFLAGS +=3D -march=3Darmv8-a+crc > -- > 2.21.0 Reviewed-by: Honnappa Nagarahalli