From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A4E0A2EEB for ; Wed, 11 Sep 2019 07:38:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6378A1EB38; Wed, 11 Sep 2019 07:38:44 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10085.outbound.protection.outlook.com [40.107.1.85]) by dpdk.org (Postfix) with ESMTP id 6D6C21EB36 for ; Wed, 11 Sep 2019 07:38:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ATNktioodJXqT8yx2NxHrUO2EexPxi1pWvsKyhkdzhU=; b=vlfHUo3jxReUx77FVPfJIkKlFRldaIk1NibYK4KIARxJYec9b8/B5cgZ5HdXC9rZzC11Oy2wA4ryu4Z1T78qCmoU4Szd5mroOTOsR8DErKHM4/pfQkEUa38qwfcmw3+h0TZ3aGGHSk/ofjEK83n/q0WcPNXjKOhKxtLBcRweTx0= Received: from VI1PR08CA0272.eurprd08.prod.outlook.com (2603:10a6:803:dc::45) by AM6PR08MB3110.eurprd08.prod.outlook.com (2603:10a6:209:45::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.18; Wed, 11 Sep 2019 05:38:39 +0000 Received: from VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::203) by VI1PR08CA0272.outlook.office365.com (2603:10a6:803:dc::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.14 via Frontend Transport; Wed, 11 Sep 2019 05:38:39 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT005.mail.protection.outlook.com (10.152.18.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.14 via Frontend Transport; Wed, 11 Sep 2019 05:38:38 +0000 Received: ("Tessian outbound d77f7b4e3be1:v29"); Wed, 11 Sep 2019 05:38:35 +0000 X-CR-MTA-TID: 64aa7808 Received: from 7e613c523ec5.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.0.53]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 39365083-E637-4733-88F1-12F03B092A97.1; Wed, 11 Sep 2019 05:38:30 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2053.outbound.protection.outlook.com [104.47.0.53]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7e613c523ec5.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 Sep 2019 05:38:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jsthXFhsP/31kJsZ7ZPa7nlKcATjhaDSltP7+C5V2lYROlnBWM/NqhXqU4xQh07e7oqj+t1tdspl8hscgBl7HX9RyxQZ86jqjMUbfTQ2TUE7QaDAYa3nPAcBKUpk1sQpI1z3qw6y6RYPPpG3VWXY8p8C1DWAbwJsVEF8GlMuE/d5in64/w44nQyXpJXksiuSswLNGZ6M0pqfE2dcjYHek0s3q3tPJ0/7SDwNTcJcudsL3dSbot3IQ+mt5F71jMjm2e3L5Zia3i4FANXYQfipADXG/DUqfLTowkCWoghqzghiS6I1w5UJcDgnEaryI2U9LTUSYhBVYcZm/W6SCr144Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ATNktioodJXqT8yx2NxHrUO2EexPxi1pWvsKyhkdzhU=; b=XtRBOWbXRLACJ+3kFURNkU7eoMFTTexc++OLROmADC3qDKXFrGxpGfdWkePkRLlsmbfnIxWj0+I3qEueL//7vruwlEiuZjCGOR+hJd1NJhVcu3QiW/4Nl65TVtzXdA8AjfbbkuidaQ+Xk/J/lpZL5WznmFe79F4e5VDnQNzatqqKkEZ0bWs57LXQfK1KVKJJ7eVYxKMnHaGcL/7l9512Kp9Ih+4GSj+Sj46qymgFt36vIY1/PAvmFQBlBROWf+pYVOflklpFlict56sotG3gsvP/PnKY8R5LvuHZdRHVDIsb5b7mzVQh3Lq5qertzs3cPO7qq0CHkj5jCRf+8EYEpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ATNktioodJXqT8yx2NxHrUO2EexPxi1pWvsKyhkdzhU=; b=vlfHUo3jxReUx77FVPfJIkKlFRldaIk1NibYK4KIARxJYec9b8/B5cgZ5HdXC9rZzC11Oy2wA4ryu4Z1T78qCmoU4Szd5mroOTOsR8DErKHM4/pfQkEUa38qwfcmw3+h0TZ3aGGHSk/ofjEK83n/q0WcPNXjKOhKxtLBcRweTx0= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1SPR01MB0011.eurprd08.prod.outlook.com (20.179.235.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.18; Wed, 11 Sep 2019 05:38:26 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::5050:1354:f0bd:4b92]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::5050:1354:f0bd:4b92%7]) with mapi id 15.20.2241.018; Wed, 11 Sep 2019 05:38:26 +0000 From: Honnappa Nagarahalli To: "Ruifeng Wang (Arm Technology China)" , "Ananyev, Konstantin" , "Kantecki, Tomasz" CC: "dev@dpdk.org" , "Gavin Hu (Arm Technology China)" , Honnappa Nagarahalli , nd , nd Thread-Topic: [dpdk-dev] [PATCH 0/2] add lock-free mode for l3fwd Thread-Index: AQHVZJ2Q1XHMMc8yV0CKKz3cRmji26cecv3ggAQVfgCAAhqkwIAAD7OAgAFI9qA= Date: Wed, 11 Sep 2019 05:38:26 +0000 Message-ID: References: <20190906102615.36942-1-ruifeng.wang@arm.com> <2601191342CEEE43887BDE71AB977258019192657B@irsmsx105.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258019196218E@irsmsx105.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 8013a124-60e9-422d-8181-ceab7118001b.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: a21a66eb-816f-4e4e-9d6d-08d7367a4bcd X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1SPR01MB0011; X-MS-TrafficTypeDiagnostic: VE1SPR01MB0011:|VE1SPR01MB0011:|AM6PR08MB3110: X-MS-Exchange-PUrlCount: 1 x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:1728;OLM:1728; x-forefront-prvs: 0157DEB61B X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(366004)(396003)(346002)(39860400002)(189003)(199004)(11346002)(229853002)(55016002)(9686003)(446003)(3846002)(6306002)(966005)(14454004)(478600001)(74316002)(71190400001)(71200400001)(305945005)(64756008)(81166006)(8936002)(8676002)(81156014)(14444005)(66556008)(5660300002)(53936002)(66476007)(52536014)(6436002)(66946007)(256004)(66446008)(25786009)(2906002)(7736002)(486006)(86362001)(7696005)(476003)(99286004)(4326008)(6246003)(54906003)(76176011)(26005)(6506007)(102836004)(110136005)(76116006)(316002)(186003)(33656002)(66066001)(6116002)(32563001); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1SPR01MB0011; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: lT3SjXuhrMKc+DL1XXE7/FOv4g5lozzuHCTzPFmOnOHza5pG7WYeB03CPM/0Zmy0492GoDqdpPeV7WRhQze136zP2SUfOdPBbDfWYPoHqugF+0+fDHVbFTVzioxbPJ77rYSgWVUH94kb83UblZHflQaVMQayTw5iSHsg5cXUDSZzSY6xfvF2cjSkmy77zde4bVmi+5nh3vcdoQxdZmkUymaWrk0BJQFCqkAsL3jbeC/S3iPVcUZH2leZdy2wnYExmZT9UTFlgjqVac+JXINGyWzemB7Y6TZHOdNpAQCblvtsfOFHKhb8NrudxZe+3L9ph7a4OFBWqeTpGHzvsGFkYxigZu1t8Z1z2n/c6Fk2I/r9Kb9LtcxyDJPerGTHXubHSHV0MpfQhPYxC+RY0lWHZAMr7FK0IUUuNxr9lTU27o4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1SPR01MB0011 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(396003)(39860400002)(136003)(376002)(346002)(189003)(199004)(966005)(97756001)(70586007)(336012)(446003)(11346002)(63350400001)(63370400001)(126002)(70206006)(33656002)(74316002)(26826003)(26005)(22756006)(476003)(186003)(305945005)(7736002)(50466002)(7696005)(46406003)(14454004)(229853002)(316002)(99286004)(356004)(110136005)(54906003)(36906005)(14444005)(6116002)(3846002)(86362001)(76176011)(9686003)(23726003)(52536014)(66066001)(47776003)(76130400001)(4326008)(81156014)(8676002)(6246003)(486006)(5660300002)(2906002)(478600001)(8936002)(8746002)(81166006)(25786009)(55016002)(6506007)(6306002)(102836004)(32563001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3110; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 84a8f059-dccd-45f8-bc56-08d7367a44d3 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(710020)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM6PR08MB3110; NoDisclaimer: True X-Forefront-PRVS: 0157DEB61B X-Microsoft-Antispam-Message-Info: ZFYDaOMBwHGepb5FCUWdzNkx16Jw/y1QIYTFTnIWGia4FauGa1OiVPPExS826uI0Aahdxy4dEK8EnatimrSSQspyKdSKOzCfhkUu1j7CY1UBRc8VApLr+rS1i2yXMMeg+460cwE68yUfPYtORfZzOn5MC48Mzrbg3I1PsiAVT00D/4HZTZbtymjU1fBBdSXpKEQZt3x1fO5Hd4eU3BZ564XjCwfC5Q2PE0Ay+aPen2Wi7FqgqhtCGuOYvOYBv8EAm27M3DGYxQlfQI498Gd1palQPvh2fnEfjEbWANOrYQgxcl6OzxyCkobIMAc8e5b3iHp9DR4pm83gYJ1FfH/jEslHfp3r6lvBfKfNpDkVWAWus/FYAwM3mPPSN2QpYtzWLo93bVtx5jtBhYU/ruGQBmuVixQTf3gmym+HhjzxePw= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2019 05:38:38.0710 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a21a66eb-816f-4e4e-9d6d-08d7367a4bcd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3110 Subject: Re: [dpdk-dev] [PATCH 0/2] add lock-free mode for l3fwd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > > > > > > > > > > > > > > > Lock-free mode is supported by hash library and LPM library. > > > > > Now we add an option for l3fwd example to enable the lock-free > mode. > > > > > Necessary preparation steps are added to use lock-free LPM mode. > > > > > > > > Can I ask about the purpose of these changes? > > > > Right now in l3fwd both lpm and hash tables are static and hard-co= ded. > > > > we initialize them at startup and then just do read from them. > > > > Do you plan to enhance l3fwd with ability to dynamically update > > > > tables contents? > > > > Though fir that we first have to get rid of hard-coded values > > > > (config file or > > so). > > > > Konstantin > > > > > > > Thanks for your questions. > > > Currently, we have no plan to enhance l3fwd with ability to > > > dynamically > > update table contents. > > > Lock-free method is being integrated into Hash library and LPM > > > library. Lock-free algorithms are not only about control plane > > > (adding or deleting routes), they affect the data path performance as= well. > > > Since l3fwd application is showcasing data path performance, we need > > > to show the impact of including the quiescent state reporting on data > path. > > > This change also serves as an example of using the RCU APIs. > > > > > > But what you suggest doesn't provide the complete picture. > > With dynamic updates in place (via control path) the data-path impact > > might be completely different then without. > > Again without dynamic updates how can you test that your data-path > > lock- free approach does work as expected? > > Also it can't even be used as a reference implementation for users, as > > half of the functionality they need to implement is simply missing. > > My opinion - we either need to leave l3fwd as it is (static routes), > > or implement a proper control path with ability to dynamically update > > routes before starting to introduce some synchronization schemes (RCU > > or whatever). > > > > Konstantin > > >=20 > Agree that dynamic control path updates should be included for a whole > picture. > I will add dynamic update to l3fwd and reroll the patch series. > Thanks. I think we should have an agreement on what exactly we mean by 'dynamically= update routes'. IMO, we should not disturb the existing static routes as there might be aut= omated tests running in the labs. I suggest that we should add/delete new r= outes/hash entries which are different from the existing routes/hash entrie= s. This should be sufficient to showcase the functionality as well as measu= re the impact. >=20 > > > > > > > > > > > > > Patch 2/2 has dependency on RCU QSBR integration with LPM library= : > > > > > http://patches.dpdk.org/project/dpdk/list/?series=3D6288 > > > > > > > > > > > > > > > Ruifeng Wang (2): > > > > > examples/l3fwd: add lock-free option for l3fwd > > > > > examples/l3fwd: integrate RCU QSBR for LPM mode > > > > > > > > > > doc/guides/sample_app_ug/l3_forward.rst | 3 ++ > > > > > examples/l3fwd/Makefile | 1 + > > > > > examples/l3fwd/l3fwd.h | 4 +- > > > > > examples/l3fwd/l3fwd_em.c | 10 +++- > > > > > examples/l3fwd/l3fwd_lpm.c | 72 > > +++++++++++++++++++++++-- > > > > > examples/l3fwd/main.c | 27 ++++++++-- > > > > > examples/l3fwd/meson.build | 1 + > > > > > 7 files changed, 108 insertions(+), 10 deletions(-) > > > > > > > > > > -- > > > > > 2.17.1 >=20