From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "Ruifeng Wang (Arm Technology China)" <Ruifeng.Wang@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
"Ruifeng Wang (Arm Technology China)" <Ruifeng.Wang@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v1] test/rcu: remove redundant header file
Date: Wed, 24 Jul 2019 18:01:57 +0000 [thread overview]
Message-ID: <VE1PR08MB5149EDE1A496D4178578919298C60@VE1PR08MB5149.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20190724032538.45318-1-ruifeng.wang@arm.com>
>
> RCU library now includes stdbool.h header itself.
> There is no need to include this header file in RCU user files.
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
> app/test/test_rcu_qsbr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c index
> 1d273e39d..d1b9e46a2 100644
> --- a/app/test/test_rcu_qsbr.c
> +++ b/app/test/test_rcu_qsbr.c
> @@ -3,7 +3,6 @@
> */
>
> #include <stdio.h>
> -#include <stdbool.h>
> #include <rte_pause.h>
> #include <rte_rcu_qsbr.h>
> #include <rte_hash.h>
> --
> 2.17.1
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
next prev parent reply other threads:[~2019-07-24 18:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 3:25 Ruifeng Wang
2019-07-24 18:01 ` Honnappa Nagarahalli [this message]
2019-07-30 9:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB5149EDE1A496D4178578919298C60@VE1PR08MB5149.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).