From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <shreyansh.jain@nxp.com>
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01on0049.outbound.protection.outlook.com [104.47.1.49])
 by dpdk.org (Postfix) with ESMTP id 2D1C62E8A
 for <dev@dpdk.org>; Wed, 12 Apr 2017 12:33:27 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; 
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
 bh=CYoRmT6vzLxx7iSGbSeX3DkBvtCPxUHUq4QvkY5naX0=;
 b=HAw8OV5UhLr5SwN9M+NKQELZhtbzF3Q0vbjI67t3JQulL3IflB8XNYgE/lLjYCJ/imEr4KfaI3QPLCWK8wCgTCil6ecGaFjEpDKHoudrxMRv4tVqB+XBQRpdquIpIhdAv/TfqcGXj0HNlG6DBToMPU3k07ox8QrlLy9uaU2aq2k=
Received: from VI1PR0401MB2464.eurprd04.prod.outlook.com (10.168.64.147) by
 VI1PR0401MB2463.eurprd04.prod.outlook.com (10.168.64.146) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id
 15.1.1019.17; Wed, 12 Apr 2017 10:33:26 +0000
Received: from VI1PR0401MB2464.eurprd04.prod.outlook.com ([10.168.64.147]) by
 VI1PR0401MB2464.eurprd04.prod.outlook.com ([10.168.64.147]) with
 mapi id 15.01.1019.025; Wed, 12 Apr 2017 10:33:26 +0000
From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Bruce Richardson <bruce.richardson@intel.com>
CC: Thomas Monjalon <thomas.monjalon@6wind.com>, john miller
 <john.miller@atomicrules.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>
Thread-Topic: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y
Thread-Index: AQHSsvnI2e0Pji/1mkmkConF81MA66HBKgfwgABYnQCAAATLkIAAAhIg
Date: Wed, 12 Apr 2017 10:33:10 +0000
Deferred-Delivery: Wed, 12 Apr 2017 10:33:07 +0000
Message-ID: <VI1PR0401MB246422DBE171F0679E6710ED90030@VI1PR0401MB2464.eurprd04.prod.outlook.com>
References: <357262EF-AA7B-4064-963E-FF130E4607E6@atomicrules.com>
 <1675520.qVeAGBHxLM@xps13>
 <VI1PR0401MB24648F856D8A44B843D68AC990030@VI1PR0401MB2464.eurprd04.prod.outlook.com>
 <20170412100521.GB20092@bricha3-MOBL3.ger.corp.intel.com>
 <VI1PR0401MB24643FF1ED8BDD7E10E1488990030@VI1PR0401MB2464.eurprd04.prod.outlook.com>
In-Reply-To: <VI1PR0401MB24643FF1ED8BDD7E10E1488990030@VI1PR0401MB2464.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: intel.com; dkim=none (message not signed)
 header.d=none;intel.com; dmarc=none action=none header.from=nxp.com;
x-originating-ip: [192.88.169.1]
x-microsoft-exchange-diagnostics: 1; VI1PR0401MB2463;
 7:Xi5s+3NjhsYlT078cpZjij3IxNyUj4IqKYgKP5gnEwelrorE7mDJNm5VUITpRsm0+bnaE5AZkxIKR9kBs17K0+bg+bZeN+4TY4UxTeiwZwoET3CclNW7b2511rlA7dFzBGsBVAa0Ivepwusx6oaHNwZAK/FpaYDvxjtHjtzJLaP6ETmI/RfuWjS/E06DKeQyS4TlXP2gF3OZxj5uO5PdO09nj1Jb2Nv/keTNhWNDhDe+lKXgAVSfHDgack0DtT2vu5PAIXyQQCcHxcTUZlRePo8fyjjFcOO1BVoIiBxdgbeTTctGJfJewxGfSi4LS43QzWSBtg57AjE7leDutbPV2A==
x-ms-office365-filtering-correlation-id: d98cb028-f814-48b3-41b0-08d4818f5a78
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0;
 RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);
 SRVR:VI1PR0401MB2463; 
x-microsoft-antispam-prvs: <VI1PR0401MB2463B2741791F81D521D84C790030@VI1PR0401MB2463.eurprd04.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0;
 RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(6072148);
 SRVR:VI1PR0401MB2463; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0401MB2463; 
x-forefront-prvs: 027578BB13
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(6009001)(39450400003)(39860400002)(39840400002)(39410400002)(39850400002)(39400400002)(24454002)(377424004)(13464003)(377454003)(229853002)(54906002)(86362001)(110136004)(38730400002)(55016002)(6666003)(33656002)(3280700002)(99286003)(2900100001)(7696004)(8676002)(3660700001)(8936002)(77096006)(6436002)(2950100002)(81166006)(6506006)(2906002)(6916009)(102836003)(3846002)(53546009)(74316002)(6246003)(54356999)(305945005)(25786009)(76176999)(7736002)(4326008)(50986999)(53936002)(5660300001)(189998001)(122556002)(6116002)(66066001);
 DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0401MB2463;
 H:VI1PR0401MB2464.eurprd04.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en;
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2017 10:33:26.1677 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2463
Subject: Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Apr 2017 10:33:28 -0000

My bad - I was too quick in replying - some clarification beneath.

> -----Original Message-----
> From: Shreyansh Jain
> Sent: Wednesday, April 12, 2017 3:55 PM
> To: 'Bruce Richardson' <bruce.richardson@intel.com>
> Cc: Thomas Monjalon <thomas.monjalon@6wind.com>; john miller
> <john.miller@atomicrules.com>; dev@dpdk.org; olivier.matz@6wind.com
> Subject: RE: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=
=3Dy
>=20
> > -----Original Message-----
> > From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> > Sent: Wednesday, April 12, 2017 3:35 PM
> > To: Shreyansh Jain <shreyansh.jain@nxp.com>
> > Cc: Thomas Monjalon <thomas.monjalon@6wind.com>; john miller
> > <john.miller@atomicrules.com>; dev@dpdk.org; olivier.matz@6wind.com
> > Subject: Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_L=
IB=3Dy
> >
> > On Wed, Apr 12, 2017 at 04:52:47AM +0000, Shreyansh Jain wrote:
> > > > -----Original Message-----
> > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > > Sent: Wednesday, April 12, 2017 12:58 AM
> > > > To: john miller <john.miller@atomicrules.com>
> > > > Cc: dev@dpdk.org; olivier.matz@6wind.com; Shreyansh Jain
> > > > <shreyansh.jain@nxp.com>
> > > > Subject: Re: [dpdk-dev] error in testpmd when
> > CONFIG_RTE_BUILD_SHARED_LIB=3Dy
> > > >
> > > > 2017-04-11 14:02, john miller:
> > > > >
> > > > > We are seeing an issue when running from the head of the master
> branch
> > in
> > > > dpdk-next-net and building with CONFIG_RTE_BUILD_SHARED_LIB=3Dy.   =
When
> we
> > run
> > > > testpmd using  -d to point to our PMD we get this error
> > > > >
> > > > > EAL: Error - exiting with code: 1
> > > > >   Cause: Creation of mbuf pool for socket 0 failed: Invalid argum=
ent
> > > > >
> > > > > This error occurs as a result of the rte mempool ops table having=
 0
> > > > entries.  This table is populated from a call to
> > rte_mempool_register_ops().
> > > > This function gets called in rte_mempool_ring.c via the static
> > initialization
> > > > MACRO MEMPOOL_REGISTER_OPS and exists in librte_mempool_ring.so.
> However
> > > > this library is not loaded when the rte_eal_init() gets called so t=
he
> > static
> > > > initializers are not yet loaded.
> > > > >
> > > > > I am requesting advice on the proper way to repair this.
> > >
> > > "-d" the ring library (rte_mempool_ring) - just like any other shared
> lib.
> > >
> >
> > I think this is a bug that should be fixed. The user should not need to
> > have to specify a mempool driver just to get testpmd working, so I thin=
k
> > the ring handler as default should be compiled in automatically so as t=
o
> > allow regular mempools to just work as before.
>=20
> For Ring Mempool as default enabled, +1
=20
Actually, Ring mempool is enabled by default. But, obviously for shared lib=
rary case, this still means "-d".

>=20
> >
> > > This change was done recently to move ring handler into its separate
> > drivers/mempool/ring directory. That also means it no longer is compile=
d
> into
> > the librte_mempool.
> > >
> > > >
> > > > We should just add a better error message if no mempool driver is
> > available.
> > >
> > > Yes, that is something to be improved.
> >
> > This should be fixed by always having a mempool driver installed.
>=20
> Agree.
=20
Probably, as ring mempool is a driver and compiled in shared mode, enabled =
by default will not fix this.

> Otherwise also, the framework seems to be replying with a valid code 'EIN=
VAL'
> for an invalid mempool specified.
>=20
> >
> > /Bruce