From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6147EA0577; Tue, 7 Apr 2020 12:25:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 33A812B96; Tue, 7 Apr 2020 12:25:03 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2056.outbound.protection.outlook.com [40.107.20.56]) by dpdk.org (Postfix) with ESMTP id 3D4482B96 for ; Tue, 7 Apr 2020 12:25:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dPW3yUf9jI+xME/r0W5XPR34Mh/PXAUKiuHk/tgMg8OERuXnGqaKWYUOmzfY2BpDttX00eVqE2bPZkMscYdlZ3YwNwpSqfFF4+UeJMERhNR3WiyThHAVEfmOPnwUcWnKwZr4gf0wtAetLMO47qPAezSd0aSLqN+Oyx67K8rOeyNAYRkng5mlEz91G6/k8jRENVqN9VnkmXxxZWP2gnyJbw5ak61n4IMarrj11QteOIuZa+zzCu+TgFAOORtL85jwqmw/DxHu32p4Mrz+f5MiAfXBTwLpBqk3LWcRpzYkIR0+ca9t83HmchO2huvvtB5FxDPPI+VEQkNLb5kN76gvdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p85bEmuQgUzx2lmD2lrbCeie6m/j3uOc1q91YfYp/5c=; b=m1NSBTl2N6iHI4UO34Fh9wiNewyBuTLgiSAD/tTLqMapB23hyQC29S+CS/eph7jbztz5BsMb9FEWTuZRxRLHkiObe/jtBHpTvuqYul9qJnmGwDHS6A1pAOHrCM+ACJXixgqBq5XZ4veFW+BjIyUl2sPmEL8MPnR7+/2STlkwmhUUU+uLtdn99HwLxhG4UAXPjiI3u5IahhfSoKdnnj+JXQPgNBRsmOd0Hcptn44n8LB4Q7QsiQZtlxFUieqbcW45LwFpvHQCe6JcmpbT7JG7TiMWkNMGoUxJLc2ytHYstlUfeYRyP1ohQCD+vO4qLzhGvzM+cgj8zHJClxOv7GjsNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p85bEmuQgUzx2lmD2lrbCeie6m/j3uOc1q91YfYp/5c=; b=BjSStfwdej1sMNm0HkGmU5y6jPw24SFrxlrXYwVXuQBNToGOUe4V7JF/tiTMSeG8X3z0baow2AW+3lXWgmyw9+DPfxe7OUeKUzdGOP/+ycJ4vjNeW9IxSC7KhAaymzE7SpSzfcdY0byMCitBaazIYS+9I96u2tgG2AVwnG+99Oc= Received: from VI1PR0401MB2541.eurprd04.prod.outlook.com (2603:10a6:800:51::11) by VI1PR0401MB2608.eurprd04.prod.outlook.com (2603:10a6:800:4f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.19; Tue, 7 Apr 2020 10:25:00 +0000 Received: from VI1PR0401MB2541.eurprd04.prod.outlook.com ([fe80::c0e5:9ade:9b5:9434]) by VI1PR0401MB2541.eurprd04.prod.outlook.com ([fe80::c0e5:9ade:9b5:9434%4]) with mapi id 15.20.2878.018; Tue, 7 Apr 2020 10:25:00 +0000 From: Hemant Agrawal To: Dodji Seketeli , David Marchand CC: "Hemant Agrawal (OSS)" , "Yigit, Ferruh" , dev , Neil Horman , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 00/16] NXP DPAAx fixes and enhancements Thread-Index: AQHV8HStVcndcB1BGE+Xa3kYgyTmZqg1RHgAgAR1LLCAAAEegIAAAorggAGhLICABlAmpIAr/JFA Date: Tue, 7 Apr 2020 10:25:00 +0000 Message-ID: References: <20200302145829.27808-1-hemant.agrawal@nxp.com> <877dzscx97.fsf@redhat.com> In-Reply-To: <877dzscx97.fsf@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-originating-ip: [182.69.160.222] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 533b512f-dc80-44b0-5fce-08d7dadded80 x-ms-traffictypediagnostic: VI1PR0401MB2608:|VI1PR0401MB2608: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 036614DD9C x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0401MB2541.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(136003)(39860400002)(396003)(366004)(376002)(346002)(6506007)(5660300002)(2906002)(4326008)(76116006)(52536014)(66446008)(66946007)(66476007)(66556008)(64756008)(53546011)(9686003)(8676002)(33656002)(81166006)(45080400002)(478600001)(54906003)(71200400001)(966005)(316002)(110136005)(7696005)(186003)(44832011)(86362001)(8936002)(26005)(81156014)(55016002); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N4Z9om2roYM3IOR7Bm6ngTAmb92Cgm8CQTdD0HNXEvRkyjcYgWiaPVeGtvRROADjTvdGxeLe/CSI5f5GP7SXFUEBplPDzne0QsVa201FpT5gP05ibUY4fyIJeh5j2Af5m4/576eBpxoS9CzK2/6+YnhPgQQlTsQA3VVjycgJawZhsGgCCfN3kssa+aKIOiOXGoPBQg9k5aPNAtEn+4CDitv6+n/+PrZN1MpEzajuixPDmYW0TNAQcGdnp5yHu2A3u9l6fBI1gJq7pZgaSI+LdBj+Wwm5KloCJ1Il6nOuNTPQFIqzFoDMk7WN//QzPMbjiEfckhqpjW7YqfX3ToMK31wnEYxaI+MRg/d0457ohkCJK5ddLLfa4wNu1U4nzDJAW8os45ISogUW01kV99zG5XSWghlgesE4Bzz0dftGGBQpBcYPtjYhkaIkXyKXKZ5k6pMyUFgqdWt+r0CHU9Uu//KHQi6F0xnUGsbfIQCYuPemGzY/aZWWnbR1U+zW+YPPovITORi+eF7/U7Izvm8GGw== x-ms-exchange-antispam-messagedata: Flge1KAoRNR6CHzf1KuZs0rjXSuFvuO5QCgbLFKiaiK4O3tn5dl3npVpgOl1BI1IH5Rn1bgiHqzz/bEN/YJ1qPxKh5Xm6NXhQqCyRvErKE5/RXD+uAd6EGjL306jlvsB0nTCsC+Iglu5DP1A5MHc2w== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 533b512f-dc80-44b0-5fce-08d7dadded80 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2020 10:25:00.2375 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RNV/mh2S83I20YIoE95iLBW3dcWewzKjLF7ozhKkCV+Uh8B9ffASa4MqJmvEZdsGKZQiXoq0go1a8m5AfOnC6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2608 Subject: Re: [dpdk-dev] [PATCH 00/16] NXP DPAAx fixes and enhancements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" HI Dodji, >=20 > David Marchand writes: >=20 > > On Thu, Mar 5, 2020 at 10:19 AM Hemant Agrawal (OSS) > > wrote: > >> > On Thu, Mar 5, 2020 at 10:06 AM Hemant Agrawal (OSS) > >> > wrote: > >> > > > >> > > Hi David, > >> > > > On Mon, Mar 2, 2020 at 10:26 AM Hemant Agrawal > >> > > > wrote: > >> > > > > > >> > > > > This patch series add various patches for enhancing and > >> > > > > fixing NXP fslmc bus, dpaa bus, and dpaax. > >> > > > > > >> > > > > - the main change is support to allow thread migration across > >> > > > > lcores > >> > > > > - improving the multi-process support > >> > > > > >> > > > This series triggers an ABI warning that must be investigated. > >> > > >https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F= % > >> > > >2Ftravis- > ci.com%2Fovsrobot%2Fdpdk%2Fjobs%2F292904119%23L2233& > >> > > > >;data=3D02%7C01%7Chemant.agrawal%40nxp.com%7C91a3230cfd334c28bbd > b0 > >> > > > >8d7c4dee590%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6371 > 943 > >> > > > >33920176015&sdata=3D%2BViKwS2sNucwLFD9VtvwxOK1huq0g%2B6TfT6 > Fqp > >> > > >Nyz5w%3D&reserved=3D0 > >> > > > >> > > [Hemant] > >> > > As per the logs: > >> > > > >> > > Variables changes summary: 1 Removed, 2 Changed, 0 Added > >> > > variables > >> > > 1 Removed variable: > >> > > 'dpaa2_portal_dqrr per_lcore_dpaa2_held_bufs' > >> > {per_lcore_dpaa2_held_bufs@@DPDK_20.0} > >> > > 2 Changed variables: > >> > > [C]'dpaa2_io_portal_t dpaa2_io_portal[128]' was changed at > >> > dpaa2_hw_dpio.h:40:1: size of symbol changed from 5120 to 2048 > >> > > [C]'dpaa2_io_portal_t per_lcore__dpaa2_io' was changed at > >> > > dpaa2_hw_dpio.h:20:1: size of symbol changed from 40 to 16 > >> > > > >> > > Error: ABI issue reported for 'abidiff --suppr > >> > > devtools/libabigail.abignore -- > >> > no-added-syms --headers-dir1 reference/usr/local/include > >> > --headers-dir2 install/usr/local/include > >> > reference/dump/librte_bus_fslmc.dump > >> > install/dump/librte_bus_fslmc.dump' > >> > > > >> > > --------------- > >> > > > >> > > These changes are w.r.t modifications in internal structures and > variables. > >> > They may be ignored. > >> > > >> > The ABI check considers symbol exposed in headers available to final > users. > >> > If those are internal, why are the headers public? > >> > > >> > >> [Hemant] These symbols are not part of any public header files, but > >> they are part of *.map files to share them between different driver > >> libs i.e bus_fslmc and net_dpaa2 > > > > I would expect libabigail to skip those symbols, so there is something > > I have missed in how --headers-dirX work. >=20 > In libabigail speak, we make a difference between *ELF symbols* and types= . >=20 > --header-dirX is about telling the tool what the public *types* are. As = you > rightfully implied, types that are defined in files that are not found in= the > directories specified by --header-dirX are considered to be private types= and > are thus not shown in the ABI change report. >=20 > ELF symbols however are a different matter. Header files don't usually d= efine > ELF symbols, be they variable of function symbols. Header files can at m= ost > declare variables or functions that would be actually defined elsewhere i= n > source code, leading to the definition of ELF variable or function symbol= s in the > final binary. At this point, we aren't talking about types anymore, as t= he ELF > format doesn't know what types (in C or any other language) are. So --he= ader- > dirX don't deal with ELF symbols. >=20 > And from what I understand from the message quoted above, the changes we > are talking about have to do with EFL variable symbols which size have > changed. So in practise, these are global arrays (exposed by at the bina= ry level > as an ELF variable symbol of a given size) with public visibility which s= ize have > changed. >=20 > So my guess would be that if you guys don't want these arrays to be part = the > binary interface of this library, they should probably be declared static= at the C > level and accessed through some accessor function or something like that.= At > least, that's my humble uninformed opinion. [Hemant] Actually some of these are in datapath, there is a performance imp= act of accessing them via function calls.=20 >=20 > In the mean time, the tooling can be tought to ignore changes to these EL= F > symbols, as you you guys all know already. >=20 [Hemant] will you please help me about adding entry to libagigail.abignore= =20 I tried doing following, but it is not helping --- a/devtools/libabigail.abignore +++ b/devtools/libabigail.abignore @@ -2,10 +2,15 @@ symbol_version =3D EXPERIMENTAL [suppress_variable] symbol_version =3D EXPERIMENTAL + name =3D per_lcore__dpaa2_io + name =3D dpaa2_io_portal ; Explicit ignore for driver-only ABI [suppress_type] name =3D rte_cryptodev_ops + name =3D dpaa2_io_portal_t >=20 > > Anyway, all of those symbols in dpaa are part of the driver ABI. > > We are still missing a way to mark internal symbols. > > Neil had posted a framework for this > > > https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fpatchw= o > rk.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D5004&data=3D02 > %7C01%7Chemant.agrawal%40nxp.com%7C91a3230cfd334c28bbdb08d7c4d > ee590%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6371943339 > 20186005&sdata=3D1Is%2BqQwP%2Bn0QVJ2HYK2%2Bx7TJooEvry1sNUUN > fWMygkM%3D&reserved=3D0. > > > > In order to get this series passing the checks, I recommend NXP > > rebasing Neil scripts (I will help reviewing this part), then mark all > > those symbols as internal in its drivers. > > Other vendor will convert their drivers later, as there is no need at > > the moment. > > [Hemant] I have commented on Neil's series. It needs more changes in exist= ing code. An approach like __rte_experimental will work better. > > Thanks. >=20 Regards, Hemant