From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4F62A057B; Thu, 2 Apr 2020 11:49:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 56FCB2BCE; Thu, 2 Apr 2020 11:49:23 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2064.outbound.protection.outlook.com [40.107.20.64]) by dpdk.org (Postfix) with ESMTP id 93BF8F12 for ; Thu, 2 Apr 2020 11:49:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CdyzJLaHDvWnfUTnTwJu5GnZLoD4gBAL30iZP7OPMTAYkLY6J5YR9FZr5RVmHhY5YSoLilRnnszthSYFird2sp9ccMe6IMbpxmOWSuZJk2bHTSYjEEHOX8MZyGdv2lBTtmE8O4EnzJOvdCPKOt0helyJnqfxw8Ln+Nm8uggu0+1J/AsSvNyfVvFT6lu6L5e7UCGIy2R5kFd1QcGcp4p+WwUBfcGkEXrf4ffMGmJbIZYW3Ee7c7EFOiAl14MUGQzan6LFOZb+cSZktg/ZBOSvDG99C4ygJkMZZW3FVK9QbCoB3o74+XnoFRwqO8i+fXpRtXLkfe1Kvdo4R+FKoXKQHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iw2JbNmeGxs3gw/Kb7aDMuSJOS2tDvrAWCA35zGyjfA=; b=ndKjLtofVTjvDts6xNh+Zr1scPeuZet8VkLGXIcGLYssHNetnnq/cN5WA9v5lDFoRskOio8svKsy3CrleYsmMqQHt1hIngV4nT2P48aVtQJ0+TojweYGw2oaVYlxuPFX8yggkWKIO9TEd+gzzJqoalshoWLKp7HNRwDHhpMJJz7DX5chwos8ViFStIo48VIJJg2YrHUgUJaXc2nmGC1OCzPfMrHnPVY+vDOyaDFAHpEmuwSnZGyTppqnPIfNlsTURcEmkwObN6NJoEdhJ0vHJVo0nK++VuDH+HsgTTrOEivOXjTbNdoTKTjfB8krTaLWIdzMXtsrIpuwbuevHzNELQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iw2JbNmeGxs3gw/Kb7aDMuSJOS2tDvrAWCA35zGyjfA=; b=W9qXd8Ndn67/Dpr23uhlLROMnbG0n1pnMz+wnlyuul3lPlB7WwiP8pFdHOocqE2SQpAWbpPzTai3DE6+kkR0dejOhGRDxEau0dGzdFD123V2flL6Lqngjx0Fob4edw9Q+cNsKQbRCVVg4xN+a1+12iYdxaWXOt0BAqtFl8tuau8= Received: from VI1PR0401MB2541.eurprd04.prod.outlook.com (10.168.62.139) by VI1PR0401MB2368.eurprd04.prod.outlook.com (10.169.133.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.16; Thu, 2 Apr 2020 09:49:20 +0000 Received: from VI1PR0401MB2541.eurprd04.prod.outlook.com ([fe80::c0e5:9ade:9b5:9434]) by VI1PR0401MB2541.eurprd04.prod.outlook.com ([fe80::c0e5:9ade:9b5:9434%4]) with mapi id 15.20.2878.016; Thu, 2 Apr 2020 09:49:20 +0000 From: Hemant Agrawal To: Neil Horman , "david.marchand@redhat.com" CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Bruce Richardson , Thomas Monjalon , Akhil Goyal Thread-Topic: [PATCH v2 05/10] fslmc: identify internal only functions and tag them as __rte_internal Thread-Index: AQHVIfO1SAD/0vQdcEurvr2RNsm1HKafdgfQgANeWoCBxI1tkA== Date: Thu, 2 Apr 2020 09:49:20 +0000 Message-ID: References: <20190525184346.27932-1-nhorman@tuxdriver.com> <20190613142344.9188-1-nhorman@tuxdriver.com> <20190613142344.9188-6-nhorman@tuxdriver.com> <20190619104543.GB19712@hmswarspite.think-freely.org> In-Reply-To: <20190619104543.GB19712@hmswarspite.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-originating-ip: [182.69.71.168] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 645249e4-7af8-46f2-acbc-08d7d6eb1deb x-ms-traffictypediagnostic: VI1PR0401MB2368:|VI1PR0401MB2368: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0361212EA8 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0401MB2541.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(136003)(366004)(376002)(39860400002)(346002)(396003)(5660300002)(8676002)(81156014)(81166006)(9686003)(110136005)(186003)(26005)(478600001)(33656002)(86362001)(2906002)(52536014)(64756008)(66556008)(316002)(66476007)(66446008)(44832011)(7696005)(66946007)(76116006)(55016002)(8936002)(54906003)(53546011)(71200400001)(6506007)(4326008); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: n4DYUM7ZtTs9lSQPtkHHTzM83gVnlOJTK/347U7jNFs9zghohFAj0dA4v6KkPU2W3b7O1BJ8CuDKKroUeQMpFtqnyrb/g8FvV/V+0an5zJU0jndyJb0VWfcTIWx/H9iWGQadRL1Ux1HEeu45lVz8TzY+8/Vinr0heJxY+44d28qzrBACwECnXZmN2Exr9Rw8z19xYKJ1brY1LARHIyL/v15k0j/SJCqzuIheSRDbAWsAHAsyHp56FS4SkJZDZwlikQrJi5UHZm+6Oleg4yw+hPIzoUuSGhFplMLb8/5yOiK7iSx2RtvVWMVGrRtBHAwjkbMryghjWwYbsFxB+dbOsjbmE8zNRAtOXR585xd2sKL6rtQG9fm5kZJfiL5JFjuWUr1uaHoVqgP5iDY6NlajbBXz1EQhT/VKKeWOhoA9wWdv8X1nNEsv3E+KTqHzi/gF x-ms-exchange-antispam-messagedata: sJpSQVVfq8BRc2V4o57oe7E2nE/Wmjk7imTY4fvFpyc+YmOFZw3auLWvALm+NLByk/JcecZBdIKG0q5NBJP8g1cxVpsPwFGpQQjxKf0yzOxCy+dSN/tvpykx9/+HfShGTMdqowXFLlvl6TuKgctNcw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 645249e4-7af8-46f2-acbc-08d7d6eb1deb X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2020 09:49:20.2748 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7cegubLRMbCC1wQ5y/EUPg2/bU3P2gG/ORD/mk0fvq+yQuEp/gAR+6UwwukZiu80T2wZ1EQorXOWm59NMyTToQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2368 Subject: Re: [dpdk-dev] [PATCH v2 05/10] fslmc: identify internal only functions and tag them as __rte_internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" HI Neil, > On Mon, Jun 17, 2019 at 07:30:34AM +0000, Hemant Agrawal wrote: > > HI Neil, > > The same code of low-level HW driver is shared with different OSs > (kernel, uboot etc) and different framework. If we introduce rte_internal= in > these low-level hw files, it will be a big maintenance issue for NXP. Eve= rytime > there is a change or upgrade, it will be a pain. > > > Why? If you don't want to support the use of a project specific tag in o= ther > projects, you can add a global cflag to those like this: > -D__rte_experimental >=20 > and the code will be eliminated >=20 > I'm not sure what you see as difficult here [Hemant]=20 Do, we have an alternate for this approach? Also, w.r.t to changes, at present you are adding the "__rte_internal" afte= r the function return type. Is it possible to add it before the function re= turn type and limiting the changes to header file only i.e. something simil= ar to the current approach of "__rte_experimental" =3D> current approach > * Return: '0' on Success; Error code otherwise. > */ > -int dpbp_open(struct fsl_mc_io *mc_io, > +int __rte_internal dpbp_open(struct fsl_mc_io *mc_io, > uint32_t cmd_flags, > int dpbp_id, > uint16_t *token) =3D> approach used in rte_experimental >__rte_experimental >uint16_t >rte_bbdev_count(void); This will help in minimizing the changes. Regards, Hemant >=20 > Neil >=20 > > Regards, > > Hemant > > > > > -----Original Message----- > > > From: Neil Horman > > > Sent: Thursday, June 13, 2019 7:54 PM > > > To: dev@dpdk.org > > > Cc: Neil Horman ; Jerin Jacob Kollanukkaran > > > ; Bruce Richardson ; > > > Thomas Monjalon ; Hemant Agrawal > > > ; Shreyansh Jain > > > Subject: [PATCH v2 05/10] fslmc: identify internal only functions > > > and tag them as __rte_internal > > > Importance: High > > > > > > Identify functions in fslmc bus driver which are internal (based on > > > their not having an rte_ prefix) and tag them with __rte_internal > > > > >