From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Matan Azrad <matan@mellanox.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: Sachin Saxena <sachin.saxena@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0
Date: Thu, 25 Jul 2019 06:04:38 +0000 [thread overview]
Message-ID: <VI1PR0401MB2541FE303C0F4C1CB55E665D89C10@VI1PR0401MB2541.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <AM0PR0502MB4019B9AD806B86246FD0E24DD2C60@AM0PR0502MB4019.eurprd05.prod.outlook.com>
HI Matan,
> > On Wed, 24 Jul 2019 15:37:40 +0000
> > Matan Azrad <matan@mellanox.com> wrote:
> >
> > > Hi Hemant, Sachin
> > >
> > > Looks like issue in dpaa.
> > > Please check.
> > >
> > > > -----Original Message-----
> > > > From: dev <dev-bounces@dpdk.org> On Behalf Of bugzilla@dpdk.org
> > > > Sent: Wednesday, July 24, 2019 6:35 PM
> > > > To: dev@dpdk.org
> > > > Subject: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0
> > > >
> > > > https://bugs.
> > > >
> >
> dpdk.org%2Fshow_bug.cgi%3Fid%3D335&data=02%7C01%7Cmatan%40
> > > >
> >
> mellanox.com%7Cef4c519dd7b1495178f808d7104c7400%7Ca652971c7d2e4d
> 9
> > > >
> >
> ba6a4d149256f461b%7C0%7C0%7C636995792862104273&sdata=DrdcC
> J
> > > >
> >
> mYUMZxk3j%2F%2BxPlqXMOAb9GDNBPzSNzpifzcMU%3D&reserved=0
> > > >
> > > > Bug ID: 335
> > > > Summary: Compilation fails when HEADROOM is 0
> > > > Product: DPDK
> > > > Version: unspecified
> > > > Hardware: All
> > > > OS: All
> > > > Status: UNCONFIRMED
> > > > Severity: normal
> > > > Priority: Normal
> > > > Component: ethdev
> > > > Assignee: dev@dpdk.org
> > > > Reporter: matan@mellanox.com
> > > > Target Milestone: ---
> > > >
> > > > The compilation error:
> > > > In file included from
> > > >
> >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > > rtal/dpaa2_hw_dpbp.c:28:0:
> > > >
> >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > > rtal/dpaa2_hw_pvt.h:76:2:
> > > > error: #error "Annotation requirement is more than
> > > > RTE_PKTMBUF_HEADROOM"
> > > > #error "Annotation requirement is more than
> > RTE_PKTMBUF_HEADROOM"
> > > > ^
> > > > cc1: error: unrecognized command line option
> > > > "-Wno-address-of-packed- member"
> > > > [-Werror]
> > > > cc1: all warnings being treated as errors
> > > > make[6]: *** [portal/dpaa2_hw_dpbp.o] Error 1
> > > > make[6]: *** Waiting for unfinished jobs....
> > > > In file included from
> > > >
> >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > > rtal/dpaa2_hw_dpio.c:37:0:
> > > >
> >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > > rtal/dpaa2_hw_pvt.h:76:2:
> > > > error: #error "Annotation requirement is more than
> > > > RTE_PKTMBUF_HEADROOM"
> > > > #error "Annotation requirement is more than
> > RTE_PKTMBUF_HEADROOM"
> > > > ^
> > > > cc1: error: unrecognized command line option
> > > > "-Wno-address-of-packed- member"
> > > > [-Werror]
> > > > cc1: all warnings being treated as errors
> > > > make[6]: *** [portal/dpaa2_hw_dpio.o] Error 1 In file included
> > > > from
> > > >
> >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > > rtal/dpaa2_hw_dpci.c:26:0:
> > > >
> >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > > rtal/dpaa2_hw_pvt.h:76:2:
> > > > error: #error "Annotation requirement is more than
> > > > RTE_PKTMBUF_HEADROOM"
> > > > #error "Annotation requirement is more than
> > RTE_PKTMBUF_HEADROOM"
> > > > ^
> > > > cc1: error: unrecognized command line option
> > > > "-Wno-address-of-packed- member"
> > > > [-Werror]
> > > > cc1: all warnings being treated as errors
> > > > make[6]: *** [portal/dpaa2_hw_dpci.o] Error 1 In file included
> > > > from
> > > >
> >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/fsl
> > > > mc_vfio.c:40:0:
> > > >
> >
> /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
> > > > rtal/dpaa2_hw_pvt.h:76:2:
> > > > error: #error "Annotation requirement is more than
> > > > RTE_PKTMBUF_HEADROOM"
> > > > #error "Annotation requirement is more than
> > RTE_PKTMBUF_HEADROOM"
> > > > ^
> > > >
> > > > --
> > > > You are receiving this mail because:
> > > > You are the assignee for the bug.
> >
> > It seems reasonable for a driver to require headroom to store extra
> > data in receive buffer. It should be documented though.
>
> Yes.
>
> But if so, this driver should not be compiled by default, or change to raise
> run-time error instead.
>
> What do you think?
[Hemant] We will change it to run-time error.
prev parent reply other threads:[~2019-07-25 6:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 15:34 bugzilla
2019-07-24 15:37 ` Matan Azrad
2019-07-24 16:24 ` Stephen Hemminger
2019-07-24 16:40 ` Matan Azrad
2019-07-25 6:04 ` Hemant Agrawal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0401MB2541FE303C0F4C1CB55E665D89C10@VI1PR0401MB2541.eurprd04.prod.outlook.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=sachin.saxena@nxp.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).