From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: "Michał Krawczyk" <mk@semihalf.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Maciej Bielski <mba@semihalf.com>, "dev@dpdk.org" <dev@dpdk.org>,
Marcin Wojtas <mw@semihalf.com>, Guy Tzalik <gtzalik@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
"Chauskin, Igor" <igorch@amazon.com>
Subject: Re: [dpdk-dev] [PATCH] net/ena: change license clause to SPDX tags
Date: Fri, 27 Sep 2019 08:49:36 +0000 [thread overview]
Message-ID: <VI1PR0401MB2541FFE4F9C457628A3D9CA989810@VI1PR0401MB2541.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAJMMOfO9bzAYiYdJavK353JMUU0awZaDVAPY+vsTS3yq=R98Lw@mail.gmail.com>
Hi Michal,
You also missed doc/guides/nics/ena.rst
Regards,
Hemant
> -----Original Message-----
> From: Michał Krawczyk <mk@semihalf.com>
> Sent: Friday, September 27, 2019 1:46 PM
> To: Hemant Agrawal <hemant.agrawal@nxp.com>
> Cc: Ferruh Yigit <ferruh.yigit@intel.com>; Maciej Bielski
> <mba@semihalf.com>; dev@dpdk.org; Marcin Wojtas
> <mw@semihalf.com>; Guy Tzalik <gtzalik@amazon.com>; Evgeny Schemeilin
> <evgenys@amazon.com>; Chauskin, Igor <igorch@amazon.com>
> Subject: Re: [dpdk-dev] [PATCH] net/ena: change license clause to SPDX tags
> Importance: High
>
> + Igor
>
> pt., 27 wrz 2019 o 07:32 Hemant Agrawal <hemant.agrawal@nxp.com>
> napisał(a):
> >
> >
> > > -----Original Message-----
> > > From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
> > > Sent: Thursday, September 26, 2019 11:17 PM
> > > To: Maciej Bielski <mba@semihalf.com>; dev@dpdk.org
> > > Cc: Marcin Wojtas <mw@semihalf.com>; Michal Krawczyk
> > > <mk@semihalf.com>; Guy Tzalik <gtzalik@amazon.com>; Evgeny
> > > Schemeilin <evgenys@amazon.com>
> > > Subject: Re: [dpdk-dev] [PATCH] net/ena: change license clause to
> > > SPDX tags
> > >
> > > On 9/26/2019 1:31 PM, Maciej Bielski wrote:
> > > > Signed-off-by: Maciej Bielski <mba@semihalf.com>
> > > > Acked-by: Michal Krawczyk <mk@semihalf.com>
> > >
> > > <...>
> > >
> > > > diff --git a/drivers/net/ena/meson.build
> > > > b/drivers/net/ena/meson.build index 091ca6e3f..c7e71f494 100644
> > > > --- a/drivers/net/ena/meson.build
> > > > +++ b/drivers/net/ena/meson.build
> > > > @@ -1,5 +1,6 @@
> > > > # SPDX-License-Identifier: BSD-3-Clause -# Copyright(c) 2018
> > > > Intel Corporation
> > > > +# Copyright(c) 2015-2019 Amazon.com, Inc. or its affiliates.
> > > > +# All rights reserved.
> > > >
> > >
> > > This part is changing the copyright owner, it is under the ena
> > > driver but still is there a reason to change the owner?
> > >
> > > Overall this is a meson file, I personally don't see the meaning of
> > > having a copyright in a meson file, but trying to be fair.
> > >
> > > Would you mind keeping the original copyright for the file?
> > [Hemant] Not sure, if you kept the Intel's copyright by mistake or you
> copied this file from other driver having Intel's copyright.
> > You may like to keep add yours, but not delete the old one.
>
> Ok, let's keep the Intel's copyright.
>
> Thanks,
> Michal
next prev parent reply other threads:[~2019-09-27 8:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 12:31 Maciej Bielski
2019-09-26 15:55 ` Stephen Hemminger
2019-09-26 17:47 ` Ferruh Yigit
2019-09-27 5:32 ` Hemant Agrawal
2019-09-27 8:15 ` Michał Krawczyk
2019-09-27 8:49 ` Hemant Agrawal [this message]
2019-09-27 13:03 ` Maciej Bielski
2019-09-27 8:34 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0401MB2541FFE4F9C457628A3D9CA989810@VI1PR0401MB2541.eurprd04.prod.outlook.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=ferruh.yigit@intel.com \
--cc=gtzalik@amazon.com \
--cc=igorch@amazon.com \
--cc=mba@semihalf.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).