From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D762A0555; Wed, 25 May 2022 18:55:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 80A3C40146; Wed, 25 May 2022 18:55:09 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10132.outbound.protection.outlook.com [40.107.1.132]) by mails.dpdk.org (Postfix) with ESMTP id 11C06400EF; Wed, 25 May 2022 18:55:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m1CEp1nUwDIVR5cJ5Gv6Rz/EDcXNE4hNLP2TBVNI0RnH4Jp565mUwIngMaGr9sG4uRCGmvySC2TN7ln0Q+vV63BYmNjIHfRMp7baRICeIFfRbBZcPjQTbzEXNe6dwMvxXonWHaNUkJYYnBj0dQ48vWNSKKZBnpWOZaNcdl37KxQ1YmRhYwEVKa35X/hgD/fcBi/PHVS+4nL+Sx+EA58FIyp8vwH3ZrtaRH1y1U7zqzYZcNYOF+5jEL7Z2v7ZCWbYgpNxt661jKjMys/4fFXEg+bi67/dgsCLThYcoyvsbr+vNuttpAzZrZ4FZxVgAjqo5b4hZneIkVkbmpl/dmbfzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OPNtjnrFNBuAVroJiwWxAir4wNRMMoQ6vOn//5el094=; b=OYrkqid73HH90TfXvRE94JwSQlfeC/yjJNUoO0UtrzrUQ41+lOOwhxaviPD2oE22wtNkeL8kZEXsPR6he3dTulYyBPTkfPQHqEj1cKtyPC6nzCnB7vMnI2QNLxiZXOVM94vL9hep9sTvIDa5AVC+How1m1EVKF0m5FSC0AehVh0L4T2hxXpLsVH1A/LkfIudYzqgwbsXR4uFNmbfkTEbzfYcg6ymXh+xL1x8TWNu5UxLJPUDxQJwovQlwE7o8Wt65JbrqBdtr+P3yaLsQibC81dBpiaZEaFz/F5ePs4QKCTzTtrKs6HqFZUOaOFZuxG49n4QeUcSBtWzIZlN4JJPVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom-usa.com; dmarc=pass action=none header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OPNtjnrFNBuAVroJiwWxAir4wNRMMoQ6vOn//5el094=; b=MdLWE7hnKdUyfF8gb/K8yRhVSILW1kzcRkDmJAKy98Fm8xXAg7HGqJKZLtbRnJJ2g+xov1LFZSVYdbsIKzAZJipAExxQz3H1giPf3yyV4GywlLt5CQ9ABMZ4jAJj9TVXzA5x1qFcDof7EbolC1swCIgPtQb2ZJR0LOtg888ZDFA= Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com (2603:10a6:803:b::16) by DU2PR04MB8696.eurprd04.prod.outlook.com (2603:10a6:10:2df::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 16:55:06 +0000 Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::9198:ca97:d3b9:d3cc]) by VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::9198:ca97:d3b9:d3cc%4]) with mapi id 15.20.5293.013; Wed, 25 May 2022 16:55:06 +0000 From: Jeff Daly To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "stable@dpdk.org" , Stephen Douthit Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug Thread-Topic: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug Thread-Index: AQHYTpSxgnie9TYA7EmxFtoINkPBYq0aoXgAgBVw01A= Date: Wed, 25 May 2022 16:55:06 +0000 Message-ID: References: <20220228152937.21247-1-jeffd@silicom-usa.com> <20220412174220.31195-1-jeffd@silicom-usa.com> <20220412174220.31195-3-jeffd@silicom-usa.com> <6ed20a09404145869918a77a58670b67@intel.com> In-Reply-To: <6ed20a09404145869918a77a58670b67@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silicom-usa.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 69ac69ae-8bf6-4d20-e506-08da3e6f51e1 x-ms-traffictypediagnostic: DU2PR04MB8696:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: H6Q4U+EzU6xEtgC6U+tK9ASivWSE5IHaEwdpai/4Nahed63DTNy4VC1zvIIhTdzORBk9MsyLUDCOby5lApUs/DH3W1Dc6buNBz0etc3zrH3JzgMSFePO/e2pgKUkdEUSjVDD7TH/NnyTJa1SsnoZSAAFe65CRH9PNBWeQeAA9D6aeVfboVzC6DWvifxyXOIcGLgxMPtMaPnhbnN/6KUdLL06oHCdaGxnVx4aXFKxNg44Eqmhw6IjxtIPZlrwiDjC+rhwoagLdSukhWUfm5QVmebtI3YmPunDRJZhMlzk6SNbzLWcdhwQAkpk8Qw2SQ9jgWD22qZQ3pknbRjCADriffk0/J7EMh4t1KvQHuEFcW6vrNO+TLPP83HxUgEQ0GeV82wbTox7P1HYwAb5dMRc7IOfwb5MP4o/7kNlmwQ9r+QOmkUBEhYJQeqcSPOmP11t3mLnIme+RUcHWjeSxIYFRKh64kIJZhBSp8e3UeentTJG9ZQXXI2EHwTppPLcWzbVNlG09PsRT+k6DqgKGu2SRuYcnueQU8W3h/BNXgjDWz71d7D7yGSR9TSfDNafhcq/STffSlZOo7/XOD7oploeHMbtQzBbbG+65TXJxGY0ImrAyrsoVP4u/aCfEDzzjN045fhkJ0GDCWXibiWNBbmWCAHKXm5wnO/kEmfh3YoXJz8e6hZR5QZGbKr6hO3hiU5yAg2d2vAVZh7ckvry8ZFJwHPEJOeMbw79exlfydHeUKlq0WLENPe0m+vGeIgXdjTOq8qo0HLLs/ZukrSO/N7BypSvWdOOsmm4u2+Pn8Z/Vm4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0402MB3517.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(86362001)(966005)(55016003)(508600001)(38100700002)(71200400001)(6506007)(54906003)(7696005)(316002)(53546011)(33656002)(9686003)(8676002)(107886003)(66446008)(64756008)(66946007)(66556008)(4326008)(2906002)(76116006)(66476007)(38070700005)(186003)(5660300002)(52536014)(122000001)(110136005)(8936002)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eGJRT0GhNi+0jjiQxVvw9MhrO2NcBymgqqrP2OO2p3zUpGJnASaNveQKkGu1?= =?us-ascii?Q?Sy9XFOheprQc/We2ydb0bkdj2F4mpgaZvE4YRPsmZXtBRoLYslxiWeDfHFys?= =?us-ascii?Q?TmoDghTxHRSrkf2HaLrMcYrzcqyhTrRLVKBZ7sYrW+FxVm1JmtEHyjCLywJD?= =?us-ascii?Q?HRCSOX3PxAjycgTkq6SRW5B8r82GwsgtG07VETDqB1TwotoccT1yv0eLlgci?= =?us-ascii?Q?9JyAvMJO/FwO5PQmb5AOoTA52wp0+rBFjYuABkZMCIKQiyhfpaDx8TSKcVZv?= =?us-ascii?Q?bLXqCJbZOL6f1s6QLT4PbEBslMHSZYYEDyeM+BbHo3yaxWUkw15JX75HiLkl?= =?us-ascii?Q?my9g6W+LThG1qPh7gUfJ9VFMfphNwqjic7rW9MqFzAoVBBCOp0vKq0BsZJpq?= =?us-ascii?Q?ozqECtV6diiJ8lQ4CljwMxw9F/PfutcbjtgCA/XsoyKhCzxZ/uG0cvnJLre5?= =?us-ascii?Q?czywG8iWTBJgmIA+WqKxH+qettND6LnPVaujxBBDX+I20eR63AnzMwTgk9pA?= =?us-ascii?Q?zBQr4QI51r6Elwa5XbDHx/2z4BvZLFBtgjk7G3mgJ18DXvATQqZciBxG1tOS?= =?us-ascii?Q?MeR3ayEtrNgVbc3lfIQCRIdKXDHK07VoOB0DO/dSHStvS/VJK/y5sJ2OJCgY?= =?us-ascii?Q?bnbDhGM5wSMGgIXWf0ho0cTW0hi5xF3RTI1Nuy78giBla2esVku3bNTap6nO?= =?us-ascii?Q?FxHrDXPVzfjrJSSBwwnx1D2y8qwTbaDVmYo+/8ubNUPdJJrcLgqC2Kvaj4x4?= =?us-ascii?Q?d5l5x6G7SWBPylp/JZ4EMghtwuk6op9eKC1kVCukO8sLbQIFcah5AE+8DVPs?= =?us-ascii?Q?lUpDRTQxMYa845mlJtUdt206tlzp/ivoo+AhTrE6f0JqFbYZ7DDHxH77iIZz?= =?us-ascii?Q?K2QTpFiBkeNwuYDGNJwX9i1b+TaXkDTLnAw/0YKjE9Ync0ANY8n70meoG/NY?= =?us-ascii?Q?QCRkBI/lVKFw5YvVf9LoCQjoTDb6pjHNw6uIHmPVMKbAOzmCSYhbV3BPT8Gi?= =?us-ascii?Q?e8EY0drY/aQxk+rLj3kZOVj9KCwUXpSTsHwagLjdFUARksBGF+YHly4rU5g1?= =?us-ascii?Q?Y2YealB2CZpBymkhe5uxkuRTaTX3GVxeeC1ftGTYfBFohZM4F3sx+3oMDKc/?= =?us-ascii?Q?eVLpWxORbDmSMV7v49sQlz1/LwLFS8m3FjkxrQDeBaTeyntqCdVD/PlJGrP7?= =?us-ascii?Q?xPWaqnUY6nVzgSIMqjbvKmhMbFp0nb3+tJZHPa8bo2w5YTSTuP19Ao3AMHxK?= =?us-ascii?Q?VdSSmUsuZUBP1WBrexBwgh5q0qDe1W6/XIkdU9WeMWalupahO+jKg33iYTZ6?= =?us-ascii?Q?5NTznGTs2ifqfLLzotrkkSMd7noJibyCAXeIhHxSrEJx6uiSJLlj1pprWQd+?= =?us-ascii?Q?sF5anThmyeBvoxtpZIqiB3pZvhrqDHQZYmrfoaVarrdkEJXo6x0/GWoX+D+N?= =?us-ascii?Q?7WG1kHK4qr872lEC55xmZ3C1ga74ripKM8JiK3c4/pFy25FnMTeUrT5qV/9M?= =?us-ascii?Q?dUsAr+H9vRVNT7QMK/RXjf9jeNsBHF0VuhoSBQEUlE/sZHEGhqREoJoayv8F?= =?us-ascii?Q?m1ZfqxnVyuiT1Pd+WYrnpiBQJmQrQdcjDA4H/eXT93U8CgVZuMacjh35xfeu?= =?us-ascii?Q?CVw5wVX5bxYjJouciUprlzqjHGhPXKVjKQBXOq+1UQQbHUh4mrOz6C4smgGb?= =?us-ascii?Q?drkb/O0ZVReCKSLo+OwHjpR7qmYsvFiEZ14er7t1Eh4/r5Sublz5c0SekElr?= =?us-ascii?Q?f16zFlBBmRu6HTitcZt6NnW0pvs0arHpUF8dHb1Xr6VVIRxJWN9x?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: silicom-usa.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3517.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69ac69ae-8bf6-4d20-e506-08da3e6f51e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 16:55:06.2084 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N7nzwVmw/8nh9VjcrqYEkINo+/HSfkyzPDnnwutrozrOYqS3vXnJfdY11+Y4rY/qN1LoXVHquCVN+5oXZPQ8ZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8696 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, May 11, 2022 9:27 PM > To: Jeff Daly ; dev@dpdk.org > Cc: stable@dpdk.org; Stephen Douthit > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on > hotplug >=20 > Caution: This is an external email. Please take care when clicking links = or > opening attachments. >=20 >=20 > > -----Original Message----- > > From: Jeff Daly > > Sent: Wednesday, April 13, 2022 1:42 AM > > To: dev@dpdk.org > > Cc: stable@dpdk.org; Stephen Douthit ; > Wang, > > Haiyue > > Subject: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on > > hotplug > > > > Currently the ixgbe driver does not ID any SFP except for the first > > one plugged in. This can lead to no-link, or incorrect speed conditions= . >=20 > Does kernel driver has the same issue for this? >=20 No, the kernel driver does the correct thing. > > > > For example: > > > > * If link is initially established with a 1G SFP, and later a 1G/10G > > multispeed part is later installed, then the MAC link setup functions > > are never called to change from 1000BASE-X to 10GBASE-R mode, and the > > link stays running at the slower rate. > > > > * If link is initially established with a 1G SFP, and later a 10G only > > module is later installed, no link is established, since we are still > > trasnsmitting in 1000BASE-X mode to a 10GBASE-R only partner. > > > > Refactor the SFP ID/setup, and link setup code, to more closely match > > the flow of the mainline kernel driver which does not have these > > issues. In that driver a service task runs periodically to handle > > these operations based on bit flags that have been set (usually via > > interrupt or userspace request), and then get cleared once the requeste= d > subtask has been completed. >=20 > If kernel driver don't have this issue, Is this the same way that kernel = driver > handle this issue? > The history can probably be searched back for, but yes the mechanism implemented in this patch tries to follow the kernel's method for handling hotplug. The patch has been split into 3 chunks, starting with: https://patchwork.dpdk.org/project/dpdk/patch/ffbdaf3aa487241a51bb6512bbb47= 01da17e69fe.1652988826.git.jeffd@silicom-usa.com/ it was refactored according to the wishes of the prior maintainer, so it's = not exactly the same as this one which is why it was submitted as a new one,=20 not a revision of this. =20 HTH. =20 > Btw, could you break down the patch for easy review? >=20 > Thanks > Qi