From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71654A0093; Thu, 21 Apr 2022 19:31:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19DB540042; Thu, 21 Apr 2022 19:31:10 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2119.outbound.protection.outlook.com [40.107.20.119]) by mails.dpdk.org (Postfix) with ESMTP id 0112040040; Thu, 21 Apr 2022 19:31:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l7VmpbPnniYZUMT6qrHu+FooEMax9xprweQdr5NMwfC4g44k4lOrwH7Vd32jGtfxrSjtUTP1dJvbEewy9/S/gJ4Fc7wUexiyi+2SUWQ2gcoiAosPdLKuEwjUCitrHQjqq6jtffoV0sy3aIqkRKzdRNDX78r1ZvZRb3Sz9J2zE+cn1LWWp2wCd+/FqloJJpT2uP3VYIVufOUcxYCE0PcparRXG+NFd032t6Ozyy4ZZqzPfa0NWhsDWk1Qqxc53akPLPctcOtQO0wbxsXerVo4a1aOB/GDr7cZt9qdi399FIgaNRgLj+nGHlgTVwUNIS6nDEQXXQvQ1EwB43enwDSKZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1UfmM4+5KcwFMlq36lOX7kO4PvTGntClvm+od0MHypo=; b=ZPTJ0bwlYvoqL9H6xn9EuL2I5jRozmuUKTDigPm+TKzaqBUFB1Ctjx+S1LSSwtVcdR3Hei9C1+OXyckTaTewajonA0WSUdQdttUrpDBSnl4vLtFIFRGzKqh/mkOL1/aqjzOoELqUSxNdxj0xrxG6bLMZFJTR90SLqEQf8hoHKEMDFxVPdJ8+k+rWZlL74/7MCgjJQRF2fnlu6/4GNlRkHvLnGYz9PNpgbI0TE98kRZcc3ybk/rQGHxXMvboYXGQDAFoQ1anDF4e+9Cs8ztyOVMG0VkzAH8dBy3HAuPpfRA3Imul2mzlWp6oWuXIAOxROpnl8dWMQchc+6X1nNTDrnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom-usa.com; dmarc=pass action=none header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1UfmM4+5KcwFMlq36lOX7kO4PvTGntClvm+od0MHypo=; b=GtH0cevqJlbEKHyWdxY4TX2XCrHW21IKm91uZ6UHt6qOK/PFSPhQ8jOGZ05aZIV5ExTY/9CjJg8pup+/bdDVikmxmGnQAKZ6fUcLinhKZTcwaVnizA5123itHD0PYojM4bA8f3eG5HPEo+VqoGCfbA9OD7Yik2Dh5NhTI3Oous0= Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com (2603:10a6:803:b::16) by AM0PR04MB5826.eurprd04.prod.outlook.com (2603:10a6:208:134::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 21 Apr 2022 17:31:05 +0000 Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::1598:c12f:25c6:b987]) by VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::1598:c12f:25c6:b987%7]) with mapi id 15.20.5186.014; Thu, 21 Apr 2022 17:31:05 +0000 From: Jeff Daly To: "Wang, Haiyue" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yang, Qiming" Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug Thread-Topic: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug Thread-Index: AQHYTpSxgnie9TYA7EmxFtoINkPBYqzut1YAgAAC04CAAIB+kIAAGaEAgAboqgCAAEm7gIAAuebwgADI04CAApk4sA== Date: Thu, 21 Apr 2022 17:31:05 +0000 Message-ID: References: <20220228152937.21247-1-jeffd@silicom-usa.com> <20220412174220.31195-1-jeffd@silicom-usa.com> <20220412174220.31195-3-jeffd@silicom-usa.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silicom-usa.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a6e7f205-0b72-4b71-1749-08da23bcb6f5 x-ms-traffictypediagnostic: AM0PR04MB5826:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YZGF5ldyBz8ScL9Ea/sTAGWtFVhvgc6jCZiTiYCJoPV1mZ7VIeZbwM4NCAF79rAEFdmZF8BkObokB2HJuGClBv8mPd6RhgPB9OxP1L/ahnErZdt/uiIUmNdZ67+8Bqfsykxsx2JG+clypzaoZTsnikjSBBBVIgFXQdvh/ds6YCBrYd13YOaoE3tpBZI4DL82/mtqVpRTPvDscGGBusDL2YN3Vk42UBV5TJd9HBtjBPo9zV6i3ux7tNiPYCrJX3sq5XpA13tOCrWbOla0hHRozxb+oK40GceE3kw7McGTIOLd2dkPk5oLjkkg03hthbWnp/UEA1EV7DYLhaq5AcgbboZPDMhlss5ayHS8qmKikUopuD5rlXanL7zFe2V2sjmc3P1xGTLijuqGEwKJr78qbq0SN9c5TyFpbsyH13y2RVibfkshWYE5TSrTmXIpiHqlo+KI8+Wn1/diXdHtCgwt8uZxFaNmjwLxjZHjholJnV6oqBWOv29RrhEH1E3hVuK/dE5civaxLN8UVYOwB2GBN//fEfXt1siPJ4psvu54JGI2mmESEclCjQe2E9H3SJwAKYZaK8F3RkNJTWcbdx04PjsYLfwlaK0WE9cjiUaG18qGYEglWC9t183y43rfia9ZxJ5tg5phoYWBMydBF598wQDoAkOWNclWZfjSWPkH13zDsgXYfGSYrvKjMOVKyiM4I6VfzvArmbciTCnp1xJN8w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0402MB3517.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(7696005)(122000001)(54906003)(110136005)(5660300002)(38070700005)(2906002)(71200400001)(30864003)(53546011)(52536014)(186003)(8676002)(4326008)(83380400001)(55016003)(6506007)(86362001)(33656002)(66556008)(8936002)(316002)(508600001)(38100700002)(66946007)(66476007)(64756008)(9686003)(76116006)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?C3YU1qM+keMv29ngdO2zZKgK1kl9ceBpzjfBWYL0syGxhAUDXVwImaboZbbb?= =?us-ascii?Q?YZPHGV6d7KEba00DiIenjNG0f+laPvywkHBIGw2bB+jEC4pSBXUD5lqexMeM?= =?us-ascii?Q?r3zUNhs2BET6vCPOt5jjBGtWj1CaKGz5wkAoNCptBbRy8r7hjH7ZylQBnOGc?= =?us-ascii?Q?g/iW2AzO5vCtU4E+iSuIDKs2U2C1Jx+KwMZb/Rf0Bp0w6wlPvKrXszAUe+tf?= =?us-ascii?Q?iscGWnzgVCfn4aHt9CjKwhteU8Zb/ye7hs9Wfxdaga1zGGNVssodlWFEcBcM?= =?us-ascii?Q?n92G0G0hwSXJiacUwEHtaunh1sIgr1DwVGV69cg63j+AQURKunkjBS6L1yVx?= =?us-ascii?Q?W+Fsqg9YOQ0lkti/QDoFV80PcVh3NfG+tVPR9XLxd+qQzZLjKzB0Xdi69tgp?= =?us-ascii?Q?HugTsT7dxmUpvLa1gvyn3W8Uhp0Ab/+g2S7SQ4n9oGbKaYszE7XrhHNShOH/?= =?us-ascii?Q?TGH2Uv+iqMJoLnMw5mWQH5k+Yzce6aS3rHGje/18LIFCX/sZrjdfoe+2CQSR?= =?us-ascii?Q?1S6W3S0HhY7EHbnyMmuT+dd2xMf0eimH0mDG8dJ+pY5FpVjgiDRVpiB1mN+F?= =?us-ascii?Q?pg05DO8+nCfklfRtAZiDqepJxlcN2b4Jx6fGIA31TNovVlOlYxvXNuZ74aKV?= =?us-ascii?Q?vYwkKIWjh/VScxw92c+TYTeJVUk+fo9oYa2SpVap0jjnq2rODfkYUse5Jvj8?= =?us-ascii?Q?0N+DsFH03kyxXOQxIrkbIE8TVjyi0Dh5qt985e5Znp8fN3iLjKxXt8TbnKto?= =?us-ascii?Q?uiltDC/U1sNu98tNBbHJ0j2AeRZTiKZSWameDMxb73PMWrsfOaJjLpiIu+2R?= =?us-ascii?Q?wNoN12tB/BNaDAOu4s0GE048IFQ/UATSc7evTN/ckKlYC4WWGmTF2L1QU4QI?= =?us-ascii?Q?SLXXKNbLuLkR3GIRQo5za6uaaLvlG53OF+gLya+IWzXyJYQZkGxj1TdyUv8a?= =?us-ascii?Q?sIK/TWpKr/BdSITyqqEgU3JvKB7Zu/+QWUicWGK4nqxpcNMiJv8i/cWiJaQF?= =?us-ascii?Q?PxBYExTnAzSxDUeMWV2nGNAkPHe7/Fi6ZWnNFpmmF6+VKT1Dc+sd7dRKEnIK?= =?us-ascii?Q?du6c7gppF5lQ6lhs0nICk6l+EbPACZNhweFb/fRhEZ2qlxa2csV6Btp4LtiI?= =?us-ascii?Q?QaCZuymgSR3D6t1EgY57e/u/HyCk7s5O/GoSpLAe7NXJKV39iHI2cUMNQrq4?= =?us-ascii?Q?+nQu98//sdqOSX0VSEfKTKZcT2bbJG1iIzcJmNvsOxvszqW6ex+9OCGeaeAn?= =?us-ascii?Q?Ekb9teasHy3SZzhBp+Y85BZ8cmIO2UZMy54udyqsQyfy3K0KQREyzV0QlTKi?= =?us-ascii?Q?Vx/NxNQqPz/D471qxURIAjnRpzssb+3ylaKjIGtOyIVLeJ4JTV9qel0JWPg+?= =?us-ascii?Q?EvvuC19fMziNDn5Ptwe5ZSD9ecykJuBVRNFjM7yb+il9ptWWYwOE+6xj/Lhc?= =?us-ascii?Q?80w+g5W3o603T496x72tDBpUTI9Q6GGzbyoGHdGYyVVOj+Zs7WEd7eAYB1er?= =?us-ascii?Q?WgPYwvlaQ+ANDv8JPnrfXgjRhNODLcsoP6jsPgHGMz/A919uENIswrfc0pD0?= =?us-ascii?Q?948sh0FyK9iC3BchM1WFdhvU8qC06cvH7tOYnBSMp4aAGNJch4+s55abytza?= =?us-ascii?Q?X8M6W3zWQYXGmIVN+WESVwIZ2zAOevrLYG2Kj0kGCWTLIdq5LUCT3WE6FZaU?= =?us-ascii?Q?SrLrTgz1HvYbWjoAEG1G87U9YRYguNuMvtu0V/h9mLUstXddkyNDiJnxcJOB?= =?us-ascii?Q?yygbiHyBeb28kCnlayN/QOtjPP68pfxNODQJ+g2EZ6izujgHhkwL?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: silicom-usa.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3517.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6e7f205-0b72-4b71-1749-08da23bcb6f5 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2022 17:31:05.6529 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: airWB2CkbiAdn8lhAPNbOr6mtM7U4UyMVZi8ouOhlavpfshBcqzAqqfJL2dNZoc5DFDPTNfmH02iVqVFy0X4HA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5826 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Wang, Haiyue > Sent: Tuesday, April 19, 2022 9:09 PM > To: Jeff Daly ; dev@dpdk.org > Cc: stable@dpdk.org; Yang, Qiming > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on > hotplug >=20 > Caution: This is an external email. Please take care when clicking links = or > opening attachments. >=20 >=20 > > -----Original Message----- > > From: Jeff Daly > > Sent: Wednesday, April 20, 2022 01:34 > > To: Wang, Haiyue ; dev@dpdk.org > > Cc: stable@dpdk.org; Yang, Qiming > > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking > > on hotplug > > > > > > > > > -----Original Message----- > > > From: Wang, Haiyue > > > Sent: Monday, April 18, 2022 10:05 PM > > > To: Jeff Daly ; dev@dpdk.org > > > Cc: stable@dpdk.org; Yang, Qiming > > > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking > > > on hotplug > > > > > > Caution: This is an external email. Please take care when clicking > > > links or opening attachments. > > > > > > > > > > -----Original Message----- > > > > From: Jeff Daly > > > > Sent: Tuesday, April 19, 2022 05:55 > > > > To: Wang, Haiyue ; dev@dpdk.org > > > > Cc: stable@dpdk.org > > > > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and > > > > linking on hotplug > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Wang, Haiyue > > > > > Sent: Thursday, April 14, 2022 8:11 AM > > > > > To: Jeff Daly ; dev@dpdk.org > > > > > Cc: stable@dpdk.org > > > > > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and > > > > > linking on hotplug > > > > > > > > > > Caution: This is an external email. Please take care when > > > > > clicking links or opening attachments. > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Jeff Daly > > > > > > Sent: Thursday, April 14, 2022 18:41 > > > > > > To: Wang, Haiyue ; dev@dpdk.org > > > > > > Cc: stable@dpdk.org > > > > > > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and > > > > > > linking on hotplug > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Wang, Haiyue > > > > > > > Sent: Wednesday, April 13, 2022 11:00 PM > > > > > > > To: Jeff Daly ; dev@dpdk.org > > > > > > > Cc: stable@dpdk.org; Stephen Douthit > > > > > > > > > > > > > > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and > > > > > > > linking on hotplug > > > > > > > > > > > > > > Caution: This is an external email. Please take care when > > > > > > > clicking links or opening attachments. > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Wang, Haiyue > > > > > > > > Sent: Thursday, April 14, 2022 10:49 > > > > > > > > To: Jeff Daly ; dev@dpdk.org > > > > > > > > Cc: stable@dpdk.org; Stephen Douthit > > > > > > > > > > > > > > > > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection > > > > > > > > and linking on hotplug > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > From: Jeff Daly > > > > > > > > > Sent: Wednesday, April 13, 2022 01:42 > > > > > > > > > To: dev@dpdk.org > > > > > > > > > Cc: stable@dpdk.org; Stephen Douthit > > > > > > > > > ; Wang, Haiyue > > > > > > > > > > > > > > > > > > Subject: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and > > > > > > > > > linking on hotplug > > > > > > > > > > > > > > > > > > Currently the ixgbe driver does not ID any SFP except > > > > > > > > > for the first one plugged in. This can lead to no-link, > > > > > > > > > or incorrect speed > > > > > conditions. > > > > > > > > > > > > > > > > > > For example: > > > > > > > > > > > > > > > > > > * If link is initially established with a 1G SFP, and > > > > > > > > > later a 1G/10G multispeed part is later installed, then > > > > > > > > > the MAC link setup functions are never called to change > > > > > > > > > from 1000BASE-X to 10GBASE-R mode, and the link stays > > > > > > > > > running at the > > > slower rate. > > > > > > > > > > > > > > > > > > * If link is initially established with a 1G SFP, and > > > > > > > > > later a 10G only module is later installed, no link is > > > > > > > > > established, since we are still trasnsmitting in > > > > > > > > > 1000BASE-X mode to a 10GBASE-R > > > > > only partner. > > > > > > > > > > > > > > > > > > Refactor the SFP ID/setup, and link setup code, to more > > > > > > > > > closely match the flow of the mainline kernel driver > > > > > > > > > which does not have these issues. In that driver a > > > > > > > > > service task runs periodically to handle these > > > > > > > > > operations based on bit flags that have been set > > > > > > > > > (usually via interrupt or userspace request), and then > > > > > > > > > get cleared once the requested subtask has > > > been completed. > > > > > > > > > > > > > > > > > > Fixes: af75078fece ("first public release") > > > > > > > > > Cc: stable@dpdk.org > > > > > > > > > > > > > > > > > > Signed-off-by: Stephen Douthit > > > > > > > > > > > > > > > > > > Signed-off-by: Jeff Daly > > > > > > > > > --- > > > > > > > > > drivers/net/ixgbe/ixgbe_ethdev.c | 533 > > > > > > > > > +++++++++++++++++++++++-------- > > > > > > > > > +++++++++++++++++++++++drivers/net/ixgbe/ixgbe_ethdev.h > > > > > > > > > +++++++++++++++++++++++| > > > > > > > > > 14 +- > > > > > > > > > 2 files changed, 410 insertions(+), 137 deletions(-) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > struct ixgbe_stat_mapping_registers { @@ -510,7 +509,7 > > > > > > > > > @@ struct ixgbe_adapter { > > > > > > > > > uint8_t pflink_fullchk; > > > > > > > > > uint8_t mac_ctrl_frame_fwd; > > > > > > > > > rte_atomic32_t link_thread_running; > > > > > > > > > - pthread_t link_thread_tid; > > > > > > > > > + pthread_t service_thread_tid; > > > > > > > > > > > > > > > > No need to rename this variable, > > > > > > > > > > > > > > Let's do link related service now, so we can keep it, I > > > > > > > missed to add my comment. ;-) > > > > > > > > > > > > > > > > > > > I don't understand this reply, are you still asking to rework > > > > > > the patch or > > > > > not? > > > > > > > > > > > > > > > > Different thing. > > > > > > > > > > 1. This var can be kept to trace the created thread. (change > > > > > less code to > > > keep > > > > > the patch clean.) > > > > > 2. Yes, two patches. > > > > > > > > > > > > > ok, I guess I'm just being thick-headed here, but I still don't > > > > understand why you are saying it should be split into > > > > 2 patches. if I understand *what* you are asking, you're saying > > > > make the original thread periodic to continuously > > > > > > Well, ... > > > > > > Your patch merges the original 'ixgbe_setup_link' task into one, > > > this will make us hard to review the whole design. So what I said > > > is: firstly, let's change the thread to a service thread to handle > > > the 'ixgbe_setup_link' subtask firstly. Which is 'ixgbe_link_service' > > > in your whole patch. > > > > > > > still not 100%, are you suggesting that the original > > ixgbe_dev_setup_link_thread_handler() > > which currently is not periodic and only really calls > > ixgbe_setup_link() be changed to be a periodic task that essentially > > does what the patch's ixgbe_link_service() function does which would > > only be checking whether link config is needed and if so calls > ixgbe_setup_link() as before? > > > > if I'm following the code correctly, it ends up going down to > > ixgbe_check_mac_link_generic() which looks at SDP0 (in the case of > > needing xtalk fix) which incorrectly will set sfp_cage_full when in > > fact the PRESENT# signal (or MOD_ABS#) is active low. the code is > > extremely convoluted in it's effort to be smart so I may be missing > > something, but I *believe* that what we end up with is completely > unnecessary probing of i2c busses looking for SFPs that don't exist. eve= n > when making it periodic, I don't think it's going to end up with working = code. >=20 >=20 > I'm lost ... >=20 > The 'periodic' is the service thread running mode, but the subtask is ONL= Y > called when be scheduled, like: >=20 > if (!(adapter->flags & IXGBE_FLAG_NEED_LINK_CONFIG)) > return; >=20 this makes no sense. the *only* time right now when IXGBE_FLAG_NEED_LINK_C= ONFIG is set is immediately before the thread is created! there's no 'hotplug' part of the= patch vs fixing the=20 'original issue' (your words, below). the 'original issue' is that the cod= e doesn't work for hotplug (SFP cages), so there's no breaking up the patch to fix any original issue = first. the only issue is that for SFP cages, the code doesn't work. =20 > > > > > Small patch is good for us to review, and try to do one thing. > > > > > > Hope this time, I can make myself clear. ;-) > > > > > > > do ixgbe_link_setup() ? I believe the problem with the setup is > > > > that the sfp_type is only detected once at initialization time and > > > > if nothing is in the cage then the code just returns > > > > IXGBE_SUCCESS, in which case making this task periodic is useless. > > > > the whole issue of hotplug is only addressed by the entire patch > > > > which > > > > 1) makes the > > > > task periodic, 2) changes the actions of the task to look for > > > > whether the cage has something in it and whether its been changed > > > > and needs to be configured again. > > > > > > > > > > > > > > > > we can separate this patch as least into two patches: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 1st, change the thread handle > > > 'ixgbe_dev_setup_link_thread_handler' > > > > > > > > from > > > > > > > > > > > > > > > > run-once to as periodical, to handle the original issue. > > > > > > > > > > > > > > > > The name 'ixgbe_dev_setup_link_thread_handler' may be not > > > > > > > > suitable now, as it is a service thread. > > > > > > > > > > > > > > > > We can change it to "'ixgbe_link_service_thread_handler'" > > > > > > > > to reflect the change purpose. > > > > > > > > > > > > > > > > 2nd, add the SFP hotplug in this patch. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > }; > > > > > > > > > > > > > > > > > > -- > > > > > > > > > 2.25.1