From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11143A0032; Mon, 30 May 2022 15:47:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C39AA40694; Mon, 30 May 2022 15:47:01 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10129.outbound.protection.outlook.com [40.107.1.129]) by mails.dpdk.org (Postfix) with ESMTP id 78A8E400D6 for ; Mon, 30 May 2022 15:47:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nLq1Sul9Qnl9zMFw+Ud03bGfKuZsNuLisjYVSwDCFXeMpmj3lbfEjcxMZFwuTl5BdkyAQfX9C3mfqqQu2u8/iSwXiMBvmqEHmqnUQPbYw89PZpYZfZAK+HTsCUNtmvhxRgXqrHi+LsHHcV7nlwaN95S3T6S3hjzAdwmZ7zG2CZzsBJc6KLft70d/6iA2YaRXns/TciwoRKUkEYNTlMrr4DF+VIKcEfx9fG951sUhmyaBDm22aq2/hCa2FpDzUDiG32MhzFYGMLERv5o1hijPvmdOzlNIDr2S4BhhIrQt2yzwEsdDvVLoBsm7jUfzsOuxdQ2ejc9F2Be+gcCQvGi3gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VBShkCxScMN/rnATSrqva9ksLgy8DDveYFp6WKh6Luw=; b=K13MibSMrvjK2WYvqx+ZSDlydPKOclc6/t2n4x70UfC2X3TZ8yFH9IjTh00knhRpIYcyv4qM7+brXbWqDc3Z/xJQjhKVeB+GJg8lyicqCwvY1H2Ryc4V2MbWBCNmK7OY0xKQWWHvhrRe/hNgPZTzKkTD5pKug7lQfSF78KqqUX8/gDdp32L49RuwoZj77KacSFjiXYYpN3I+WBYPy+o5dF9tuEHKXLNS5mTP/JChTpYKduhjQ/DPVAxgacrJrHSutFLOL7jHC5mTN4Uo4YjeXm+LwV8N9JmObFSn4HlAuFyqbraWFPk2EQJfbCord0QkKGYE9K1ZVoJmzcPbjXMmcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom-usa.com; dmarc=pass action=none header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VBShkCxScMN/rnATSrqva9ksLgy8DDveYFp6WKh6Luw=; b=tX2g0HHQK4X4A2swv1tjN/c/Pw5M5lV0gUqdRiXHEsPh9txNMUzIXbeMvQxFZ2MybdpNyoVn676aLJBwc6ggMsebyfn8PqOx6JTR15BcfeICWemRsvCoRwzz3AUtHWnCjPAUIz39qzLIdy7RPKZN57YwhMDAsHA7n+zTh14PufE= Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com (2603:10a6:803:b::16) by AM6PR04MB4293.eurprd04.prod.outlook.com (2603:10a6:209:42::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Mon, 30 May 2022 13:46:58 +0000 Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::9198:ca97:d3b9:d3cc]) by VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::9198:ca97:d3b9:d3cc%4]) with mapi id 15.20.5293.019; Mon, 30 May 2022 13:46:58 +0000 From: Jeff Daly To: "Zhang, Qi Z" , "dev@dpdk.org" , "Yang, Qiming" , "Wu, Wenjun1" CC: Stephen Douthit Subject: RE: [PATCH 1/3] ixgbe: make link update thread periodic Thread-Topic: [PATCH 1/3] ixgbe: make link update thread periodic Thread-Index: AQHYa6q2RAUCCMYMukSnYSydiV9PGq02j2gAgADs3iA= Date: Mon, 30 May 2022 13:46:58 +0000 Message-ID: References: <20220519180248.23831-1-jeffd@silicom-usa.com> <20220519180248.23831-2-jeffd@silicom-usa.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silicom-usa.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a35300dd-4b4b-4b8f-4ad6-08da4242de03 x-ms-traffictypediagnostic: AM6PR04MB4293:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lyYi9Ev3C6unLG52k9f1BqbNl9ewKuAEf1Qjd5fyf3g99V6t0nOlqUaWYrRO+TRlmVRbFeFXS10xiLA4eZzGvyfR9GJ52G2v01elF2ZBxjfdV1Qz1mh3sp/Xrn7L5wCQN/B8clKq0YNT5/M39r96NMc7Y/U4dHhiJjtBwQ9E/lE+MYQC4vFVfgZP5+bdMO3785VEa5zO41voRd5gNPJ7SodGKNVyLIojbvlu14sE1YVp4UTTKuNCnQRbR22zpdM4Xx1mftT5FX/RArG3OYsuyAIWh0OEKtxYSMddZDJVEtvPJ+4WQfNMOQfbahzTSpo4kg972P9DR4o6gjaL9JBgJM8uFfLio/r08M1AftfYtoIzHgnDDrMizaSi5eg7IVZ6VXZ4b7ay36/vpJYw67davrJsT9NVUBjaW1xvXXmovhQoXNjdA7HUdmZylYueQKl5do3bRYtvYfn/7aiRy1KSLpvfPYusIbC/oV/iIEKHFOuzlXTgKLiaqa7652I58146z83BZtLpcCExL81KuBssA1a4VzqgY0TEyXeqddWrEFsokV6fJ4ANMo/vJmKqjjrykCkAx+7NjPgKIaITGOtFtF6lf0BJ7P3gy9AdXbDWLhVr2UQnYKjqrlxIpXJY8JszPpIeZFEvXjH1y0PZOB3blbX81I8edJGK0bsHuhamkq5lso7szbNyFLDsTxqE4w5W5118szhhoRjwBWR0FUn6tQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0402MB3517.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(508600001)(5660300002)(33656002)(53546011)(52536014)(66556008)(66946007)(8936002)(7696005)(6506007)(86362001)(64756008)(9686003)(15650500001)(71200400001)(2906002)(122000001)(38100700002)(55016003)(107886003)(186003)(38070700005)(83380400001)(110136005)(4326008)(8676002)(316002)(66446008)(76116006)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5mlXCuGwi7KWyL0iUfvr7vCHS0jl2hpvWJSWS61ephKdH9oLgbduX/J93cLU?= =?us-ascii?Q?Ip0xpBvRjO6D0ovCFIJG/7yTcTKIZCUB5qvrPv52xFntntpSBhdqBkY6eV/I?= =?us-ascii?Q?VMBfFwIFJNQnE899TMsmVv7znefwYVm20rZNLvlMMlYvswv2aKElcZMq3H+S?= =?us-ascii?Q?Q5wat2Be8McKgARU1frE4H5e1JMC3miSGvrkwM28+EjCXcLGLi4L00E2Kuk3?= =?us-ascii?Q?saGJdPd7A2k6ZDwqbj1PMAKxzp/XOILrMWEE+v0cZlk3xGD0+rZcIDDvVQhJ?= =?us-ascii?Q?mJ0vu98hIq8i9pXfOMV12UusZcwZO1WWfeBm/vMUSiXMmCpJyUe+jWzgFMmw?= =?us-ascii?Q?hOcDZPpEh8d28jBsUTa2NrCUPHmlV9GLALejv0DZmIMXIm/Js7tOxlKI2bkI?= =?us-ascii?Q?5onYApMiTrBHb/SUntVOKMEP/Gm0h3jIr6BBAwIOly1e7T7vF5h7AxyHp/p3?= =?us-ascii?Q?TPqKS9dB2ZF0jy68UFV3t8D3ft411hzSSk224Hg+VRgX+sBjLNPgq1G2dLHp?= =?us-ascii?Q?YChu7wVhPoymxRvvymZfUwWX0kOcJ7Kc/7sMdOF+WmG20U8zGc9IMZd10Q3/?= =?us-ascii?Q?4O1vtAIVISI8dWXPzTyJOJ7Te2qfJromVD7HhPMEaFmh5z5jjUZyhLSCOiZG?= =?us-ascii?Q?dmxTKORgiD6ax8WjuzdJj2n4pr4YVce73W5oL0zIis2aZ9c5HA7NCT8WZWA/?= =?us-ascii?Q?iWLxnzn/QD5hy5HZgT5qlqA5G/pXjZEGk6K9nANtn9ijXohCLn39qiKRFt63?= =?us-ascii?Q?E6J1mm/bYLMIvcc65l7XMnvGfOrF4iuGOdba65zc2q61Yma9dpOliBz/Xjwn?= =?us-ascii?Q?2vGYJ/bfA3fd/sKdfC+fP+8oKuxvSVbqsTYiPZvcWYdL7pgd1I+AwcdWEZra?= =?us-ascii?Q?3KTD7YtdJ0ef19CCwKt2uJDu/T8Hz/d3plzliolZNJdsfVTXZDuv14LguvoF?= =?us-ascii?Q?gmXTIM6/8LouUT1wma4CeOclmNKNmZvzDzL5vrgoyZOSk4AEV89ZKtgY7E97?= =?us-ascii?Q?g0Nj6kvtxISaGVDMDZ1vN3B2iUsYCLPRTNheRoY4medU3sJ8rwqL6fn9j3cb?= =?us-ascii?Q?iHz4Z+QN4zjIlBbA2xo4tmRLIzx5w8kthXDiTEXocl/eWqCJYQD7wemiR9t1?= =?us-ascii?Q?vvy6fX++6pY31G8JaUwyr5GOK0YnBt7cbfJ3auDut/pgbwM077GZNQ+2Q+7M?= =?us-ascii?Q?KphpYMoRMZF7TIZ534+rUtMwm0InJNBCuHO991XYHk3nmK7tuXSARjBsx5IF?= =?us-ascii?Q?dKFZO/Lf/SeIrMbGyh3nOZjGiH6VK3bElEd5l74jXB26Z7s/hhVCd1FLwGyz?= =?us-ascii?Q?JdPIWhA4lnrtZl6xzhLfYjkmxq0rzLZwGqF9fAINA0Qhsgn2UR/6phB9JJsZ?= =?us-ascii?Q?jCVIJMvZncnyYsjw1DaZF4L626R9PHuLcw7g7fwkjlsXasqanPb/0KUPprrD?= =?us-ascii?Q?frnyygyhMhqlZTA/tgRvpFHc+3dOYDvMk9Qrb9LmehvwSKqQIzoCJeGFKER0?= =?us-ascii?Q?1+aZ4A9e++AMYqISeWr4fWKcaFXmMcwXz87CPJIrEffNY23FfVSCAgOZBrr2?= =?us-ascii?Q?TEc0OzVqGf4SDtDxsCF1QCUESHX/+LE1mOdoApAbBDZ6nOCXqsEDeeG+Ka+y?= =?us-ascii?Q?Eey1ecIJ9i4YxrMlkeXtSGpwEYDpH1ErIfb3zTpBYTx6tTlH4+1Y7/5PCYUH?= =?us-ascii?Q?Esm2JwI/DGjYVdSV2AQM3qfLZp4AVtbQdh2ZxodLqqJLRl0R1Lo9vWUq+vhr?= =?us-ascii?Q?vx0BOKnLCazxDfchLAeAABHGwnAWxT4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: silicom-usa.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3517.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a35300dd-4b4b-4b8f-4ad6-08da4242de03 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 13:46:58.6222 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eopz5F0G63tjgrbbnCiQKtrwmCD085A6aNxFhkAqnvicYPwXvrIuNa/go1PA+koZsI6gOkHJPsaIQ7u9rDXRow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4293 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Sunday, May 29, 2022 7:25 PM > To: Jeff Daly ; dev@dpdk.org; Yang, Qiming > ; Wu, Wenjun1 > Cc: Stephen Douthit > Subject: RE: [PATCH 1/3] ixgbe: make link update thread periodic >=20 > Caution: This is an external email. Please take care when clicking links = or > opening attachments. >=20 >=20 > > -----Original Message----- > > From: Jeff Daly > > Sent: Friday, May 20, 2022 2:03 AM > > To: dev@dpdk.org; Yang, Qiming ; Wu, Wenjun1 > > > > Cc: Stephen Douthit > > Subject: [PATCH 1/3] ixgbe: make link update thread periodic > > > > Rather than run-to-completion, allow the link update thread to be > periodic. > > This will set the stage for properly handling hot-plugging. >=20 > Could you explain more about what's the hot-plugging issue with run-to- > completion you try to fix? >=20 it doesn't work right when you have SFPs. (at least not on our platform or= on an 82599 dual SFP add-in card we have). run-to-completion only works 1x. if = you remove and plug in a different SFP it doesn't work. This patch series shou= ld have been taking in context with the original SFP hotplug patch but apparently s= ince I can't ever seem to get the patch submission threading to do what I mean p= erhaps some context has gone missing. the SFP hotplug fix has been in the queue s= ince=20 Dec 2021, has been reworked several times, has gone through a change in Int= el maintainership. this patch series makes the SFP hot plugging work like the= Intel kernel driver does. > > > > Signed-off-by: Jeff Daly > > Inspired-by: Stephen Douthit > > --- > > drivers/net/ixgbe/base/ixgbe_common.c | 4 +- > > drivers/net/ixgbe/ixgbe_ethdev.c | 180 ++++++++++---------------- > > 2 files changed, 71 insertions(+), 113 deletions(-) > > > > diff --git a/drivers/net/ixgbe/base/ixgbe_common.c > > b/drivers/net/ixgbe/base/ixgbe_common.c > > index aa843bd5c4a5..712062306491 100644 > > --- a/drivers/net/ixgbe/base/ixgbe_common.c > > +++ b/drivers/net/ixgbe/base/ixgbe_common.c > > @@ -4154,8 +4154,8 @@ s32 ixgbe_check_mac_link_generic(struct > > ixgbe_hw *hw, ixgbe_link_speed *speed, > > break; > > case ixgbe_mac_X550EM_x: > > case ixgbe_mac_X550EM_a: > > - sfp_cage_full =3D IXGBE_READ_REG(hw, IXGBE_ESDP) > > & > > - IXGBE_ESDP_SDP0; > > + sfp_cage_full =3D !(IXGBE_READ_REG(hw, IXGBE_ESDP= ) > > & > > + IXGBE_ESDP_SDP0); > > break; > > default: > > /* sanity check - No SFP+ devices here */ diff > > --git >=20 > Looks like you change the behavior of link status check for x550. > I'm not an ixgbe expert, but I know this is not kernel driver's > implementation. >=20 sigh. this was supposed to be part of a different patch which also had som= e question about functionality. the SDP0 bit check doesn't specifically need= to be a check for a '1', since the bit reflects the state of the pin on the platf= orm. Intel's platform implementations have an inverter on the board to switch the state. MOD_ABS from an SFP will be '0' when an SFP is plugged in. with an inverte= r in the platform the signal will be '1' when an SFP is plugged in. there's no = guidance from Intel's platform design guide that an inverter needs to be between the= SFP and the NIC SDP pin so having it only follow Intel's platform implementatio= ns is hard to justify. =20 > So do you think this is a fix for both DPDK and kernel driver? if it is,= please > move this change into a separate patch and we need to reach the right > expert to approve this. >=20 >=20 no, as explained above.