From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAC9CA050D; Thu, 14 Apr 2022 17:11:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 56E9F40694; Thu, 14 Apr 2022 17:11:55 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80131.outbound.protection.outlook.com [40.107.8.131]) by mails.dpdk.org (Postfix) with ESMTP id B95E440687 for ; Thu, 14 Apr 2022 17:11:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gxjkgrkZj0N8+Lhnr5jvHKn/7Kuv5AUoZZPgXMwEjWOfUWX5tkipA8bA4XufI5QVYIyCvxezf4JtHAcid3zEhjPLdxi50yS4FA4QXC7pGsl1mdeESkUt4w/CznReG/yWXoahq3cgkoUt6YCHfPGj0/ymCs0x9c9idiL4qSV84NoYIU/clrwNeU5uyCoUwWH8wU+vEzVFKB+rzSH+Zq82zH12fmphuYVB9zEaq5D23r3mQ9hKgu2LeSUYE2Lz9rXyZPwjYg2MQsOE9TBdG0yUR60SSukruPNNkhpu2aXnSJeQHdm4RYyz/yCMpNgqYjdemsr0Yxf/CjzRA/chQG9bdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G0bbmfhndEvIkiQ4GFc5aVjCr0rx3DNYMLSYcaTIxVA=; b=KY48CdOpv6vh0hzF6gCDO0hVce+GBCT2ZrI9YOFhL8JT4mNBSNQqQKqKtpyi8Aw27ArptuarSITUPTgtwvQJj5gYfrvIgWzG5fcJHbPe4NYF2kMhvLQk6EfMeHKY9UYguwVplNYMjMGZyS3WM7Dh3HBAdAk63iXlM34JB7GbowYeUfJzIuBh2paAKY1kMeu6lU3B/M9E1DO7IfrmPadV4ai60gYuvUcP1kq0LmiR4jeAT36yo1pluxhWlz6D3cDViix6Adf6Ul6bghAUptQHwTuyzuyBokr0dxJIjf4qC+ddtUGJ6SY6i46awQR++1q9k10BWFs5d05hSBCXNLgJUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom-usa.com; dmarc=pass action=none header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G0bbmfhndEvIkiQ4GFc5aVjCr0rx3DNYMLSYcaTIxVA=; b=nKwhS1Frn10TxBtNr0ZFGI0WrLPZTujdlAG39XNPVJoFNyOf8ql7Pz4wrMjojJ19rlEccH9FcLppNgO0HeeagE+k9HHkBK1x0xst/TgjUMns1rbjEJVYeL9n84ns3O11/nsPmYVpT2wm7VjPgzBbILSHxVaRmYM89JpMPvmR0Gg= Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com (2603:10a6:803:b::16) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 14 Apr 2022 15:11:52 +0000 Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::5dd5:47e1:1cef:cc4e]) by VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::5dd5:47e1:1cef:cc4e%6]) with mapi id 15.20.5144.029; Thu, 14 Apr 2022 15:11:46 +0000 From: Jeff Daly To: Thomas Monjalon , "Wang, Haiyue" CC: "dev@dpdk.org" , "qi.z.zhang@intel.com" , "john.mcnamara@intel.com" Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Topic: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Index: AQHYMnOR1ZG0azI89kSESFkJBuENiqzu2dkAgACJDICAACpsgIAAAVYAgAAuTiA= Date: Thu, 14 Apr 2022 15:11:46 +0000 Message-ID: References: <20220307223442.28012-1-jeffd@silicom-usa.com> <1889452.fIoEIV5pvu@thomas> <2937496.687JKscXgg@thomas> In-Reply-To: <2937496.687JKscXgg@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silicom-usa.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9d8b2b8a-1d8d-4a2f-52ad-08da1e29176b x-ms-traffictypediagnostic: AM9PR04MB8633:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6K1y3mKFdwwuB/kHwcnXOs293MIIR5HHsClcUVExyN3YWerHWMcQ6qw1hlcFG/Bw1C9WpRS1WVPnj4gJ7W3a1ZB1G9N9xSJmHdouvpyLPw5/++KwyJK39/eXBnjMAhUrRE+hOFIsqmCtUrjtRZ4HLnCBLuSIadCNMldgdPWv0skEDAD8VWKMehTX6CSx14YwhtO08dUnsTwyay6gdAS3ve5rRgIgkj/fDzTMI1RCLWtw34UcVA9zzaUInnJS7dP0tbas6JSVXx0qcc5nBhdl3ATG4d0ZIEFv1NJavRMNEKPOXFqyK0el3UeV2u2g85AZ/5WVz54EeRFEeLY4q8SdsY/Iyv5f8krhI3OUJgbICBxhPfKGMlnEW4gHX7HvjEJgNKNksicF+ZP/I0yZUNOyAA+5xhonzIGrHLt+w84SdxV33W8fZ3NFroj4KRIuH9q2XV7xOZ/rUqrwIKY1ziN4qfyfCaY+UYbzpKVmbaW50nTWG3tW2HiKULwbEO7/aeSsrJ9U4hk5xKjQeUvu6XcCXDXlpkk5QV8vPh0Dl9L9eskLKF6l9OX7Lj8MGK5/F5P/L18eH3u/5sgR1yrGwTus/VhTCHguc5peJPbulMhQyi4Y3Uv1uT6+HYHLqddgbw83o/y47en4F+NQpmNzqxnKI6H7Scpe1haci0iMbVVSWVaStgkjgpbIo72WoPfZIzxqGQWgxiQY8bW23tqgGMhSGg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0402MB3517.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(83380400001)(54906003)(5660300002)(186003)(316002)(7696005)(6506007)(9686003)(122000001)(55016003)(38100700002)(38070700005)(53546011)(508600001)(52536014)(71200400001)(86362001)(66946007)(76116006)(66556008)(66446008)(64756008)(66476007)(8676002)(4326008)(8936002)(2906002)(33656002)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/4pE4FvrUMru70xX4KNR/k9RI9NH9XFPQZoQa0U53hIGeYKZ3gK5TtNvnWqJ?= =?us-ascii?Q?Lr3W1/7TrVLdYXwI+VVO6/5CWhzF66ullIh+QW1gBYxNXxpL101dOcOopg1u?= =?us-ascii?Q?Idp/cGNoS9RjDaxmiCNKikkj4X1dHMN4VThxj6DrMAqNdzfRyjy6TWaBmPAZ?= =?us-ascii?Q?YLsZmGr/Txx9pDRkuIlmBHacNDtjCP6mph9JczxlfHrBP5YZMtCuSSeYhmaD?= =?us-ascii?Q?ZFa9Cucg2cPwj+kgznZcioYjZ0wyu+p8O6krUnc9WjrqBQxoGnAPAIKuQAlX?= =?us-ascii?Q?4JJPDPNwQ8WQNNZtN+BzJdI2LrwHIQeWd4hTG7RvEryZnwxP5g8Q1nzYowMN?= =?us-ascii?Q?PqXbFjgOvDxdmRhvQu5rmI805Jf99iqRnWh8d5Swit8mD3/GJlB05wkS3/Z7?= =?us-ascii?Q?9mHY+WyhkyaXJeMV2x8p5//mINhFJ7S9wPclnXoODcN8Vk17VelAFDeNNh13?= =?us-ascii?Q?VTfdx7P31ZgJPJVtQZ1oNuXKrQl0qWhUz4n+p8L0ueT2scDAREy9psQ7r08l?= =?us-ascii?Q?QJKUksWLQ3KZkiyRPmtYlQg1xGwlDltWQyZDp0s0fKLv6M678vxoL9lOYPRQ?= =?us-ascii?Q?APgX/2IxVUj/xlopy1tjcTPQZ/QfY1tesLI0IFgZPYft+md1piPm1GKnP3/E?= =?us-ascii?Q?bZxB5GTq7jWf7Y2/RSA1DBQMxaZJyALtrevtwpQ28poC8YpSIvWsHgfvPHpi?= =?us-ascii?Q?kUah5O47OwaVd9GyJbgSnUeyreNZ7m/z6KPt59Q0KKqt21MsFGLbni6jvt3A?= =?us-ascii?Q?Swq8cbZtnFHCeG7jEHFO1jFpqcHMREKNp0EhZaAO3SjuBaanfEMicwk83DhJ?= =?us-ascii?Q?Wcg6YtnU3BIR3J2PvChtvR6iH7nuJN1Eqbe1jBJsFFLTLJ3PtwWGSq8TVBmx?= =?us-ascii?Q?s9e8x6G3l4+2oCx2lPgwRtE+FliVuFWdSzDbaRnqzY4vE9Cnr12QHXyd3nDO?= =?us-ascii?Q?pG5RCDBwIDZgxf5V+bDIjdw/BAORg/G/DZK69ZdGMU2y8F831NzBuQ3IrQpB?= =?us-ascii?Q?HzSPmG3C+8k9+QNXgAU2BZxQiBxSxDsMeOqqMVIbkAH6bMLRQnl1v0ybXfIO?= =?us-ascii?Q?pAqrcua52n4IVgA/xV+SHdoA4PUXdQo0xms5V22zv5XlhDZmTyDyakOIsvem?= =?us-ascii?Q?ModCGeii0+3yvVI9/okI/SLT4rjsoLnPoORrH82JRr8n9OlobUZ9fuM1KJsa?= =?us-ascii?Q?yCkzOLIkgPfDmNeD443jXAcMVdGBBs4CVDWDN2K8YXtXHzZxdq4XjDmsj/eb?= =?us-ascii?Q?U8Al1no7g6nvOWiRW521o8TFBm6kxQqXRlkXxYFjzVYfxaQ1OQjjbjwht48+?= =?us-ascii?Q?Enj0qdxzbfnkFbU8qglyM1xpUBLc5MqlnK8HC/XNiM4B+sS2JyW23kV9yP1B?= =?us-ascii?Q?WM0oVQgL07E62x8fwtqlHMv33GJi4D2ys1+j+GF5K7BiTs0NlVdG3Q771CIv?= =?us-ascii?Q?mkwAeHJrUtM6ahEt29U4mAhK57Ls4zMPrefjQYqVtJ7cFNuRUNqRQdAWSqmF?= =?us-ascii?Q?LZKbXKTtrZGROooArjLc6jUGl7cHw2sI69go37rqcqavLn3J0GhDziUajxd0?= =?us-ascii?Q?YsU292XLMLM7RxzsQ9UqDZV/rX7Xbk2Zxo8TW7uEh9XDXQPjBkpScrzK5Etr?= =?us-ascii?Q?msRUZpY8jGJbh3JJFPLTf0WSJL3DpNs2OTpaXzsGX0QPF1saZD39F/FrRjCw?= =?us-ascii?Q?E5IRtDJ/4NH4eoUkq0RdO/89ARmc97qGcKgbizWivB2iGqSs98MXKbjBq4FR?= =?us-ascii?Q?NPBqSRjCLFLT4701nCEuFtIaPmfSkyQxCGYdDTaQSQ9v5rNTU/FX?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: silicom-usa.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3517.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d8b2b8a-1d8d-4a2f-52ad-08da1e29176b X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2022 15:11:46.0342 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Xctfi98ly9uFVkGK/GeBz3Txf0UPz/5Ei3IQaVrzNw0ScV/1n0T36YJrd0KPOTdAqvf0irKh1Qz5YWrmoAwLeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, April 14, 2022 8:19 AM > To: Wang, Haiyue > Cc: Jeff Daly ; dev@dpdk.org; Stephen Douthit > ; qi.z.zhang@intel.com; > john.mcnamara@intel.com > Subject: Re: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > devices >=20 > Caution: This is an external email. Please take care when clicking links = or > opening attachments. >=20 >=20 > 14/04/2022 14:13, Wang, Haiyue: > > From: Thomas Monjalon > > > 14/04/2022 03:31, Wang, Haiyue: > > > > From: jeffd@silicom-usa.com > > > > > From: Stephen Douthit > > > > > > > > > > 1G Cu SFPs are not officially supported on the X552/X553 family > > > > > of devices but treat them as 1G SX modules since they usually > > > > > work. Print a warning though since support isn't validated, > > > > > similar to what already happens for other unofficially supported > > > > > SFPs enabled via the allow_unsupported_sfps parameter inherited > from the mainline Linux driver. > > > > > > > > > > Signed-off-by: Stephen Douthit > > > > > Signed-off-by: Jeff Daly > > > > > --- > > > > > drivers/net/ixgbe/base/ixgbe_x550.c | 14 +++++++++++++- > > > > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > b/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > index 8810d1658e..8d1bc6c80d 100644 > > > > > --- a/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > +++ b/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > @@ -1538,9 +1538,21 @@ STATIC s32 > > > > > ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool > > > *linear) > > > > > > > > NACK. > > > > > > > > As for 1G Cu SFP treating it as 1G SX, some 1G-Base-T SFP modules > > > > require the use of RX_ILOS and some Intel Ethernet products don't > support that. > > > > > > So what is the solution? > > > > > > > And the DPDK keeps the same design with kernel. > > > > > > It should not be a justification for limiting DPDK features. > > > > Um, this is upstream version driver to keep the same behavior. > > > > There are also some kind of custom release ... >=20 > I don't understand. > Upstream DPDK (and Linux) must support a maximum of hardware and > setup. > Why rejecting adding such compatibility? >=20 so, I will ask a question directly in case people just aren't inclined to m= ake a suggestion (and perhaps this should be also directed to the Linux kernel driver mailin= g list), but if there's a driver option: module_param(allow_unsupported_sfp, uint, 0) to= allow=20 enabling non-official support of some SFPs, then I can't image that it woul= dn't also be acceptable to add: module_param(cu_sfp_as sx, uint, 0) to be able to select= whether to enable this specific handling as well? if a patch of this nature is acceptable to Linux driver maintainers, then i= t would also be here as well according to your explanation of the NACK, correct?