From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6E84FA00C2;
Tue, 8 Mar 2022 16:01:24 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 0BA054068B;
Tue, 8 Mar 2022 16:01:24 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
(mail-eopbgr150109.outbound.protection.outlook.com [40.107.15.109])
by mails.dpdk.org (Postfix) with ESMTP id CD9CF40141;
Tue, 8 Mar 2022 16:01:22 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=CGpu4Sfe8Evzs8i5tPwO+OSQyZfTc36rPGyFTEDm4xqvm9Di+7KpLJo1un0HThsc6e7Fywj+OXMoDsYviQJKQFyaoZgYXRR12eUuBNyvg955dxdmSwifLh10RI18Zo9KZ5j4HzxCCZqIm2/9HCs8baI7iTXNV6UchvVfIQnZFgILdDPU521Zrt5iVSwpfDE9GdD5amQBcq+TtqirQs7/appx2Z89IbFLAl6VyUuyrpcA522qYgAXVkY5RSyjdp2Bkdberg5XxMy3Ni/TWQGO6S2CJmApkIssDqUoT16JPWlx9qQ2QBF+66LvlHE+aMcCvzDSxOC3PV1gfCRGeUuptA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=6mTVVlWhwT2bZ9iuwa9fhjqy2qL/FgWFHMOtQwLNXvE=;
b=VZyFu61gkzIlA1fxYbMTYNJQso0F6Rf8ptKLhZmKQZZw4y4SNwp7cIrnTxUWWdyhGWbyM+mqlSXHNwQBucQdertNBcPN4ZzDpP6ZjB1D5Cna7v98X5VCn067oRf61z12dHjDJIjsbW9FteAEKRG8CMUnZGyXq8a0JfrreK0C3p5C5hkOnRAl/dC/yfdKjUeWGIF5VFTYf0KV15rQadA5LaxUY4SbtcPIyrsLPiNxm6AwWxTrq/4zk+3pGU9yg/L8ODF8Jh6H20YCHAjyXWNuF20J1XMPCb3XrJhf9R2aBBq+aSUaarlc8/vGW7Su4s6Ql6SEUqhyRy2ujP+RBB+KGA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=silicom-usa.com; dmarc=pass action=none
header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=6mTVVlWhwT2bZ9iuwa9fhjqy2qL/FgWFHMOtQwLNXvE=;
b=ASBmMowQnrf6clrDyEwGZoMMY//nNqx/GGqg3ienq8UMZfbf+OMuRjKkiPLyG00Qm/gdfvGi/dOyHrZyHIb9CsTgQuHUHykw/WApnh1bG0zuoeuuBVvxyNK6S0BD/52gzoan1HBsIcB0xneMd5g7f9S5HnZsW8PAPknOVYXBpcg=
Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com (2603:10a6:803:b::16)
by VI1PR04MB6301.eurprd04.prod.outlook.com (2603:10a6:803:f1::19)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Tue, 8 Mar
2022 15:01:14 +0000
Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com
([fe80::a0f5:7a14:c41a:7d62]) by VI1PR0402MB3517.eurprd04.prod.outlook.com
([fe80::a0f5:7a14:c41a:7d62%3]) with mapi id 15.20.5038.027; Tue, 8 Mar 2022
15:01:14 +0000
From: Jeff Daly <jeffd@silicom-usa.com>
To: Thomas Monjalon <thomas@monjalon.net>, "Wang, Haiyue"
<haiyue.wang@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>,
Stephen Douthit <stephend@silicom-usa.com>, "Lu, Wenzhuo"
<wenzhuo.lu@intel.com>
Subject: RE: [PATCH v4 1/3] net/ixgbe: Fix ixgbe_is_sfp() to return valid
result for X550EM_a devs
Thread-Topic: [PATCH v4 1/3] net/ixgbe: Fix ixgbe_is_sfp() to return valid
result for X550EM_a devs
Thread-Index: AQHYLLgOlpxvG3j5sUyLL3ymZvEJaayqCOAAgABZ1YCACErcAIAC7nCw
Date: Tue, 8 Mar 2022 15:01:14 +0000
Message-ID: <VI1PR0402MB351750F6F822722D429CD7FBEA099@VI1PR0402MB3517.eurprd04.prod.outlook.com>
References: <20211206221922.644187-1-stephend@silicom-usa.com>
<BYAPR11MB3495BE9DA4F9327B40E54C16F7029@BYAPR11MB3495.namprd11.prod.outlook.com>
<e45d297ac5fb4fc2b185cad1b350ec52@intel.com> <8453140.K2JlShyGXD@thomas>
In-Reply-To: <8453140.K2JlShyGXD@thomas>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=silicom-usa.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5a6063db-0b9f-4eb3-26cd-08da01147da7
x-ms-traffictypediagnostic: VI1PR04MB6301:EE_
x-microsoft-antispam-prvs: <VI1PR04MB630198CF7D06AE4CF5B123FEEA099@VI1PR04MB6301.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: BeohXEfEwtEk6s5jQmP7WDK+Tsie1EojVdeP5w0mSIS1y63DdBV3uPZpjLP/iJAvHYbAGW80h99zQ5KOwGFjMlUCXoOZVoC/zIOXBYL8DjaPkU9ckswFOppSf406eIygtbm/7MW2aXzJuqrA6bzX4KbZicZv2tHIWYao2zDptzSvIAD8J+szH9p/P6ZfGE7D9h25KOp73b2TbS6e7chcHi+snn+l7j0Bl8AdfYHjKVShq6CJzV413GuUm5V3JkJf1fmPdrw+9BxAP/HNEzEE639DfZBwQKjK5wg9LquBq4aXpq/VA+c8o2ULmzCvMrvT2P9BYRRBnlVRRkxqPp07MXh3ZlvDy0KKgWBpuo069hQbXVNPMgXzzZ/g5xm8XpaeFYYo5nqRCv/0TsvxFM2b2zt+qqI3R/YuKiAXhVmcDsi+4PvrH/yi6tT3muOcXN0AoeHVd5oD2t31KzlltAohgSpBg4ggDm8L4yLwdKxTBIpcXEAxZ69Z993LLx2djGvQEdhmMNGd6uxGVOt72xyk0brieFqL7Fm62NFXsQaXs60mOghOuX9L4u4plhYdZ1xYpeDdGtmul77WYUxHOV3R9r5TokL1XspDj+xrWKsbnguCAlZkHASHWYEw+sssW9hPBEjTKNJ/Bb35YEOSmKRSCX2f60qbINvi8r/77uRqTjPKIdSW6aNe/CWEHlItd8sY/DdTkkbht+gYIvVILYU3Dw==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:VI1PR0402MB3517.eurprd04.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230001)(4636009)(366004)(316002)(71200400001)(86362001)(122000001)(110136005)(54906003)(26005)(186003)(38100700002)(83380400001)(8936002)(38070700005)(33656002)(8676002)(4326008)(64756008)(52536014)(5660300002)(53546011)(508600001)(6506007)(7696005)(2906002)(55016003)(66946007)(76116006)(66556008)(9686003)(66446008)(66476007);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?W5PLUPUSxxfuYXRxZXxBKVjm3WFEgIqEF4IhpCZskuNOnDk2dU8/hsjugQl8?=
=?us-ascii?Q?/+W0Kz/Z4YDl0A/LoWxYbWt+ViQ9+7VS6l2UUe9FJ8xB4DAgBicbCd9nbPow?=
=?us-ascii?Q?oK9Vvm3G+MiYbC5MU3DPGnUrRenwzjcIA9sEaH5j+GGHTqMisnehVuV2o7gk?=
=?us-ascii?Q?MPzg5rinUlF5ln0Z+iyuukEJV964RXdkLTMKIH6PkncCls3Lf0ff925pwb3+?=
=?us-ascii?Q?tDGgmRxsb6S1nnGoePXDvqkfihHMWWOkOzPSFC2ZZ6POGXGf7L46j7OG9/zm?=
=?us-ascii?Q?9Up8unMTV15YawJlsPgYjy2VdvbfdnGqpJ+1R2lKvtNXtIUdDSQbe2+rPHId?=
=?us-ascii?Q?X0BhKi4ym2ytfsrfBpKymmgxzCrcKV73bbvoa1GSaCQNelIWDoZJMhiK0pCb?=
=?us-ascii?Q?WXSCGmn25sz+FhtYZHsnH+iZbL3KJUr8MQ85xYGJMqkvL0llVmEoqyI6YP4x?=
=?us-ascii?Q?MYI0GSY7vGi2iSN1Cx1sFYKmHhPpq4qeBhlCKYWDwKrO0AOMQA87qf/IxVGy?=
=?us-ascii?Q?GwgY59HeQPBxE2y4L8il+I+ewrCG5FHU9RuFN/gJaUu95FvzIPIEipv7ZOdo?=
=?us-ascii?Q?7qhsKqMtsPpPIcaw7aAkT5pjjPSLPaZQwVJgdCc0k3c4KspUyBG9REiEkT37?=
=?us-ascii?Q?V5aRLDRC6yvM2IqFQDKrHLGvcZrFqS167eQ7eurUCTvZLqc3kxklcZWGxkCq?=
=?us-ascii?Q?ynvpi6szSSQGlknKB2ASHAPnBFieDqxdJZDuZ7w2V8bX0arC6SHlHiO0hPzE?=
=?us-ascii?Q?+CYTPot4aX/YP0Z/It8gSscH2wXJW4Q72XvGz/IRRgpZAO/xaAKRrWPpcSYJ?=
=?us-ascii?Q?/HCT+ZcMMc0bYx+IOnS65qFBBcG+KoubblXXTVr7b2tJ6dc9HzvvFFRPl/IA?=
=?us-ascii?Q?JKqO8NFcQsg++j0vjDlWJ/bJqu1NgKK3QPjLc25yJNpM0QhyX8qyijI49xku?=
=?us-ascii?Q?uzsprs3i9K2REqTQcLrJ94+OK0fWra+kdvEJoPrgWRCrlJacXCJiX93p13TZ?=
=?us-ascii?Q?BwKNNQXv3hWFRp+PucMcfnVdDwi0r6ggK2zdc9rMQ3LqDdoh3jQLuzNtC5Ds?=
=?us-ascii?Q?hiPmOYxKL/glfx/UKCif6rOjwACHB6auaSDvl1pMkUbVgUxm99+RppBHhfpy?=
=?us-ascii?Q?ebf/HwIL6Yo3f1SYr52nwGRb8gPMG9Z6e4WLTI2W6xCSY8rAQwMku3iZ6k3W?=
=?us-ascii?Q?rUAXvMkRctf/LASIXpa1xz4wsUVc/GjxF46+7aNQbG7IroCP2Uts5cPOK0JN?=
=?us-ascii?Q?tNQvqnbw/lRPUtBomwcqvvPqW6PilaNCtOIBab5qYh4yu3xNEk7TQ849OmVG?=
=?us-ascii?Q?PhGmIHssCOCWypN/qnMsdeVB7TM6oTdP9vJedgk7+Ls260zfIB5+eHBDMIXR?=
=?us-ascii?Q?7ow+8RVN+i2+2NztEPDn5rCs8YsC1ETFAT8cMoHjwTvIkYyxUaEr1SkQ1sih?=
=?us-ascii?Q?D0wrrd6twafsS4c4122/gtUWhQU5GgVMJWk3eP4YfsYKAfod7V/yjewWRAqK?=
=?us-ascii?Q?DiaOMCXfQv6NpYVutBREusgDgM4JqU12GJsj/KZC2IRBZfH85TfMSbMfH0/R?=
=?us-ascii?Q?UzYOJtRWo/piYIRWN3qyExV41IQ0zRM7RMk4EFUrP8K1qsc3AhjWQmRPd3Pb?=
=?us-ascii?Q?wQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: silicom-usa.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3517.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a6063db-0b9f-4eb3-26cd-08da01147da7
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2022 15:01:14.5114 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vNuLz3r2upMaQ6XgdnuIvkKdzR4KvfrTzkEWHXSjEEVC8w8cb8fYvPZAGqqzx3UVYv3wVeaQu+MbtlLI/PXyqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6301
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Sunday, March 6, 2022 12:56 PM
> To: Wang, Haiyue <haiyue.wang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; ferruh.yigit@intel.com
> Cc: Jeff Daly <jeffd@silicom-usa.com>; dev@dpdk.org; stable@dpdk.org;
> Stephen Douthit <stephend@silicom-usa.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Subject: Re: [PATCH v4 1/3] net/ixgbe: Fix ixgbe_is_sfp() to return valid=
result for
> X550EM_a devs
>=20
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments.
>=20
>=20
> 01/03/2022 12:18, Zhang, Qi Z:
> > From: Wang, Haiyue <haiyue.wang@intel.com>
> > > From: Jeff Daly <jeffd@silicom-usa.com>
> > > > From: Stephen Douthit <stephend@silicom-usa.com>
> > > >
> > > > Currently all X500EM* MAC types fallthrough to the default case
> > > > and get reported as non-SFP regardless of media type, which isn't c=
orrect.
> > > >
> > > > Fixes: 0790adeb567 ("ixgbe/base: support X550em_a device")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Stephen Douthit <stephend@silicom-usa.com>
> > > > Signed-off-by: Jeff Daly <jeffd@silicom-usa.com>
> > >
> > > Acked-by: Haiyue Wang <haiyue.wang@intel.com>
> >
> > Applied to dpdk-next-net-intel after renaming the title to "fix FSP che=
ck for
> X550EM devices" to fix check-git-log error.
>=20
> It seems you have applied only the first patch of the series. Why?
> Is there a good reason to split a series without any justification?
> What about the two other patches?
>=20
I should explain the [PATCH v4 x/y] and why it changed from 7 patches to 3 =
initially..... In Stephen's initial v1 of the patch series there were 7=
patches and during the discussion of the v2 version before Stephen left he=
intended to break it into 3 separate submissions. After speaking with Eki=
nops/Swisscom regarding the best way to move these forward it was decided t=
o move some functionality back to ethdev.c. So currently: [PATCH v4 1/3] =
is basically [PATCH v2 1/7], [PATCH v2 2/7] and [PATCH v2 5/7] were reworke=
d and included in [PATCH v4 3/3] . [PATCH v2 4/7] became [PATCH v4 2/3]. =
I submitted 2 separate patches yesterday for what was [PATCH v2 6/7] and [=
PATCH v2 7/7] since they were small patches to base/ rather than ethdev. =
Finally, [PATCH v2 3/7] i'm working out whether it can be reworked into som=
ething that only touches ethdev (could be more kludgey) or really kinda jus=
t fits into base as originally submitted, like the last 2 patches I submitt=
ed for special handling of some SFPs.
I discovered the ixgbe_api functionality the other day while looking into t=
his, and was thinking perhaps it could be somehow done there. Still under =
base, but not touching the main driver files. Is there any documentation =
that describes the ixgbe_api usage or process to get a wrapper call added t=
o it?