From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0728A0547; Tue, 31 May 2022 14:31:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A514440143; Tue, 31 May 2022 14:31:03 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00131.outbound.protection.outlook.com [40.107.0.131]) by mails.dpdk.org (Postfix) with ESMTP id 75E97400EF for ; Tue, 31 May 2022 14:31:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dZxMhn5GrhmvWFwpBIKVbsWh5x0qqSGvTr8twcxXzkd5M1ngB8PK8upAsr5xFU0IT5h3hz3ANtNprfipN1HZCuYcPaqvFF1f2nnSMYSHV1xQVQKZjBC9dCL/b9LGgJl5miGPUZiDtbX7uK1RzdEb3ZIWhA58XC82HPFpHDZdHNxuqUBXy/u0XrLrIWfd0NSLQs6rZNP0az9MfivMM80SuN8OSV9YNDUNMlF3pnAfb1Ux6kSCQ9xIc5VCiKB9bF2Xi9shy3YaM60fWnLAdnviEnKI/K9NXVm2XFl6VfVXB0xMpA+xLJ2qEJH0W5H1TtDNRQx3WXQoaM3IP/qZCP5PGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3MIJX5jLA29fhL9nF3Wep4n4sAjcNmrQd2N8Fij4C7c=; b=hQ8TJCady9THvob1ex3Q3Kf7SvfQnbNPkeBt84sHaP53zeChakcoVEAH0IOTHJ5/9DrGtvzO8I+x/ORx3KY0SbQx+1niwS4ZiwfVJpSxyusVgqR9h7DwSyzbxDzs1NbTMcGs+sw7ukno5Gk9Fxih8N/WL0J9is7E5+lLALTaaGH+xPB0zR9aAyh2heG2OacjrKIM8xvMHhrDbaMofDOLws7sDIfG0lTpF5LptNh4+kmjYI0VUKMy17l2NOchSlD7N7XBAvn4/oNym4LcZSekJJFXqANcVibg3/uqZmVbxVSb19jBJ7QUCQCT+4LYny3fyDg5D9PE+q/NtM7GGBPaag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom-usa.com; dmarc=pass action=none header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3MIJX5jLA29fhL9nF3Wep4n4sAjcNmrQd2N8Fij4C7c=; b=V+ofHZmwk41QCnKwecZ6fpnQyQv4gE7eezPJTmRPQ3qYUP2Wat86jCnx/tcH0BUHBS3zS/+9IhmyBqvJZV6XWIf/Jj2CKEcvMDHLMSk3x2V5MN5Y0gXReeM0BQN+E5TQjsypicPts2GWetjAhgJ0AIXdjdwmzHNSTYm1F4Kgw88= Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com (2603:10a6:803:b::16) by PR3PR04MB7339.eurprd04.prod.outlook.com (2603:10a6:102:8b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 12:30:59 +0000 Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::9198:ca97:d3b9:d3cc]) by VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::9198:ca97:d3b9:d3cc%4]) with mapi id 15.20.5293.019; Tue, 31 May 2022 12:30:59 +0000 From: Jeff Daly To: "Zhang, Qi Z" , "dev@dpdk.org" CC: Stephen Douthit , "Yang, Qiming" , "Wu, Wenjun1" Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Topic: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Index: AQHYcUFXvA8cZ9eKhkOoIjWYX2Z2va02ejEAgADzsfCAAAgRgIABevlg Date: Tue, 31 May 2022 12:30:59 +0000 Message-ID: References: <20220307223442.28012-1-jeffd@silicom-usa.com> <20220526204355.5014-1-jeffd@silicom-usa.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silicom-usa.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1488e0fc-d7a7-4af3-62bb-08da43016b1c x-ms-traffictypediagnostic: PR3PR04MB7339:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oGnRLtTsOO4tgH4WJ/X4fZatJbOUi3no4GVMmXBwt3SEDp5ATLHjlYLYp9ozFJ3L7zghE/TmuBNXMIZSFWPSIoaZNYmtgaRfCLQaOu8sJjp5xpeja/wH7e2SoRbTfQXY0MljAeQaV0hPBPSo5/ttL6EYAutbv+4aIQtxykdL1ffXO5m8q0GLjLXF79KJ8IsGDtcJj/OHraaNDh2PBsBbKMw3u9eVHU77AvMtuXPBfnEybhYz88gE06uKcwIz2ZyrjEa5oPPbPwwxb+GdLBw8u4KT+CabYd4IPRAI1f/t67aQ4GnZ4smhqOZU6D8BKoe/6sWeI7dSxImYa5TeH4ePcKmz+Bll69inZIpiolZ1GDAhMQvPMhHeNBwm+MyQFnaZ6Wt8Bc3whsbwH16X9Hp9uzXUG1HgsNOHMO8/tcZwbdn3IiRcL2NPPZugwAdGrm9tds1EfSDVwkUigO88flCfF9u1JaQS+6v/h2jzoxuVEmaJBjDO02Impk7u1+0kczkmNG5UZKytqrp2L5UJHwz31zIqX6YpsgFLDhQLXxWMuPqXwVldx2rWRmevVU2Y03c/TvaM5UZM4JZXwoIQTSWtj31/hx8xe0oBBADumw1WI2dVm8QKHUM8mgUh3FUW2QH9Ckl4BFuaIwBYJsjmug5cX/zTFjfd760ltFsiuGHKnMqrNJ5EZWbFyqS8xlSK6Qr3BQnfNqpCIcMqaHrLiBe8rQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0402MB3517.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6506007)(122000001)(186003)(9686003)(86362001)(55016003)(53546011)(38070700005)(7696005)(54906003)(38100700002)(316002)(8936002)(52536014)(110136005)(4326008)(8676002)(66556008)(66946007)(2906002)(71200400001)(66446008)(64756008)(66476007)(508600001)(33656002)(5660300002)(83380400001)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0NlTflOFjSS389x7VgJJ3vpo7OgwrZx7fIq106x3yz+lkffvQzJSRhVIzh+C?= =?us-ascii?Q?4QVEOiVBSwIVpeU1fxsGV04P4wRqe7HT1owNS9lYHN/ZO/+E4ONYI5CV0hYm?= =?us-ascii?Q?Wu7+088X0jZOKkI0H/L6YxNNd0t2jgunFmDoYbrZeHvcuGhS7/YQG/OXDI3C?= =?us-ascii?Q?srlUiSZc0UGI16XiF+cGAyNeK/jp0Hq/msy0Dm2//f15snpkugZR0Js2+Fyh?= =?us-ascii?Q?nCrRV0xLuoHgCA4fKJZYC5I6cosqRu3fvRp0d6AHncebbwezcMZQ7lWcqLlF?= =?us-ascii?Q?Bb5Fo0kO9/cFDEmPmd4q7RaNiNInACls1F0zRKYfRRvZAkmBvf2wRm3GeM4q?= =?us-ascii?Q?8VTileedUv/f7oihGHQ0VEuOCagKHGgiSHaAH0YwGkI99I7puKJOJmlTEUPH?= =?us-ascii?Q?Yg3RMJvfkv8tuMbK7JneNrtTiC1xGpQt4Hmt+UiZw0Ov4txdLQNjU7JetJFI?= =?us-ascii?Q?04JQFrN4haJsEi4kIE0AkmxI7gPIgL3lLVPj79aiDRnUxMXEJmEcpcelEaWX?= =?us-ascii?Q?5EOlA1y4lDhQVQ/LmfZHMdEKf8rZxW/3ttMhhNj2S4ltA0zRHZ2Ult8DRa98?= =?us-ascii?Q?ITGciMSX1EvyLK4d1z5F25jLpy+6aumNZhI83phPtylx+s9MOTQaEpfZxiAX?= =?us-ascii?Q?4MuqoFy8CgoIlEhbUgQnlb0HjcMGdf8n9h+3372kjll7NYRqcf8W9gBRDvJh?= =?us-ascii?Q?Efp3SdIowUjNu5jV70lyzTL/zjSHzuxrWUxy48QgHNj1xALcBQTLLU5RBIOe?= =?us-ascii?Q?IIwqw0Bgwqpcw2iJhskCgtCbcjKhFSKVTA2ZPZcJ6lalmgXlXv8Qht6rT8BY?= =?us-ascii?Q?JtRMjTpJ8c2/ucKG7QtK7wVRBDk+LWV3cKnqxlSlW38nojHgZqCimP6SZGFT?= =?us-ascii?Q?kd5Eyu5aUCGWst1JUDQYlCnhIAGCciYP47+qaN1QZuwdNMO9q2rQCXOMUJkP?= =?us-ascii?Q?zhiH9Zq61DGOmN5cLe7hvXMrDF6tMAH3p0NifCeOZg3+WzlngrTTDmDr2YU8?= =?us-ascii?Q?hn4wKnc/PXg3wLX5/Wq/vHS+uIQTHfAEsmNaiKO/D2XvFBv9EFMkWlBfoD56?= =?us-ascii?Q?ELdtZCKD2rrO4oWwvS+eWHOqR0QtkrlLxBBqY5bvIv+r9Vz6LbTMQZ7yEuXj?= =?us-ascii?Q?ThbyhI0P3VEX4pH/AzXESGBCSf48gPt1hkvqTpGPdBqUcYhhfoy2wWO1L3c4?= =?us-ascii?Q?/dWIeIeSQf+1eoLCwXxmdPE9XJW2r6j/Uc4foB+oLPdicRnyO7VaCgWH0TBj?= =?us-ascii?Q?2cWnxRO3gF6gIRJylkRNdslCqJTrpt8Buo6gl3mx7Q0yeuvZ5dnlkYi8AjPZ?= =?us-ascii?Q?ECylH8ZdCDASnNHOEUDy6utfhwXJSzSmQngvC8OrkSE9DGtvfQ8KjEhuURQp?= =?us-ascii?Q?Mzne4Qz6XU6c86/1pmjVGvrtsf0G8UfeawcWjl2mHnfPY2/p6+66klWsKgBp?= =?us-ascii?Q?zAW6jl+AmAxdry4R9Jn6K6nDbrqextqY6JxqNXMNX21LWZ9ACeDzbMEknZse?= =?us-ascii?Q?11655xwNYVnt0TnBukFJy2vTE+yzmScV71xsWo7iM2jyURXUrAg3xyjCz0fd?= =?us-ascii?Q?Ny59GXCvlJaL6gLAfHtBnoyBQi11oYYJzAdlCZjewCahFSdhN0D6kn65+WY1?= =?us-ascii?Q?LbSLuQzL9iBxHABkyRZjoMhvmB8l2BsOVT6cQJ+8UWITNI8yX8rT9Y2RXntH?= =?us-ascii?Q?kyMfE+hIALvMPukpbqQRtf9AHBt3RlyJS7iCl9F9cecA38Zt9Y9rEiwiAHLr?= =?us-ascii?Q?HaN33NBdnAzIxwXF60LctMHYsPDTDC52gx+hwtfjPgWp2y7XJtAt?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: silicom-usa.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3517.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1488e0fc-d7a7-4af3-62bb-08da43016b1c X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2022 12:30:59.7084 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DvA4EpzAamJozLroPpfeAYVyPGXpnh2QjzavrVecEEusDaBPv9bfEx1z0KS7ljG9tQ+HGBI6g54JbQr3DZ5xbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7339 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Monday, May 30, 2022 9:51 AM > To: Jeff Daly ; dev@dpdk.org > Cc: Stephen Douthit ; Yang, Qiming > ; Wu, Wenjun1 > Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > devices >=20 > Caution: This is an external email. Please take care when clicking links = or > opening attachments. >=20 >=20 > > -----Original Message----- > > From: Jeff Daly > > Sent: Monday, May 30, 2022 9:33 PM > > To: Zhang, Qi Z ; dev@dpdk.org > > Cc: Stephen Douthit ; Yang, Qiming > > ; Wu, Wenjun1 > > Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the > > X550 devices > > > > > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Sunday, May 29, 2022 6:49 PM > > > To: Jeff Daly ; dev@dpdk.org > > > Cc: Stephen Douthit ; Yang, Qiming > > > ; Wu, Wenjun1 > > > Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the > > > X550 devices > > > > > > Caution: This is an external email. Please take care when clicking > > > links or opening attachments. > > > > > > > > > > -----Original Message----- > > > > From: Jeff Daly > > > > Sent: Friday, May 27, 2022 4:44 AM > > > > To: dev@dpdk.org > > > > Cc: Stephen Douthit ; Yang, Qiming > > > > ; Wu, Wenjun1 > > > > Subject: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the > > > > X550 devices > > > > > > > > 1G Cu SFPs are not officially supported on the X552/X553 family of > > > > devices but create an option cu_sfp_as_sx to treat them as 1G SX > > > > modules since they usually work. Print a warning though since > > > > support isn't validated, similar to what already happens for other > > > > unofficially supported SFPs enabled via the allow_unsupported_sfps > > > parameter inherited from the mainline Linux driver. > > > > > > > > Signed-off-by: Jeff Daly > > > > Suggested-by: Stephen Douthit > > > > --- > > > > v2: > > > > * Introduced cu_sfp_as_sx option, default off. > > > > --- > > > > doc/guides/nics/ixgbe.rst | 16 ++++++++++++++ > > > > drivers/net/ixgbe/base/ixgbe_type.h | 1 + > > > > drivers/net/ixgbe/base/ixgbe_x550.c | 12 ++++++++++- > > > > drivers/net/ixgbe/ixgbe_ethdev.c | 33 > > > +++++++++++++++++++++++++++++ > > > > drivers/net/ixgbe/ixgbe_ethdev.h | 3 +++ > > > > 5 files changed, 64 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst > > > > index > > > > 82fa453fa28e..5db63083eef8 100644 > > > > --- a/doc/guides/nics/ixgbe.rst > > > > +++ b/doc/guides/nics/ixgbe.rst > > > > @@ -101,6 +101,22 @@ To guarantee the constraint, capabilities in > > > > dev_conf.rxmode.offloads will be ch > > > > > > > > fdir_conf->mode will also be checked. > > > > > > > > +Runtime Options > > > > +^^^^^^^^^^^^^^^^^^ > > > > + > > > > +The following ``devargs`` options can be enabled at runtime. They > > > > +must be passed as part of EAL arguments. For example, > > > > + > > > > +.. code-block:: console > > > > + > > > > + dpdk-testpmd -a af:10.0,cu_sfp_as_sx=3D1 -- -i > > > > + > > > > +- ``cu_sfp_as_sx`` (default **0**) > > > > > > Can we make this devargs more generic e.g.: "allow_unsupported_phy" > > > So we don't need to add a devarg for similar requirement case by > > > case in future, of cause we still need to well explain all the > > > unsupported cases in the document. > > > > > > > > > > this patch is specifically to change the driver's recognition of Cu > > transceivers and treat them as optical transceivers. so should we > > consider this an unsupported phy and use that same switch > > 'allow_unsupported_phy' or are you looking for a more generic name > > than 'cu_sfp_as_sx'? if you are looking for a more generic name vs > > just reusing allow_unsupported_phy, then please pick something and > > I'll submit a new patch, but I don't want to guess what would be ok by > submitting patches. > > >=20 > I'm not sure if there will be a situation we need to enable a unsupported > phys in a different way, But as kernel driver take allow_unsupported_spf= as > module_param, so I will prefer we keep the same in DPDK. >=20 edit: we should have been saying 'allow_unsupported_sfp' all along. that's= the kernel option. hopefully that didn't confuse anyone reading this thread....= .. so you realize that DPDK by default *always* sets allow_unsupported_sfp. a= re you now suggesting that this patch functionality falls under the same optio= n? meaning it will *always* be treating 1G Cu as 1G SX?