From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A16CCA0543; Mon, 30 May 2022 15:32:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8AAAD40694; Mon, 30 May 2022 15:32:43 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2099.outbound.protection.outlook.com [40.107.22.99]) by mails.dpdk.org (Postfix) with ESMTP id E71F0400D6 for ; Mon, 30 May 2022 15:32:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jHpzrpUpZ31fEZCHjZtTbZURub34LKcRQXx3OZXzAbXQUEM5LIkdC6NI3dXXKaX1/mhVxtWM8ms9dF0u1LUAIheaVHEQKuY4lOLPaIYHPCo4+rMYdtWs03AdYlr9/Fevnwrt5TNh9gZlLs9dw7NmkzbdJskWaq9FX+70q+X/0ZqZv6PnTOTH/4ogyFJVa7TrquLt0Jgj8KG6hCQZP8YAH2qfGpDSX3AJIxzFqZl+fRIA006yzGvpgaU83agrTtPef/6TMLnQyl7CGRGlOV3LWL/vJuXuYFQMSe3G8w38CLa0aQUGZEbyNbcyEmWXF1R6hefOAMZDg29vfZzxF9RF/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q077EpwqW7l+dSD01Rtl/YadqZyQ+1GYCtqMvdUTId8=; b=lIRVK1vLMOdkq9jiyHaCurG9qpAINn1GyW1EukdCTci/ON6CttAGX6DxOTBz7glCCPYkFnLPlZrJQ3dOjukiAsKqerQ1f+lNfnC2FUROuaUfrkKbt2O7qOU9dVu1Z6OJPJRnwlJDcB7f5T4G1BNUFTtpDGCoPOWjVhTEkNhRtG5a0HM6ORIcQVieSRAEbrbOIlo8vFAU5ES0ZXxvpRICYND5Dhl99A8fDSbKn4e/wr7DDIhRA4oepG8/VlObnXv8Dp+ZG8HtNzWLY85gV0c3X8UOBOLtb+7zrJdTTiy29qkCtKcDl88Vp0bGao8koJZ4BYEKdPUUP2SwHCDfEbUYMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom-usa.com; dmarc=pass action=none header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q077EpwqW7l+dSD01Rtl/YadqZyQ+1GYCtqMvdUTId8=; b=ULQ1CKvbqMCXmm9kJWkBk38j8iu1FI2qXNAVHeptnkenGhe6pXGsyIlEPuv7MbOqKBn4oXm0ZDiYO/4r8YjrTeNsB/Iigy9NYx8l8CD88P5bU9LPOONWLvoI6ql7tGBRfq3aX5/OYTLBR+3b9qPHTvv3JHXSmBvF5HI1E0Y4dtM= Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com (2603:10a6:803:b::16) by VI1PR04MB3134.eurprd04.prod.outlook.com (2603:10a6:802:d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Mon, 30 May 2022 13:32:40 +0000 Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::9198:ca97:d3b9:d3cc]) by VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::9198:ca97:d3b9:d3cc%4]) with mapi id 15.20.5293.019; Mon, 30 May 2022 13:32:40 +0000 From: Jeff Daly To: "Zhang, Qi Z" , "dev@dpdk.org" CC: Stephen Douthit , "Yang, Qiming" , "Wu, Wenjun1" Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Topic: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Index: AQHYcUFXvA8cZ9eKhkOoIjWYX2Z2va02ejEAgADzsfA= Date: Mon, 30 May 2022 13:32:40 +0000 Message-ID: References: <20220307223442.28012-1-jeffd@silicom-usa.com> <20220526204355.5014-1-jeffd@silicom-usa.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silicom-usa.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c2c4284e-3817-4eee-aa79-08da4240de75 x-ms-traffictypediagnostic: VI1PR04MB3134:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fW9G1QViIG89vVBtcA3L2hNfX4WmDRQ0hMGcCWfpda/bSkdSr0spfDcTSmy59V3p2is1naUypmnZwRx+yCQM0x0xhO3hp5qIrBX/um29/26OyDOfI2tMkcWfYqHD1WgsfV2wxUNVzapouIvTNLCynYOg+Ye+BRfo6zk9qzOc1ZvwO0M1wWtSHdOdW2stk+c5VS0UesPwf7LzHg4k12nClgB8WBy5aOjLVybiTeOS+BAIifzKDyIOu7Ay6y2lz3HFY6OkZ9Pm5KhnUY4Cfx+MwV7bl/NkNPVDW97GW1JwHdJNPShAyY7QS9yX8lHPX7j93ZWn1L9r/7YxTCR21yIfmjgpCJMn2ouVJcxXD+JQ7Wx252JcUW4MZ+W3EITovgz+mo2jC0KtepTdpAxMMLZTnEEFkUW+xCT9aQ6rxv/AYrrWWh1UEGdzE4A5mPxq9U+ZazpSWjadeZhvzRTeFNv/eVFc/GHZyR2dvrivzlPURWShB75hhJHs0Mn1K7fprHwGRnEnDv0okC7j2Hwj9uUQJhhfHY2e3+ZeTOw8Tfc24y+53FdrSNsyC7lUZ41s5vjqp76Sh2QswOt1vLpcM+z40xcNJCmK9pStFDiBrQf6L4dj5ymhHKh6PsKfeoYTfJQSRZ7AzpXk6wUD7LKN/SXPtkEJvb4AeIjYbeOvMGifg4U7I9eYeNf5v3rZ0zVbgXE+00iyoCNvzB4NPSNGVBN0Rw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0402MB3517.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(508600001)(8676002)(9686003)(66556008)(86362001)(38070700005)(53546011)(7696005)(4326008)(33656002)(6506007)(316002)(5660300002)(110136005)(76116006)(122000001)(54906003)(52536014)(64756008)(83380400001)(66446008)(66476007)(8936002)(2906002)(186003)(38100700002)(66946007)(55016003)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iNoTR1EoZxFrBc6E4iX1TTAtBcHXk2HdSdtLbB0KyLi4OyRnduJ3oDEjYtJj?= =?us-ascii?Q?whAw4JWz7yFwY+f13cx9G8DNSt+MqB1GU8vvwCDn4f9zHKE7mJI7HlxBG5zQ?= =?us-ascii?Q?fVlPH/fW5tgMcvAguXMeqFgQnBGPD4hKoR8qF3bMcQcIfsL0HyPLSnPzk9wG?= =?us-ascii?Q?RTJhymZW9PViR7qF4xUaWg9I/RLE5EC0DTnjjlQkip1KkHV/HwIQD/MAJQRa?= =?us-ascii?Q?+kptWgdbnzMa5IEhHmExoXT17Kni+k7yVzcHwhymmppYPxOdt9+/HY+GsKO/?= =?us-ascii?Q?fGk6M9TOxqogZ6qcy/DiN9LOwy4Ztt/ExPfECPd6VrffmZz6J8PHM4irlnPK?= =?us-ascii?Q?5xvmTmINfo7W+lQxq9Kb2KvjeZQ2FljVSndKD9ah6vd4u9nyTzTkmjv5X7kY?= =?us-ascii?Q?enLQoMMDxaQaOq/Iiiq9DBDzlgCGXhfUWZ9a513cgVcGDpo+YS1eS8lUH6m/?= =?us-ascii?Q?v8CNSnCZaIPqqbmku8n+3VsU6xcRbyZNBHEufjgmf1nUCDuU4TaO20QoP6Fi?= =?us-ascii?Q?h2WMXvz1kjQB2RitMZ32bcQ+Rkp3CSWXUt+lvckrvzhzIV4ONXsmVGW6hbJe?= =?us-ascii?Q?CCQVroQj2pmbYsx1mHSt3jt05/jtmuEM0LGhFsfBa6WDTrqWrRpB7xQLhjAF?= =?us-ascii?Q?bXJ0fFrxqnrtFmaBDmce9CmtuoLNjhxzHHBvzS5DDl8JlcEdFAb1muh1AGFK?= =?us-ascii?Q?Bgs1HNLauV1XO85R6bZBAcTaKUjKM3JQmlEKUk3pFK8W4H1oSCRjPd5qXMti?= =?us-ascii?Q?bM2vFf+2F8zk6B4GSQLd0iySxynHXfDcVYS7I2FKNpu/t6fLKwRskncol3uv?= =?us-ascii?Q?fDohltD0qL9GIWdoBP2bCuehc6Xe+ayxlPLu00+tuEPdNHZ5EZixLTaBZBP3?= =?us-ascii?Q?P2++wsiPkG1hlRheYM7Mlqx8eUIob2cezP7e1Kgx6xIH9WNDWy7dsf7QL67C?= =?us-ascii?Q?jWG5rO88J7tPAoV8d8LFeWSmNCsILAZCUZ5GwHV7eEZHBSj8BsIZRWc0zYXr?= =?us-ascii?Q?E1Tdn1moeahbAG1iWio7m6emHR6bY8YcUTVe7qssQsTgX79c63WYxZ+/BwRq?= =?us-ascii?Q?cUuaRGAGW7k4dG/UjNO6s93oTg5foIGQcqgwYo0M1SbfL3IOCqMSq5KxhAMK?= =?us-ascii?Q?1ZKTCGEPqn52R/JzAe3dmfQz/FiPMJtJ4IqrB6/GGfjiMl05hb9ulZpI6brK?= =?us-ascii?Q?UVLsBZId5QgeGI615L4lCZTohkdhbItuEBCr6eSBZkT1uCnRBoz3VNsWvIuC?= =?us-ascii?Q?l8LmwVn0CN79rNXO3PJI2pK57Tk7yPH6vrYTSSh3pWz3GdqtIEZ8Kj58B113?= =?us-ascii?Q?VxbAYEqx84/4wpjYjlvfEY7Xl/Jzl8iijRXBpwxxq7Mb/bfyeyi0ZdILZNL4?= =?us-ascii?Q?sYfoGEkqyxWOgpE0DofzmmCEKjraA6YkojerznakjWvNhBfxOJ5txLqf4btl?= =?us-ascii?Q?9mzXvZDLx5Oic5sq7nor45UTfBxUoai/6134MDap40/WRUC+LsD1DB3Vd7pG?= =?us-ascii?Q?1POmMU0koGGNa/jNl3QO+cJzLyoIuZSg3mfGNBeYhbcoQ/plASIswcTDX88J?= =?us-ascii?Q?sG4NsdwlT9C390dnAQ+WI4fhHQbo3S7kPxBjp0xTwl1u1BWyNReFLYkFG2Mi?= =?us-ascii?Q?FeT5BvnjJfRzNqEQ9UvbCty9zzI/AQfyYhNekN9fFbydALupwR/GYvbPSmdZ?= =?us-ascii?Q?in84cgk1s04HuLk7LIEeZG0STK/idm5V2joQCS++A3DE0nAzU6Dvavpb/3F8?= =?us-ascii?Q?zIdDZXLVlhYg7XVbYkbRr4KG2CXzFBs=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: silicom-usa.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3517.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2c4284e-3817-4eee-aa79-08da4240de75 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 13:32:40.3783 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: T4QKy3u3blV6J+9T8Mmm2xysQ6W88kBYm3dCsAGqOcaxby3IyWdl6xCBFVpuDXrHjeE+6xIcc42OF7pbz9E9Vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3134 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Sunday, May 29, 2022 6:49 PM > To: Jeff Daly ; dev@dpdk.org > Cc: Stephen Douthit ; Yang, Qiming > ; Wu, Wenjun1 > Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > devices >=20 > Caution: This is an external email. Please take care when clicking links = or > opening attachments. >=20 >=20 > > -----Original Message----- > > From: Jeff Daly > > Sent: Friday, May 27, 2022 4:44 AM > > To: dev@dpdk.org > > Cc: Stephen Douthit ; Yang, Qiming > > ; Wu, Wenjun1 > > Subject: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > > devices > > > > 1G Cu SFPs are not officially supported on the X552/X553 family of > > devices but create an option cu_sfp_as_sx to treat them as 1G SX > > modules since they usually work. Print a warning though since support > > isn't validated, similar to what already happens for other > > unofficially supported SFPs enabled via the allow_unsupported_sfps > parameter inherited from the mainline Linux driver. > > > > Signed-off-by: Jeff Daly > > Suggested-by: Stephen Douthit > > --- > > v2: > > * Introduced cu_sfp_as_sx option, default off. > > --- > > doc/guides/nics/ixgbe.rst | 16 ++++++++++++++ > > drivers/net/ixgbe/base/ixgbe_type.h | 1 + > > drivers/net/ixgbe/base/ixgbe_x550.c | 12 ++++++++++- > > drivers/net/ixgbe/ixgbe_ethdev.c | 33 > +++++++++++++++++++++++++++++ > > drivers/net/ixgbe/ixgbe_ethdev.h | 3 +++ > > 5 files changed, 64 insertions(+), 1 deletion(-) > > > > diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst > > index > > 82fa453fa28e..5db63083eef8 100644 > > --- a/doc/guides/nics/ixgbe.rst > > +++ b/doc/guides/nics/ixgbe.rst > > @@ -101,6 +101,22 @@ To guarantee the constraint, capabilities in > > dev_conf.rxmode.offloads will be ch > > > > fdir_conf->mode will also be checked. > > > > +Runtime Options > > +^^^^^^^^^^^^^^^^^^ > > + > > +The following ``devargs`` options can be enabled at runtime. They > > +must be passed as part of EAL arguments. For example, > > + > > +.. code-block:: console > > + > > + dpdk-testpmd -a af:10.0,cu_sfp_as_sx=3D1 -- -i > > + > > +- ``cu_sfp_as_sx`` (default **0**) >=20 > Can we make this devargs more generic e.g.: "allow_unsupported_phy" > So we don't need to add a devarg for similar requirement case by case in > future, of cause we still need to well explain all the unsupported cases = in the > document. >=20 >=20 this patch is specifically to change the driver's recognition of Cu transce= ivers and treat them as optical transceivers. so should we consider this an=20 unsupported phy and use that same switch 'allow_unsupported_phy' or are you looking for a more generic name than 'cu_sfp_as_sx'? if you are lookin= g for a more generic name vs just reusing allow_unsupported_phy, then please pick something and I'll submit a new patch, but I don't want to guess what would be ok by submitting patches.