From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8FE06A0353; Sun, 10 May 2020 00:02:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 68D8F1D67E; Sun, 10 May 2020 00:02:46 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150054.outbound.protection.outlook.com [40.107.15.54]) by dpdk.org (Postfix) with ESMTP id 4F7181D67C for ; Sun, 10 May 2020 00:02:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CUPpesL9/w48LVJZM/LegGQDUNLHbKfUhr9FBreyVXpiNrKBSjDlguaxTKGmRUgC5G740q4YSXWCFfS11sGaXmIU/3jb3LaNz0PEpIfkFztGZV6xSUVec6QV32gxSPM8i8iQkLD8adoi6lHaQNoSa+RFCeWUucUfUnAocFcnLh4LapE8DuX9wCA8Tb9F7XsnUvKrrbLkZXJHDfYQRZy7wAFTiwKnCxnoHv9grfIgGeS8og2vrMlHfmEe8E1H3HQDLvEcm6QoPbaKJkdvKsnsr7LeX3xvOySdDTI7BY9pwu8nkGhtD91FAV1I8ytCoYqjbtziHt9DXVAvvvD9b6EzRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vbwi+LZRmSHiLXaMjl/0xK2E7okirNv4DI2JgQMJ/kg=; b=WEHa3gql55erZO/yUFmWh3hMYsWz2O1gk3JY2hvq7pgq0T8Dy30n/tr/7NSxTkFRpIWdDMbQGPaBZaP9S71Kg+f8YR4PRoBl/nGqSzshpMQ8umhPkThKhUg7dxS7alowlbVwnts8JFgptGpc1xAvgAaERxw1LZgV6nfSGqfFyWWuCPk2x5yqLexDtPAXmgPJIlFYeGk7/ymFWOelH2JN5FaBMYC+ORal5XuLWoZZorbqHBMzQpa5jp7OA8dLfxD1T80/v6EddxcEFViVYm9g32K59hCfycWSF8Sdzt/VhtAVlCu1TeNe9wQwtOUwcNfnzeWHbBkumMIzZZO8KyItiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vbwi+LZRmSHiLXaMjl/0xK2E7okirNv4DI2JgQMJ/kg=; b=Ffz/eQFSbdnnqDgWv+mXLMAnycNaDhqgqgjpsRULluHYY/DJ79T53IVVi0Y+1B5TgOMdxwHEefC8riEm1HDpZ3Hv/+qz+XVmVY+0hrW7FwXjHZxATF6j0hLBtx5tRaL3oxzbUdVeG4G3iAySoGOdP32gFYwdn4Lok9jm68CTS7Y= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB5037.eurprd04.prod.outlook.com (2603:10a6:803:57::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27; Sat, 9 May 2020 22:02:43 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74%7]) with mapi id 15.20.2979.030; Sat, 9 May 2020 22:02:43 +0000 From: Akhil Goyal To: Anoob Joseph , Praveen Shetty , "dev@dpdk.org" , "declan.doherty@intel.com" CC: "bernard.iremonger@intel.com" , "konstantin.ananyev@intel.com" Thread-Topic: [EXT] [PATCH v3] examples/ipsec-secgw: fix negative argument passing Thread-Index: AQHWI5XhoV0aHVqE20qJNfj4MvhRSaicBesAgARN7+A= Date: Sat, 9 May 2020 22:02:43 +0000 Message-ID: References: <20200506103752.20478-1-praveen.shetty@intel.com> <20200506110241.21118-1-praveen.shetty@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.118.167.66] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: bac236ec-d0ab-4ad6-cc6a-08d7f464b2fa x-ms-traffictypediagnostic: VI1PR04MB5037: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 03982FDC1D x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aLa1O8QiS0I0g3cHvhrJtku0eha1BaO8HBI8QkQ5iDM9L+2vrCOf6MCKAEEu/PAi7H/LSeaGOjbRcviVo/1A6Qyz2AiJRJKQ1Sk3hYP2xU332+xqUw1lXzLVv7wuguUCA7RbfbIecbkFbYwYvE9EQRQG0PSYEWmokB+rRJXBByrae1riIMTzC5Hd6Lf8Qq+HYcvZY6iZXoc7+YH7gOmvvyeS3FdCtvD27GQSRcqNGXf8xY0oqIzvQkA1NEwMaN6q4/fEsUR9TakEuAXUCqxYEUkS011+ZypOjN4jLXPajSPUlJ9C7dlHvYPFvVp5AhK8b94kK6YRp6vJj9v8+Cdcm5zi4g62IUz9ZDFWC5a1e8pMIUFq7P4hSh0IESUGBN6takmN7hNPT7OVkPAubXwqDeUFYUv/7tqMIHlGOQtujJOO6odzd67DCQpTY3sjFxqRac/LRQA93Azb50N2+5dKqIRsrWDKpo4eDl9A74o3Bm5lLRDgygwTPOQgNri+LiTTkiOZRiKiX9rV7t2gs3dulw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(39860400002)(136003)(346002)(376002)(396003)(33430700001)(66556008)(86362001)(44832011)(52536014)(66446008)(8676002)(33656002)(66946007)(64756008)(66476007)(4744005)(54906003)(71200400001)(110136005)(8936002)(316002)(478600001)(76116006)(9686003)(33440700001)(186003)(2906002)(4326008)(55016002)(7696005)(6506007)(5660300002)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 1+4smzieC4Xtx2WVTqEYaR6+zZQaiGjwkGClUkF9Dfis5HqG+q0/AFcq7CPP36OtlMSlT86G7sMjQHtnYklq4Xn1upCudQ0QLvbgIbwVTW8xO+H18aIlNHULJMjDCsaYUl1CNxByM43jckztFwPmYR50AIzEn8g0/RJHapbPA0vy6DxaxfADrs+7EEuUa5yRkdHQ6/WyGCOhBca0j1VpWbrEINn/ECWFQcoUfhQC/xp6M7UkL0lNNKkHlf+S4S0EJEfDYYpwX8hZHTY9TQV788YbnJBnu6BmsRI8NwMZxx/gwpe+uhWpWyRp+u/dtUAQEfad9iWH9JUWKa8qMK/vv9yVJaq8imI0/G83Gq9rsh5WiKJycS99sAYSVP7UBYWDVErjLrF1ZeRmVxB0u2fRjJS6WC/2/72RfSCb+MrhyVyau94EGBIMLNz56dfIN2KeMuOs3D0/mZ/MZmYAHuVmowrVWYjB9f1ty7bz73Xok2BqMToqDW0z0sICFD7zERAy x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: bac236ec-d0ab-4ad6-cc6a-08d7f464b2fa X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2020 22:02:43.1133 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dB/6CZeE67hlYlckt1Nvcwhcd9n1B7ryr1tcmnc7hQOOuqkv1tzMMijjHuJON2A+TdigaDBjAo+5jPTSTvOA7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5037 Subject: Re: [dpdk-dev] [EXT] [PATCH v3] examples/ipsec-secgw: fix negative argument passing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Function create_ipsec_esp_flow returns a negative number in case of any > failure > > and we are passing this to strerror to display the error message. > > But strerror()'s argument cannot be negative. > > In case of failure, displaying exact error message to console is handle= d in > > create_ipsec_esp_flow function.So it is not required to print the error= message > > again using strerror. > > This patch will remove the unnecessary calling of strerror function to = fix the > > negative argument passing to strerror issue. > > > > Coverity issue: 357691 > > Fixes: 6738c0a95695 ("examples/ipsec-secgw: support flow director") > > Cc: praveen.shetty@intel.com > > > > Signed-off-by: Praveen Shetty > > Acked-by: Lukasz Wojciechowski >=20 > Acked-by: Anoob Joseph Applied to dpdk-next-crypto Thanks.