From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87691A0521; Tue, 3 Nov 2020 18:07:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9D3A45947; Tue, 3 Nov 2020 18:07:23 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150054.outbound.protection.outlook.com [40.107.15.54]) by dpdk.org (Postfix) with ESMTP id 068262BF9 for ; Tue, 3 Nov 2020 18:07:23 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ag7jkUrfoW1vfDxQ1ifuT9VrkeNX/bc8JOMpyBo7RKGu3f9BLWbn8SKcFRwXHPvQ9iFNgJUz5Lqbz4fqUC7xI24OS1HnLhvpJ+RGtq9Zrf2dO0/YB6PlUjPOB2KNnUiex9aVwuqxAxns/tq7VxzhcQorccqyK3a9BYSkBYmlF/vai+HJDvzgBJkcmVSjSKCBcvYnYXpKSUGK4CRuQ2V3cia0UK58SiWUCPtCGPq7WkTIbmZYO5+XzGatKfRHUj33MvmBJ7jMW92vGDIboM9XP/WJNSlk0X2rS8qrbSDd3pRQzdbvYZlBP37nIsY3Q4ezdY0l/8KA5CGlzB4s2Ga5yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f6HNVwngQsWeWKIVld8qKrbJZYkfZqjw0VIqt3r97E0=; b=XCMGuIvZKX+rQ/PYTzphsobiHQfSL3k+XF3UvBR9eTB5Fu1EJIJ2lMom65/7miM2IdsPzL0MzzBVD7SM8m5vCaK6VnypX6FNmbc0fqzW2hc5020XPS6gaJf6BaEcfWLyE03gf/q9dmlrZvtCkVsjZTT9SOj/MH9eaVvz1CR/iWfoRZFUpdEr1GARRM32NY/FeHTnlaqrVybpac5r7sSOf2iDGwk+gxlc2hm+PU85w0qoNmXz8Hhi7C1WaU7WOW43JHFwGzU5s3cHVmmevZ/pBE+G53QRg89zQ9WdC2xiiyIWkgnZXl/Tj8EAyGgA5MTtKt5L+bbMb4Mc+0IUumifAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f6HNVwngQsWeWKIVld8qKrbJZYkfZqjw0VIqt3r97E0=; b=B4+kQjhmkYcJPub2NSuH/1qv4MiojvnAlNoqRNouO4OMuyUN/LKs8KUxT8MgQsI6ae447/AhRegwU4hJ56AYKCTIyOc6x9jn4rsm5RmWjS8sJnDGYo8M5XHrD64cJIkx34iO9SVsrNzYgsDH3/UmNaWLSs8I5xaec647IZlksW8= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR0402MB3373.eurprd04.prod.outlook.com (2603:10a6:803:a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.28; Tue, 3 Nov 2020 17:07:20 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e%4]) with mapi id 15.20.3499.032; Tue, 3 Nov 2020 17:07:20 +0000 From: Akhil Goyal To: "Gujjar, Abhinandan S" , Thomas Monjalon CC: "dev@dpdk.org" , "Doherty, Declan" , "Honnappa.Nagarahalli@arm.com" , "Ananyev, Konstantin" , Hemant Agrawal , "Vangati, Narender" , "jerinj@marvell.com" , "Mcnamara, John" , "david.marchand@redhat.com" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions Thread-Index: AQHWrpUd/M0tQ0WGjES5pYkR0+gFBqmwdpQAgAADXgCABCBsgIAAm5/wgAC3aICAAAeRwIAAGEgAgACLe4CAAAliAIAAA1xAgAADyQCAAAB1AA== Date: Tue, 3 Nov 2020 17:07:20 +0000 Message-ID: References: <1603926611-19086-1-git-send-email-abhinandan.gujjar@intel.com> <1882047.WhnCstt3cK@thomas> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [171.50.183.179] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 14eff11f-dbcf-4c69-79c3-08d8801aecd6 x-ms-traffictypediagnostic: VI1PR0402MB3373: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: edoZvRb77cc/tzdy6yi/BZ4n15WDdsEW12VBSuAhIEJI76iGrKKP17SaH4OPF9QFO3CDDP1CHvOTkvZpYw7xAWta1VrOMaxVYWPFy13BkBOP0xLPpgFdfmzgG3adODLX/GAyc37eCwjirnPlUOzMUUUL190YjUjzYTrKZqmFtDb1Y8zqdRVH+QFF6BnYIhYPCzJ0KTncuc+6mdF4Cb3VB//RJpoXT7Iwr3/SvJylflguvTAP3PIdnVYjSbzM0LpJzPC03nHRWHACCIwdnh3MDpA/0NCuijenAFZ0tAZknGMVcK8iInDAYaJZFLvsE5JOAg+culUTdpcPMa4Mj10ZKA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39850400004)(396003)(136003)(376002)(346002)(33656002)(2906002)(54906003)(71200400001)(55016002)(83380400001)(316002)(7416002)(110136005)(8676002)(5660300002)(66476007)(9686003)(86362001)(478600001)(66556008)(26005)(186003)(8936002)(52536014)(66446008)(66946007)(64756008)(7696005)(6506007)(4326008)(76116006)(44832011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: fufYF5QvWIeW8s6UxqAD3xwyweaBIwrV2dzIGFxvlYv6VFlHFwgnEnJg3Jxj/9WSzYWXsEzORkz3MHtwzbm7KIlCz8UOosSimGJFCbayZdqqMA/WooVub58zq+0/L/h89xmzIkhUxVeP5zxMXHBM9XfVXWxe/NsbXItx19pN6iyt+BG7TfUNQISH7YdLlgaPkkBBT5XCNpNkXM7hQFQia8kGq8XNAvI2FlSO4v8u4f7b+CXGjMr7w0bICR/jHNAOzZ6PzlU3aosI85BIvWywP0aP3GCuXU8oBsswUkF0N/cKm3uyn0R+dGwZbHUqs6a2jXM7zTExng1OsfHm7aSpTmkZhM+eS/X+cVbQ0zpkQECb3ePAyLi7XjGeqK/u7ZpZrXIcYZM4RHGXbDUdaiaczN8G+FMY4qvuVqGxXNJmKmT58p3YY35OorEuIKL+GYN52v+NsP3rT74KCW/OoZVxepMjsGCJZXRRqhLKReVIVaAiySMDltulBEXPJsi8pw0VASY1UvFlc8Uf8WAdIkl2tkz43HPuqt9rvcAJSRxN4faPH1FbJ+7TgYK2PzABh5yFyzLqf36XQyip6d9Va42H5akkZwGcNx2o8GipTrRw3pnf89cmIPS77wpOKH6ZADkqmvBjRJmONltaEsXuk7veWg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14eff11f-dbcf-4c69-79c3-08d8801aecd6 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2020 17:07:20.3179 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RcnBPREgf9kg6DZo0mapochLZWiF9r8pDSxE0UajxxTkIeDy6K6fGaXL90AnfNykpG0cmrc0eFmjnVy5f8ZGYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3373 Subject: Re: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Hi Akhil, >=20 > > Hi Abhinandan, > > > > > > Hi Thomas, > > > > > > > > > > > 03/11/2020 08:44, Gujjar, Abhinandan S: > > > > > From: Akhil Goyal > > > > > > As I suggested 2 times that there are documentation issues. > > > > > > Haven't seen a version To fix that. Please check it at your end > > > > > > and try fixing the timing of your system so that CI Can pick it= for > > compilation. > > > > > > > > > > As far as I remember, I have pulled in all the comments from you > > > > > for the > > > > previous patch. > > > > > > > > > > > > > I understand that we work in same time zone, getting feedback > > > > > > > from you in the mid night will not help me/you to pull this p= atch in. > > > > > > > A quick response will enable me to prepare patch set quickly > > > > > > > and send it > > > > > > across. > > > > > > > > > > > > I am not dedicatedly working on your patchset. I will work as > > > > > > per my > > > > priorities. > > > > > > > > > > It is same for me. End of the day, we have mutually agreed to get > > > > > this > > > feature > > > > in. > > > > > > > > > > > Had it been a CI pass for compilation for both documentation an= d > > > > > > code, it would have been applied last night. I could remove > > > > > > those extra spaces, but there are other issues also as the newl= y > > > > > > added APIs are not visible in html files generated. Please > > > > > > ensure that there are no issues in doxygen build issues and > > > > > > should be able to see the > > > > newly added APIs in html guides. > > > > > > > > > > This is the kind of information I was looking for, which was not > > > > > available in your previous patch. If this info had been available > > > > > quickly, I > > > > would have prepared next patchset. > > > > > > > > It seems you didn't do all the checks you are required to do. > > > > Please be kind with Akhil who is working hard for the community. > > > > If you want to accelerate the process, help by reviewing other patc= hes. > > > > > > > I have done enough follow ups with Akhil and we both agreed to get > > > this into RC2. > > > I did not realize that CI did not pick up the patches because of > > > mismatch with my system time. > > > All I am saying is giving this information would have helped me. > > > > I highlighted the documentation issue and the system timing on Friday i= tself. > > When the fix was not there on Monday, I tried to fix on my side which t= ook me > > late To comment back. Had it been done by CI, it would have been faster= . > What is the next step? >=20 I have closed the crypto tree for RC2, and it is upto Thomas to take it dir= ectly on main branch.