From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E06CA04B7; Mon, 21 Sep 2020 11:30:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2666E1D8DA; Mon, 21 Sep 2020 11:30:36 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80048.outbound.protection.outlook.com [40.107.8.48]) by dpdk.org (Postfix) with ESMTP id 7A0941D8D9 for ; Mon, 21 Sep 2020 11:30:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OvhZR7yablm4Ox4dz9vP6Pw8mnFrGBA1ekyQLtHJMctBA2mcvRySeNXLaujz16cM01wksxjLrjFQJQ0IWW/sWBlIRK3S7g2Fwfc8rwFbPfWcffAH2s7Cr9SqWQx4XK5cWwKWkU4ixtlWylwiAvu5C/ENH8xYddcB1v5juh44N+cz7AqQw3ix54mkTN3E9ZxtS1aWs2+oAP9kT8GSYISWho7jnKX8jPM234AGJGz9uyxH4kBQQpmrqzH+TNnY3Xnq9Ov9smyKldEPjfjFJOPr0XA15sVIOvOm/eWoyB7c26ZfrI6oWw9hJn9M+rc0ICMaMklYOMbguiio0IgYbjMyZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fRJ71EgjKm4LidHsvLoYBVpeEX03kHKH+k95ZYaZ2Po=; b=GXHwIfpPZOHGS/FV1LmL9nhTGiO1I/TPzv0q/A+8t53dJuu1cYOjaUGCEhrHvUKdl4zY0f3J+4SUd/sYgPLshd1bPYS1JdHycg645eiOIsKEWuM/jharAZPRnrrIe8ufc1vIQneX2H18EA/JhX0xQfEexYfhEyNHtICdDtBL+PirpHumWdo6P/HN62xGwyOcVkng7oX9jWpcIELqqvW7z3pH0vQtLOsanhPh9zkDnuV5Rvftt55G9ISiibUIT+/g36Du8GMkFITITsnCFge6aS4ELqS8kgqwHeGshqsDgH3v9wBP78e0DemnrjADRBxiT0hduw4RSBaR5tmxXFaulg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fRJ71EgjKm4LidHsvLoYBVpeEX03kHKH+k95ZYaZ2Po=; b=TSQxjwFUh0q6XVqs5l5JHX+tfCG1ivsYuJL8LdXhjESW77P08iKWXtR8+VI4+1kY4mWFs7SPXLV22GvyDu3PrPrcJY4r5QzbnWxH1/HmVqu0YvQpuT0e9U8/2zppUS1ZEYg5jSEl4v7opxEjfvKekRm5t1b7dPCWM1AlHT9M4Hc= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR0402MB2750.eurprd04.prod.outlook.com (2603:10a6:800:b5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Mon, 21 Sep 2020 09:30:33 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e%4]) with mapi id 15.20.3391.026; Mon, 21 Sep 2020 09:30:33 +0000 From: Akhil Goyal To: Tejasree Kondoj , Radu Nicolau CC: Narayana Prasad Raju Athreya , Anoob Joseph , "dev@dpdk.org" Thread-Topic: [PATCH] security: allow application to specify UDP ports to PMD Thread-Index: AQHWgbXiDyRShz8tqk+E/9HUS5aMBqliR4EQgBCkCICAAAJ70A== Date: Mon, 21 Sep 2020 09:30:33 +0000 Message-ID: References: <20200903064206.16208-1-ktejasree@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [122.162.67.38] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 96d1fde2-ef1e-4b92-5a6e-08d85e10fd56 x-ms-traffictypediagnostic: VI1PR0402MB2750: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cL2FZS/Rr+XmDSxBYRxo6YGGKK707+8JxlaSA+/+OGdObO1zvDkHbdScanBnpGEfKiRrYbSNerOJg5K2nGY947HXqSYNQA0A+q35s+WH4Vvl0wiAuKkkhxkV6s4Wqij7o65sszBF6+t5cvg0ZrPgZwhVkbHawloU/rnuZsSwZok3IKU1sZdsy9c3d82GiL/T7EOTvBayrWQNu0Rx5S3WgofpHNQ6Vxdk83AQ0oHUPmlQSL4KWqOPE4+yHfOykRs2IFZpDXyV1H6xySDdpSUCvAItiXsLi4X/hbi7aOClMUn8P6b0J5L9wFoXgto23Gd3 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(376002)(396003)(39860400002)(136003)(26005)(55016002)(316002)(6506007)(186003)(9686003)(478600001)(86362001)(4326008)(8936002)(33656002)(71200400001)(66946007)(7696005)(54906003)(110136005)(2906002)(44832011)(83380400001)(66556008)(5660300002)(66446008)(64756008)(8676002)(15650500001)(66476007)(52536014)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: jLCugMc2MQJv8Z3PzuiZRvEmkipSb0+5ITl2lr5ipY6RQH4haXxrJ8ra5K8xM7kKqJNf0XWLMPV3bej4u+acRnpU5Js2WRyf8Y1ERaxFs3wRUEMsNDe5mkFJvKmWyY52arlfMBlAV+QBjBcnlDMmjtLZXnMytkqJ7NqEETXjhE+lcriG9ZpZZMa9Tqm8DJMc2/uJKjzEVztvMNqDmrddSohSI+5/MapLDu6QJE7Iunq/yp6Oma3iEP9ykSv9CDKg2oL/96HfZFJjL/BqggHzGllcYLk2MhJoI1//fMiLtrs7UEK2IZJM+xRYaHEbNJManBxB/rwT2aKXdTVfu1V0Bu2gXvT9Fditx2aO3ESrs57yfZ2y9JselVleqo5KKizqkMtJNSK/zUqdnhPmZDyPzKr9bIzE99psHzIzg0j1AXyWTFM4W548roTeX3v7gFUMBuDxxaP23KEiYLbJcUvS95zedvX/MgMcvPs0gBWOzf63cJaAXCD+bUErVm8lS/SHRFI9Sfrj19V5u6Qx0Gewv+0kJ3AOP45eQm8IDjBmCss4p5tbDA82vFHEKYMKCDdLBT/FpiWRLwPeo8ConZZXlRAmqgwlDfZ7wkMXds99cCqcWNaoESg8FFUSUENShveIICxS1IoLB9pF98Zim4neTA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96d1fde2-ef1e-4b92-5a6e-08d85e10fd56 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2020 09:30:33.4628 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xYJR9W0mUeO93spddCRkuZCp0t+kyRlas/IJMUtmZFlbiNS7c1dI330fHuS1uKhSSUDLUfuv0d1VGE5gX7J6/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2750 Subject: Re: [dpdk-dev] [PATCH] security: allow application to specify UDP ports to PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Tejasree, > > > Add UDP source and destination ports in ipsec_xform to allow > > > application to specify ports to be used for IPsec UDP encapsulation a= s > > > they are dynamically changed by NAT in between. Also adding an extra > > > flag to indicate whether PMD needs to perform encapsulation header > > > verification in case of inbound. In case of inline IPsec > > > implementation, verification of outer IP headers and UDP encapsulatio= n > > > headers need to be handled in the PMD. For lookaside IPsec, > > > application can optionally offload this to the PMD. > > > > > > Signed-off-by: Tejasree Kondoj > > > --- > > > > I think we should add some usage of these newly added params > > - either in app/test or in examples/ipsec-secgw >=20 > [Tejasree] You mean adding test case in either of the above apps or addit= ion of > PMD implementation also? Also is the proposal sounds fine? >=20 I would say both, so that the newly added parameters are tested. I am ok with the proposal with a minor comment, We can have udp_src_port and udp_dst_port directly into rte_security_ipsec_= xform Instead of adding a new struct rte_security_ipsec_udp_encapsulation. Regards, Akhil