From: Akhil Goyal <akhil.goyal@nxp.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>,
"anoobj@marvell.com" <anoobj@marvell.com>,
"shallyv@marvell.com" <shallyv@marvell.com>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms
Date: Tue, 22 Sep 2020 19:17:40 +0000 [thread overview]
Message-ID: <VI1PR04MB316835EA8AB72685593724B1E63B0@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CY4PR11MB18304DB9A097F042E7AE87CF9F4B0@CY4PR11MB1830.namprd11.prod.outlook.com>
Hi Arek,
>
> Hi Akhil,
>
> @Akhil: Is there a chance getting this change into 20.11?
>
> Any more comments or anyone see any potential issues with this approach?
>
I am ok to take this patch in 20.11 release. Could you please send a new version
With complete patch, removing all references of RTE_CRYPTO_AUTH_AES_GMAC.
Please explain in the release notes and deprecation notice as well.
> Subject: Re: [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms
>
> On 29/07/2020 3:22 PM, Arek Kusztal wrote:
> > This is proposal to move AES-GMAC algorithm to AEAD set of algorithms.
> > It is however not 100% conformant GMAC as instead of aad pointer data
> > to be authenticated is passed normally and aead.data.length field is
> > used to specify length of data to be authenticated.
> > Reason behind this move is that GMAC is variant of GCM so it may
> > simplify implementations that are using these algorithms (mainly IPsec).
> > AES-GMAC therefore needs to be removed from auth algorithms.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> ..
> >
>
> I think this makes sense in light of how AES-GMAC support is specified in the
> IPsec GMAC rfc
> (https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftools.iet
> f.org%2Fhtml%2Frfc4543&data=02%7C01%7Cakhil.goyal%40nxp.com%7Cf
> 0aec031674e4832272108d838f7e961%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C0%7C637321984712376305&sdata=OgaLnAqcAGg1xzD8QfSWn%
> 2F9Qa8vOkqEiZutDZcz5JLo%3D&reserved=0)
>
> Acked-by: Declan Doherty <declan.doherty@intel.com>
next prev parent reply other threads:[~2020-09-22 19:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 14:22 Arek Kusztal
2020-07-29 14:36 ` Kusztal, ArkadiuszX
2020-07-29 16:20 ` Trahe, Fiona
2020-07-31 14:33 ` Doherty, Declan
2020-08-05 4:27 ` Kusztal, ArkadiuszX
2020-09-22 19:17 ` Akhil Goyal [this message]
2020-09-28 9:32 ` Trahe, Fiona
2020-09-01 8:13 ` Zhang, Roy Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB316835EA8AB72685593724B1E63B0@VI1PR04MB3168.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=shallyv@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).