From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA21EA0543; Wed, 15 Jul 2020 21:54:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 84D902C58; Wed, 15 Jul 2020 21:54:09 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50066.outbound.protection.outlook.com [40.107.5.66]) by dpdk.org (Postfix) with ESMTP id C990B1AFB for ; Wed, 15 Jul 2020 21:54:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XGQeDzG1zdg5FFIH1qFhXHv1yWKkkv81OEWRLJzni/iVtXUrf2z0D1adeex8ga+SB8I+XpllNv61fZR6c22Nh2aD+sDvgIiiIXBtPBSEfHfM63vlQARj87WCSxJ0rugbUYhtXFPthZE8aLnUsKsdeHwehfrRsiWlJpdJm2kP2u6r59EwaNmYJ2AAODqxBqqZHMqntATFb3UMEvS+Owuw8gkKd/KgAs6dmDvSKk3+4LZFk5Vli56MbucPoPZUJwhApiHt75ehNgw88lma67I7vV/JrFrNiDehsPDbUfFI4Y3B6QQD9aEJyzXQ5NFHSBNrfQguGEQdYoxTa4x+Nxk0Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a+CSWnp+SctvDaSBuBiwUCGArBmGA4zATX6BUnias14=; b=RuDYHbMKtDVbIo3bSsv4hRYnCiYwBOxWaVEU5M8beFsVddcDy280GRx7MSxlSdF37t10T9K7pdvQZnFjhNPdnZivXgFoPd28IawLo0ti+v33E9dzq5lynL4304eLzDoC3+m6VVTBLvG3r/oKkXYeP3mTuqJBhxowZUW9jwe4DrqP95Z/iZzKj6SE+nESxtjyEbIU6A6homgqHYtpJaj/hb5UBkncmBu51SkeH/5ycgYS7DywDzKeqhsAOLxZO6lK77AAh+XR9PM5fyLBrix+WGtMHDb95X/+O5NOI6FxiaIQU4es8HxjGtyrlmLd3MfwgVRMZX9D8QwonbJagOuZMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a+CSWnp+SctvDaSBuBiwUCGArBmGA4zATX6BUnias14=; b=DK3Ok0WpbbJc0IUu4twgQGOBsSjLfl4lKzJuQSxxurq/l5OxNYfPdSVEeZ/n0G5bsBaEFE2lo3sVPqg+iTEhw6QhZQMvpGsSeMORsr4hoajX+Ckr8Lz8dH4mYnPg5WI1C0lG4PbDdNIVAb387fSBVpZldRi8FKcjhmTKPwxqW9c= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VE1PR04MB6605.eurprd04.prod.outlook.com (2603:10a6:803:124::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Wed, 15 Jul 2020 19:54:06 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::b077:1fe4:d352:b464]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::b077:1fe4:d352:b464%7]) with mapi id 15.20.3174.026; Wed, 15 Jul 2020 19:54:06 +0000 From: Akhil Goyal To: Anoob Joseph , Ankur Dwivedi , "dev@dpdk.org" CC: "declan.doherty@intel.com" , Hemant Agrawal , Vakul Garg Thread-Topic: [PATCH] test/crypto: change cipher offset for esn vector Thread-Index: AQHWOxOtMDzmJDGeR0KqgVz6oEZL66j6qEhggAAu4YCAAD+cMIAAvM0AgADbeoCAAPVqAIALp17Q Date: Wed, 15 Jul 2020 19:54:06 +0000 Message-ID: References: <1591345833-19159-1-git-send-email-adwivedi@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.118.167.123] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 405682c8-6963-42b4-85ca-08d828f8d547 x-ms-traffictypediagnostic: VE1PR04MB6605: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VFEh0PK9PGONv/se23Zo7DJ7mkpOHW0o/ZE9zQ+/JPL8uTwcVkzHFUlWTX5AFQeMJaV7iQk0Uk1pia/q9aC/zCztoUX/IEq9s0amovdjEgJh1qYXATAmaEswgQIK34k+/VSzmyPZkUjqF8yIR5uuQtTNdCzFbmfJXYag3ZAZ1bq0oWVKPAIw3MIB3zuwU3G3HgYnYnP2c65+OIW1WPSKKRSLlBHQhYxbhvVp2KGkbxms2DL6ckCmGW6Q1FSgJtSnPHYi1vkAMzZHV1u3GtAS7TiNaMp7+Xk9O4u1TinsgcH2bjzhG559Kel7sk4bZ/MgvLpQYgixGUVMw0ygqvsiKQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(376002)(346002)(136003)(39860400002)(366004)(26005)(110136005)(71200400001)(2906002)(186003)(7696005)(6506007)(52536014)(76116006)(44832011)(83380400001)(55016002)(66946007)(64756008)(66446008)(316002)(66556008)(8936002)(478600001)(9686003)(8676002)(54906003)(5660300002)(66476007)(33656002)(4326008)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: R/6RakfWgz4aCij5qTkQdLNboslhiOFEWN65t7D6AiWGyhRMUtoRFer1tvBJ8w73iFxo8vm5LdBUqGOfyEf5y4N8jtkOERMgr1lhvoVhnzFIbKtoJg4gfLwLMKp2VTRDwVmq9lJaQmjsHaSFY7+SSoUhlDPq0HU8h67TSjeeKiMfnbwREACs5Pb8Dkcqy0qBlUkWgGA14YVR2aEkC4JlCfPBcL8rMpS9zONFsnGrcqoJ/ty+YMMKztwhGanx25IGz5BOlTMeHgjiIYVSfHINS27cAI/ZeXeI2zr5T5VnYSwujW2d11zy32A02NXe5jydvx7nyemaMd/A0oy/Dgerb1/APgNmL5/9Dbff3K2XPcg8ejsc4fw1zhLUZK7Fr42eyZIrdFsb5SgrLGyoRRhzUO0JQxkssqyuTTTfPkSNW6b/zh3rYbmhoPXiTZGGd1u/DKCxXcI7ZAgU9DWGUtm2GjJBzo7MAP4wYMPrhACv68Q7ByDIWAX8D1jyZowor+ZU Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 405682c8-6963-42b4-85ca-08d828f8d547 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2020 19:54:06.6430 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2yx0RY2p5d6S/5JbXSRYfyhrSV3GeeaCamKS+WzX5XsPxqGwXKDaOlWL8Si5C06Tb0jwlHTRbIP6okQOo5B/dA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6605 Subject: Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > >> >Why do we need this change? > > > >> >The existing test case is to demonstrate a generic case where we > > > >> >can have an auth only trailer as well. It is similar to a case of > > > >> >IPSEC ESN but not exactly IPSec. Cipher offset can be anything as > > > >> >per the app > > > >requirement. > > > >> >I don't think there is anything wrong in the vector. It should > > > >> >pass in every hardware without any issue. > > > >> [Ankur] It's a limitation in OCTEON TX PMDs that the (encr offset = - > > > >> auth offset) should be 8 bytes aligned. > > > >> In the IPSEC ESN scenario generally the offsets will be such. > > > >> But in the above IPSEC ESN test vector, this requirement is not me= t > > > >> and hence the associated test cases fails on the PMD. > > > > > > > >In that case, I think it is better to have a separate test vector an= d > > > >both should be executed. With the previous one as not supported in > > > >your case and this one will be supported. > > > [Ankur] The offsets values are present per crypto operation. So to > > > make these tests as unsupported the pmd datapath needs to be changed. > > > Is there an alternative to make these tests unsupported? > > > > I believe this is a data path error and a limitation in your PMD. > > You can not stop the application writer from using unaligned cipher > > offsets(non-8 byte aligned) >=20 > [Anoob] Yes. But the typical case with IPsec is what is supported in the = PMD. >=20 > > > > This is just a test application, which may hide your PMD limitation by > > accepting this patch But in actual the scenario will fail when some use= r > > configures a 12B cipher offset. >=20 > [Anoob] Agreed. But autotest having a failure is not an ideal situation t= o be it. > Especially when it's not the typical usage. Can I propose to add a field = like "Know > Issues:" in the summary field? We can add a check for OCTEONTX PMDs in th= e > test case and mark it as a known case. I do understand that the vision wa= s to > remove all driver specific tests and have generic tests for all PMDs, but= here we > are left with no other option. Chances are, other PMDs also could have si= milar > limitations when moving to generic framework. >=20 > If you have suggestions to skip this test in any other way, that would al= so work > for us. >=20 I don't see there is a straight forward way for skipping this test, but we = cannot allow PMD specific checks going further. If you are not ready to accept this failure case, I am ok to take this patc= h as is. I believe it will hide your PMD limitation and may come up As a surprise to your customers if they start using non-8 byte aligned ciph= er offset. Applied to dpdk-next-crypto Thanks. > > IMO, you should add a new test vector instead of replacing this one and= it > > should Be OK to have the existing one fail in your case. > >