[dpdk-dev] [PATCH v3] crypto/aesni_mb: support DOCSIS AES-256

[dpdk-dev] [PATCH v3] crypto/aesni_mb: support DOCSIS AES-256

[Mairtin o Loingsigh]

This patch adds support for DOCSIS AES-256 when using AESNI-MB

Signed-off-by: Mairtin o Loingsigh <mairtin.oloingsigh@intel.com>
Acked-by: Pablo de Lara <Pablo.de.lara.guarch@intel.com>
---
 doc/guides/rel_notes/release_20_05.rst         | 5 +++++
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 6 ++++++
 2 files changed, 11 insertions(+)

diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst
index 6b1a7c58c..72d2f6c27 100644
--- a/doc/guides/rel_notes/release_20_05.rst
+++ b/doc/guides/rel_notes/release_20_05.rst
@@ -81,6 +81,11 @@ New Features
   by making use of the event device capabilities. The event mode currently supports
   only inline IPsec protocol offload.
 
+* **Updated the AESNI MB PMD.**
+
+  Updated the AESNI PMD with additional DOCSIS algorithm
+
+  * Added support for AES-256 DOCSIS
 
 Removed Items
 -------------
diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
index 845661174..0d555ec29 100644
--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
@@ -319,8 +319,14 @@ static const struct rte_cryptodev_capabilities aesni_mb_pmd_capabilities[] = {
 				},
 				.iv_size = {
 					.min = 16,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
+					.max = 32,
+					.increment = 16
+#else
 					.max = 16,
 					.increment = 0
+#endif
+
 				}
 			}, }
 		}, }
-- 
2.17.1

[dpdk-dev] [PATCH v4 1/2] crypto/aesni_mb: support DOCSIS AES-256

[Mairtin o Loingsigh]

This patch adds support for DOCSIS AES-256 when using AESNI-MB

Signed-off-by: Mairtin o Loingsigh <mairtin.oloingsigh@intel.com>
Acked-by: Pablo de Lara <Pablo.de.lara.guarch@intel.com>
---
v2: Added IPSec MB version check
v3: Added doc update
v4: Added missing patch
---
 doc/guides/rel_notes/release_20_05.rst         | 5 +++++
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 6 ++++++
 2 files changed, 11 insertions(+)

diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst
index 6b1a7c58c..72d2f6c27 100644
--- a/doc/guides/rel_notes/release_20_05.rst
+++ b/doc/guides/rel_notes/release_20_05.rst
@@ -81,6 +81,11 @@ New Features
   by making use of the event device capabilities. The event mode currently supports
   only inline IPsec protocol offload.
 
+* **Updated the AESNI MB PMD.**
+
+  Updated the AESNI PMD with additional DOCSIS algorithm
+
+  * Added support for AES-256 DOCSIS
 
 Removed Items
 -------------
diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
index 845661174..0d555ec29 100644
--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
@@ -319,8 +319,14 @@ static const struct rte_cryptodev_capabilities aesni_mb_pmd_capabilities[] = {
 				},
 				.iv_size = {
 					.min = 16,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
+					.max = 32,
+					.increment = 16
+#else
 					.max = 16,
 					.increment = 0
+#endif
+
 				}
 			}, }
 		}, }
-- 
2.12.3

[dpdk-dev] [PATCH v4 2/2] test/crypto: Add AES-256 DOCSIS test vectors

[Mairtin o Loingsigh]

This patch adds test vectors for AES-256 and sets AESNI-MB as the
target PMD

Signed-off-by: Mairtin o Loingsigh <mairtin.oloingsigh@intel.com>
Acked-by: Pablo de Lara <Pablo.de.lara.guarch@intel.com>
---
v2: Remove duplicate code
---
 app/test/test_cryptodev_aes_test_vectors.h | 81 ++++++++++++++++++++++++++++++
 1 file changed, 81 insertions(+)

diff --git a/app/test/test_cryptodev_aes_test_vectors.h b/app/test/test_cryptodev_aes_test_vectors.h
index 08ae09390..df338756f 100644
--- a/app/test/test_cryptodev_aes_test_vectors.h
+++ b/app/test/test_cryptodev_aes_test_vectors.h
@@ -5,6 +5,15 @@
 #ifndef TEST_CRYPTODEV_AES_TEST_VECTORS_H_
 #define TEST_CRYPTODEV_AES_TEST_VECTORS_H_
 
+#ifdef RTE_LIBRTE_PMD_AESNI_MB
+#include <intel-ipsec-mb.h>
+#endif
+
+#if !defined(IMB_VERSION_NUM)
+#define IMB_VERSION(a, b, c) (((a) << 16) + ((b) << 8) + (c))
+#define IMB_VERSION_NUM IMB_VERSION(0, 49, 0)
+#endif
+
 /* test vectors */
 static const uint8_t plaintext_aes128ctr[] = {
 	0x6B, 0xC1, 0xBE, 0xE2, 0x2E, 0x40, 0x9F, 0x96,
@@ -2739,79 +2748,151 @@ static const struct blockcipher_test_case aes_docsis_test_cases[] = {
 		.test_descr = "AES-256-DOCSIS-BPI Full Block Encryption",
 		.test_data = &aes_test_data_docsis_4,
 		.op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
+		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT |
+			BLOCKCIPHER_TEST_TARGET_PMD_MB
+#else
+
 		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
+#endif
 	},
 	{
 		.test_descr = "AES-256-DOCSIS-BPI Runt Block Encryption",
 		.test_data = &aes_test_data_docsis_5,
 		.op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
+		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT |
+			BLOCKCIPHER_TEST_TARGET_PMD_MB
+#else
+
 		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
+#endif
 	},
 	{
 		.test_descr = "AES-256-DOCSIS-BPI Uneven Encryption",
 		.test_data = &aes_test_data_docsis_6,
 		.op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
+		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT |
+			BLOCKCIPHER_TEST_TARGET_PMD_MB
+#else
+
 		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
+#endif
 	},
 	{
 		.test_descr = "AES-256-DOCSIS-BPI Full Block Decryption",
 		.test_data = &aes_test_data_docsis_4,
 		.op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
+		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT |
+			BLOCKCIPHER_TEST_TARGET_PMD_MB
+#else
+
 		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
+#endif
 	},
 	{
 		.test_descr = "AES-256-DOCSIS-BPI Runt Block Decryption",
 		.test_data = &aes_test_data_docsis_5,
 		.op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
+		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT |
+			BLOCKCIPHER_TEST_TARGET_PMD_MB
+#else
+
 		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
+#endif
 	},
 	{
 		.test_descr = "AES-256-DOCSIS-BPI Uneven Decryption",
 		.test_data = &aes_test_data_docsis_6,
 		.op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
+		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT |
+			BLOCKCIPHER_TEST_TARGET_PMD_MB
+#else
+
 		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
+#endif
 	},
 	{
 		.test_descr = "AES-256-DOCSIS-BPI OOP Full Block Encryption",
 		.test_data = &aes_test_data_docsis_4,
 		.op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
 		.feature_mask = BLOCKCIPHER_TEST_FEATURE_OOP,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
+		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT |
+			BLOCKCIPHER_TEST_TARGET_PMD_MB
+#else
+
 		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
+#endif
 	},
 	{
 		.test_descr = "AES-256-DOCSIS-BPI OOP Runt Block Encryption",
 		.test_data = &aes_test_data_docsis_5,
 		.op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
 		.feature_mask = BLOCKCIPHER_TEST_FEATURE_OOP,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
+		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT |
+			BLOCKCIPHER_TEST_TARGET_PMD_MB
+#else
+
 		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
+#endif
 	},
 	{
 		.test_descr = "AES-256-DOCSIS-BPI OOP Uneven Block Encryption",
 		.test_data = &aes_test_data_docsis_6,
 		.op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
 		.feature_mask = BLOCKCIPHER_TEST_FEATURE_OOP,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
+		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT |
+			BLOCKCIPHER_TEST_TARGET_PMD_MB
+#else
+
 		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
+#endif
 	},
 	{
 		.test_descr = "AES-256-DOCSIS-BPI OOP Full Block Decryption",
 		.test_data = &aes_test_data_docsis_4,
 		.op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
 		.feature_mask = BLOCKCIPHER_TEST_FEATURE_OOP,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
+		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT |
+			BLOCKCIPHER_TEST_TARGET_PMD_MB
+#else
+
 		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
+#endif
 	},
 	{
 		.test_descr = "AES-256-DOCSIS-BPI OOP Runt Block Decryption",
 		.test_data = &aes_test_data_docsis_5,
 		.op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
 		.feature_mask = BLOCKCIPHER_TEST_FEATURE_OOP,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
+		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT |
+			BLOCKCIPHER_TEST_TARGET_PMD_MB
+#else
+
 		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
+#endif
 	},
 	{
 		.test_descr = "AES-256-DOCSIS-BPI OOP Uneven Block Decryption",
 		.test_data = &aes_test_data_docsis_6,
 		.op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
 		.feature_mask = BLOCKCIPHER_TEST_FEATURE_OOP,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
+		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT |
+			BLOCKCIPHER_TEST_TARGET_PMD_MB
+#else
+
 		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
+#endif
 	},
 };
 #endif /* TEST_CRYPTODEV_AES_TEST_VECTORS_H_ */
-- 
2.12.3

Re: [dpdk-dev] [PATCH v4 2/2] test/crypto: Add AES-256 DOCSIS test vectors

[Thomas Monjalon]

10/04/2020 17:03, Mairtin o Loingsigh:
> This patch adds test vectors for AES-256 and sets AESNI-MB as the
> target PMD

There is really something wrong in the cryptodev API.
Why the PMD must be selected in the tests?
Isn't there some capabilities in cryptodev?
Whitelisting PMD in the test prevents testing capabilities API.

It looks the required refactoring is not progressing enough.
I suggest blocking all crypto-related patches until is is fixed.

Re: [dpdk-dev] [PATCH v4 1/2] crypto/aesni_mb: support DOCSIS AES-256

[De Lara Guarch, Pablo]

Hi Mairtin,

> -----Original Message-----
> From: O'loingsigh, Mairtin <mairtin.oloingsigh@intel.com>
> Sent: Friday, April 10, 2020 4:03 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; O'loingsigh, Mairtin <mairtin.oloingsigh@intel.com>
> Subject: [PATCH v4 1/2] crypto/aesni_mb: support DOCSIS AES-256
> 
> This patch adds support for DOCSIS AES-256 when using AESNI-MB
> 
> Signed-off-by: Mairtin o Loingsigh <mairtin.oloingsigh@intel.com>
> Acked-by: Pablo de Lara <Pablo.de.lara.guarch@intel.com>
> ---
> v2: Added IPSec MB version check
> v3: Added doc update
> v4: Added missing patch
> ---
>  doc/guides/rel_notes/release_20_05.rst         | 5 +++++
>  drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 6 ++++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_20_05.rst
> b/doc/guides/rel_notes/release_20_05.rst
> index 6b1a7c58c..72d2f6c27 100644
> --- a/doc/guides/rel_notes/release_20_05.rst
> +++ b/doc/guides/rel_notes/release_20_05.rst
> @@ -81,6 +81,11 @@ New Features
>    by making use of the event device capabilities. The event mode currently
> supports
>    only inline IPsec protocol offload.
> 
> +* **Updated the AESNI MB PMD.**
> +
> +  Updated the AESNI PMD with additional DOCSIS algorithm
> +
> +  * Added support for AES-256 DOCSIS
> 
>  Removed Items
>  -------------
> diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> index 845661174..0d555ec29 100644
> --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> @@ -319,8 +319,14 @@ static const struct rte_cryptodev_capabilities
> aesni_mb_pmd_capabilities[] = {
>  				},
>  				.iv_size = {
>  					.min = 16,
> +#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
> +					.max = 32,
> +					.increment = 16
> +#else
>  					.max = 16,
>  					.increment = 0
> +#endif

Apologies, I missed this earlier and I just realized this is wrong.
This should be done in key_size, not iv_size.

Thanks,
Pablo

> +
>  				}
>  			}, }
>  		}, }
> --
> 2.12.3

Re: [dpdk-dev] [PATCH v4 2/2] test/crypto: Add AES-256 DOCSIS test vectors

[De Lara Guarch, Pablo]

Hi Thomas,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> Sent: Sunday, April 12, 2020 5:44 PM
> To: dev@dpdk.org; akhil.goyal@nxp.com
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; O'loingsigh,
> Mairtin <mairtin.oloingsigh@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; Dybkowski, AdamX
> <adamx.dybkowski@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v4 2/2] test/crypto: Add AES-256 DOCSIS test
> vectors
> 
> 10/04/2020 17:03, Mairtin o Loingsigh:
> > This patch adds test vectors for AES-256 and sets AESNI-MB as the
> > target PMD
> 
> There is really something wrong in the cryptodev API.
> Why the PMD must be selected in the tests?
> Isn't there some capabilities in cryptodev?
> Whitelisting PMD in the test prevents testing capabilities API.
> 
> It looks the required refactoring is not progressing enough.
> I suggest blocking all crypto-related patches until is is fixed.
> 

You are right, but Mairtin was following the same approach as it was taken previously.
I agree that this approach is not the best one and we are currently working
on a better solution.

Thanks,
Pablo

Re: [dpdk-dev] [PATCH v4 2/2] test/crypto: Add AES-256 DOCSIS test vectors

[Thomas Monjalon]

14/04/2020 10:49, De Lara Guarch, Pablo:
> From: Thomas Monjalon
> > 10/04/2020 17:03, Mairtin o Loingsigh:
> > > This patch adds test vectors for AES-256 and sets AESNI-MB as the
> > > target PMD
> > 
> > There is really something wrong in the cryptodev API.
> > Why the PMD must be selected in the tests?
> > Isn't there some capabilities in cryptodev?
> > Whitelisting PMD in the test prevents testing capabilities API.
> > 
> > It looks the required refactoring is not progressing enough.
> > I suggest blocking all crypto-related patches until is is fixed.
> > 
> 
> You are right, but Mairtin was following the same approach as it was taken previously.

I know. His patch was accepted.

> I agree that this approach is not the best one and we are currently working
> on a better solution.

Now that's clear, let's not merge any new crypto patch until
the capabilities are working and tested.

[dpdk-dev] [PATCH v5] crypto/aesni_mb: support DOCSIS AES-256

[Mairtin o Loingsigh]

This patch adds support for DOCSIS AES-256 when using AESNI-MB

Signed-off-by: Mairtin o Loingsigh <mairtin.oloingsigh@intel.com>
Acked-by: Pablo de Lara <Pablo.de.lara.guarch@intel.com>
---
v2: Added IPSec MB version check
v3: Added doc update
v4: Added missing patch
v5: Dropping test vector due to refactoring
---
 doc/guides/rel_notes/release_20_05.rst         | 5 +++++
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 6 ++++++
 2 files changed, 11 insertions(+)

diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst
index 6b1a7c58c..72d2f6c27 100644
--- a/doc/guides/rel_notes/release_20_05.rst
+++ b/doc/guides/rel_notes/release_20_05.rst
@@ -81,6 +81,11 @@ New Features
   by making use of the event device capabilities. The event mode currently supports
   only inline IPsec protocol offload.
 
+* **Updated the AESNI MB PMD.**
+
+  Updated the AESNI PMD with additional DOCSIS algorithm
+
+  * Added support for AES-256 DOCSIS
 
 Removed Items
 -------------
diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
index 845661174..0d555ec29 100644
--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
@@ -319,8 +319,14 @@ static const struct rte_cryptodev_capabilities aesni_mb_pmd_capabilities[] = {
 				},
 				.iv_size = {
 					.min = 16,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
+					.max = 32,
+					.increment = 16
+#else
 					.max = 16,
 					.increment = 0
+#endif
+
 				}
 			}, }
 		}, }
-- 
2.12.3

Re: [dpdk-dev] [PATCH v5] crypto/aesni_mb: support DOCSIS AES-256

[De Lara Guarch, Pablo]

Hi Mairtin,

> -----Original Message-----
> From: O'loingsigh, Mairtin <mairtin.oloingsigh@intel.com>
> Sent: Wednesday, April 15, 2020 10:04 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; O'loingsigh, Mairtin <mairtin.oloingsigh@intel.com>
> Subject: [PATCH v5] crypto/aesni_mb: support DOCSIS AES-256
> 
> This patch adds support for DOCSIS AES-256 when using AESNI-MB
> 
> Signed-off-by: Mairtin o Loingsigh <mairtin.oloingsigh@intel.com>
> Acked-by: Pablo de Lara <Pablo.de.lara.guarch@intel.com>
> ---
> v2: Added IPSec MB version check
> v3: Added doc update
> v4: Added missing patch
> v5: Dropping test vector due to refactoring
> ---
>  doc/guides/rel_notes/release_20_05.rst         | 5 +++++
>  drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 6 ++++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_20_05.rst
> b/doc/guides/rel_notes/release_20_05.rst
> index 6b1a7c58c..72d2f6c27 100644
> --- a/doc/guides/rel_notes/release_20_05.rst
> +++ b/doc/guides/rel_notes/release_20_05.rst
> @@ -81,6 +81,11 @@ New Features
>    by making use of the event device capabilities. The event mode currently
> supports
>    only inline IPsec protocol offload.
> 
> +* **Updated the AESNI MB PMD.**
> +
> +  Updated the AESNI PMD with additional DOCSIS algorithm
> +
> +  * Added support for AES-256 DOCSIS
> 
>  Removed Items
>  -------------
> diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> index 845661174..0d555ec29 100644
> --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> @@ -319,8 +319,14 @@ static const struct rte_cryptodev_capabilities
> aesni_mb_pmd_capabilities[] = {
>  				},
>  				.iv_size = {
>  					.min = 16,
> +#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
> +					.max = 32,
> +					.increment = 16
> +#else

This should be done in "key_size", not iv_size.

Thanks,
Pablo

[dpdk-dev] [PATCH v6] crypto/aesni_mb: support DOCSIS AES-256

[Mairtin o Loingsigh]

This patch adds support for DOCSIS AES-256 when using AESNI-MB

Signed-off-by: Mairtin o Loingsigh <mairtin.oloingsigh@intel.com>
Acked-by: Pablo de Lara <Pablo.de.lara.guarch@intel.com>
---
This patch depends on these two patches:

v2: Added IPSec MB version check
v3: Added doc update
v4: Added missing patch
v5: Dropping test vector due to refactoring
v6: Fix key size
---
 doc/guides/rel_notes/release_20_05.rst         | 5 +++++
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst
index 6b1a7c58c..72d2f6c27 100644
--- a/doc/guides/rel_notes/release_20_05.rst
+++ b/doc/guides/rel_notes/release_20_05.rst
@@ -81,6 +81,11 @@ New Features
   by making use of the event device capabilities. The event mode currently supports
   only inline IPsec protocol offload.
 
+* **Updated the AESNI MB PMD.**
+
+  Updated the AESNI PMD with additional DOCSIS algorithm
+
+  * Added support for AES-256 DOCSIS
 
 Removed Items
 -------------
diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
index 845661174..434e2652b 100644
--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
@@ -314,8 +314,13 @@ static const struct rte_cryptodev_capabilities aesni_mb_pmd_capabilities[] = {
 				.block_size = 16,
 				.key_size = {
 					.min = 16,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
+					.max = 32,
+					.increment = 16
+#else
 					.max = 16,
 					.increment = 0
+#endif
 				},
 				.iv_size = {
 					.min = 16,
-- 
2.12.3

Re: [dpdk-dev] [PATCH v6] crypto/aesni_mb: support DOCSIS AES-256

[Akhil Goyal]

> 
> This patch adds support for DOCSIS AES-256 when using AESNI-MB
> 
> Signed-off-by: Mairtin o Loingsigh <mairtin.oloingsigh@intel.com>
> Acked-by: Pablo de Lara <Pablo.de.lara.guarch@intel.com>
> ---
> This patch depends on these two patches:
> 
What are the dependent patches?

Re: [dpdk-dev] [PATCH v6] crypto/aesni_mb: support DOCSIS AES-256

[Akhil Goyal]

> 
> This patch adds support for DOCSIS AES-256 when using AESNI-MB
> 
> Signed-off-by: Mairtin o Loingsigh <mairtin.oloingsigh@intel.com>
> Acked-by: Pablo de Lara <Pablo.de.lara.guarch@intel.com>
> ---
> This patch depends on these two patches:
> 
Applied to dpdk-next-crypto

Thanks.