From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9B82A04B5; Thu, 29 Oct 2020 15:00:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1158DCD84; Thu, 29 Oct 2020 15:00:52 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2059.outbound.protection.outlook.com [40.107.20.59]) by dpdk.org (Postfix) with ESMTP id C9A61CD82; Thu, 29 Oct 2020 15:00:49 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I84Iotz3vfgdFAlrweoKYt+sTU3NYoUf+Zq/Z6A3HMH9ywglWW7nkMOzXzhwsAEJCdlCpSzzRpbW2/4xDGkggHQ1Tvt6lCsXiuWUJCqs0a8TkE2bppsp8ZFPq5DfqEo/CCcbrfkcfnsuT0noHJsVw9drg3EoD9+tBRdnpcUP/5M947qZ5Dmw2/CuATDbJaJMdDWFegxZQfxyg3r7UKKeAfh7G9QB9rkTKPJJjsDuWxIGDeyMGtNN78Xel9DxOrtl0+b4SUh1k+JUrQuYBPqmxvPjwgb48WrSbGFQQrTRMgv0MVcDpnYizq1WQwoFion1MASLF74emYJiQB0sT3qN8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kyz7fMCn5++Ln56hHEEMeLY/s9SdJi7ELlecC8WMJmI=; b=WM2mX0jPYEqio6g64LSdjKUIXF9NWuaEDdqNzAnblBAPRfZeZS6r4V0W4PD/jJGokblZ5Q/MiEiFxJNkEWDJAtm3ILvrkkNidJ9OuAl4Ft11cP+T3P0vib3uYBXeSTCgHfKFaaZtvem63U9CIQG5tCKJljVOca6TLqJZckB2XWBRkW3Q6yDO+8cwfjEDgVVqh1rGsaoXPt9LOO7nelxQRIlsxKjuRN4XQGeo/UKKBweoJZWE43YKZUN5NWB7OQVr5QEegM2HbycZ/OWSpiFqn2E10MVG/vPGJ5GC8uEDTrp4JATcBXHipfI93pdjXdmNGFKt8pjmo0qk4q7uiXy7lQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kyz7fMCn5++Ln56hHEEMeLY/s9SdJi7ELlecC8WMJmI=; b=UAEoiFMGfKwISnAjjO0BslU3yps+1s88dQvvlBwvm07NokMDQfD+TGU+82G1+PzZ8a3FMF5DfGair46zyJQmiX8Wsv8n1xHHdYP3PysZIG/frUS6cHqT0A4x3QnJL4mUFWANM0GY0iCVeE5+7qneWAKdNY2zWHO4hQuJ3oqC8dM= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR0402MB3696.eurprd04.prod.outlook.com (2603:10a6:803:1e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.27; Thu, 29 Oct 2020 14:00:47 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e%4]) with mapi id 15.20.3499.027; Thu, 29 Oct 2020 14:00:47 +0000 From: Akhil Goyal To: "Gujjar, Abhinandan S" , Honnappa Nagarahalli , "Richardson, Bruce" , Ray Kinsella , Thomas Monjalon CC: "Ananyev, Konstantin" , "dev@dpdk.org" , "Doherty, Declan" , "techboard@dpdk.org" , "Vangati, Narender" , "jerinj@marvell.com" , nd Thread-Topic: [dpdk-techboard] [v4 1/3] cryptodev: support enqueue callback functions Thread-Index: AQHWq8kYL4cZYB+DTUiYqx6FrV0786mrw8dwgADrLQCAAEzQgIAAGDkAgAANqwCAAAL2AIABeV8AgAAAl0A= Date: Thu, 29 Oct 2020 14:00:47 +0000 Message-ID: References: <1603619090-118652-1-git-send-email-abhinandan.gujjar@intel.com> <1603619090-118652-2-git-send-email-abhinandan.gujjar@intel.com> <20201028151130.GD1634@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-Mentions: abhinandan.gujjar@intel.com,thomas@monjalon.net X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [171.50.183.179] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: eaa30bad-bcac-4c01-52cc-08d87c130943 x-ms-traffictypediagnostic: VI1PR0402MB3696: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YNRy9DlTSwnhdU4UY3uow3NEfQrnbY6k9fq+R1fYivAXXNx6gaJJwqDJCE/HuSvuSFGsYQ8OzU6cjAOY9HA+44M1yV7Qub9gcprP18O+skuqoShBTImXGRdRAAdqKYQJgeHnDQyugIYMDjB80cxC7cypVM1F2gbr/2SwI94xffpp8A0eLW3GFtaf+EnH1EHz/wPK1a0AsZSO65A7mXyu/lLiWBmb/o9aldY5jw2bMLaDdHS2BHQ/erSwKL2LoxexC3X4s66tiRV8jesH2NECy4qv12mOTdlu7012NtKLua0M1jgSVTFSve5cLWsGiOhzJXuzdgwJsmuV7ebb8osaUQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(39860400002)(346002)(376002)(366004)(26005)(6506007)(8936002)(186003)(71200400001)(7416002)(86362001)(83380400001)(33656002)(64756008)(316002)(8676002)(54906003)(478600001)(7696005)(9686003)(66556008)(4326008)(5660300002)(52536014)(55016002)(44832011)(66946007)(76116006)(66446008)(110136005)(2906002)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: SZLTH7WZ/amt1bG+B8rk4a2Y0n7dmnn7sRU+sJPtcIF7swibzgO+FPSsQxBSrJ6D0XuM4DGtG+UFUxT2nAhYLKDkYx7uG7MPyypr0DlBqXdBSGcqBOefD/OKRzl7a4fk7hbUDUiPUl7NlVGj66FxGjau/lNwK3FfrxGjK0LLSnf4/oEzDs8VT2oRM288CIIm/KGL3KM0HJlxIT5uLukIjwM01z3xSMkEWJ8AGwqv1Ndpi+elilGwMNrgSiOJo81qKHoc/YizWn+XgMSHHrh57lzc9bbTFIxjKM0hGUuq45isv5MQg7R8Fvoc9EVRGn80UqzpykjB7qzCSN9jL3k1V0GlTUO+OWAMC5tiqcMoDNUIh5UekWJzWKXPH57n+3B0/vjFtyNVbDw3qokZDhUWrhqPBQuL+0B0T1r9DDMXsknomvGiryn6RzYniS1bDp54wdyuoW7Z7g00xRq1RRJftQhYUgFtPhUETDIg+dZJ5btC+dmBncfBTdrnib6uo6Of6zz+2rGHV3PC6Q7S+Hq3n9dtG+xF1riGcUzr9mJ95ONAn4mdvDyQMds8ZvS9TaDD6UNynVcbCC1+bpKc8lfhgSLd4rv+GEIe2x7ja4TtvVBcjrDil+RlxnkyYyGsBrlmQ5ZpUklqVSh//lMty5cqsA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eaa30bad-bcac-4c01-52cc-08d87c130943 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2020 14:00:47.3945 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9flpW6kz1Ck0gjcH+mme8AkRJOjh93jKgHXcDxAEnDefQkH24f5P/Tjfw/2gvqvNwp7fbS9NKQ43P9Dip1Ys8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3696 Subject: Re: [dpdk-dev] [dpdk-techboard] [v4 1/3] cryptodev: support enqueue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Hi Akhil, >=20 > Any updates on this? >=20 There has been no objections for this patch from techboard. @Thomas Monjalon: could you please review the release notes. I believe there should be a bullet for API changes to add 2 new fields in r= te_cryptodev. What do you suggest? @Gujjar, Abhinandan S Please send a new version for comments on errno. If possible add cases for deq_cbs as well. If not, send it by next week. Regards, Akhil > > + Ray for ABI > > > > > > > > > > > > On Wed, Oct 28, 2020 at 02:28:43PM +0000, Akhil Goyal wrote: > > > > > > > > Hi Konstantin, > > > > > > > > > > > Hi Tech board members, > > > > > > > > > > > > > > I have a doubt about the ABI breakage in below addition of fi= eld. > > > > > > > Could you please comment. > > > > > > > > > > > > > > > /** The data structure associated with each crypto device. > > > > > > > > */ struct rte_cryptodev { > > > > > > > > dequeue_pkt_burst_t dequeue_burst; @@ -867,6 +922,10 > > > @@ > > > > > > > > struct rte_cryptodev { > > > > > > > > __extension__ > > > > > > > > uint8_t attached : 1; > > > > > > > > /**< Flag indicating the device is attached */ > > > > > > > > + > > > > > > > > + struct rte_cryptodev_enq_cb_rcu *enq_cbs; > > > > > > > > + /**< User application callback for pre enqueue processing > > > > > > > > +*/ > > > > > > > > + > > > > > > > > } __rte_cache_aligned; > > > > > > > > > > > > > > Here rte_cryptodevs is defined in stable API list in map file > > > > > > > which is a pointer To all rte_cryptodev and the above change > > > > > > > is changing the size of the > > > > > structure. > > > > > > > > > > While this patch adds new fields into rte_cryptodev structure, it > > > > > doesn't change the size of it. > > > > > struct rte_cryptodev is cache line aligned, so it's current size: > > > > > 128B for 64-bit systems, and 64B(/128B) for 32-bit systems. > > > > > So for 64-bit we have 47B implicitly reserved, and for 32-bit we > > > > > have 19B reserved. > > > > > That's enough to add two pointers without changing size of this s= truct. > > > > > > > > > > > > > The structure is cache aligned, and if the cache line size in 32Byt= e > > > > and the compilation is done on 64bit machine, then we will be left > > > > with 15Bytes which is not sufficient for 2 pointers. > > > > Do we have such systems? Am I missing something? > > > > > > > > > > I don't think we support any such systems, so unless someone can poin= t > > > out a specific case where we need to support 32-byte CLs, I'd tend > > > towards ignoring this as a non-issue. > > Agree. I have not come across 32B cache line. > > > > > > > > > The reason I brought this into techboard is to have a consensus on > > > > such change As rte_cryptodev is a very popular and stable structure= . > > > > Any changes to it may Have impacts which one person cannot judge al= l > > > > use > > > cases. > > > > > > > > > > Haven't been tracking this discussion much, but from what I read here= , > > > this doesn't look like an ABI break and should be ok. > > If we are filling the holes in the cache line with new fields, it shoul= d not be an > > ABI break. > > > > > > > > Regards, > > > /Bruce