From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC24BA04DC; Mon, 19 Oct 2020 14:50:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4255CC8F8; Mon, 19 Oct 2020 14:50:05 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70078.outbound.protection.outlook.com [40.107.7.78]) by dpdk.org (Postfix) with ESMTP id D1A72C8F6; Mon, 19 Oct 2020 14:50:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cs19TfigCPItDdF22Voa323G/BuSMl3H5L9N/CNzfHH56l9uEVBPIdPMzIVXi2eqtCRh1NBFLY3uSlCenb3jvUfq3QR/7hmKUL/6C1T1gAE7+hcGxPIKRacCdDfqvZifuzSBu5Ax5FWMpNGjhf+TynNARbQPaXEZcgqOY9fxZ+ET8JZXBWzBHazTADd2X9sovzLpdkoXKwtfl/KImcgXZ3GVLcks31Xm0mcl1H19NZbCOIV0YK1sUg9YsyYTvdDbI9zyxKBxi386bxVtNTfbWppwOVEQlLxjNjuvX/BKy0CQJRbIFiQo0rwdJtMLa5eEdhJplfgY920gpY0Tp6coIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v6ZE2ru1NvUTrlJ48HldPN4a4/teM6axV7V/MGOR1xY=; b=fnKhCkVq8qtR2OEulqAxG0EwkGUejodO3Smw0eNvq9WfAZIIW+W2Twlx/WMoeW3L6r7tPESrqc4THbzozJ+CWX8rXUKuVmFv8XpAxrHGWLPppyB1UUSNdSuNc2QwwSM/y8pV6O7HwhBQz/hc9TlScLgHUN6Dik7AWQLsMV2B7d9EEgJd7MXJPkBBfxUHattE+J6UbHm5pz1ctxL8rtlunHXdb06qnfWybuOVBCKXsiKm43uwqa9fhitz1d4Kkih9GChBhQ++izS7kvgocmepjFmXwvy8xc8wLAS4kDyq7N8IV9TLhXduEVcyazsRKLxZyCl/xuqt5NTfBqKe9mgn0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v6ZE2ru1NvUTrlJ48HldPN4a4/teM6axV7V/MGOR1xY=; b=aM8aXIY4099wMHVKeujWkC1J+0EkIMSvoab2/HGu7utHRYvuhCFP5T7/bQvyjrDMYleLQZ3oMb8lbAV5MGFHthybAKY6LbWCGfCaH/tt1VFxt0kF2Tk2UgdPtWICVRg8tNE3ffMOrBJLnnT76a7omFnsGelsEFDOBiNS0QJpD1k= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB4205.eurprd04.prod.outlook.com (2603:10a6:803:42::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21; Mon, 19 Oct 2020 12:50:00 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e%4]) with mapi id 15.20.3477.028; Mon, 19 Oct 2020 12:49:59 +0000 From: Akhil Goyal To: Thomas Monjalon , Gagandeep Singh CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-stable] [PATCH] crypto/caam_jr: fix caam sec era invalid issue Thread-Index: AQHWpfz781Af/seQi0CL/n4lTEidaKmeucbwgAAj04CAAABFkA== Date: Mon, 19 Oct 2020 12:49:59 +0000 Message-ID: References: <1603100881-11504-1-git-send-email-g.singh@nxp.com> <3239794.rKUyCbyTsL@thomas> In-Reply-To: <3239794.rKUyCbyTsL@thomas> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nxp.com; x-originating-ip: [122.180.231.103] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 10ad2fda-3eba-4a0a-7826-08d8742d7d69 x-ms-traffictypediagnostic: VI1PR04MB4205: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TVOL8o1gFRngYC3j26h76DH+ixZoCU/PAZmhbO9ZUa9LoUeb7cX6cSYgPepbczYLik+unJ/Tf9+5uuqI26Jem7dlCOEONowcWyI/gR5KNbLSpI1v4g8dQXbVT/LGtKN1/Co/40nm+Nk8y3HFw1A2Fy6/soKZpr4qoJCEjuuhblXsO2ksarHD3CQLDtnv8R/39uqsVYR22UJ7X/8u8U0x19su9wz8gHyVHsvGcIDv+OCm2zgd4qFgkqg/hnRzELmuvJm8bvbjFahdwAF/DjiRUjeuNtQ2hQA0PObG9TJYo9cpX1w36g1GX96j+PRFH5ieHwQ0dtjKy2YXBuyjx9eUEw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(39860400002)(136003)(366004)(346002)(110136005)(52536014)(316002)(6636002)(44832011)(5660300002)(478600001)(54906003)(83380400001)(66946007)(76116006)(66476007)(66556008)(64756008)(66446008)(71200400001)(2906002)(33656002)(7696005)(9686003)(55016002)(6506007)(26005)(8936002)(186003)(4326008)(86362001)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: S0xwU/CdUyNH7+kPiVZ3IXn6SqoHPfM+hXnTbm0Zm07aLHx/M2B6hkaK11ZCYAH6tr4sHl3+wjSXNYIe42X6Pudu5l3RFoacePg/d1u+EL89y20EwjGGVZf5ZQWtT4XRDGqI6M7yKbiE26I+Ecpm5CAw34FHzvNaWnO4S9TqR/GRhyOQaebPd/InrxUw9KYhgemz0A+PrP31xikJSSz1IQgFSnTQ6Q0sg2NQS3sTEjxxHurCnPKR2KYKncvv246puXIf5t1Bq3p9dxcsvQ0aXEBXM1eVWrOvNp6REGcldZ0EI9Oio163AwKENSUJ37tgWPpN4PH95HyFneT76dNUjZeo+sMaIvJEc3+kn1yvO9XpBQeWhgBicrYPVnoFvU4Uj/IehUBoIXA/y5Q0w7SE1P68/wWrBM8iwcyTQemEN6h2VcxsEOgIGBUPPUBE8nmWuiuwvBMlgUibQPgO71fJVewe/sD6Czby40w3entxPXM7pfyEp9VpJfOVbS53OWlDzUi/Wbs4TjfIwzosRCdfHLuS8J53OiypicsMInX5CphzKiXzjIpVEjXZpshiSQxE9dEcIlz3rHVOr8jqAIXK7WvezlnYKczBs7mf71Q4mLCoSgvaHfHygs8g0k97Z+MeICuVVQH5o2K5AQ9OkmsXjA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10ad2fda-3eba-4a0a-7826-08d8742d7d69 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2020 12:49:59.7890 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0a1tQiwGh4DT69X67VPYGtnB3L2Bjx0PfCMHVndhDU3Qv4TQGXJmsLlJeLEUIHLxoeE0XYUMZmVn/aM62XXfWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4205 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] crypto/caam_jr: fix caam sec era invalid issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > 19/10/2020 12:33, Akhil Goyal: > > > Subject: [PATCH] crypto/caam_jr: fix caam sec era invalid issue > > > > > > of_init() should be called before using any of_* APIs to retrieve > > > information from the device tree and if reading integer value > > > that must be converted to cpu endianness before using. > > > > > > Fixes: 1d678de329ab ("crypto/caam_jr: add basic job ring routines") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Gagandeep Singh > > > --- > > Acked-by: Akhil Goyal > > > > Thomas, > > Can you pick this in RC1 directly as this is fixing a critical issue in= one platform > of NXP? >=20 > It does not say what it fixes (or I am not able to understand). > What is "era"? ERA is the hardware block version for crypto. It may be different on each p= latform. On one of the platform this value is not getting read properly. Title and Description could be altered as below crypto/caam_jr: fix device tree parsing for SEC_ERA Previously, SEC_ERA was hardcoded and it was removed in [1]. Now when that hardcoded was removed, it is supposed to be read from the device tree but it is not done correctly. This patch calls a necessary API of_init() before using any of_* APIs to retrieve information from the device tree and if reading integer value that must be converted to cpu endianness before using it. [1] eef9e0412a84 ("drivers/crypto: fix build with -fno-common") Fixes: 1d678de329ab ("crypto/caam_jr: add basic job ring routines") Cc: stable@dpdk.org Signed-off-by: Gagandeep Singh Acked-by: Akhil Goyal