From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC559A04B5; Tue, 27 Oct 2020 19:28:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1B3E52B9D; Tue, 27 Oct 2020 19:28:53 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30042.outbound.protection.outlook.com [40.107.3.42]) by dpdk.org (Postfix) with ESMTP id 970561D9E; Tue, 27 Oct 2020 19:28:50 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ANkeCC5nxeVCKgBwDbuH9kG+B4XjWEfnObAsL+qrAggMoE/e9E62mFIuL3fpfPQKzCH5T+Uqkc7x0finVEOjTnd1XfOcpEi3xGu4718/fXEOKYU4qILcFrxzMK4GtXK5VsrrD6r4A9W9aZJTEMvS4YMrwAOXJ/vku2BKselR4uMAi+RWZbt5KNcxPHYFl2FqAVdNUMYXaHq1ybiSY6yRlF6R3bB9OYs7PBSuok9FYvgVHsH7UWp2RuBIUDUjmcvqV0rJ4xgxSc4XuW/uDFBja2h5HHNZmPCqZopA+k67ifeKoe1y+FKYVaLoXpa178jPxnqDTsKdG/HZZF/1PuKlLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RecShhqOrfzJPtPM/AZlk+RRYgwJkeQGBRVFq0/djNY=; b=E0OALQcRfHvEOiDu5+l32XtbEanBNDRC6gSXtLcvaFPxDo1WEDPoZPQn3BxaIa63Q+PJjwFTfRPz/igqh58IRJt8tKjJVAy2KzQWcNSzPm+oJz8PuNf0PvLNzhC1A7TldONNlabdaMvkn1oKSodpppWajSK6UKMtRjb5YznCjY8QM1Se6RxgEIUnpPe6Jae86A8P7HqF8NGNCn6V4YTlgfvH83zjDC8+7PtsYwGppBxkA8pY0L5NZNzODoFylBEw00pIqeEDA/X6C5+MjQ2eKnEBy8YI0MQxsfnjonV3njMohMOnMzBpIcACJ3vkxn2EhKCVvwEWtwarnX4jyc2SQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RecShhqOrfzJPtPM/AZlk+RRYgwJkeQGBRVFq0/djNY=; b=SUoG0OoHacu3ccKguJcY+2goBTnhxwy9zXmcNffOepW2edTSHRwAVUXSnvreYH0S3H47qCrvvpU/IQAbifTqnIxViJmEdZwYMwvxK6dabOHjLGzSX+nn2/Kk+3JbIT+bxuPYsBFWDfXrzkLmdfq1MEtLH71bHvQkS8zzzNOD2q0= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB7136.eurprd04.prod.outlook.com (2603:10a6:800:122::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 27 Oct 2020 18:28:47 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e%4]) with mapi id 15.20.3499.018; Tue, 27 Oct 2020 18:28:47 +0000 From: Akhil Goyal To: Abhinandan Gujjar , "dev@dpdk.org" , "declan.doherty@intel.com" , "Honnappa.Nagarahalli@arm.com" , "konstantin.ananyev@intel.com" , "techboard@dpdk.org" CC: "narender.vangati@intel.com" , "jerinj@marvell.com" Thread-Topic: [v4 1/3] cryptodev: support enqueue callback functions Thread-Index: AQHWq8kYL4cZYB+DTUiYqx6FrV0786mrw8dw Date: Tue, 27 Oct 2020 18:28:47 +0000 Message-ID: References: <1603619090-118652-1-git-send-email-abhinandan.gujjar@intel.com> <1603619090-118652-2-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: <1603619090-118652-2-git-send-email-abhinandan.gujjar@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [122.162.226.234] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: bd21895b-35ad-4e7a-56ae-08d87aa624ed x-ms-traffictypediagnostic: VI1PR04MB7136: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fVRs8ICQT1diYMuk3JKrTQ61D81fwnxNpOiDPIE3Z03C0a0opraH+ccq0oy39nmFoLobs3FbX2DRkFO6YJy7g39zs5AChOGEyZgJqnxbdihvGQYZIpO9rhX/aTGD4W0kT+trX1xovk3YD3vAnTOZOyaMxN+F4heRX3VkxtB2UMuBnxNuTyRsaev51vl9l6lkdCgs0fNxK0xX9wYu8SRJ/wAv6SbMp50DWiH0AB5+nSmoWW7MlJA9vTouEM/8R4k5LHyWDukhdyjzcJYan0/Y4NGniS9QkQ1spNsNbJVI833K5zOjotSEv/dbuv+NdzJxsqmbo6Y7UL7hSv4TNz/yZw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(346002)(376002)(39860400002)(136003)(8936002)(66446008)(55016002)(64756008)(66556008)(66946007)(44832011)(2906002)(76116006)(4326008)(5660300002)(86362001)(66476007)(110136005)(6506007)(7696005)(9686003)(83380400001)(54906003)(478600001)(316002)(52536014)(8676002)(186003)(26005)(33656002)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: puz1wKO6P7Fcf3K0lTSzoxVmjxllzlbUM9BGIX7Eazc8DYcUXiU3UwH7sGWz4N1JMu4mgKbHhQpXbWgpt3mFNH6STddtTPPpDFXY9rTshhSq3rwriq4JjqEjdOdPtvEHaAhgcU7GlhEPh1HuPlfsXM3FNGEd1ZgbWT477HZjRxTLF/V0pr7lT3iT47SQKvp1pyWq1tGA642oKTCn/5n2XSrCTs5dHKwPBc9QnqI/eCXeq3kNxESCGsV2REn3k737OhHkVjdJ9bCM1mWHiDNqpOb8W66cJ4jyXfGIRoTlVhPPor1sHw5n5E6k5+sn28CKvM1FuD++rCkyXnCJmY8qsjQ3Se9q9zUNqNGQ9M/hZADAgwo71i3lWiPFPIbm2wkzfeY39RkEOm4DvJl4p5EqzicLyuuHCOk5MuAbqjdVETqX3ZgC/fFu2xl0H8HD7BUR+oSruThKkmIJH7nBvjV67ynWs/myMpjlc+QGvVXapqCyji6P8PdwJPiYCjzuYzaHT+LheiYHmx4LSo+ixWOCB7MLH3RHQ5Oik8sU0AX188I4nvsYttBsdhmNnj3eYEXroCqUd2D/iKiur+9WwQqCyU72Ho3pcde/phku4wAPcC8o5IxdRZj4a5hoeT/KuAzQ4hvrZwN3oA/MtsNjx7JkIw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd21895b-35ad-4e7a-56ae-08d87aa624ed X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 18:28:47.5179 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: z9xfsVnzNk6KAaT4LD6sqems5qKM/W/FAXFX6iouu+HNM8MAWuazD7UFwuutMPbrOFoj0mL0n7NUedFAxUaNOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7136 Subject: Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Tech board members, I have a doubt about the ABI breakage in below addition of field. Could you please comment. > /** The data structure associated with each crypto device. */ > struct rte_cryptodev { > dequeue_pkt_burst_t dequeue_burst; > @@ -867,6 +922,10 @@ struct rte_cryptodev { > __extension__ > uint8_t attached : 1; > /**< Flag indicating the device is attached */ > + > + struct rte_cryptodev_enq_cb_rcu *enq_cbs; > + /**< User application callback for pre enqueue processing */ > + > } __rte_cache_aligned; Here rte_cryptodevs is defined in stable API list in map file which is a po= inter To all rte_cryptodev and the above change is changing the size of the struc= ture. IMO, it seems an ABI breakage, but not sure. So wanted to double check. Now if it is an ABI breakage, then can we allow it? There was no deprecatio= n notice Prior to this release. Also I think if we are allowing the above change, then we should also add a= nother Field for deq_cbs also for post crypto processing in this patch only. Regards, Akhil