* [dpdk-dev] [PATCH] test/crypto: fix flag check
@ 2020-04-16 17:12 Pablo de Lara
2020-04-16 17:51 ` Trahe, Fiona
0 siblings, 1 reply; 3+ messages in thread
From: Pablo de Lara @ 2020-04-16 17:12 UTC (permalink / raw)
To: fiona.trahe, declan.doherty; +Cc: dev, Pablo de Lara, stable
An incorrect flag check was done, using "&&" instead of "&".
Fixes: 2717246ecd7d ("cryptodev: replace mbuf scatter gather flag")
Cc: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
app/test/test_cryptodev_blockcipher.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/test_cryptodev_blockcipher.c
index 2ff7fc91b..4973c74a9 100644
--- a/app/test/test_cryptodev_blockcipher.c
+++ b/app/test/test_cryptodev_blockcipher.c
@@ -93,7 +93,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,
uint64_t feat_flags = dev_info.feature_flags;
uint64_t oop_flag = RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT;
- if (t->feature_mask && BLOCKCIPHER_TEST_FEATURE_OOP) {
+ if (t->feature_mask & BLOCKCIPHER_TEST_FEATURE_OOP) {
if (!(feat_flags & oop_flag)) {
printf("Device doesn't support out-of-place "
"scatter-gather in input mbuf. "
--
2.25.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] test/crypto: fix flag check
2020-04-16 17:12 [dpdk-dev] [PATCH] test/crypto: fix flag check Pablo de Lara
@ 2020-04-16 17:51 ` Trahe, Fiona
2020-04-17 20:58 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Trahe, Fiona @ 2020-04-16 17:51 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Doherty, Declan; +Cc: dev, stable
> -----Original Message-----
> From: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Sent: Thursday, April 16, 2020 6:13 PM
> To: Trahe, Fiona <fiona.trahe@intel.com>; Doherty, Declan <declan.doherty@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> Subject: [PATCH] test/crypto: fix flag check
>
> An incorrect flag check was done, using "&&" instead of "&".
>
> Fixes: 2717246ecd7d ("cryptodev: replace mbuf scatter gather flag")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] test/crypto: fix flag check
2020-04-16 17:51 ` Trahe, Fiona
@ 2020-04-17 20:58 ` Akhil Goyal
0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2020-04-17 20:58 UTC (permalink / raw)
To: Trahe, Fiona, De Lara Guarch, Pablo, Doherty, Declan; +Cc: dev, stable
> >
> > An incorrect flag check was done, using "&&" instead of "&".
> >
> > Fixes: 2717246ecd7d ("cryptodev: replace mbuf scatter gather flag")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-17 20:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-16 17:12 [dpdk-dev] [PATCH] test/crypto: fix flag check Pablo de Lara
2020-04-16 17:51 ` Trahe, Fiona
2020-04-17 20:58 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).