From: Akhil Goyal <akhil.goyal@nxp.com>
To: Ankur Dwivedi <adwivedi@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "declan.doherty@intel.com" <declan.doherty@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Vakul Garg <vakul.garg@nxp.com>,
"anoobj@marvell.com" <anoobj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector
Date: Mon, 6 Jul 2020 12:23:33 +0000 [thread overview]
Message-ID: <VI1PR04MB3168836D2EDB0450D278BFCEE6690@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1591345833-19159-1-git-send-email-adwivedi@marvell.com>
Hi Ankur,
>
> In the IPSEC ESN test vector the cipher offset for encryption
> should be 8 bytes which is the size of esp header.
> This patch also changes the ciphertext and the digest reference
> data against which the operaton result is validated.
>
> Fixes: 699741912d71 ("test/crypto: add case for auth only trailer")
>
> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> ---
Why do we need this change?
The existing test case is to demonstrate a generic case where we can
have an auth only trailer as well. It is similar to a case of IPSEC ESN
but not exactly IPSec. Cipher offset can be anything as per the app
requirement.
I don't think there is anything wrong in the vector. It should pass in
every hardware without any issue.
Regards,
Akhil
next prev parent reply other threads:[~2020-07-06 12:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 8:30 Ankur Dwivedi
2020-06-30 14:15 ` Ankur Dwivedi
2020-07-06 12:23 ` Akhil Goyal [this message]
2020-07-06 15:03 ` Ankur Dwivedi
2020-07-06 18:54 ` Akhil Goyal
2020-07-07 6:07 ` Ankur Dwivedi
2020-07-07 19:20 ` Akhil Goyal
2020-07-08 9:51 ` Anoob Joseph
2020-07-14 7:52 ` Anoob Joseph
2020-07-15 19:54 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB3168836D2EDB0450D278BFCEE6690@VI1PR04MB3168.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=adwivedi@marvell.com \
--cc=anoobj@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=vakul.garg@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).