From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1405BA00BE; Tue, 7 Jul 2020 21:20:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6EDCE1DDFE; Tue, 7 Jul 2020 21:20:42 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70042.outbound.protection.outlook.com [40.107.7.42]) by dpdk.org (Postfix) with ESMTP id BACDB1D9C9 for ; Tue, 7 Jul 2020 21:20:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rl4akwXSwi88sm4Z9wPyzlttElfV228TZt+ax/jnKiPLUGtkn++XLt/+jRGrfLesMFQ8wCuCuceCoygu/XJMxPhUUPQ4vIzwwUr+T14fEntLeO3QJHb1+7zvoI7PedkdYoCKy6aPC4T2xW9lnGj+fuCx4wjKEdyEI0gKnT1Y6wnf1Ng0iUqvRegFWYB2Vhfg4HUwkjxDNUFPQv/E7oG2aB9PqHwcVRG6gSQffkR1SrZGuJLjP8U5NzMRu0bUyz16d1PGB12Ww4GPg0U1bgsV/Iwp9d6rjEvyUa6HyDNI38j5Q+kmUBZiCMhcO9fO0/chpwZjdyWJ/G+nxm2gwWwwdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hc2CWzLKs4FNx0sAmoV40auwt0wG6i6lXPTz85W/5mI=; b=jTgC0CaPdAyOtfkjMNZfCyTlHbJv+9cgliNM6bzBQvlPJbdsLotWrGE+GuDT+ymiil7MglG9CJ/bHvWvf2wBgmJkvXXp4TwFqcHPmsb3PRPtotO9XlqhsPzKCfoTeM/zNioR0JP+3qlLqvUyFcsMncoyK76gCROP1RbHFWogiOCjRVFvASf/I2qtJAH59Y7WqD1TuR63EaK/kFiU9XbvQ9YRz5aHQmSYDAI6F0yrloCyVeE7KyPD+mm3DyayP5600g6QMd8JQDNTJv3ulF3yFit+ZkSzZAzF0Fk9z7499IXp7U2VnsLrS4hI5ExxG9IghW6cbgD1BzoU974uMNrKEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hc2CWzLKs4FNx0sAmoV40auwt0wG6i6lXPTz85W/5mI=; b=mLPUj5LVkBS05jNOaZtGVSoiV0G+LnJJOMDY31xL6IEGvaH9TXKaW81SJp9XUnKhR7kJX3RwqhBwlO8WyZQpT/t1XlHAVjC7dppT/jtAtljI0RAsq/mnIBKp8B+m4XY57JeD/KihnDentz3T4jSDswe3cRP2LNW5RTjPP6SUxac= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB5839.eurprd04.prod.outlook.com (2603:10a6:803:e0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.24; Tue, 7 Jul 2020 19:20:39 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::b077:1fe4:d352:b464]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::b077:1fe4:d352:b464%7]) with mapi id 15.20.3153.029; Tue, 7 Jul 2020 19:20:39 +0000 From: Akhil Goyal To: Ankur Dwivedi , "dev@dpdk.org" CC: "declan.doherty@intel.com" , Hemant Agrawal , Vakul Garg , Anoob Joseph Thread-Topic: [PATCH] test/crypto: change cipher offset for esn vector Thread-Index: AQHWOxOtMDzmJDGeR0KqgVz6oEZL66j6qEhggAAu4YCAAD+cMIAAvM0AgADbeoA= Date: Tue, 7 Jul 2020 19:20:39 +0000 Message-ID: References: <1591345833-19159-1-git-send-email-adwivedi@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.118.167.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 586cfa5b-50f2-49fb-2b88-08d822aad57b x-ms-traffictypediagnostic: VI1PR04MB5839: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0457F11EAF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OrdnN59hyTyilYIKEUxmSfHGmqRlTVxPUeXCuOFYgbTzvVpbbcXAL0LKyJLuiBf0rhaIDqZ4uGKGvnt07ENL1DIWoqWKtzvySYkRFyMw5dbEsAzz1cPxukQh8UYsN4tvPcXwQrEzgIBaaIdwiw9ICWqf159uVNEiq+MjxcO79ce99DbbXqpNApw6hdHwf8DpkLrDl6qqo4yei02ypLmYhdxUuFrWKC3ieO7VdQQpGNUuoAXDLZZBb0IAX5G4k0gplZOygsuPALxr7zDRyRGR0tvCHSmR3QQaj6+V2YGXslLBL0cFPepDNkvrE/1Ii7h2MQYjuBUxrEpW8OUwGXr74A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(396003)(376002)(366004)(39850400004)(136003)(54906003)(2906002)(9686003)(52536014)(44832011)(26005)(186003)(55016002)(8936002)(86362001)(83380400001)(66446008)(66556008)(66476007)(64756008)(66946007)(6506007)(76116006)(8676002)(4326008)(33656002)(110136005)(7696005)(316002)(5660300002)(71200400001)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: ZYlQaOFOh2WuKfcoe0uM66AOT3Vun7W/k4Xh698CVnUm8aBV45uNiOLyNY2e3DvJUsDW2TRNs4Fffig/X3MchdHSAEcq9n2gYL+k/ZiHzpZZcg5X+52Z4wIeLUAEKI2952Kenfu8dmxEuRZLFjJgzkKnYJhB3yaTn9YmpV8CI03pp/czjwHtZrLtikS/V5leGDn0vamlvgqjS8OgG50g+OavGhWjwCOmbNZQr2jy1Fewm9jAJ7QO7O4EmvoikPXDK96FLiGwziH7f7C4SQMOtf6+Sni+IppkenauoeFyehTGnlYIahpp4rI2G76pd3hUZDjW+37qJj5SNLykH7StQyVbAnpkSG64UtB1n4882qfO8BSswzxLLzu8JENsMZJ55b7zYGEhyTT1TEOUuZH2ymmjHwwv9WHgI3GPH3VorxXhApNQE4QZuwtdpHhjTgr1Cv29QOlR4BHztrVZdQRhhT+woNZk5YfbEozsRCbtgIQ= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 586cfa5b-50f2-49fb-2b88-08d822aad57b X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2020 19:20:39.2570 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7cY6Rjhqmo8dLeWldonMmGhrCN0xYAtuPKmmSXVl43RPE4G16ddO0AGBeXPCRqH0WtzDEyHk640MSIce3t5tMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5839 Subject: Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > >> >Why do we need this change? > >> >The existing test case is to demonstrate a generic case where we can > >> >have an auth only trailer as well. It is similar to a case of IPSEC > >> >ESN but not exactly IPSec. Cipher offset can be anything as per the a= pp > >requirement. > >> >I don't think there is anything wrong in the vector. It should pass > >> >in every hardware without any issue. > >> [Ankur] It's a limitation in OCTEON TX PMDs that the (encr offset - > >> auth offset) should be 8 bytes aligned. > >> In the IPSEC ESN scenario generally the offsets will be such. > >> But in the above IPSEC ESN test vector, this requirement is not met > >> and hence the associated test cases fails on the PMD. > > > >In that case, I think it is better to have a separate test vector and bo= th should > >be executed. With the previous one as not supported in your case and thi= s > >one will be supported. > [Ankur] The offsets values are present per crypto operation. So to make t= hese > tests > as unsupported the pmd datapath needs to be changed. > Is there an alternative to make these tests unsupported? I believe this is a data path error and a limitation in your PMD. You can not stop the application writer from using unaligned cipher offsets= (non-8 byte aligned) This is just a test application, which may hide your PMD limitation by acce= pting this patch But in actual the scenario will fail when some user configures a 12B cipher= offset. IMO, you should add a new test vector instead of replacing this one and it = should Be OK to have the existing one fail in your case.