From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 041CBA00C5; Mon, 11 May 2020 13:20:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A8D5E1C1CB; Mon, 11 May 2020 13:20:45 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2059.outbound.protection.outlook.com [40.107.21.59]) by dpdk.org (Postfix) with ESMTP id 173A41C11C; Mon, 11 May 2020 13:20:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GHV9mZRb5eEZ9TVUcEUOGKm4RUMjgQ8hlDN7QqiJ61MwGXODGPBuL8fntsrZ9h3aIqELb3b+MPNYjimRpcvtafUr9o3XXjWxZm9DEI4u6zSlI4m4GZ7ni3yHKOTlBXS7sqae3qhOD89+GsunjkvBe9PxcW8XJam+mHV2e8p37oabADgQ/BDcXgQrd7YJNQkwPSz7iwGC5B2dNsObrbqGVOKdkpsXYEFYAGMiNkEo9eJhQNDVloJLeq0eJuuKXTOI/JIlumvL/BelkAxjJmPX3ygFhFfz6yg5oFQ+K5c61Tow/BJnjhn6wDGmk3IMwB5SW3uqjCiI9FVylpFtXJrmJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1fYoB1vNGXzUcEQ8Ycm68FnCGzgFIrW0r8f9psFNw+E=; b=edpCPAfpA45rm/ulH5FXf6ekzIxzG1incIUAkYRkp+7PKciqvlMzOzBftqcR1d5z9FAfkJ80Ixu3Lawu5r5tdYOf4LCEvMd+RvFzMQ4vYtpCjH0xWmvE9YBmjPi0oGJdY7OlXugVHMDwr3ek6D/bZGxm15tfyJ5lisvGP9x0gurZw5TyzgS7ei+5eVTOQ3AMufCplLXFqVjPC6mFdwmfAVFvPov5VfFL2U0QiCbVMOcnoSvj+J0iqsEiATEDQENMAdM2ofB4PS19MSTVGJKFFuX8Uqz3oGQhPHpLVjX1Niyj6dyymwGg2XZHlGMXIke6ZsmVCGRy3xPkujvSlxJ7ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1fYoB1vNGXzUcEQ8Ycm68FnCGzgFIrW0r8f9psFNw+E=; b=PpENd7SZGg6+p7n4akS+Vb8YLqiwZbUpprr0CT34DlafxYMSGMa0HDVKCqY8lH1nMlRHm37FOV4lJThrw+glj00Y9Pa8FTgszfAHZFiFRl8TYtVIVZaQi02cl0ch1/d0ibspMexrEfkX+2QBh6KbvM4KFhI4VyKUABfCkcDFTao= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB6079.eurprd04.prod.outlook.com (2603:10a6:803:f5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.30; Mon, 11 May 2020 11:20:42 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74%7]) with mapi id 15.20.2979.033; Mon, 11 May 2020 11:20:42 +0000 From: Akhil Goyal To: "Ananyev, Konstantin" , "Medvedkin, Vladimir" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH] ipsec: fix unchecked return value Thread-Index: AQHWJ3XL3OknsVyRVUCto3QU1cWlK6iiuiMAgAADKyA= Date: Mon, 11 May 2020 11:20:42 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.118.167.80] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 762da538-dce4-48ff-fb63-08d7f59d57d6 x-ms-traffictypediagnostic: VI1PR04MB6079: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:229; x-forefront-prvs: 04004D94E2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: beUIiCY8/qUczAhu36tByR3Ivu4H8zWU2+OX9A1uoLKuRUw2uUyB43Q2vIjGMP3deVN1tuPb+yAAFgmnMjJ9YI7yiFsaajxN7hJSALdK2jFqb02uWiQD9OPoVZvYP4RKLPFu2qxn+SFe73a877ffu7vkS24fuy5IP0HEAh1G87ml7kpMjG/ls2dkqWCEejuXXcZ5Liurwe6a9yCEN/5kjIexPxFVdwg4qmcPwvIQyBA/QN+kCSjaIJIewOWCRTulG4i6GYeUFQIPCH1PAcwGRKM+QEVVVm8wnnnRJ85ovsFNJj7usU11RpAL57aHfAgCz84FINtC75OALAVROshQvbhmbpSQvOwLp4LkPCURdORiiEPlWjJ+BFZbhGI02bd/4TcwUvwflcNoC+PEP4k35563RnOW5DCvFwTCVaz/qABxlilBLqC5//nL9cD5XtJRaZgByVPvT4eVLTILQq2WDvuJRDrMQGo26ow81DL3Ri2ffwqOq6ZazhZ+chHL85sVava+3WLejeSdcyYRDByoSw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(376002)(346002)(396003)(366004)(136003)(33430700001)(33656002)(71200400001)(55016002)(52536014)(26005)(5660300002)(186003)(4744005)(478600001)(44832011)(2906002)(8676002)(66446008)(64756008)(6506007)(316002)(110136005)(33440700001)(66946007)(86362001)(7696005)(66556008)(9686003)(8936002)(76116006)(66476007)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 0j6xpzFJLIh9Ncij9MDNoRTw6PNfiAuGL0PaqvKBr801S3ocjlCk5A/43PI173kgkl9bkc8nAa/QW7zb58ocb/MsU1VS+D5I8Q0WFvpYcDr+kgIxLkSNtYfJ5jjjMEChnvKjEBtMGWSiAnY8zZnY1iV423ODnn3IDIzjIu/eaPY6Iyc7OWIChfUAWHcgiIFJP+lz6+Bb/QhLkw/pq5fKL+mLppgxgeAYiFMgskjO/8YuDpEWaFjhQ0KJ74IfbjhOB93ml2pPXBORBncoCLqcXyughgzFzu4hB/UYggI5vEsGrJyIPW5jF58SMsbYhYeI1IDVTNnggFvZh30nLHyGDNNgMAeSsktsWNlyJd2afbyXjdullBksREMbJ+9cNtG0DGuAefv145mDytzPxbyzQAmn9j3Rn0t9+53J/etM/SYuIfiPTAVE9iq4+d+N3pG4KD+bRYhR0SqBC+ayRKgRh7aFhqEanUBBe0EN17ZmjO2h1HfPvYOcopih3Nx10gBt x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 762da538-dce4-48ff-fb63-08d7f59d57d6 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2020 11:20:42.8122 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sP3MLCHR1RfrgzN5C4xbCKc4chhyZT7aNq8E/rZD8J9CEyomwhH8668yPOUtR4SbSsQC9/w1f/8EK5noxja/zQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6079 Subject: Re: [dpdk-dev] [PATCH] ipsec: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Explicitly check return value in add_specific() > > CID 357760 (#2 of 2): Negative array index write (NEGATIVE_RETURNS) > > 8. negative_returns: Using variable ret as an index to array sad->cnt_a= rr > > > > Fixes: b2ee26926775 ("ipsec: add SAD add/delete/lookup implementation") > > Cc: stable@dpdk.org > > > > Signed-off-by: Vladimir Medvedkin > > --- > Acked-by: Konstantin Ananyev Applied to dpdk-next-crypto Thanks