From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5166A0588; Thu, 16 Apr 2020 12:25:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ABA191D62D; Thu, 16 Apr 2020 12:25:22 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2050.outbound.protection.outlook.com [40.107.21.50]) by dpdk.org (Postfix) with ESMTP id 6EF951D5B6 for ; Thu, 16 Apr 2020 12:25:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H22MzluionXttW1EYN0W4mz3H9Swv1CubVZRUSMEa2EQwWCvhXiZYynMXJZx1wRS3XpQWil4T6I1j13tJK4LYTOjDffaEFcdx6jaZIVx54+Fq9YqSZY6w0xh9E0jB9VpTLKUQSJWzPCfvICmcMsM7EFV9O9OUyTtQiKjQUcO+AezLhTZITjlQFxp9nfk0/klPl/THSa3Iuz+s1SJAogUbqaa0gjOJf6BG51EJDe8YPn/mwHRlhAcyOt6ZnfcHEIJ9KCXgA0+ye9p8wKU0wXaK9EuLk1WE95Nb7KWVMzxoFE71ajQK01Utk0yCNrliKYSbNa9wjVpNZpUZRZ8duXWaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uL4xecEUn0c6QQoDf2n7AtYpHSY2XIxmzW8kUB5jJxM=; b=SFfBTQGmga9KKihq3mYsR3HGWQkGLXSoCXrFCCOM4YihVPO1A48GNfetufttS3xrjECBamtbNwutyZxBUN8mjvetHcdux397iYyq6RahP5Jrf8DMxwoiAy7NnHRaosLbFEzTIVpfhj9Z/4cPzZLO8K+m6EYV3Z6zrQ4Td/exZaytIr1gLhPTSVDb3DhGGYykRCqbkapBTeYVRjXErSc4bEQ9kseBbXvlDJJH/48Jzm+mlj7tu2e5hxzg/2x6ggzFmDSBJO+GcVKSsM7UmAkwPS3tHsIF7/H5yO0X98+4ISBBggQdf8pQqn1F3lYbMDqxstUra4ZyREUuaMtyEktNuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uL4xecEUn0c6QQoDf2n7AtYpHSY2XIxmzW8kUB5jJxM=; b=f3NLKLRAjOBTGzM2UphcvBsm59Z6zRbVig5lAbhUflLTfZznC7r4W6ftLewGwyk0sB/fIuLfKiGnDuFbVDMoTYTPXG/oRju7vkVobyzpq5zeGvpdNnbEqcfw2/X79s0WdBvYQMRbJa8Jt4RPFaQrbnExZ4mIxPHZPhGPYc+Lfh0= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB3184.eurprd04.prod.outlook.com (2603:10a6:802:9::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.27; Thu, 16 Apr 2020 10:25:19 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74%7]) with mapi id 15.20.2921.027; Thu, 16 Apr 2020 10:25:19 +0000 From: Akhil Goyal To: "Trahe, Fiona" , "Dybkowski, AdamX" , "dev@dpdk.org" CC: Shally Verma Thread-Topic: [PATCH v2 2/2] test/compress: im buffer too small - add unit tests Thread-Index: AQHWDaRhlhVWnQmb702KIK9DOAfFGqh6jO/QgAEECoCAAAT/sA== Date: Thu, 16 Apr 2020 10:25:19 +0000 Message-ID: References: <20200408125101.25764-1-adamx.dybkowski@intel.com> <20200408125101.25764-3-adamx.dybkowski@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [45.118.166.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: bfa9d0fe-77a4-4718-4bfd-08d7e1f076a7 x-ms-traffictypediagnostic: VI1PR04MB3184: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0375972289 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(376002)(39860400002)(136003)(396003)(366004)(346002)(76116006)(66556008)(66476007)(64756008)(66446008)(52536014)(66946007)(478600001)(44832011)(110136005)(8676002)(7696005)(81156014)(8936002)(6506007)(26005)(186003)(316002)(5660300002)(71200400001)(2906002)(33656002)(55016002)(4326008)(9686003)(86362001)(160913001)(15963001); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kUOtLqnplRL3M63+2WLvS3SdRVxDDzsUpWf11b13A2g3rnW5ZFTJQaUAjPeKsNigW4T7E6ZYb2B39R7llXN4NnBzKe6EoxY5ayX6G4RkY27uleqQSGWtjgbiD9yRWboCgtXKa1nwVBFbff2ZwRGnEVfkDAf96oieSoqKDBDX0JIotSavLmyCv/YfPYTYFxKnTXyj7O39X1wfHhp87CzpWf086YNxskVWxV9LJuUlevBr/IwQZ+1i11jvwR8Y3rjYBuBCasLGXOkDrDf7SeI6xZXusrBzXDz4qV7ctR7TnmtRuYJDXX/mlv04mAccPbpkc3SN1uw0SMT3CVOxRIZo/jM28t8lVCCs5W2TnYQA3U1OEqNQSpTIE7z4DgOjTZFnCzdtZkUKVteIPb76kU6VpFE7TQPCQ/a/zkDA5f5/okhgd4g/HF7rpDhge4P2pzEnoAt0XFP1lIJaZjVVxqkfM5ilMmWTpPn+RgpTP9BUnpnfhPzCImN+LdP4WfLlFdWVK0UC2+odEyBpzMSQc70Qcw== x-ms-exchange-antispam-messagedata: kPQF02MUWbxclXW+bMTk5Ftzf/+wvuQOrKdXa0xOUtwVYmYcyOf14zYuwQRIAt8n1hV4bYvgSOI3vVJB+9I9dGAFpi1KZ8iuASifZTCZPwLTKIs/iQZ7quovvI1khs8V+sXrOwTAgDZmyBPYSBT2WQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: bfa9d0fe-77a4-4718-4bfd-08d7e1f076a7 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2020 10:25:19.4141 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3Jt0lFP6NUj8gYrcLaWdWTv/Eu4SlmoKQp9QG0nXCrBkp8/Kp59xGQoGugSQavDLAv1PBPFLLGRMBlxPcdSNJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3184 Subject: Re: [dpdk-dev] [PATCH v2 2/2] test/compress: im buffer too small - add unit tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Fiona, >=20 > Hi Akhil, >=20 > > > > Hi Fiona/Adam, > > > > > This patch adds a new test suite for verification of the "internal > > > QAT IM buffer too small" case handling. These unit tests are > > > specific to the QAT PMD only - that's why they are contained in > > > a separate test suite. > > > > > > Signed-off-by: Adam Dybkowski > > > --- > > > > Why do we need to have separate testsuite for QAT? > > Can't we have a single one and based on capability of the driver, > > Determine which tests need to be skipped in case they are not supported= . > > This would create a mess in the longer run just like cryptodev. > > > > Please fix this, we cannot take this patch as is. >=20 > [Fiona] Yes, I understand your concern and we considered including in the= main > suite. > However these tests are not based on something that can be > checked in capabilities. They are tests to hone in on a specific corner c= ase > based on a QAT limitation in its intermediate buffer size. So some of the > tests are to validate that the recent changes we made in the PMD correctl= y > work around that limitation, but other tests are negative and expected to= fail > as provoking a corner-case that still exists. Other devices would probabl= y not fail > the same tests. Does that mean that all PMDs will pass with the newly added testcase which = is for A corner case in QAT. If that is the case what is the issue in adding that = in the main Test suite. It will get passed in all PMDs, isn't it? Am I missing somethin= g? I believe we should not have PMD specific test suites, rather it should be = based on Capabilities to identify the cases which should be run for that particular = PMD.=20 > This was why we felt it better to have a qat-specific suite. > We would expect any future tests to go into the main suite, so don't thi= nk this > should cause a > mess in the future. >=20 >=20