From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C219FA0598; Sat, 18 Apr 2020 09:09:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1E04B1DD05; Sat, 18 Apr 2020 09:09:29 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2078.outbound.protection.outlook.com [40.107.20.78]) by dpdk.org (Postfix) with ESMTP id F03AF1DCC7 for ; Sat, 18 Apr 2020 09:09:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bZfjiQbLhlEi2qYuJZ/ShLXlZ22wqTU1s0YC21RxJUHjWQoDj2YAe0qC8C+ETzVCWWHwPyq6Ko+AhH4VJRq1kKBVaFewLI4TJzqxffSYCtqWSxMjVPvk5tSaKFkGr5nysRHiPhSoFc4kRIS6t2TWxz0lXEveqvfRke3r9Av+y4P0Eeu07jSfREuNtMhBkp0EgEQidLrTrOawtXcv+HCR2tQgVt/SaZjrcUGrDkEz1QgppcXQuP4QgTfjjjdxYUJqWkJJ5B7ob7GbJ88sA0j9d/lqx5ppEft9zpf5PPDb1GwcH/4DBiLdbxE69yUwM8DimaLIlIxjOfr+wrfyhONesA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WOKgHNF/LKmHaROg7IKCgy9WQ7mZhzqbVAD+2hiH22U=; b=FfYkZao917vE22uU/9G+mryjaBHJQGjxuUlM/3GrnAkb/qC6N+QPji0+Nop/HrD5TB25XSdx66rABuvw3FEZricQemoOKbh7X4WBFXzJmPswk1S7KA8GflffxtmVIwZ9taMUc9/EZ7mGbBLitViJI3M5rMXIvWCMuhMwNxb4YcbApNUbRwV7NgiURDo7A4zl3NJeav7NN3D68Z0hzDgaiawwJZLsY4TqEYJ5IFtTPNWBeGvrQpVTOBw/nw4bBHIzJmUk8/F1nLdSgfDdjX6O4JjKgt/3h3Pdl1x9w2CIUBHNl/SI/n0yB+3IxoS8jMcH3kE6CgYlPcCOEDvwJUJwxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WOKgHNF/LKmHaROg7IKCgy9WQ7mZhzqbVAD+2hiH22U=; b=IQHwLfpYWekq7eNpCeeMn2vjJ4KdMM3pbo/CN32yFngoL1Sm+q6ySDZh2XpNbF2csRjA7L+COFiSTfvSUt7OaOJyg7pkYo2MsYZm44Zttb+0zppI8OOnt1rHZL0VuqeklZoSfpxANYQkQHJ+t2sE1r4o5eBe6LimorWkqFJbl6k= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB5039.eurprd04.prod.outlook.com (2603:10a6:803:59::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Sat, 18 Apr 2020 07:09:25 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74%7]) with mapi id 15.20.2921.027; Sat, 18 Apr 2020 07:09:25 +0000 From: Akhil Goyal To: Nicolas Chautru , "dev@dpdk.org" CC: "bruce.richardson@intel.com" Thread-Topic: [PATCH v4 00/11] drivers/baseband: PMD for FPGA 5GNR FEC Thread-Index: AQHWFS41ugWr6/zrP0qi41CzXyL+pqh+cqww Date: Sat, 18 Apr 2020 07:09:25 +0000 Message-ID: References: <1587179056-133714-1-git-send-email-nicolas.chautru@intel.com> In-Reply-To: <1587179056-133714-1-git-send-email-nicolas.chautru@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [45.118.167.76] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4367b54e-eac6-4c22-50ec-08d7e3676d9f x-ms-traffictypediagnostic: VI1PR04MB5039: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0377802854 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(39860400002)(376002)(136003)(346002)(366004)(396003)(186003)(81156014)(55016002)(44832011)(33656002)(66574012)(5660300002)(7696005)(478600001)(6506007)(8936002)(8676002)(2906002)(26005)(9686003)(71200400001)(86362001)(66556008)(66476007)(66946007)(66446008)(64756008)(76116006)(110136005)(4326008)(316002)(52536014); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hVrOhjI/muZU/mynUr+qAG1O7yyLrsi+9AIRJ0XjW+NdY+jaIpn171tmPgmhYpyKNIp3/yBTDEavenXhrvaVg3hsz612FQ/ypP7mXQgeoTSH67jGEO6EbFigiaXnlKMSnGZwMlVXWaYR4D7QF5Is6i2/zTWpYGAQiNcfW5R+awnrXj+Lho1JCJlBehHY+K68jXesCYoqXkoHXiQjcZKdlpIUVoeLc3G35OIacLMGv4dAobUYPsihvomZD5pELaUsCJHRBBeuveuYCzlwlM2ndRrzN4cmszi56iiosUrkYnO6aDrvt2bkW/C8a1ESsNPxIoPVLoHDV3E8mOeHrNMQIjmogSszqlIdsIf1SCshakXDn8L2pQ19925SFLW1+rhh1457OpIiQ22tOGKDX5yItECQ4M02XE83DtgCLRnqsY/w42IsawC5VN1reWsM7Bfu x-ms-exchange-antispam-messagedata: N57obFrFP/RmUs5wIbwrj7AVDG6/8zRZvod6C9vPAWpsc3MXIri047DxoPoJda+5tw8Jos0rORD6XwiRcczfmZFXLYLBuKRVMKCUls0h9t3Mb1SUA6+IwsY8XuoKoWfsDLqaYd57hIuwJ8rajJ9MkQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4367b54e-eac6-4c22-50ec-08d7e3676d9f X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2020 07:09:25.5029 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gap2YE/3/dQaSMUG3S8EahcPJdBAxCIYT1EBnl5SgnMtoS09YE4GlKyTtKW1O+f4vfltNXduQsEc955YmvSvfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5039 Subject: Re: [dpdk-dev] [PATCH v4 00/11] drivers/baseband: PMD for FPGA 5GNR FEC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Nicolas, I am seeing some compilation issues again on individual patches. Please be = careful. This is causing a lot of duplicate effort. /home/akhil/up/dpdk-next-crypto/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gn= r_fec.c: In function =E2dequeue_ldpc_enc_one_op_cb=E2: /home/akhil/up/dpdk-next-crypto/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gn= r_fec.c:984:76: error: unused parameter =E2op=E2 [-Werror=3Dunused-paramete= r] dequeue_ldpc_enc_one_op_cb(struct fpga_queue *q, struct rte_bbdev_enc_op *= *op, = ^~ LD librte_pmd_octeontx_zip.so.20.0.2 LD librte_pmd_null_crypto.so.20.0.2 INSTALL-LIB librte_pmd_octeontx_zip.so.20.0.2 =3D=3D Build drivers/vdpa INSTALL-LIB librte_pmd_null_crypto.so.20.0.2 =3D=3D Build drivers/crypto/dpaa2_sec LD librte_pmd_axgbe.so.20.0.2 /home/akhil/up/dpdk-next-crypto/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gn= r_fec.c: At top level: cc1: error: unrecognized command line option =E2-Wno-address-of-packed-memb= er=E2 [-Werror] cc1: all warnings being treated as errors /home/akhil/up/dpdk-next-crypto/mk/internal/rte.compile-pre.mk:114: recipe = for target 'rte_fpga_5gnr_fec.o' failed make[6]: *** [rte_fpga_5gnr_fec.o] Error 1 /home/akhil/up/dpdk-next-crypto/mk/rte.subdir.mk:35: recipe for target 'fpg= a_5gnr_fec' failed make[5]: *** [fpga_5gnr_fec] Error 2 /home/akhil/up/dpdk-next-crypto/mk/rte.subdir.mk:35: recipe for target 'bas= eband' failed make[4]: *** [baseband] Error 2 make[4]: *** Waiting for unfinished jobs.... Apart from the above compilation issue. Please make some other changes. I w= as doing this myself but since I am asking another version, please include = following changes. 1. Rebase your release note just below the other baseband PMD change. 2. remove DALLOW_EXPERIMENTAL_API from Makefile 3. remove allow_experimental_apis =3D true from meson.build 4. header installation in meson.build is not correct -headers =3D files( - 'rte_pmd_fpga_5gnr_fec.h', -) +install_headers('rte_pmd_fpga_5gnr_fec.h') Please do the above changes and make sure you check meson build/clang/gcc s= hared/static builds on all patches separately. I don't want to spend more t= ime on this. Regards, Akhil >=20 > v4: Fix incremental patch build and expose PMD header file to meson. > v3: Incremental changes from reviews : file name change, moving few inlin= e > function to .h, adding missing inline, doxygen markup fix. >=20 > Adding new baseband PMD for FPGA 5GNR FEC implementation. >=20 >=20 > Nicolas Chautru (11): > drivers/baseband: add PMD for FPGA 5GNR FEC > baseband/fpga_5gnr_fec: add register definition file > baseband/fpga_5gnr_fec: add info_get function > baseband/fpga_5gnr_fec: add queue configuration > baseband/fpga_5gnr_fec: add LDPC processing functions > baseband/fpga_5gnr_fec: add HW error capture > baseband/fpga_5gnr_fec: add debug functionality > baseband/fpga_5gnr_fec: add configure function > baseband/fpga_5gnr_fec: add harq loopback capability > baseband/fpga_5gnr_fec: add interrupt support > doc: add feature matrix table for bbdev devices >=20 > .gitignore | 1 + > app/test-bbdev/Makefile | 3 + > app/test-bbdev/meson.build | 3 + > app/test-bbdev/test_bbdev_perf.c | 57 + > config/common_base | 5 + > doc/guides/bbdevs/features/default.ini | 16 + > doc/guides/bbdevs/features/fpga_5gnr_fec.ini | 11 + > doc/guides/bbdevs/features/fpga_lte_fec.ini | 10 + > doc/guides/bbdevs/features/mbc.ini | 14 + > doc/guides/bbdevs/features/null.ini | 7 + > doc/guides/bbdevs/features/turbo_sw.ini | 11 + > doc/guides/bbdevs/fpga_5gnr_fec.rst | 297 +++ > doc/guides/bbdevs/index.rst | 2 + > doc/guides/bbdevs/overview.rst | 15 + > doc/guides/conf.py | 5 + > doc/guides/rel_notes/release_20_05.rst | 5 + > drivers/baseband/Makefile | 2 + > drivers/baseband/fpga_5gnr_fec/Makefile | 29 + > drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h | 388 ++++ > drivers/baseband/fpga_5gnr_fec/meson.build | 10 + > drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 2186 > ++++++++++++++++++++ > .../rte_pmd_bbdev_fpga_5gnr_fec_version.map | 10 + > .../baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h | 74 + > drivers/baseband/meson.build | 2 +- > mk/rte.app.mk | 1 + > 25 files changed, 3163 insertions(+), 1 deletion(-) > create mode 100644 doc/guides/bbdevs/features/default.ini > create mode 100644 doc/guides/bbdevs/features/fpga_5gnr_fec.ini > create mode 100644 doc/guides/bbdevs/features/fpga_lte_fec.ini > create mode 100644 doc/guides/bbdevs/features/mbc.ini > create mode 100644 doc/guides/bbdevs/features/null.ini > create mode 100644 doc/guides/bbdevs/features/turbo_sw.ini > create mode 100644 doc/guides/bbdevs/fpga_5gnr_fec.rst > create mode 100644 doc/guides/bbdevs/overview.rst > create mode 100644 drivers/baseband/fpga_5gnr_fec/Makefile > create mode 100644 drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h > create mode 100644 drivers/baseband/fpga_5gnr_fec/meson.build > create mode 100644 drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c > create mode 100644 > drivers/baseband/fpga_5gnr_fec/rte_pmd_bbdev_fpga_5gnr_fec_version.map > create mode 100644 > drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h >=20 > -- > 1.8.3.1