From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 434CFA0561; Sun, 19 Apr 2020 22:51:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B4F8A1C1DB; Sun, 19 Apr 2020 22:51:54 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2041.outbound.protection.outlook.com [40.107.22.41]) by dpdk.org (Postfix) with ESMTP id 1528A1C1D6 for ; Sun, 19 Apr 2020 22:51:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fIbCEGWRVnd/YdTiBLf9DQQoR+PFgEim8gDBpntcUF79fChNMpBZPJbFeySPZEr8OE8SmVXn4KxEoA/9pUEMUKrz4KkK9eQ5dUG+GHkxRLQGoKxsTUnes90a5jLItmjevCF48ljqPxULlEDUoEqOEhrzuT1THHtwxSbi2DyIAd3eaxvqRKF+UQS0XILTSTzUjkBHANUQRNZ/E0bZlF4BNFxh92x5bWwdc5eWJ3pz+Eb5W3trF29of4u97SIAL7zFPI8gXHAVMwMYOrVSTln/8nXxlpgL6gioz9U3GXRgLU3QNFLZvUr3yERvmU9LKx4Z+wFMxIIQgGPqn+YHVeJuqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SZfSAOItw3NPNclq08SuUL5P6kPqGSnPrnXfBS9wlJA=; b=dCwPzUT2HKq1FxoOWIqXc6lgP0Kzqjr61MDP6YDPudo+QW0L49AfhHohhngR0e4t8VK/HtfRuxq+XNjk1xptFi/y4z6ROIHLk/6pbF2i3CuUIwG5GBnwmg7d9Fp9VuLIT2iOtoi787u2TBxaQUL13TL3Y2V8Hcwk3zhjHo8FMli+oEKVBM5QGjts8Zds/Duru/dZQiDNa5jnZ0CwI1QhFekXAKPXEKzboUQ3RV0Xs19SGX3PMMotlFnZUGLybTPWZYjtjfDlZIVEippwN0OsQLxtyrHyGtQCpeiC8e1/zmirKJofh6VkfRaHooyLsnMyw5oBPlq/1f1k3DUb+tbcDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SZfSAOItw3NPNclq08SuUL5P6kPqGSnPrnXfBS9wlJA=; b=pcyQLBErvGdXBVFg2FXTzeuuYksvSBz5XXPA+k/ijudqp/kGD9w0PV54Bj0TH9RtUclm1O+owq2iyuoZdodppJeMpNhQotX1qFvZ761wuKWLLyryY8CHLmvAGZf9TyLeAO61UmRTRAKhYD4RQlbcZsgcXXTZFGblmxnGPeXyK3A= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB5135.eurprd04.prod.outlook.com (2603:10a6:803:62::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25; Sun, 19 Apr 2020 20:51:52 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74%7]) with mapi id 15.20.2921.027; Sun, 19 Apr 2020 20:51:52 +0000 From: Akhil Goyal To: Nicolas Chautru , "dev@dpdk.org" Thread-Topic: [PATCH v1] bbdev: doxygen update only Thread-Index: AQHWFovFFBJGO0HmK0mZUjq5mbnAX6iA6yKA Date: Sun, 19 Apr 2020 20:51:52 +0000 Message-ID: References: <1587329243-225242-1-git-send-email-nicolas.chautru@intel.com> <1587329243-225242-2-git-send-email-nicolas.chautru@intel.com> In-Reply-To: <1587329243-225242-2-git-send-email-nicolas.chautru@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [45.118.167.94] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 519a0cbb-1e9e-4d09-cfd5-08d7e4a37d24 x-ms-traffictypediagnostic: VI1PR04MB5135: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:449; x-forefront-prvs: 0378F1E47A x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(136003)(376002)(396003)(366004)(346002)(39860400002)(66946007)(66446008)(66476007)(64756008)(2906002)(478600001)(71200400001)(186003)(66556008)(15650500001)(316002)(110136005)(55016002)(9686003)(86362001)(5660300002)(6506007)(53546011)(8676002)(44832011)(81156014)(52536014)(8936002)(33656002)(7696005)(76116006)(26005); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eWGrRLcPraMQhX/BTuFNgcApxerHM0vvXgIX1QHj6gVtObU9uH0K9T0DPeQbySiq/ZIdWjpvU4SybTD1EAdSl+bdpCIf7kiAwUGm1JkR4znbfa4jLcNyOJy0NoIBDisug6UOurW0B2YM8koq4MDyiWx+cirDpIPxQ6MOUDjmiUwPU7Po34bzAQl/4PErTikaIiTwoN7b105CmShTywruUCmOeMFvgj+3R0HnJ5MES+7E7wFXKy2dM81+vC/lBWG6cE23pqU5EIOc5IMojLewZgLy1DQyWYRY+OCEgMUI3iUdYF210g9GinRYrph0a4/HdZBEO+EUjjwhYbZtJJcyWxAKf1NbNCyCUMG6vTOPOJS3+cBPZS97Omc/BkQpAf5jZTlljgfehJoUk1niqHWTzwUrgGUsHAqd/ZxGU9dUOqXl7djttn3xaioo4CX/Pf2x x-ms-exchange-antispam-messagedata: I/vXwP7rtU4WRvU+yyrNl1iIrpP3CTbG8mlRl/tbtNL4NMIVC/xQBUwe3kWo2uTGg1quM7e19xq6FiBM9CktmmQb356Hez9vJFwaqWiuotEm7jUWMScvfI6FH4Lx6Ozg15I8ggrzp4mhU4prAn1Q7A== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 519a0cbb-1e9e-4d09-cfd5-08d7e4a37d24 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2020 20:51:52.4952 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zdSP8hyWxPNH455UkBoiOb+dmdWwx2YsM/bgIsOb2MGqMhxppvaAAm0LocaO16Vo/W0fVHN+p4EPNYATnyMA3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5135 Subject: Re: [dpdk-dev] [PATCH v1] bbdev: doxygen update only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Nicolas, Can you add fixes lines for the commits which introduced these issues so th= at these can be backported as well? Also cc stable Regards, Akhil > -----Original Message----- > From: Nicolas Chautru > Sent: Monday, April 20, 2020 2:17 AM > To: dev@dpdk.org; Akhil Goyal > Cc: Nicolas Chautru > Subject: [PATCH v1] bbdev: doxygen update only >=20 > Several doxygen markup were incorrect in header files. >=20 > Signed-off-by: Nicolas Chautru > --- > lib/librte_bbdev/rte_bbdev.h | 16 ++++++++-------- > lib/librte_bbdev/rte_bbdev_op.h | 16 ++++++++-------- > lib/librte_bbdev/rte_bbdev_pmd.h | 14 +++++++------- > 3 files changed, 23 insertions(+), 23 deletions(-) >=20 > diff --git a/lib/librte_bbdev/rte_bbdev.h b/lib/librte_bbdev/rte_bbdev.h > index 38d9d50..ecd95a8 100644 > --- a/lib/librte_bbdev/rte_bbdev.h > +++ b/lib/librte_bbdev/rte_bbdev.h > @@ -442,21 +442,21 @@ struct rte_bbdev_data { > * these fields, but should only write to the *_ops fields. > */ > struct __rte_cache_aligned rte_bbdev { > - /**< Enqueue encode function */ > + /** Enqueue encode function */ > rte_bbdev_enqueue_enc_ops_t enqueue_enc_ops; > - /**< Enqueue decode function */ > + /** Enqueue decode function */ > rte_bbdev_enqueue_dec_ops_t enqueue_dec_ops; > - /**< Dequeue encode function */ > + /** Dequeue encode function */ > rte_bbdev_dequeue_enc_ops_t dequeue_enc_ops; > - /**< Dequeue decode function */ > + /** Dequeue decode function */ > rte_bbdev_dequeue_dec_ops_t dequeue_dec_ops; > - /**< Enqueue encode function */ > + /** Enqueue encode function */ > rte_bbdev_enqueue_enc_ops_t enqueue_ldpc_enc_ops; > - /**< Enqueue decode function */ > + /** Enqueue decode function */ > rte_bbdev_enqueue_dec_ops_t enqueue_ldpc_dec_ops; > - /**< Dequeue encode function */ > + /** Dequeue encode function */ > rte_bbdev_dequeue_enc_ops_t dequeue_ldpc_enc_ops; > - /**< Dequeue decode function */ > + /** Dequeue decode function */ > rte_bbdev_dequeue_dec_ops_t dequeue_ldpc_dec_ops; > const struct rte_bbdev_ops *dev_ops; /**< Functions exported by PMD > */ > struct rte_bbdev_data *data; /**< Pointer to device data */ > diff --git a/lib/librte_bbdev/rte_bbdev_op.h b/lib/librte_bbdev/rte_bbdev= _op.h > index 9c66721..f726d73 100644 > --- a/lib/librte_bbdev/rte_bbdev_op.h > +++ b/lib/librte_bbdev/rte_bbdev_op.h > @@ -398,12 +398,12 @@ struct rte_bbdev_op_turbo_dec { > */ > uint8_t num_maps; >=20 > - /**< [0 - TB : 1 - CB] */ > + /** [0 - TB : 1 - CB] */ > uint8_t code_block_mode; > union { > - /**< Struct which stores Code Block specific parameters */ > + /** Struct which stores Code Block specific parameters */ > struct rte_bbdev_op_dec_turbo_cb_params cb_params; > - /**< Struct which stores Transport Block specific parameters */ > + /** Struct which stores Transport Block specific parameters */ > struct rte_bbdev_op_dec_turbo_tb_params tb_params; > }; > }; > @@ -554,7 +554,7 @@ struct rte_bbdev_op_enc_turbo_tb_params { > * the Turbo operation when r >=3D C-, [K:3*Kpi] > */ > uint16_t ncb_pos; > - /**< The index of the first CB in the inbound mbuf data, default is 0 *= / > + /** The index of the first CB in the inbound mbuf data, default is 0 */ > uint8_t r; > }; >=20 > @@ -751,11 +751,11 @@ enum { >=20 > /** Structure specifying a single encode operation */ > struct rte_bbdev_enc_op { > - /**< Status of operation that was performed */ > + /** Status of operation that was performed */ > int status; > - /**< Mempool which op instance is in */ > + /** Mempool which op instance is in */ > struct rte_mempool *mempool; > - /**< Opaque pointer for user data */ > + /** Opaque pointer for user data */ > void *opaque_data; > union { > /** Contains turbo decoder specific parameters */ > @@ -792,7 +792,7 @@ struct rte_bbdev_op_cap { > } cap; /**< Operation-type specific capabilities */ > }; >=20 > -/**< @internal Private data structure stored with operation pool. */ > +/** @internal Private data structure stored with operation pool. */ > struct rte_bbdev_op_pool_private { > enum rte_bbdev_op_type type; /**< Type of operations in a pool */ > }; > diff --git a/lib/librte_bbdev/rte_bbdev_pmd.h > b/lib/librte_bbdev/rte_bbdev_pmd.h > index 24ddcee..237e336 100644 > --- a/lib/librte_bbdev/rte_bbdev_pmd.h > +++ b/lib/librte_bbdev/rte_bbdev_pmd.h > @@ -146,18 +146,18 @@ typedef int (*rte_bbdev_queue_intr_disable_t)(struc= t > rte_bbdev *dev, > * fields are for non-vital operations > */ > struct rte_bbdev_ops { > - /**< Allocate and configure device memory. Optional. */ > + /** Allocate and configure device memory. Optional. */ > rte_bbdev_setup_queues_t setup_queues; > - /**< Configure interrupts. Optional. */ > + /** Configure interrupts. Optional. */ > rte_bbdev_intr_enable_t intr_enable; > - /**< Start device. Optional. */ > + /** Start device. Optional. */ > rte_bbdev_start_t start; > - /**< Stop device. Optional. */ > + /** Stop device. Optional. */ > rte_bbdev_stop_t stop; > - /**< Close device. Optional. */ > + /** Close device. Optional. */ > rte_bbdev_close_t close; >=20 > - /**< Get device info. Required. */ > + /** Get device info. Required. */ > rte_bbdev_info_get_t info_get; > /** Get device statistics. Optional. */ > rte_bbdev_stats_get_t stats_get; > @@ -170,7 +170,7 @@ struct rte_bbdev_ops { > rte_bbdev_queue_release_t queue_release; > /** Start a queue. Optional. */ > rte_bbdev_queue_start_t queue_start; > - /**< Stop a queue pair. Optional. */ > + /** Stop a queue pair. Optional. */ > rte_bbdev_queue_stop_t queue_stop; >=20 > /** Enable queue interrupt. Optional */ > -- > 1.8.3.1