From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C341AA00C2; Wed, 22 Apr 2020 11:43:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D43FE1D509; Wed, 22 Apr 2020 11:43:31 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00062.outbound.protection.outlook.com [40.107.0.62]) by dpdk.org (Postfix) with ESMTP id 39BC91D453 for ; Wed, 22 Apr 2020 11:43:30 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IOtIhJbrQ+o0ml5mClkT7VdGqfnp0wPjN2qlvhBRNF5W9gJrRElg03+hIPuCX0Je1K2JWuzdP52R/ddmpLsTgnE4s9zCuetaFClBS+paHAaHUv8AuBG14H1TkZsIPpcnJCX48KySr84V+A/weTrU25ZcpdibYqBBQmyRZ9woRsACIy5Jb638PggDq4cTzpZaEfZC1rnOz0o7Vz8Fv6ep5fbu5CtYeH6XCMBYfEG5HLRjhBTNIdeJ4VqNi/Ghm/5w107v/+1fx5uJFyURCnCy7jLfcxfZALCAibf0Xi0CBEhY8PLeAoX+QaNw+dAtocVYX6Wc7ekrCfmfrasmN1Jb/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J2FkNZBn88ASIkZFYwaNITENVinOpUlW4PSP8iOGKqM=; b=mqezVY+1hKAEbDuYpkNejco14BKFaoi7G4KSvAfSBzr0l6hamsKI+L2mVqbU1M/bo/ZDgaLi9jYeAM3Chg3I4z4hlmgcgFpuRed0pNgbpZe+csvNvqTL9y/+NSi7ZgicfZw3UecWCwPavFcYN7pXM6TM3J+gL8cLOPehv/0hRbPrYD64hNQi53oLp/3AX/qTmJuOPQ7AacZQr5fyqEtSYfs30SlioXd+pWCL+k3RGaZ6jRF78NHOaO37mLgBiu09hENO3OQ7Yuqc0ScHBqrzweiy545PoIGfHLlaI3jbdeW5EMb7yPsN1fM50SJf5IIZx+naX3t6LcPeHTCFFLsBCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J2FkNZBn88ASIkZFYwaNITENVinOpUlW4PSP8iOGKqM=; b=hDYsRKPCjlvT15n14ksFjNf/uOoyqhpegoavPXTEPBJk8oFOglEMosxojLuBSfgk1pkXFgxD8GnYBV+klvg4lS+JGnMxye2eTaTAHEeIqLbfyZfkAO9dbaETK+QPXEiEAkPHhOnUbD0+JfAveg06i0qeQEdfY6/Vy9XY7R3999M= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB5373.eurprd04.prod.outlook.com (2603:10a6:803:da::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Wed, 22 Apr 2020 09:43:29 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74%7]) with mapi id 15.20.2921.030; Wed, 22 Apr 2020 09:43:29 +0000 From: Akhil Goyal To: Thomas Monjalon , "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "Doherty, Declan" , "Zhang, Roy Fan" Thread-Topic: [dpdk-dev] [PATCH 2/2] test/crypto: do not check for IMB_VERSION_NUM Thread-Index: AQHWEkao++x4PTOASkGaCyiidaqUx6h4a+2AgAByAgCAAAdfgIAMA3wAgAAENtA= Date: Wed, 22 Apr 2020 09:43:29 +0000 Message-ID: References: <1586859760-207446-1-git-send-email-pablo.de.lara.guarch@intel.com> <3924051.KRxA6XjA2N@thomas> <9564647.0AQdONaE2F@thomas> In-Reply-To: <9564647.0AQdONaE2F@thomas> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [45.118.167.83] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f143cfaf-7c56-4524-46df-08d7e6a19ced x-ms-traffictypediagnostic: VI1PR04MB5373: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 03818C953D x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(366004)(136003)(39860400002)(346002)(376002)(55016002)(33656002)(8676002)(8936002)(2906002)(81156014)(478600001)(316002)(110136005)(5660300002)(54906003)(66446008)(86362001)(64756008)(9686003)(66946007)(66556008)(186003)(52536014)(7696005)(76116006)(4326008)(44832011)(71200400001)(26005)(6506007)(66476007); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Z6//mLeu7o95UDKEaZ10csBrJjkg66mcxEWj0lApW8hZB3kL+EGmyzBNmiwFuadFkZqPhoGE2vkbcJeqIwKBA1nILV+MiJ1yBZt9tKKE/K8P3miQuAqi9pzbawUdVkq2D72QEtLEgQ2F1DEmMGWJgnfel6SjmRLjVAz5F6Z1u/Jf0zmRDAH7tcynyUN8vJKTk10XZHl5nIu0aOOu7gTb/o3J8BSrX1GnYNBqji+02j2mSuRhheJnal3FYxsxt6kNY0kYZqtr3LOGPJ6BfTRMCN7lOhzDz6vdekKcqhBA+XD/igucHmvQHRDmhGdJGmuh9ARsi9+8q1BRmxHvKPNGFgMo/mMwf5Lq71jnN0O9TcqUJpRY+R0BNltwHQ+8b2aVwMTqh+iHQ7If5+IbT3337o2NZbhjXE4KSW1Nooj36hZs+CcC32B8nCfc9SvGTKuN x-ms-exchange-antispam-messagedata: azx4VB1tyOI3mqvSM1pIUeWcM7riD1yT5LIzAluiC7L22G70AD4jIGLE+BRnWpV2x2D3LbbopjgG5CbAWYH3vedKSSFoiq29noFK421haPSELgo3WCSYegrDDup/wTMfVNtjp8AV89MpsQHEPQZWYg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f143cfaf-7c56-4524-46df-08d7e6a19ced X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2020 09:43:29.1904 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2iRkn5vZCUYn93yaPkw8vDAbPbUq0EIIIz7TKOHYvBmzQnSiDDorKnPgBve/mMMam4zLwaWnFLd5qHW1i5MKlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5373 Subject: Re: [dpdk-dev] [PATCH 2/2] test/crypto: do not check for IMB_VERSION_NUM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, > 14/04/2020 19:48, Thomas Monjalon: > > 14/04/2020 19:22, De Lara Guarch, Pablo: > > > From: Thomas Monjalon > > > > 14/04/2020 12:22, Pablo de Lara: > > > > > Now that capabilities are checked to see if an algorithm is suppo= rted > > > > > by a device, there is no need to check for a specific version of = a > > > > > library used in a PMD. > > > > > > > > Yes, and even no need to check the PMD at all. > > > > All *_TEST_TARGET_PMD_* constants should be removed. > > > > > > > > > > I am currently working on this. However, I would like to split this e= ffort > > > into multiple patchsets. A first one addressing the problem of needin= g to > check for > > > specific information from PMDs (such as IMB_VERSION_NUM), which shoul= d > not > > > have any effect on the number of test cases ran for each PMD, and ano= ther > one which > > > addresses your comment, and that will enable test cases for all PMDs. > > > This last patchset will require testing from all PMD maintainers and = it is a less > urgent > > > problem to resolve, so we can decide if we want to merge it in this r= elease or > wait > > > for more time in 20.08. > > > > Thanks for your efforts Pablo. > > If the basic is working, I am for removing *_TEST_TARGET_PMD_* in 20.05= , > > and allow PMD maintainers to validate the tests during -rc phases. >=20 > Some patches using capabilities are merged in the crypto test. >=20 > What else is remaining? I see rte_cryptodev_driver_id_get() is still used= . > I think rte_cryptodev_driver_id_get() should be deprecated. >=20 All of the cleanup cannot be done in one go. There are quite a few things w= hich need to be cleaned 1. many test cases are checking the PMD type for specific PMDs. That need t= o be removed. Currently it is done only for the block cipher cases. 2. many PMDs are maintaining their separate test suites. Which should be mo= ved to a single one 3. there are some PDCP specific cases which need to be moved to security te= st. For #1, we need to remove all calls to rte_cryptodev_driver_id_get and ever= y PMD should check If it has properly defined capabilities or not. I plan to do #2 and #3 for NXP platforms in a couple of week. May be befor= e RC2. I have asked all the PMD maintainers to move to a single testsuite otherwis= e their PMD changes will not Be picked. Regards, Akhil