From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C676A0523; Tue, 30 Jun 2020 20:33:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D48A32C2B; Tue, 30 Jun 2020 20:33:44 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20050.outbound.protection.outlook.com [40.107.2.50]) by dpdk.org (Postfix) with ESMTP id 5AE872AB for ; Tue, 30 Jun 2020 20:33:43 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KMdZ6GR5KKKjF7Emz0s/jez1fRBBAfQLZJLkjBVkhH5pXHz6z5v4gcxpLfdHmrC1zuEcwBF4P/X6jzxMUsodCrFh4MJbZUBPadE4tTqPFDXyIO1dfJnzwTNCFP/tUy/HSOD+3k79IdJ0MgHfcGlQwEAWMfU4GKOB70teZRh0eJmS1OBz261z+ZHI4w7CAfdO2X3V+BFY5kcQLLYrMA9rmdDgWFoTfNEdUupefTQPUzOJjlJJRKigwt/lyYGtMtwBx7MqseTX8qsngPfcOzocjZKwrebMo0jYnKMsb/zk3YW0WP/2uBK1dRhiO3O8/eqYEVB3ci+rAwsGZ8A/SmoQwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c5mUTRwNizeeZ10YZmjTpAOCf7gNKfpPLZ+DExCxhg0=; b=dx2RxVP9IJxMn7rfsEDRC8pkACMrF3lGdFxMh/BebeGOlzKIc+q8n9/BmpTsJhMyIM3k6ZmPyGU2v8AeJ/Gipi7doCm674sUzL9TGg7F3+KQnYWxRk79wtfK6I13LESxBJ3CjXFungIrP/Te0gYrlKB5P9jYzzCf7CV9knWBPX7Y/7XHMGYF8W2wN1IIUmZmO+HJbxWpRuju5IkexRolV0sGlAzpTDVfIkLaLSTUdjRjNduQ541V5X5rIJZDKPAaL4Fqz2OD+VXtQ2s6sKJDdlFfmOtQl88h0pJONmyiJ92wDnHiq2T9W2PfaSFtu6rTMl1geRPwmsptah2wchuoXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c5mUTRwNizeeZ10YZmjTpAOCf7gNKfpPLZ+DExCxhg0=; b=Lou97cCk83zX1PKRLZ1I/eN1Z9I9xpopoUfMdv7K/9OsOl0CiBVRZvpsgfsc/6k4GDRhZprkhjJ/AFHsitX59SeBjhr7+Z36kgF2HFIE8m66SRPFIUOkk85Zr8dciBG02dF6aX9joyw7r1aX0PF0RWYmawWxs2QtqaBqxXUj+jE= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB6974.eurprd04.prod.outlook.com (2603:10a6:803:133::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Tue, 30 Jun 2020 18:33:41 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::b077:1fe4:d352:b464]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::b077:1fe4:d352:b464%7]) with mapi id 15.20.3131.028; Tue, 30 Jun 2020 18:33:41 +0000 From: Akhil Goyal To: David Coyle , "declan.doherty@intel.com" , "pablo.de.lara.guarch@intel.com" , "fiona.trahe@intel.com" , "roy.fan.zhang@intel.com" , "konstantin.ananyev@intel.com" CC: "dev@dpdk.org" , "thomas@monjalon.net" , "ferruh.yigit@intel.com" , "brendan.ryan@intel.com" , Hemant Agrawal , "anoobj@marvell.com" , "ruifeng.wang@arm.com" , "lironh@marvell.com" , "rnagadheeraj@marvell.com" , "jsrikanth@marvell.com" , Gagandeep Singh , "jianjay.zhou@huawei.com" , "ravi1.kumar@amd.com" , "bruce.richardson@intel.com" , "olivier.matz@6wind.com" , "honnappa.nagarahalli@arm.com" , "stephen@networkplumber.org" , "alexr@mellanox.com" , "jerinj@marvell.com" , Mairtin o Loingsigh Thread-Topic: [PATCH v3 8/8] doc: add doc updates for DOCSIS security protocol Thread-Index: AQHWTv8OsCFh3a59Y02BiE5pMuOdZajxcszQ Date: Tue, 30 Jun 2020 18:33:41 +0000 Message-ID: References: <20200623101423.9215-1-david.coyle@intel.com> <20200630163049.61900-1-david.coyle@intel.com> <20200630163049.61900-9-david.coyle@intel.com> In-Reply-To: <20200630163049.61900-9-david.coyle@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.118.167.87] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 73d70e5d-9a30-40b7-399b-08d81d241d2f x-ms-traffictypediagnostic: VI1PR04MB6974: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0450A714CB x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QSBNerXjwQ8JyoA0uuLWfZWpLqeSuBecX7ibXUZKHYI5G0X4ziDXFfy/g/Sf5Dw8IWe2oA8x0Wa4UBL/N1dZ3IMGA+yxS/8Dh3UweNpqHcB+IvrjM5V8OkDA+8Q5n4BAOdViwZmrXMWQetxo7hCvXauTMUSI/Wt/0b4tYYQwjuwpceUlrSF92tkfDkr6+LvEhBmsjdK55lnrUUDvEwvJGz8LQQmFfUFGPQ/d+XePHE+r0thDZS222ocIw/3h9RaHZ6TEdmzNKldWuh/eX8xiukXycK5XAkg7L4v5RlnKCabohG9m2MDsRLv0qUJZZeUB x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(39860400002)(366004)(396003)(376002)(346002)(86362001)(6506007)(71200400001)(5660300002)(83380400001)(64756008)(66556008)(66476007)(66946007)(66446008)(76116006)(9686003)(55016002)(52536014)(316002)(54906003)(4326008)(478600001)(110136005)(8676002)(8936002)(2906002)(44832011)(26005)(7696005)(15650500001)(186003)(7416002)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: jv7fl740DZL32RGMaGrDfVvmv8YsiHh5rEEiHyPD8idqAs48rMRa870uFck0dJLjjNlLmdAgLXNuAZ6KzOA0N1vUkBJTQhPyhKQy/ps5arzLstSv9WI0jtwacT936pfSZTyULtZgIRX/twfZJEZBNIG3tuIZ82Jk2/RQjDbqfeKcjBC8MxMGVDCtxTpIYx+8MDknZfHYDT5vbhKk/t3APjX7CVOedq8PepPTLo8+zSnMcyGTunM0mo5G4+wZ1562usadDe3oUo+a3CYnZJWPTP9dHKZ9yjMKXZkaF95gLs/ei2A8mI5ZVidDD618/UMaXXfuY2zU8rqqydXCLZhPVhTidgW7gTFst72G6ToAvqLz6vYAzhcXY21m8lBpgAfPl8Ckp2WPpmXfN9WuU/aqH8QfMfukc7KnFosiSDRLe/bBnFnh+iiiOWvYXglU59rBTujLwimOFkKonfqLQDU8PdqNZUL0p+Maw+uLooeXf9dVYEWd2WxxujFlXOk3wg55 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73d70e5d-9a30-40b7-399b-08d81d241d2f X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2020 18:33:41.7388 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QILsP+jdpRaEvogLwwT4+huAhPnY5C0gAUH/AxLKoBhfOHLyJbtGY7WiLnZtzoaYozCJ0xWcHliszq062fsa1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6974 Subject: Re: [dpdk-dev] [PATCH v3 8/8] doc: add doc updates for DOCSIS security protocol X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi David, > Subject: [PATCH v3 8/8] doc: add doc updates for DOCSIS security protocol >=20 > Update Security library, AESNI-MB crypto PMD, QAT crypto PMD, > dpdk-test-crypto-perf tool and release note documentation for DOCSIS > protocol support. >=20 > Signed-off-by: David Coyle > Signed-off-by: Mairtin o Loingsigh Overall the patches looks good. However, I will do a detailed review soon. > --- > doc/guides/cryptodevs/aesni_mb.rst | 8 ++ > doc/guides/cryptodevs/features/aesni_mb.ini | 1 + > doc/guides/cryptodevs/features/qat.ini | 1 + > doc/guides/cryptodevs/qat.rst | 7 ++ > doc/guides/prog_guide/rte_security.rst | 114 +++++++++++++++++++- > doc/guides/rel_notes/release_20_08.rst | 16 +++ > doc/guides/tools/cryptoperf.rst | 5 + > 7 files changed, 150 insertions(+), 2 deletions(-) This patch should be split and merged to relevant other patches in the seri= es. rte_security related in 1/8 Like aesni-mb related changes should go in 3/8 qat related should be part of 4/8 crypto-perf should be part of 7/8 And release notes should also be split into 3 different entries and squashe= d into Rte_security, qat and aesni-mb patches. > +The encryption/decryption is a combination of CBC and CFB modes using ei= ther > AES > +or DES algorithms as specified in the DOCSIS Security Specification (fro= m DPDK > +lib_rtecryptodev perspective, these are RTE_CRYPTO_CIPHER_AES_DOCSISBPI > and > +RTE_CRYPTO_CIPHER_DES_DOCSISBPI). > + > +The CRC is Ethernet CRC-32 as specified in Ethernet/[ISO/IEC 8802-3]. > + > +.. note:: > + > + * The CRC offset and length are specified via the auth offset and > + length fields of the rte_crypto_sym_op. The above note is not correct. It should be * The offset and length of data for which CRC need to be computed are speci= fied via the auth offset and length fields of the rte_crypto_sym_op. > + * Other DOCSIS protocol functionality such as Header Checksum (HCS) > + calculation may be added in the future. > + > Device Features and Capabilities > --------------------------------- >=20 > diff --git a/doc/guides/rel_notes/release_20_08.rst > b/doc/guides/rel_notes/release_20_08.rst > index 39064afbe..0e72a26b1 100644 > --- a/doc/guides/rel_notes/release_20_08.rst > +++ b/doc/guides/rel_notes/release_20_08.rst > @@ -56,6 +56,22 @@ New Features > Also, make sure to start the actual text at the margin. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > +* **Added support for DOCSIS protocol to rte_security.** > + > + Added support for combined crypto and CRC operations for the DOCSIS > protocol > + to ``rte_security``. Test and test-crypto-perf applications have been = updated > + for unit testing. Split this release note entry into two, 1 for 1/8 and one for 7/8 > + > +* **Updated the AESNI MB crypto PMD.** > + > + Added support for lookaside protocol offload for DOCSIS through the > + ``rte_security`` API. > + > +* **Updated the QuickAssist Technology (QAT) Crypto PMD.** > + > + Added support for lookaside protocol offload for DOCSIS through the > + ``rte_security`` API. > + >=20