From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9178CA0093; Thu, 21 May 2020 14:46:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CB9E21D6AC; Thu, 21 May 2020 14:46:19 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140044.outbound.protection.outlook.com [40.107.14.44]) by dpdk.org (Postfix) with ESMTP id DCCCD1D69C; Thu, 21 May 2020 14:46:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lbi4lQds4DFjkOPYSNykDeJ23/IMFyFf3LXGyO4xbulg7/wGzHfPNaHa8R/3lhA4BlziF0yvauNK/oCnbCX97GmEZbfQZ6tK+95zbateH3F8mpwWKr2fKKcQWhj5xc26CR+6J0zrkX+QFzziO1hO4XQ72J9uyNDROj7pRvcDjrBHZlldVo/p+D4IdotGtQ0MY0TZ6hrpTqGE7LjC9/MBz4D2MndGk7sMOKnV3a409SlXReVrzLq4wsb39J8ATRrD6g2Wfg2LH/+ocKD0JYPn8bnmU5inudkfMdBl4fe47yvE+1O1JqdUi0LceroTrWLAt69rTNmesYP3a/v9X5twoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jpVBYtPsBwMnHsXI6xMCXNoxo7gbAl1Iwpou7+109Eo=; b=IFuZHxRr3d+/0fBOfQ57Js8ES/OJt9cq+iWXmqL2jCjyw+5bp5+opTcv64knL42yMyxpTCvd8KNQLdeLcwuaAUFTMxWd4SmWOcj0YfyfOGVeGv1MivJl4VZ8EJJb+xfi3myhB0v3csY1rXKCdovH1hlCFrA0XmyDcihHqYdiMHbe16OBUFTaeQPB7g1CfyLocxFm+4Rk4TuhF5upPWgfFnjewDC3Qmyx0kTr8EqguB7lwvPDy3FAyPEEfGR5jjvePJvGqU8r2HdduJ6f0gdpmMKnalNLXq1y6APjvDba1TLUwbNdxc0FtILdG7JcIvXeSPMLO0FKJosAm51hguqDAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jpVBYtPsBwMnHsXI6xMCXNoxo7gbAl1Iwpou7+109Eo=; b=gUEybGrWPCeQm1YiBxErQnebP2cSofwikWpro8dflBcFocpwv8W1OJuIezfxUv6Vq4OWd4dB8o8LNSzhutRptJUEgH3Uw07ihjyx1bXpkpKWLJkfYPuEL4VZCH2itAnmNN18ncchlGRkK43Iv9jJBk9bsRk7sL1Ez6xNLNDUbtA= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB4829.eurprd04.prod.outlook.com (2603:10a6:803:5f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.25; Thu, 21 May 2020 12:46:18 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74%7]) with mapi id 15.20.3021.024; Thu, 21 May 2020 12:46:17 +0000 From: Akhil Goyal To: Adam Dybkowski , "dev@dpdk.org" , "fiona.trahe@intel.com" CC: "stable@dpdk.org" Thread-Topic: [PATCH v3 1/1] cryptodev: fix SHA-1 digest enum comment Thread-Index: AQHWL2RWyWWAocYtgkqZ4IjPkIB3sKiyeqow Date: Thu, 21 May 2020 12:46:17 +0000 Message-ID: References: <20200521113817.3148-1-adamx.dybkowski@intel.com> <20200521113817.3148-2-adamx.dybkowski@intel.com> In-Reply-To: <20200521113817.3148-2-adamx.dybkowski@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.118.167.93] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c99bee24-cbbf-47e1-1564-08d7fd84f4be x-ms-traffictypediagnostic: VI1PR04MB4829: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 041032FF37 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DN8mrDdrtNIEbEuul+hHeZ/icirrBuQsOkiD+jGMoZrwJoVwf5oeYsAflQIgQw04FKRhMdXDxoZDN9IaaUTbb/S+8H42GmmVwP2J/UCb3ZpGH2pslSGditm2vfKIBrP3gA3EI80oUxBdXprEdyZAZdXMIoMlBbiDro/GY0P1rWCz+LLePl+Y/IzWTSOZpMy31KGFWu71EJ3HEra8hCv4v6LLoghUhrLCbNDzBXWddtdwN0XZD1Xy0dTF4UoAoKRyIgQPoKJSdShxZM/vLV3cZZKeMd3IYrTPm0te2/mJvKSjaA/S7Q/Dr+KkWFxRSXaA9iXLRKrXI+u1+pFDUz5sOHZcQMuMjju8YCVJf+OPykuCdMNgaY4fnJau1Llga2R/nhls+GUc99uuaqjZVhkZ9v6Z+dTADukq+Jh1SqJgEqBAUaPIoBtyRHCz7gU/d8J7 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(136003)(366004)(346002)(396003)(39860400002)(66946007)(66476007)(33656002)(66556008)(2906002)(110136005)(4326008)(66446008)(9686003)(44832011)(76116006)(64756008)(86362001)(55016002)(8676002)(186003)(71200400001)(7696005)(316002)(52536014)(26005)(8936002)(53546011)(6506007)(478600001)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: +aAMIjA7yDRIfRDiDzFj4/QlsQWEL0JD0JUQzhm3yGnEop7o+hJGDvrDopjXseFDIWku9Us6SKH2EvaBWLno4xc1v87sqdJ3fnrkPnSJw9fJwRl+c5OfBPdFUovelkQvWSFMikgfoOLBpWVDeh+s6j8g7q61umMJon1CqR72uqNKpawK5SOwJrS7bOP1HTMEfp7dey/W6swM7ZCZv46amFhkHzTUALqRJsOv+D0SAfEBOWBDz2yuCtmPzxuz7Eibo0dXaCuHIBmuDVxbGpXyxTDX1L2utB9pKf9gDgdCfPruqgwR0SWCbW7npX/MqVfd9hG1m+BP7/9vFO7uEn1nle2sjIZUiYo/RLK/kz/Uw+gyq6LsR6V2pnUku3xqWHESSyS86z0nXhiIAhz/CLK+hIO00RwH/of+CY5FgjQuSPpbj6WT7rsll3mnBFy9N8sKWFWlKqxsWobojBLfceFFR3KGCqBnnSw/2cCiCx4d+HU= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c99bee24-cbbf-47e1-1564-08d7fd84f4be X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2020 12:46:17.7816 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4jx1o22/HQY0qqD2bf3Dtuhq6hSqiqlaW/vhkg0ysKKZgGqhzQxV7Xcbsnze8k2eugOIxCMHLD/xFFQCMywkPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4829 Subject: Re: [dpdk-dev] [PATCH v3 1/1] cryptodev: fix SHA-1 digest enum comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Adam Dybkowski > Sent: Thursday, May 21, 2020 5:08 PM > To: dev@dpdk.org; fiona.trahe@intel.com; Akhil Goyal > Cc: Adam Dybkowski ; stable@dpdk.org > Subject: [PATCH v3 1/1] cryptodev: fix SHA-1 digest enum comment >=20 > This patch fixes improper SHA-1 digest size in the enum comment > and also adds the note about HMAC-SHA-1-96. >=20 > Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") > Cc: stable@dpdk.org >=20 > Signed-off-by: Adam Dybkowski > --- > lib/librte_cryptodev/rte_crypto_sym.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/librte_cryptodev/rte_crypto_sym.h > b/lib/librte_cryptodev/rte_crypto_sym.h > index d9585ecd6..6fc3b8f59 100644 > --- a/lib/librte_cryptodev/rte_crypto_sym.h > +++ b/lib/librte_cryptodev/rte_crypto_sym.h > @@ -269,9 +269,11 @@ enum rte_crypto_auth_algorithm { > /**< HMAC using MD5 algorithm */ >=20 > RTE_CRYPTO_AUTH_SHA1, > - /**< 128 bit SHA algorithm. */ > + /**< 160 bit SHA algorithm. */ > RTE_CRYPTO_AUTH_SHA1_HMAC, > - /**< HMAC using 128 bit SHA algorithm. */ > + /**< HMAC using 160 bit SHA algorithm. > + * HMAC-SHA-1-96 can be generated by setting digest_size to 12. It should be 12 Bytes. And should specify where to set the digest size The name of the field in xform is digest_length and not digest_size. + /**< HMAC using 160 bit SHA algorithm. + * HMAC-SHA-1-96 can be generated by setting + * digest_length to 12 Bytes in auth/aead xforms. + */ > RTE_CRYPTO_AUTH_SHA224, > /**< 224 bit SHA algorithm. */ > RTE_CRYPTO_AUTH_SHA224_HMAC, > -- > 2.17.1