From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD2AFA034E; Thu, 23 Apr 2020 18:14:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A6701C229; Thu, 23 Apr 2020 18:14:22 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130044.outbound.protection.outlook.com [40.107.13.44]) by dpdk.org (Postfix) with ESMTP id E8B621C222; Thu, 23 Apr 2020 18:14:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NvO/4ekG5rtSnrCdZOnUvI0y3/7kEOgdxLVAIW6qd31dUcOVXyLemlMG2hAKaV9zEnXJOj8pXu5PVHTAqF6SRkLF1BJ4SxUcWz6Cgn6SOFFAYD7azAVXsEG2T6i3tgVIvXblqZhOyH3/0IGSPf6kSdckLNxIqBz6vkwtgHGJSzThFFEFedeIMRRofEzQV+YHRiaJa5/GS0RF7JM7vED8MzCWDvILrG0zUSEWsxgXrBU6I3qw83i1YFwO2hEOpA33xDLse3GhJaU5oxkCxVSzaEY/In9A8e6kUWN6oXU3AzTQtBRVeTtO/vjsBhJW1ZnLe3rMzwNkH0nbyeuTeCl1nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+ya/fkcpsmHFR+gKTDuugouFlWLZsDuMASSGlu88CCU=; b=FcMIRibj0roxSatmBM1LAx3lGNob/J2MUyS7h5DBqaekddxn/Tc2ZSVfUWRXiWd7uQcmVHFLqmjXtHWz5gJtDTphv6pJnRNwwV5avEhqGUfjuRS3/7UVmPLEb/O8yj+LLARZveBJBI2r2pCFM2co2DyFpmJ2Xrk4O31wZxacKuXzEWWSqiQF7VzeFkx2EzujkuSZzHQ+37g28usHIgu02rG5vtLJ2SZ25sV6cx38sf1S1AtRahOqcVJSzBo+5pPl1V3hmGMfFR0Bl3KKsKAsJXqEEZ48B1Nc2QXEbc/QN4GqtWXRxKDt2N5muIVMCbXMMHsTKB/8pUaDTfGhkmGRgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+ya/fkcpsmHFR+gKTDuugouFlWLZsDuMASSGlu88CCU=; b=RtBhP9kyFpHl/m1crQT40fzuo2fxnrMNr8eqzLkckJXpm6rwJeyRqMj75n/QvpB1v4XZU3/IBfY1ZSza8U74V/Lcj5McMF3QKTqaDn/ejri3m0JB0+e+xn7lhsb2AVR1jHSV2E+JYiVB/BK2C3Q2biZfVHsInWYhHiraff7bfvI= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB5710.eurprd04.prod.outlook.com (2603:10a6:803:df::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Thu, 23 Apr 2020 16:14:19 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74%7]) with mapi id 15.20.2921.030; Thu, 23 Apr 2020 16:14:19 +0000 From: Akhil Goyal <akhil.goyal@nxp.com> To: Anoob Joseph <anoobj@marvell.com>, Konstantin Ananyev <konstantin.ananyev@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "declan.doherty@intel.com" <declan.doherty@intel.com>, "stable@dpdk.org" <stable@dpdk.org> Thread-Topic: [PATCH v2] security: fix crash at accessing non-implemented ops Thread-Index: AQHWGYFihzeIWohV/0qr/a4kt+bwsqiG2uDggAAE4QCAAAEfsA== Date: Thu, 23 Apr 2020 16:14:19 +0000 Message-ID: <VI1PR04MB3168EAF44C806D670D995070E6D30@VI1PR04MB3168.eurprd04.prod.outlook.com> References: <20200422235158.24497-1-konstantin.ananyev@intel.com> <20200423151042.4650-1-konstantin.ananyev@intel.com> <VI1PR04MB31682AE581995C9CF8FDA80CE6D30@VI1PR04MB3168.eurprd04.prod.outlook.com> <MN2PR18MB28773439B71C687D4D966EB2DFD30@MN2PR18MB2877.namprd18.prod.outlook.com> In-Reply-To: <MN2PR18MB28773439B71C687D4D966EB2DFD30@MN2PR18MB2877.namprd18.prod.outlook.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [45.118.167.83] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 53aa0080-3a18-492f-5b5e-08d7e7a160cc x-ms-traffictypediagnostic: VI1PR04MB5710: x-microsoft-antispam-prvs: <VI1PR04MB5710464FD04F0ABD9877E91AE6D30@VI1PR04MB5710.eurprd04.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 03827AF76E x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(346002)(396003)(136003)(366004)(376002)(39860400002)(71200400001)(44832011)(9686003)(4744005)(86362001)(66556008)(66446008)(66946007)(76116006)(64756008)(8936002)(81156014)(66476007)(8676002)(316002)(54906003)(110136005)(6506007)(2906002)(52536014)(478600001)(26005)(33656002)(5660300002)(7696005)(55016002)(186003)(4326008); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qMHvn7aQGb0BvDWXaq11XkpzBGZ677S1rl4RAV7WPHaFhtDNzgCEcSXcCmG0lv8UuxHrMKgIO2Dz10f9AREU2S35K628QR3Rp8mEgN//CJ/zU/xpxwjNJrgKVZbzfBP9q3J39G7dkX1v1b4yANibK7T5RKG3Mp5+nJ2xYU+rTM9zrzLNAkztnHmLKybxtjwqHxTcrXY7M9VZgeUoKOwNSVisFJByEkwqPhnCSAQQj7jF1+K/VNI95IqXJufi7G2lrqYW2IbbuFWL1DSNoJTc8sgohxMOGZaolcotA0M2sWXE11L9iNtHssmjRBkqeOAww8FMY1ib165yP8bjgrbTm4lKuX3RIEBz7SzjO1EETR4SJUJebCXVBl4WtvqGrvRWdHhb0tEDKe9YsGTBLtB1d5Qa+o8oVZIPz5ywpYmTTd8Op39kb6TfjnfiilQVG3P2 x-ms-exchange-antispam-messagedata: RIG0c87tLhwour3SgGiX+lG3kDS9qdIq60Fn6RHg6OjWL++47/xB7+U0GnFbWLORnF9/y50RPHWx2NvfgZgSwh/CPCnTCdsNsF5AuHZgh/U9QLa03JbTdqxbSRO9bkb/xUeAZg+Jxsu2OM6n5bEmww== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53aa0080-3a18-492f-5b5e-08d7e7a160cc X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2020 16:14:19.4611 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eKw9zpU+xu3qV9GCV1cql8AaL2So65iF+xTfBDEeRhuD7DD14N0p15VeUqNaECW5SAMtSrCRoGHfbl6HTBtCWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5710 Subject: Re: [dpdk-dev] [PATCH v2] security: fix crash at accessing non-implemented ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi Anoob, >=20 > Hi Akhil, >=20 > I have my concerns over unwanted checks in the datapath. Something that > crypto enqueue/dequeue APIs are not doing is being enforced on other APIs= . As > Konstantin had suggested, PMDs (IXGBE here) could define a function which > returns -ENOTSUP and it would have been win-win for everyone. >=20 > Anyway, I don't have any objections to this. >=20 Your concerns are valid and those can be handled separately. We will apply this patch.