From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95C46A0521; Tue, 3 Nov 2020 17:53:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E3956493D; Tue, 3 Nov 2020 17:53:11 +0100 (CET) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10084.outbound.protection.outlook.com [40.107.1.84]) by dpdk.org (Postfix) with ESMTP id 3DA132DCC for ; Tue, 3 Nov 2020 17:53:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YIZdVywv31NzDJcbiFlllZ/RfFUR0zcBN8bzyzridbRAVRU3GB9rKeXA7Gw5IwUZvCm9EovVXaJ0D+2U61QDYmGlR+oTUWFFH7eZ7LF852hOQGDul1FOTmPgNTGY0I96tJX4OCzuWqt9YjZU52xVvXA/b1GHR+WCW9PZIZB05HRmgdrtyTNZ7PmTUBYq3JSeMaj5skp/X2AzacRkQAasmxQufxIbin/bH1onggystJULCYtQecqUKsuDFHYIHcTZyiNIsHsNYwdU/b1plQAj3n2OEMzHWQeSYkLwCNbNbznBGcz04TwOxJOzwBX2qjFfOybRwnplh2qpNbwdDRfxOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6wUO/g3LDHkpTdsMaVZOryMhoVm0d39OdzL6oMaRMQY=; b=HmpudB5qfbEZcEud4z0tLBUjtri6mmAJHvdvmch4yXoBsoH/jhBGhrgDHD+wFmB0k/h6A3xdvBb2Iz9WXfEbeADhXVTd2sZ0KY4VZt45X3g7OUPAxLjcJmNdfZFjmgjKP4YKtetC8IstZpwalsMf+1BsjgonWymnZv98zD4s+9uTfzBOs//+Kr5sQvMfdjH1jSpwGjgKYTyLUKEbptt96oE9AnXt9p4nZKqwTVJxgv+cXX+LbMnZJ5vuX5WJKbjHmpHCwQeMq/sSiVu2ixaMCyxILRVboQXzTfr9ikuWsZ+CTIIZP20RGN7Eu+PNz0dw99F6I5Q78Imye/7uPVhiLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6wUO/g3LDHkpTdsMaVZOryMhoVm0d39OdzL6oMaRMQY=; b=NY5Fd2b0SMpmvO3WfKjftmuOZ3rD/ZYKxSBNAdOsM4yLCL46wwZmOPthCD1aGGAkrTRI3JfhZmbAaMOuWL0xj3hsiWio4/TkVnUhM9pfEGezcIYgCFVuInAM0yIgWC1bwaWsqhF3y5nRA2jVy8d6IKBc3emmOeOADHXE6cLZvnw= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB4207.eurprd04.prod.outlook.com (2603:10a6:803:3d::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Tue, 3 Nov 2020 16:53:06 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e%4]) with mapi id 15.20.3499.032; Tue, 3 Nov 2020 16:53:06 +0000 From: Akhil Goyal To: "Gujjar, Abhinandan S" , Thomas Monjalon CC: "dev@dpdk.org" , "Doherty, Declan" , "Honnappa.Nagarahalli@arm.com" , "Ananyev, Konstantin" , Hemant Agrawal , "Vangati, Narender" , "jerinj@marvell.com" , "Mcnamara, John" , "david.marchand@redhat.com" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions Thread-Index: AQHWrpUd/M0tQ0WGjES5pYkR0+gFBqmwdpQAgAADXgCABCBsgIAAm5/wgAC3aICAAAeRwIAAGEgAgACLe4CAAAliAIAAA1xA Date: Tue, 3 Nov 2020 16:53:06 +0000 Message-ID: References: <1603926611-19086-1-git-send-email-abhinandan.gujjar@intel.com> <1882047.WhnCstt3cK@thomas> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [171.50.183.179] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5408c1cd-f065-443b-5578-08d88018efcf x-ms-traffictypediagnostic: VI1PR04MB4207: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fxWLBE6cNOLaXHU9lIM1zBrHM0ZDophzS3jF90XEOJce9XuAGYWJoidSLyxHdSRSOQd+c705+2XlbzK0R8w2O38xPiuXLbW8YDbS9E6bX7XZXvrjjsgpX9K9JL9wk7biylK8Lw/JECNZ8sOJOiUqHY4KTf0InIw6rsQwPuTL4Nq4djLEdJroQRn3csl6jRormzezclKUDX1s/BBhIndzu/J1xiZ0ctv0iQTzifN+DH1dv3EJryWSRN7nb2myyNqzxIAvwSgwl2/CBoslORfBRZMVf3HnpVwfvcauA8iy2wo5DOVugbEOk1zfywwc0uo0CFawlX4cwdyYWesnTHvvsQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(346002)(366004)(39850400004)(136003)(71200400001)(6506007)(55016002)(8936002)(9686003)(52536014)(76116006)(2906002)(33656002)(478600001)(86362001)(26005)(4326008)(83380400001)(5660300002)(66946007)(8676002)(54906003)(7416002)(44832011)(64756008)(66446008)(316002)(66556008)(66476007)(186003)(7696005)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: LN7GjtIrndAbdEI55YDy5JbB50qZWyoxvImgn8kDpefmkGbzK6NE8Sv9SKYt58AN1jqloucjNvdo72YKT9h3qO/XGJAAPT1vNTam45+DmsUcgeT2KrmgS2plYPT62X+B3+McMAdlDvib/aw1K1estjacre9GmJnP/DBS1lAl0He0yH6bvYkT0qmQ4EjvGc6O8LemzFtKK+MCG9BxDr7PtgdTl6vdBO9wnW9VQb4S1x5lU8VVi4SswGUAEvJtj7zjTBoukv7J5WdpcWaETwnSKTJULzJeYi9hSyKQ6G2O5IyEAcQcScfk+plCJrjegN7UsmFkeyDyI8DAyBMwM/HdsoGQhRtChzsSV+Y7hKSkKDJJsunYD5BateYGdt0xOWBjHjS2rnokJeEcWzBFhiBxSs/jJ1U3ncVARtROknAd6XcGRp3yRJD1TO/199OPYBG/S3xlXpk2nhPYspEMHDeLGMQpCPRU5zMbvfq06rYMO8WnDIIu2g+rCUYxbHbf9t46kfNInbUPi2CkDEOaym/SSzv9FVU8fjgoe37VdShEJAwnKV8XyU74iyxH3vsiZ2mg1ym9vIV65hoE8WPE6kWkUS9QHnURKEk7LL7jZOtVJmthSHr9hm0aAAPt+VhhgqwD4UsXsh9nCCxtsziMJgjxog== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5408c1cd-f065-443b-5578-08d88018efcf X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2020 16:53:06.2928 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EmGpdwHCrFJaE5nEPY7Q9N9rMtncnDcA4uzikftYsmTA1PJyT8qCq/ojSFdBJv7jpD/Lv00bMkh6n71OPBPiTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4207 Subject: Re: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Abhinandan, >=20 > Hi Thomas, >=20 > > > > 03/11/2020 08:44, Gujjar, Abhinandan S: > > > From: Akhil Goyal > > > > As I suggested 2 times that there are documentation issues. Haven't > > > > seen a version To fix that. Please check it at your end and try > > > > fixing the timing of your system so that CI Can pick it for compila= tion. > > > > > > As far as I remember, I have pulled in all the comments from you for = the > > previous patch. > > > > > > > > > I understand that we work in same time zone, getting feedback fro= m > > > > > you in the mid night will not help me/you to pull this patch in. > > > > > A quick response will enable me to prepare patch set quickly and > > > > > send it > > > > across. > > > > > > > > I am not dedicatedly working on your patchset. I will work as per m= y > > priorities. > > > > > > It is same for me. End of the day, we have mutually agreed to get thi= s > feature > > in. > > > > > > > Had it been a CI pass for compilation for both documentation and > > > > code, it would have been applied last night. I could remove those > > > > extra spaces, but there are other issues also as the newly added > > > > APIs are not visible in html files generated. Please ensure that > > > > there are no issues in doxygen build issues and should be able to s= ee the > > newly added APIs in html guides. > > > > > > This is the kind of information I was looking for, which was not > > > available in your previous patch. If this info had been available qui= ckly, I > > would have prepared next patchset. > > > > It seems you didn't do all the checks you are required to do. > > Please be kind with Akhil who is working hard for the community. > > If you want to accelerate the process, help by reviewing other patches. > > > I have done enough follow ups with Akhil and we both agreed to get this i= nto > RC2. > I did not realize that CI did not pick up the patches because of mismatch= with my > system time. > All I am saying is giving this information would have helped me. I highlighted the documentation issue and the system timing on Friday itsel= f. When the fix was not there on Monday, I tried to fix on my side which took = me late To comment back. Had it been done by CI, it would have been faster. >=20 > > > Anyway, I will post the next patch set. > > > > This is too late. > > We are not supposed to add new API in -rc2, and for sure not after -rc2 > > deadline. > > > > > > > > > > And please note, do not top post your comments. It becomes difficul= t > > > > to read it in Archives. > > > > > > Ok > > > > Yes please do not top post, use --in-reply-to to gather all versions in= the same > > thread, and fix the clock of your machine. > Ok > > > >