From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE0E0A0526; Wed, 8 Jul 2020 16:05:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ABD291DB08; Wed, 8 Jul 2020 16:05:25 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2084.outbound.protection.outlook.com [40.107.20.84]) by dpdk.org (Postfix) with ESMTP id 054801D5F9 for ; Wed, 8 Jul 2020 16:05:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C2eX1MSQsSDDsd9Ej7OaaE42BhVv16oiAx1lu2a3sh2qoXzzPxFHFzE0dVFpFTgjPJwGIc9q4xP4LnuW6e6qF52Jptje2iJIxSP7fyZqtQ2Dazn2evFql1GQD7o+oKH/nk1i2SJQ9qWAZ8JhaGrOVTnz1LVwB8ZPEhJx+WI53jET5cprB4PGI0VNIk97dTweHd9eHK7ybhBVwiWY12D2cZNxqeHHKaQLxJ016p1OtqoLPATxtT9XVu8Q8vhmX3zv4wZ1NQu8Eh6rUiQB1BP4mMfJXpNz97ySxA+iOWkuMyA/G7Nacn/o/gMsobZ+tAq+E69zC3/pUerppXsmfMtq9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sYsMmw2JbTCmdah11vM8MWXEqsTJ2QSdYl0jihSzV+w=; b=dohJWtAUOCBPZn4gxHqndRaOwRFBF1dpajRD5/hC2ZBTanjfWRiJ7SVfqeNJaetLjphW8zzJnI+Rx33+ZVhw0nyCKo5kxW0aY2ia3UZIdCsFs/hpl2IaO1Dn2u8NLlgX5z+xArVMU/SuCyNbEs+cHwTd7ZTAB3bltLKfc0CfzpbgQf9euP2d5BXbvB3i7jMkcWvSmYvFrtJ3ovfObcmigmoKh+Bx/g6d6kxH8wT+ZVc+DTJ55l0wE6x7+g3WJRC63hXsge4oSVVem9E7+Nv0txJH/mJXI+Z5o3tkcDUvknGZJOGDgSJMkYRIQDTPPtRMzo0v6btjAAHp7gkLdy+n/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sYsMmw2JbTCmdah11vM8MWXEqsTJ2QSdYl0jihSzV+w=; b=K29S4CEEtzq/+sYg6/tchbBAmfdPs6VZYdEypOZboMZdzdguWIAbfQsDPAWoaAis13S7tyoTi3KReLemZzzA5SnLQZ6rJx2okPzd6AGTKgiwCm0Mvx6l6W9U9yPxxS8n2mWzbaAaYbkryIdAT5NZ+cVHK777NR0yUcmebuIBqO4= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB6974.eurprd04.prod.outlook.com (2603:10a6:803:133::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Wed, 8 Jul 2020 14:05:22 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::b077:1fe4:d352:b464]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::b077:1fe4:d352:b464%7]) with mapi id 15.20.3153.029; Wed, 8 Jul 2020 14:05:21 +0000 From: Akhil Goyal To: Thomas Monjalon , "fiona.trahe@intel.com" , "arkadiuszx.kusztal@intel.com" CC: "dev@dpdk.org" , "ferruh.yigit@intel.com" , "bruce.richardson@intel.com" , "orika@mellanox.com" , "jerinj@marvell.com" , "stephen@networkplumber.org" , "olivier.matz@6wind.com" , Hemant Agrawal , "mdr@ashroe.eu" Thread-Topic: [dpdk-dev] [PATCH v2] cryptodev: add function to check if qp was setup Thread-Index: AQHWSjOg/YfbuTx8zUm+aSX9qid1NKj9xYMAgAAFSnA= Date: Wed, 8 Jul 2020 14:05:21 +0000 Message-ID: References: <20200624142653.16488-1-arkadiuszx.kusztal@intel.com> <1939387.ZpZeW6HBnj@thomas> In-Reply-To: <1939387.ZpZeW6HBnj@thomas> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.118.167.90] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9d64a44d-fb98-413b-1493-08d82347f409 x-ms-traffictypediagnostic: VI1PR04MB6974: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7S/32L7Gk/Ff4wGpw/IQcJdwW4XNmVCQlHQArCBhLQOzdV+ncGzgIdz4+DOxSjf+W5O5P5wurywWzBQT9KSZIC1oWQRr+BpwbVGNDuO2f/8wbL1vaOjWf9Uwx6HZVzpYqAGjfGeYzM0ep9sZQ4Dy7wUOo6MC0IOJ/jw5lfHTJTWOqMIpQxlKJn+7vToyyPtf3C6YwHMa3+g+liNjFC1QKUvvC++wnoRIPSDDw2buI9s+WthVbb76oQXQmCJtJRwVS0hIgPN9rbfjW+FwlwVH8s/oQtKj/ofLYAUo4Azp6+7eNBD1sLm6sqPBHfFMi4exmj2QBGD+blBf72j8/U+ySl2qr5Gh/TwNl0ChcI+0YWA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(346002)(39860400002)(366004)(396003)(376002)(44832011)(186003)(71200400001)(7696005)(33656002)(7416002)(4326008)(5660300002)(52536014)(66556008)(26005)(66446008)(55016002)(64756008)(9686003)(478600001)(2906002)(966005)(66476007)(6506007)(110136005)(66946007)(54906003)(316002)(76116006)(86362001)(8936002)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: JKMXGmih54eav6KDdoqAJTC5WbkwLIuLqU1oOTzyQkSaAOSMkgwtu/bj3kAKZjfUmpyGkE/Ys6aQHP9aqYpin3QLgzBKfQ2zZkbr7n6S2cXi6tmCJgIa7ztwQOiWNjHUo927ySX3f+ZAG0Y/IVh4mBD1B2Ea7jCvvPGzCgWCVM1igk0ccoo8ZXKt1LVBhk4sPlO5VMoQWRoWZnkJstExIzvJWabW7/k4iEIgyXSFMgwLta8rEEbvcXa0wHzZi0JE4I29OfVgbR3Z/be/DuZ8KbrbtmjY8UIjWJcE5hDrrnlr83jpglo0A3VCx/gT8WpoL5fAl66Y4az+A2ehur1ZrE6Ny24ok6YYT+2mIgPBN9U8Ubdzey5puXmX6e7LCv/O98P6bM7xrcfXdHde+DgTryFZmr0m78R8xS+LlgW37M+TiCAAjaXpEytpmYUaKrFiW/A5HkxzsrCkNB4isitROixk01CfeuAyDe0br/9k7cZYZAi1Aj7ULLfD5ak9juC6 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d64a44d-fb98-413b-1493-08d82347f409 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2020 14:05:21.5611 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9MnyeVfGKZbBX16o+J3uTMq4STEFJfk2cp88weKjgFNfSHDT6Ss8c4p3bd4glw03jPR6huQvaJS7cya/fK8uwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6974 Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: add function to check if qp was setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, >=20 > 24/06/2020 16:26, Arek Kusztal: > > From: Fiona Trahe > > > > This patch adds function that can check if queue pair > > was already setup. This may be useful when dealing with > > multi process approach in cryptodev. >=20 > That's all? No more justification? > No usage in example apps? > No addition in test apps? > Is it needed for the application? The application is in review stage right now. http://patches.dpdk.org/patch/72156/ The current patch is a cryptodev patch which should be part of RC1. The app is targeted for RC2. The API explanation in rte_cryptodev.h is I think sufficient and the usage = will be Demonstrated in the app. /** + * Get the status of queue pairs setup on a specific crypto device + * + * @param dev_id Crypto device identifier. + * @param queue_pair_id The index of the queue pairs to set up. The + * value must be in the range [0, nb_queue_pair + * - 1] previously supplied to + * rte_cryptodev_configure(). + * @return + * - 0: qp was not configured + * - 1: qp was configured + * - -EINVAL: device was not configured + */ >=20 > I don't know cryptodev enough, but I can tell with ethdev experience > that we are a lot more demanding when adding a new API in ethdev. > We are still fixing the API errors done years ago in ethdev, > and it is very difficult to deprecate what was used in the past. > I hope my fear is wrong and you are not doing the same errors > as we did in ethdev, it would be a pity. >=20