From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BD8B0A04DB;
	Wed, 14 Oct 2020 22:26:25 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id A11A01DA60;
	Wed, 14 Oct 2020 22:26:24 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60051.outbound.protection.outlook.com [40.107.6.51])
 by dpdk.org (Postfix) with ESMTP id D33681C296;
 Wed, 14 Oct 2020 22:26:22 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m/uzaeJ6An/M+5cq/QzXEqNcbMijFABraxDARQCWYMlwc1ruBPWkSOu3E8yzuoM03Z6AE+dLhMpHFLrl7ztw+63FxI4w/DVS+tqtR4oBqIfXtql6V9WecveMNhIJr2FQW7pAqIVP9hoBd26fqFZ8hbsmLN04bpY78MXJKtaXNrG33fNcgEyhdSWMwA9abi9GgquXAeWmj8E0o4EXAqmHh3cKwsoPiyd2u1wNyJJusIIqJYy93eG073CCqzayCHjpUm+rQOER2b204NCPfAciVzHD1nnpdNVcep0w3dZ5sItDXGtyQ3De2FjGb5RipCxdwXFl1rZ31rwPF8PhGoStiQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wHR0ZRqua7NGAUOivffDYiZLFfOMlOAcYAJZdcZIXJQ=;
 b=ZB4UYWWynQvHyi8uAPi7ecH5ZGRaNu/RVfDti+sWOJVkn+VrLh0mtZCGPO97xdeYykm409BPyRq5+DE1crOyFJYlygu6oaNKwEgcc7FanUsHbe2ryy1m+kuXCMbWeH4QnBq2iItiRiYvWYR2+UskFMfAlqJX/YEEwyozvqZjsYAfyJgdTcSw+zTIyrtAZFzrncjJgpDITGoUV0Z6GfEYrO/9MPOIipQKqwH9mER64SWpHJajvQrbN5Y7Ji5FZXV28PpqXQ89t9hRJnGIKBL7cY8BCtHF1gN564I72YqkHC8By8uHYPH431clH1JGqTTd40JCDc8VjiV+a5o0ywSVKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass
 header.d=nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; 
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wHR0ZRqua7NGAUOivffDYiZLFfOMlOAcYAJZdcZIXJQ=;
 b=Bx/MlOuwB/1xIw6YHAhKT35k7rfz49CFIhQQkZRFC3RKB6x4FHm0L9K6CM6tvV9p7wcN3HzRA+7YDW8KoqKDDtGY3h0uJnukmi3Yw2VZ6660UVM38nbiKd5LPEyHLEZznK/O/EZ01+akuThHASnFZZGKCFe3aiN1KUtxqmHwsDE=
Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10)
 by VI1PR0402MB3374.eurprd04.prod.outlook.com (2603:10a6:803:b::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.21; Wed, 14 Oct
 2020 20:26:21 +0000
Received: from VI1PR04MB3168.eurprd04.prod.outlook.com
 ([fe80::9513:3b55:931f:216e]) by VI1PR04MB3168.eurprd04.prod.outlook.com
 ([fe80::9513:3b55:931f:216e%4]) with mapi id 15.20.3455.033; Wed, 14 Oct 2020
 20:26:21 +0000
From: Akhil Goyal <akhil.goyal@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: "dev@dpdk.org" <dev@dpdk.org>, "techboard@dpdk.org" <techboard@dpdk.org>, 
 "anoobj@marvell.com" <anoobj@marvell.com>, Hemant Agrawal
 <hemant.agrawal@nxp.com>, "declan.doherty@intel.com"
 <declan.doherty@intel.com>, "david.coyle@intel.com" <david.coyle@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v3 2/8] security: modify PDCP xform to support
 SDAP
Thread-Index: AQHWoKFqPpAUyJCgL0uuexCoZg/xuKmWuuWAgADRAbA=
Date: Wed, 14 Oct 2020 20:26:20 +0000
Message-ID: <VI1PR04MB3168FA4D5D805150D05FA729E6050@VI1PR04MB3168.eurprd04.prod.outlook.com>
References: <20201011213403.21169-1-akhil.goyal@nxp.com>
 <20201012141006.31463-1-akhil.goyal@nxp.com>
 <20201012141006.31463-3-akhil.goyal@nxp.com> <5343391.ofL17Uz9jy@thomas>
In-Reply-To: <5343391.ofL17Uz9jy@thomas>
Accept-Language: en-IN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: monjalon.net; dkim=none (message not signed)
 header.d=none;monjalon.net; dmarc=none action=none header.from=nxp.com;
x-originating-ip: [122.180.231.103]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 663bce0d-d543-4c09-d282-08d8707f69cb
x-ms-traffictypediagnostic: VI1PR0402MB3374:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <VI1PR0402MB3374E02F926DBA2C063EF462E6050@VI1PR0402MB3374.eurprd04.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: eVsAIitZavroqUPY8NmnQ9MGOGreAiGryWTH+Xaoe6VAbddtaTZoSlftIRAojj4enEoPTLCbsEzO+haWyvUQNii7cOqz0HP7ucK/quUgztP7U64e9EzHQLX0NUveh4Smj/NyWS6oCiV+dESLOpyeHgw8ofXyHicBbekezbDtyXGNgi8h9P8jTAZFwIMsbis3ambDT7KVmHsubo6qhL1tcuBIbNeucmaNH9/AEFepCCJFq5YiCGL0nouV/k9qYRHeN1AP2zYPSUVczJ+Bm+9fPABt+h5S/gRpGcJ6W1HPQpuzzX5qmLBB/+WbiUEJrkKRA17xM2YVO5QpU6VIqiDTbQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(186003)(86362001)(54906003)(5660300002)(2906002)(33656002)(478600001)(26005)(6506007)(6916009)(44832011)(316002)(7696005)(52536014)(15650500001)(71200400001)(4326008)(8676002)(76116006)(64756008)(66556008)(66446008)(66476007)(66946007)(9686003)(8936002)(55016002)(83380400001);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata: GvvHGCPwyJyU098oTxCgwCnTt5t5mdVO2aVL3CaskYSb9bAqDTOT9UXbK1CRxC+DwPPJM7I8V5BnoZWFs+tDXWMl6XZCYUnu0VJdDQxVuHLk21zGzTGa5A1glcdXfTbhTee0NwpSjT75Fw9STPv1uEdWFhZjzihNlnzbTaGeZ4ZWaTYI2s4K43E4Vw7j8bZa2oyPdmP8Oezs0W8oBO4pjpQZupfMZTsisnsh3CAY5cpCFsOAy+qvMEDgdEi2P6FXtDmpbxyvfBYT6Xn7mlr+cjHphfjL4kaf6xjt82Jdf81bQu58j0Yj5pfmrZ+D98Ba3DJ0wtMp7IPYUXCFGGqXGc+dRrgkvHlg6iTUPzIpl94P2UqXDRMbfAlSV87FYcnIocmFhA2G/Y9L9DF9D06s97WfkR8Aw0pqF7wvCHCe+lfKWdVpnkzPHeqFFYj47Mjjy2Yg7qYkS4vP3znCkIV6U/GjLEw6dA5A+oUKL33KExDB9kD1mz78cnhk2eEOFgr3E80fN3J7uu9dsXgHc24P2b7ARvHq1Nv2RxY0chO2dAu0+mQYgX3WC+Bq96h9egeCNfPIDOrlyj2ywoazyd1mSGoQ7x9RKkfgwnDtUATTjG7k/P78Eb7OeDCoBYwh7v/NPr0tRrPjIcYGtAskiFI9hw==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 663bce0d-d543-4c09-d282-08d8707f69cb
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2020 20:26:21.0228 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: a0f9dMvfQQRUIY3Eaf5OHQcV7onONdZW2q1Pb80folcG7BXfMnikv6yjiDlrbM3GLF7U7/fhP72Y4LSrffMNqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3374
Subject: Re: [dpdk-dev] [PATCH v3 2/8] security: modify PDCP xform to
 support SDAP
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> 12/10/2020 16:10, Akhil Goyal:
> > The SDAP is a protocol in the LTE stack on top of PDCP for
> > QOS. A particular PDCP session may or may not have
> > SDAP enabled. But if it is enabled, SDAP header should be
> > authenticated but not encrypted if both confidentiality and
> > integrity is enabled. Hence, the driver should be intimated
> > from the xform so that it skip the SDAP header while encryption.
> >
> > A new field is added in the PDCP xform to specify SDAP is enabled.
> > The overall size of the xform is not changed, as hfn_ovrd is just
> > a flag and does not need uint32. Hence, it is converted to uint8_t
> > and a 16 bit reserved field is added for future.
> >
> > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> > ---
> >  doc/guides/rel_notes/release_20_11.rst |  9 +++++++++
> >  lib/librte_security/rte_security.h     | 12 ++++++++++--
> >  2 files changed, 19 insertions(+), 2 deletions(-)
> >
> > diff --git a/doc/guides/rel_notes/release_20_11.rst
> b/doc/guides/rel_notes/release_20_11.rst
> > index c34ab5493..fad91487a 100644
> > --- a/doc/guides/rel_notes/release_20_11.rst
> > +++ b/doc/guides/rel_notes/release_20_11.rst
> > @@ -103,6 +103,11 @@ New Features
> >    also known as Mount Bryce.  See the
> >    :doc:`../bbdevs/acc100` BBDEV guide for more details on this new dri=
ver.
> >
> > +* **Updated rte_security library to support SDAP.**
> > +
> > +  ``rte_security_pdcp_xform`` in ``rte_security`` lib is updated to en=
able
> > +  5G NR processing of SDAP header in PMDs.
> > +
>=20
> Please try to keep the ordering:
> crypto and security stuff should be after ethdev drivers
> and related stuff (I would say even after flow-perf).
>=20
Fixed it while applying the series to dpdk-next-crypto

> >  * **Updated Virtio driver.**
> >
> >    * Added support for Vhost-vDPA backend to Virtio-user PMD.
> > @@ -307,6 +312,10 @@ API Changes
> >    ``rte_fpga_lte_fec_configure`` and structure ``fpga_lte_fec_conf`` t=
o
> >    ``rte_fpga_lte_fec_conf``.
> >
> > +* security: ``hfn_ovrd`` field in ``rte_security_pdcp_xform`` is chang=
ed from
> > +  ``uint32_t`` to ``uint8_t`` so that a new field ``sdap_enabled`` can=
 be added
> > +  to support SDAP.
>=20
> For the API change,
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>=20
Applied to dpdk-next-crypto