From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A67AA04F3; Mon, 30 Dec 2019 08:40:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 09D221C031; Mon, 30 Dec 2019 08:40:35 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20086.outbound.protection.outlook.com [40.107.2.86]) by dpdk.org (Postfix) with ESMTP id 3C08C1BF85 for ; Mon, 30 Dec 2019 08:40:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HYZXsANr0g6mTGQ7hLDBOjdN6d3kHfhbLukCDKUiYww1FkNdxoQSfKc494PAMQSiNRDgYdTC67/aj9+r4Krpg+DpiNaXgCgFvWVmL/DYHpUfz8rVSQc8ENtmsXDTSdaIjL8UGBn09mxYFoLRCwKyf0JHbBM+3aTsMWpXeAiZbKnA1PuzTIl3GdElLt+xyTlbNDso+ewv5r66eP8ROueqBWIYJJimioCGItBApJoW1Z8IwGZl4P/z9CPpEKTUqMilc6HdaxohdEwr9hR7InQ6ncU8ZnbKqH6xrd40Bv8ftCEEfDBcEYmk+PyjNcn5M3NNW1pm92IqDVBHJCujBZI96w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o9eS/K0ohMtzfH8ZFXJ0UfBGckT82g9NLuaXhg+M+Do=; b=lvG5p60udXWcZbBcaM++0KoTk21HnBUIeJGuWByaQb6NSOMeZWZXl4LpHYyxtJHRaGGYQb77+yq8W2z1RE1juKHqRBSY7js/Jgu3zaIcEhy0HC9V22KxLoRVwPRtz7+w8U57it289lCLXrEWx4YHIIsLAROWevqKgwUQUEsW6KUkAJu8FggGccYpuA9iVJxVUM/a1OTjLqA5/Gl6He2xo1sR0Ywy1L9FVoU4HKlTgglzS6wbNa6RtEFFbG6iruZf8gH/XMkiJB4+5D/Z+QQM0ZqW7eVZz00SxUxtUHbHSgUs7YQ5SEwm7i6c9CcHNfnTKChuWeKMvD7P+lVk+H1Peg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o9eS/K0ohMtzfH8ZFXJ0UfBGckT82g9NLuaXhg+M+Do=; b=YmOPGlbAIoRCCBLnxM51hryfV6aQUc+ukfyt2f8BFXn96IqKUplrSS1mxekzRM5ZTbKATj8GoC3IULO3rXK59bNLNt5IzHBuPXdHiPBnflW9r1TlkN1kV368uJ3sJPCA4kLd9U97w2xzDwJbqWYTB1jd13CRzEWrpfL+RVmmsT4= Received: from VI1PR04MB4480.eurprd04.prod.outlook.com (20.177.53.80) by VI1PR04MB5999.eurprd04.prod.outlook.com (20.178.124.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2581.12; Mon, 30 Dec 2019 07:40:32 +0000 Received: from VI1PR04MB4480.eurprd04.prod.outlook.com ([fe80::58a6:d929:99a8:117f]) by VI1PR04MB4480.eurprd04.prod.outlook.com ([fe80::58a6:d929:99a8:117f%7]) with mapi id 15.20.2581.007; Mon, 30 Dec 2019 07:40:32 +0000 From: Nipun Gupta To: Pavan Nikhilesh Bhagavatula , Jerin Jacob Kollanukkaran , Marko Kovacevic , Ori Kam , Bruce Richardson , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Sunil Kumar Kori , Hemant Agrawal CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 04/11] examples/l3fwd: add ethdev setup based on eventdev Thread-Index: AQHVqrFaU7Yw7Ay0HUWIwv1d2F6f0afOFyWAgANQlYCAAQRUkA== Date: Mon, 30 Dec 2019 07:40:32 +0000 Message-ID: References: <20191204144345.5736-1-pbhagavatula@marvell.com> <20191204144345.5736-5-pbhagavatula@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=nipun.gupta@nxp.com; x-originating-ip: [92.120.1.72] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: dd053bae-0c87-492c-b4fa-08d78cfb8cb5 x-ms-traffictypediagnostic: VI1PR04MB5999:|VI1PR04MB5999: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0267E514F9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(346002)(136003)(39860400002)(396003)(189003)(199004)(13464003)(5660300002)(86362001)(110136005)(186003)(2906002)(55016002)(6636002)(316002)(44832011)(9686003)(71200400001)(4326008)(52536014)(33656002)(64756008)(66556008)(53546011)(7696005)(66446008)(6506007)(478600001)(26005)(66476007)(8936002)(81156014)(81166006)(66946007)(76116006)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5999; H:VI1PR04MB4480.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GrHkHM1OkT4Y3CPyAd7JE8WVa3DXJaSadscbaoPHn/y29UjfnIoe6IfnXUp9xGgnFeulL5sSLbqhwh1Lm+dsIktJBzl9WE8AvH8/f0vnT8wxE5wofAvl1xvaELRs9st8qh/5Yqa4094qa4ilWucjTkLbE+bE4Mza6dIkiNQnTj0TCjWjuRc/q+9QDUJsUREbd2nZQZdTWeD0Nu5P3oiMTyjiAvIuNvuEfeZnuP+FMRq5czbktGEi01MMBRB9ooqHTYJYgCiuIb2zIHtoeU/dKiI5DI0hutv15DIRmgJoVuMxXnslt5GS4oWe0cpaFJ2zR2md+nJFMWFCp38lbCfSwioUvkJbUQBNObCF3hXnRmIniS3ZGtqo4BFSeH1dusuUouw60iwOAPKttlAZxynXXmwbS/ZdIyIOONpDNM5rPK7ucr6mC5YnU7NyjI2b60980Oyryef+gmLc4lTBY2a+1RIK/UK9O4bMNdt0XksQJwclV/QJRUScRlOkaULhmW5Rg7V7Fg+vDwJpCEpbGuS/Pw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd053bae-0c87-492c-b4fa-08d78cfb8cb5 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Dec 2019 07:40:32.0433 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h5Sx3Pre5+TAsxOCoRvlQ0599W10lSGxtbMQJx2T3SS92lekIblk8wm1gzB8hohWHv7KmCyY7b9A6LlWvUMDDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5999 Subject: Re: [dpdk-dev] [PATCH v2 04/11] examples/l3fwd: add ethdev setup based on eventdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pavan, > -----Original Message----- > From: Pavan Nikhilesh Bhagavatula > Sent: Sunday, December 29, 2019 9:12 PM > To: Nipun Gupta ; Jerin Jacob Kollanukkaran > ; Marko Kovacevic ; Ori > Kam ; Bruce Richardson > ; Radu Nicolau ; > Akhil Goyal ; Tomasz Kantecki > ; Sunil Kumar Kori > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 04/11] examples/l3fwd: add ethdev setup > based on eventdev >=20 >=20 > >> -----Original Message----- > >> From: dev On Behalf Of > >> pbhagavatula@marvell.com > >> Sent: Wednesday, December 4, 2019 8:14 PM > >> To: jerinj@marvell.com; Marko Kovacevic > >; Ori > >> Kam ; Bruce Richardson > >> ; Radu Nicolau > >; > >> Akhil Goyal ; Tomasz Kantecki > >> ; Sunil Kumar Kori > >; > >> Pavan Nikhilesh > >> Cc: dev@dpdk.org > >> Subject: [dpdk-dev] [PATCH v2 04/11] examples/l3fwd: add ethdev > >setup > >> based on eventdev > >> > >> From: Sunil Kumar Kori > >> > >> Add ethernet port Rx/Tx queue setup for event device which are later > >> used for setting up event eth Rx/Tx adapters. > >> > >> Signed-off-by: Sunil Kumar Kori > >> --- > >> examples/l3fwd/l3fwd.h | 10 +++ > >> examples/l3fwd/l3fwd_event.c | 129 > >> ++++++++++++++++++++++++++++++++++- > >> examples/l3fwd/l3fwd_event.h | 2 +- > >> examples/l3fwd/main.c | 15 ++-- > >> 4 files changed, 144 insertions(+), 12 deletions(-) > >> > > > > > > > >> + > >> + local_port_conf.rx_adv_conf.rss_conf.rss_hf &=3D > >> + > >> dev_info.flow_type_rss_offloads; > >> + if (local_port_conf.rx_adv_conf.rss_conf.rss_hf !=3D > >> + port_conf- > >>rx_adv_conf.rss_conf.rss_hf) { > >> + printf("Port %u modified RSS hash function " > >> + "based on hardware support," > >> + "requested:%#"PRIx64" > >> configured:%#"PRIx64"\n", > >> + port_id, > >> + port_conf->rx_adv_conf.rss_conf.rss_hf, > >> + > >local_port_conf.rx_adv_conf.rss_conf.rss_hf); > >> + } > > > >We are using 1 queue, but using RSS hash function? >=20 > rte_event::flow_id which uniquely identifies a given flow is generated us= ing > RSS Hash function on the required fields in the packet. Okay. Got it. >=20 > > > >> + > >> + ret =3D rte_eth_dev_configure(port_id, 1, 1, > >&local_port_conf); > >> + if (ret < 0) > >> + rte_exit(EXIT_FAILURE, > >> + "Cannot configure device: err=3D%d, > >> port=3D%d\n", > >> + ret, port_id); > >> + > > > >We should be using number of RX queues as per the config option > >provided in the arguments. > >L3fwd is supposed to support multiple queue. Right? >=20 > The entire premise of using event device is to showcase packet scheduling= to > cores > without the need for splitting packets across multiple queues. >=20 > Queue config is ignored when event mode is selected. For atomic queues, we have single queue providing packets to a single core = at a time till processing on that core is completed, irrespective of the fl= ows on that hardware queue. And multiple queues are required to distribute separate packets on separate= cores, with these atomic queues maintaining the ordering and not schedulin= g on other core, until processing core has completed its job. To have this solution generic, we should also take config parameter - (port= , number of queues) to enable multiple ethernet RX queues. Regards, Nipun >=20 > > > >Regards, > >Nipun > > >=20 > Regards, > Pavan.