From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FC85A2EDB for ; Mon, 30 Sep 2019 07:38:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC08CDE3; Mon, 30 Sep 2019 07:38:36 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40088.outbound.protection.outlook.com [40.107.4.88]) by dpdk.org (Postfix) with ESMTP id D1E11B62 for ; Mon, 30 Sep 2019 07:38:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gjk6kblCXLewfnccQeaiJYNE1E5rYBM1Q2/MqPQS2lpyugwKAaPDaflJyF6w1+KxO4sp/EVXWgm5YVb34N8rzMW5QvkOGRT/X8v//iJBagF5mHwkUWBw1AfYl9Vl1gpD+mM5rZ4OOIXxO3AcSipVeOrIphcAHYi2RSpIKrF6qxMUifzYjdd8KJYsBuRigJmb4PY71U5sTNqyE6MudHFS1Vi8Y6T2ooA6Dm3Rh0o6eOGPy4RHVupraxxJR71OnhU0u44K7spGTFCS/4kOshGJn8UowM6OTZedcwiqnsv/9Vv8gdvOeNVKXos14Og4tMZF+rvg0RE3+/P+o5jzM2zC6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gky8SrUiBXGOSR42mglsIYGFs9oVHR7TYK7/B0FNTU8=; b=PbB5LOQq6NYSrJ8KRnymL+wtB4f+d7V82ELNGAJoVSr1KkpYXjMqmBa5YNFFWbq4na4Jt0dVyWKYV162jrUP/YhiBpirkBAmYFQqUsxirz6T1eDd2oagy1kKcSqFfvNy4DGieVkzRQYiw4XtmrVcm7bk855bQ1z27Ez5m31cnbhy/kqTPtPwqHGQZaLsqh4FDWkUm92HTdsGT79Wr8Ieo0isfk+lWg7XFU7z2fiRa7c+UjdwaW5Kym57BIjd0NxAetnlG3kd+ZMibDVYbB+2fsi0kTsU7RCXv7TuITYC5fF+DsLaf9qCl3NdZlO+37LyfWIOaOZCMtdGBC0r5M8QmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gky8SrUiBXGOSR42mglsIYGFs9oVHR7TYK7/B0FNTU8=; b=N8hYMZU+3NulVILmkezdZHPcblsoXbc1zEob1lDTvGVtkgLIA+tODDTkKnrvgcWZj2rKXf2u4WwO41qBQ/a0On0DjkprSPrdq/W5pthcOhdrI8159cYE2SIQlw4eF1VrQDGOoNUZsm8IfOH5IaLfALgR/dGdgUgTob70TDGEwx0= Received: from VI1PR04MB4480.eurprd04.prod.outlook.com (20.177.53.224) by VI1PR04MB5406.eurprd04.prod.outlook.com (20.178.121.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.17; Mon, 30 Sep 2019 05:38:33 +0000 Received: from VI1PR04MB4480.eurprd04.prod.outlook.com ([fe80::681a:2c5b:e170:683]) by VI1PR04MB4480.eurprd04.prod.outlook.com ([fe80::681a:2c5b:e170:683%6]) with mapi id 15.20.2305.017; Mon, 30 Sep 2019 05:38:33 +0000 From: Nipun Gupta To: Pavan Nikhilesh Bhagavatula , Jerin Jacob Kollanukkaran , "bruce.richardson@intel.com" , Akhil Goyal , Marko Kovacevic , Ori Kam , Radu Nicolau , Tomasz Kantecki , Sunil Kumar Kori CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 08/10] examples/l2fwd-event: add eventdev main loop Thread-Index: AQHVcryIrfqVD8drGkK/swDhHqkjdac/iKlQgAATcwCABB35AA== Date: Mon, 30 Sep 2019 05:38:32 +0000 Message-ID: References: <20190919101346.8832-1-pbhagavatula@marvell.com> <20190924094209.3827-1-pbhagavatula@marvell.com> <20190924094209.3827-9-pbhagavatula@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=nipun.gupta@nxp.com; x-originating-ip: [92.120.1.68] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6884c65b-1693-4673-8840-08d745686eae x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: VI1PR04MB5406:|VI1PR04MB5406: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 01762B0D64 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(366004)(396003)(346002)(39860400002)(13464003)(199004)(189003)(26005)(52536014)(5660300002)(305945005)(74316002)(6506007)(7696005)(7736002)(2906002)(71200400001)(71190400001)(102836004)(53546011)(99286004)(6246003)(76176011)(3846002)(6116002)(110136005)(66066001)(4326008)(25786009)(9686003)(14444005)(86362001)(81166006)(486006)(316002)(14454004)(55016002)(81156014)(44832011)(476003)(76116006)(66946007)(66446008)(64756008)(66556008)(66476007)(11346002)(446003)(33656002)(229853002)(6436002)(2501003)(478600001)(186003)(256004)(8936002)(60764002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5406; H:VI1PR04MB4480.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yjQ4wnTOsOX005RZFEWyD0iEZzJ1p7TcJc1uQyxDH5csjnDuunRdFPufFfrxehnBUxSiuh5GUTEI7V3v+tRAdBMNmo0ZP2jOzw+Fey+ZCEs7GmkAFjOJ/S7ufCJezOuCvWtbFkaZ1OSFK5Hn06citNuGX+rcPmW6C0yAWujuhPQczwo+b80PxDwLSZ9zABUmwXP14LSXNHFRFSXvlmpZJvxvSf5zDj78+82HjTl/e6ZLod2ZPja0ZZsqkcGQubod+Yjw4+YGKOlmJKiO54eHStWo9aC5n8/LutYBtDtX5NU3+BCwLoLPu64R8GZd2+30M907YQXJ010C/Wf3Nahjel4xRxjqWzLIX4JU+xlXEGaqIhldnnHog+/pzzrJCU2Ey8U5flyEUcqollLZuxzURQTUPaW9j1pu2r2wtavEyDU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6884c65b-1693-4673-8840-08d745686eae X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2019 05:38:33.1082 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FHbCL9LoM+1HXyjhYt4hsopKyY6ea/uD4IjguK8+tuMjceLqjMi+zmDHZFRU/hxdN++BTXLtMnG/OkweXiPAjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5406 Subject: Re: [dpdk-dev] [PATCH v4 08/10] examples/l2fwd-event: add eventdev main loop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Pavan Nikhilesh Bhagavatula > Sent: Friday, September 27, 2019 8:05 PM > To: Nipun Gupta ; Jerin Jacob Kollanukkaran > ; bruce.richardson@intel.com; Akhil Goyal > ; Marko Kovacevic ; > Ori Kam ; Radu Nicolau ; > Tomasz Kantecki ; Sunil Kumar Kori > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4 08/10] examples/l2fwd-event: add > eventdev main loop >=20 > >> > >> From: Pavan Nikhilesh > >> > >> Add event dev main loop based on enabled l2fwd options and > >eventdev > >> capabilities. > >> > >> Signed-off-by: Pavan Nikhilesh > >> --- > > > > > > > >> + if (flags & L2FWD_EVENT_TX_DIRECT) { > >> + rte_event_eth_tx_adapter_txq_set(mbuf, 0); > >> + while > >> (!rte_event_eth_tx_adapter_enqueue(event_d_id, > >> + port_id, > >> + &ev, 1) > >&& > >> + !*done) > >> + ; > >> + } > > > >In the TX direct mode we can send packets directly to the ethernet > >device using ethdev > >API's. This will save unnecessary indirections and event unfolds within > >the driver. >=20 > How would we guarantee atomicity of access to Tx queues? Between cores > as we can only use one Tx queue. > Also, if SCHED_TYPE is ORDERED how would we guarantee flow ordering? > The capability of MT_LOCKFREE and flow ordering is abstracted through ` > rte_event_eth_tx_adapter_enqueue `. I understand your objective here. Probably in your case the DIRECT is equiv= alent to giving the packet to the scheduler, which will pass on the packet to the= destined device. On NXP platform, DIRECT implies sending the packet directly to the device (= eth/crypto), and scheduler will internally pitch in. Here we will need another option to send it directly to the device. We can set up a call to discuss the same, or send patch regarding this to y= ou to incorporate the same in your series. >=20 > @see examples/eventdev_pipeline and app/test-eventdev/test_pipeline_*. Yes, we are aware of that, They are one way of representing, how to build a= complete eventdev pipeline. They don't work on NXP HW. We plan to send patches for them to fix them for NXP HW soon. Regards, Nipun >=20 > > > >> + > >> + if (timer_period > 0) > >> + __atomic_fetch_add(&eventdev_rsrc- > >>stats[mbuf- > >> >port].tx, > >> + 1, __ATOMIC_RELAXED); > >> + } > >> +}