From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B5465A045E for ; Thu, 30 May 2019 08:46:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 967292C0C; Thu, 30 May 2019 08:46:17 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40044.outbound.protection.outlook.com [40.107.4.44]) by dpdk.org (Postfix) with ESMTP id 7C94B9E4; Thu, 30 May 2019 08:46:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RGNEuu0kDCVqMEF5u9/v09txWLz3Xe5hqkL0yVJGbmk=; b=CUmxN486wGFQwtzIFpRvbgDLTlQC72RrR8yC/xrf1RJqvp1CBo5NQz25UW11lZjv02SSIH6msAtxYSWeERI48aa6hUE7xvVAwoAQexa40zmslqnIbzYXjEXOWZMOvrYeSwQgAQzN83NA68R9aQFw9gwh9cf4ACtx8cZN4EeFAls= Received: from VI1PR04MB4688.eurprd04.prod.outlook.com (20.177.56.80) by VI1PR04MB4317.eurprd04.prod.outlook.com (52.134.31.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1922.16; Thu, 30 May 2019 06:46:15 +0000 Received: from VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::70b2:7c38:c5fb:9bca]) by VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::70b2:7c38:c5fb:9bca%7]) with mapi id 15.20.1943.016; Thu, 30 May 2019 06:46:15 +0000 From: Shreyansh Jain To: Bruce Richardson , "dev@dpdk.org" CC: Alejandro Lucero , Anatoly Burakov , "stable@dpdk.org" , Maxime Coquelin , Zhihong Wang , Luca Boccassi , Zhang XuemingX Thread-Topic: [PATCH v2 2/5] build: enable large file support on 32-bit Thread-Index: AQHVFUWizJvB52comU6ERXiLZvPrrKaDOqEw Date: Thu, 30 May 2019 06:45:50 +0000 Deferred-Delivery: Thu, 30 May 2019 06:44:51 +0000 Message-ID: References: <20190527161509.50252-1-bruce.richardson@intel.com> <20190528110748.10772-1-bruce.richardson@intel.com> <20190528110748.10772-3-bruce.richardson@intel.com> In-Reply-To: <20190528110748.10772-3-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [92.120.1.69] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 82ba68d9-16d6-46ea-f865-08d6e4ca833a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR04MB4317; x-ms-traffictypediagnostic: VI1PR04MB4317: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 00531FAC2C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(136003)(366004)(376002)(39860400002)(13464003)(199004)(189003)(256004)(52536014)(53936002)(64756008)(66446008)(66556008)(74316002)(25786009)(2906002)(7736002)(3846002)(66066001)(186003)(476003)(68736007)(110136005)(305945005)(66946007)(54906003)(6116002)(73956011)(76116006)(66476007)(6246003)(2501003)(53546011)(44832011)(99286004)(486006)(71190400001)(8936002)(71200400001)(86362001)(76176011)(14454004)(11346002)(229853002)(81156014)(81166006)(6506007)(102836004)(26005)(8676002)(316002)(478600001)(6436002)(446003)(966005)(33656002)(4326008)(5660300002)(55016002)(7696005)(6666004)(6306002)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB4317; H:VI1PR04MB4688.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: LE9gbm4lO7JOd6WM5m4NKOVotlLDevMJfCFlPCetbQY97EjlYJXo+sCTlyjaPv8FR3nurLbRlkU0GgeB/Cdd25g0nhYH9MGnRhbMk2AB0VxutAC3DQhx9O0XUpNT/kLjCmP9qK3M3r6cSpUlGl1llkNBJHNcRTM/PZhgK9K9vZMw7bhro83GlHrNKtlszpDjaGflrWBjhQvBtbcey1Gkj5nghfuBEe+Oj23N5jnWpQ2vN4YXwXZIGUGT57ZTo3PDFFI3Z9qVCpYx45YmNX3M0s3j9louWklLAGuFhQ/a7ZLCRyDjul1y7aLmSIt1qeV6SucKFq9kpFHVdwUWdVkYsREDFawfKfnE6wkPEt7ZFCcR0+lUujjZoqFTPuVKiYNAlhOZMNMYrfnGINm1TW5mxzGYaaTcm4naj0g0pKDeaRM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82ba68d9-16d6-46ea-f865-08d6e4ca833a X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2019 06:46:15.4411 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: shreyansh.jain@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4317 Subject: Re: [dpdk-dev] [PATCH v2 2/5] build: enable large file support on 32-bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson > Sent: Tuesday, May 28, 2019 4:38 PM > To: dev@dpdk.org > Cc: Shreyansh Jain ; Alejandro Lucero > ; Anatoly Burakov > ; stable@dpdk.org; Maxime Coquelin > ; Zhihong Wang ; Luca > Boccassi ; Zhang XuemingX ; B= ruce > Richardson > Subject: [PATCH v2 2/5] build: enable large file support on 32-bit >=20 > By default on 32-bit systems, file offsets are given as 32-bit values > which prevents support for large files. While this is unlikely to be > a problem, enabling large file support globally makes "make" and > "meson" builds consistent, since meson always enables large file > support, and without this change, the size of "struct stat" fields > will be different between the two builds. >=20 > The only location where this appears to be significant is in the > dpaax common code, where a printf needs to be updated for 32-bit > builds. >From DPAAX perspective, I am not worried about 32bit and dependency of larg= e file support. So, this 'don't care' from my side. >=20 > Signed-off-by: Bruce Richardson > Acked-by: Luca Boccassi > --- > drivers/common/dpaax/dpaax_iova_table.c | 4 ++-- > mk/arch/arm/rte.vars.mk | 2 +- > mk/arch/i686/rte.vars.mk | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) >=20 If this patch is merged, please ignore [1] [1] http://patches.dpdk.org/patch/53798/ Acked-by: Shreyansh Jain