From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4ADC4A04AB; Mon, 11 Nov 2019 17:05:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 979202AB; Mon, 11 Nov 2019 17:05:49 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40049.outbound.protection.outlook.com [40.107.4.49]) by dpdk.org (Postfix) with ESMTP id 3FD7A27D; Mon, 11 Nov 2019 17:05:47 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eR1pzZhecHfDCmw4RozNBfPPC8kXSYWp5XU1FSf8XgvdT700wsF0CWjK63kH25lvqpLQdMLCdC9l6+c5315NcnD1C6zNSZy6CmGubzCoxSTQGsn6tAwsYANJYHBfIOnlGYEk3ZCo4QIfEUbLw3SH1ZBzHEttjYiIroeZuv3vNk2IQhlzY4xxPqtU3cql8OP/nQKKpbDhYuRkTG7W1RvEdThH5jXIzQAgCwtdmh9JwO2wW4rSAan3DObPGP3zDP/hrf9TeIZmilC7B/kjzyNqrKQJQmdcAQh83pIlb7P0lbVYpHnCm3vGQxkAXUK6g+hwRRvukIXUQunaxeavASf0hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bp6BiqNGByZng+XHfy5d2kYcU3tOZrpymTO5Cgmt/qs=; b=jsgyGZrpN+3QxvQ1fRt3bf8Qpeb7b778sz2fByOwJ0TKYXQuW4NvLrSoD+BOEijPx7UiDIniND6pjaNJ5I017L4mrvZfuSkFSkT6Rf01hyHR9Bh2r8UYkMeqehqqZe2CBpbY+rAI6uvG7aTuzN82cplbLIqTPS4BmqJC+J7CAxiIEh6sHAIE8NKDxcGg+ivA7/T8FrA6Rto/b1YaJnCyOeLqZHTRKBzhxjLz3cGDy0L6lyG/yUhw54I1aSUEt8mzUXXE/Pvg/YTQOwHxuHizQLr3l35B+ToEKWGuf3YD97/K1gTVpQSZ5AXP92HLnnf46T2wv4UWhtvqT6A9tsoSpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bp6BiqNGByZng+XHfy5d2kYcU3tOZrpymTO5Cgmt/qs=; b=KarRBPj3k6SeQ+hqJvTZjrkM+lf5gIiNS65ixZx59KsPU925B7XMcgzSljRmL/7Mmi7Ox1nuWCHD/ibhbwrov3bVo+RYV8OVwFc9sn9TGi2iaI4WPgBcECLUeYiDfK31fb7VNJyNiAlfrV6aXXkXiY/RmEFQwhmqz4WrpVEpW94= Received: from VI1PR04MB4845.eurprd04.prod.outlook.com (20.177.48.94) by VI1PR04MB5822.eurprd04.prod.outlook.com (20.178.125.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Mon, 11 Nov 2019 16:05:46 +0000 Received: from VI1PR04MB4845.eurprd04.prod.outlook.com ([fe80::2093:e989:6ebc:f186]) by VI1PR04MB4845.eurprd04.prod.outlook.com ([fe80::2093:e989:6ebc:f186%3]) with mapi id 15.20.2430.027; Mon, 11 Nov 2019 16:05:46 +0000 From: Sachin Saxena To: Thomas Monjalon CC: "dev@dpdk.org" , "ferruh.yigit@intel.com" , "stable@dpdk.org" Thread-Topic: [PATCH v1] net/dpaa2: fixes issue of accidentally resetting rx offloads flags Thread-Index: AQHVmKY2O9QT6MYSzUygu+kPe4z8YKeGIBsAgAACHmA= Date: Mon, 11 Nov 2019 16:05:46 +0000 Message-ID: References: <20191111153614.12079-1-sachin.saxena@nxp.com> <2597413.12N5DsGnAP@xps> In-Reply-To: <2597413.12N5DsGnAP@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=sachin.saxena@nxp.com; x-originating-ip: [182.69.248.26] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ec4126f1-3b98-4545-3dfe-08d766c10337 x-ms-traffictypediagnostic: VI1PR04MB5822: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0218A015FA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(396003)(136003)(346002)(376002)(366004)(13464003)(199004)(189003)(76116006)(4326008)(66476007)(66556008)(64756008)(99286004)(66446008)(66946007)(55016002)(6916009)(53546011)(6246003)(54906003)(6506007)(9686003)(316002)(26005)(256004)(186003)(52536014)(102836004)(4744005)(5660300002)(6436002)(66066001)(71200400001)(71190400001)(478600001)(6116002)(3846002)(2906002)(25786009)(74316002)(76176011)(305945005)(14454004)(7736002)(7696005)(229853002)(33656002)(8936002)(476003)(446003)(11346002)(486006)(44832011)(8676002)(81156014)(81166006)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5822; H:VI1PR04MB4845.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PJ/uRwY0CHY5+Y7eFhQkLVM6iiqL2YHQayFk+BWYKCdwDBeUoJpNsvxp771rSXySPoP1fN8n31jYVeF+VODhxrnEV4UXF0odmgxb13smI/WxyxRhb+e5GWdGkr6x/WzDcfh61otf88mUKA0kuDSOIl8C37/nYywo3Jxh/Kb9Jblfjd+uJQFAzC44agm+EyCsVRXPs9Rm7ettnhtcpu2po2Po+zqdiCmvuYm6Q8M6/FW+1+wALSYRm9hfQ8FSgHC5d534CLR/680yXuN/DthmbrbTnM0GVDy+7Nn1dbrIHj/bw4YlZzuU3RKdwCgN4PN5gcEui5IilmyN76G3oLY3Y2M3G7tgUhSV5TNI4yJOTPYZuUTmZitJ6Uyxe4L2lV5egpkNUVog2oI1pwvvtAURoGAnJeDYeuLhLs2NytTvTorB9mP5aQAo6QDOC2q8q1Za x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec4126f1-3b98-4545-3dfe-08d766c10337 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2019 16:05:46.3898 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wxzbMZO29MsVaBgE+KGsReXeC+wvN4ZtNCwViAueVPII76ikMMBEtUdmU+c1vtutHXzrsXviDBsmSoLCXBwQUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5822 Subject: Re: [dpdk-dev] [PATCH v1] net/dpaa2: fixes issue of accidentally resetting rx offloads flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, November 11, 2019 9:27 PM > To: Sachin Saxena > Cc: dev@dpdk.org; ferruh.yigit@intel.com; stable@dpdk.org > Subject: Re: [PATCH v1] net/dpaa2: fixes issue of accidentally resetting = rx > offloads flags >=20 > 11/11/2019 16:36, Sachin Saxena: > > The JUMBO frame handling in dpaa2_dev_mtu_set api was not correct. > > When frame_size is greater than RTE_ETHER_MAX_LEN, the intention is to > > add JUMBO flag in rx offload while it was resetting all other flags > > other than JUMBO as AND operator was used instead of OR. >=20 > Hi, > About the title of this patch: > - "fixes" should be "fix" (infinitive verb) > - "issue" is not needed after "fix" > - we don't care whether it is "accidentally resetting" > You should just tell what is fixed and what is the case: > fix Rx offload flags on jumbo MTU set >=20 [Sachin Saxena] Thanks for information. I got your point.