DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue
@ 2019-09-10  7:30 Agalya Babu RadhaKrishnan
  2019-09-10  7:41 ` Babu Radhakrishnan, AgalyaX
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Agalya Babu RadhaKrishnan @ 2019-09-10  7:30 UTC (permalink / raw)
  To: dev
  Cc: reshma.pattan, hemant.agrawal, sachin.saxena,
	jananeex.m.parthasarathy, Agalya Babu RadhaKrishnan, stable

From: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>

1 issue caught by 344967
Leaked_storage: Variable sep going out of scope leaks the
storage it points to.

When 'sep' is not null and sep_exist is 0, 'sep' is freed
before going out of scope of the function irrespective of
'addr' exists or not.

Coverity Issue: 344967
Fixes: e67a61614d0b ("bus/fslmc: support device iteration")
Cc: stable@dpdk.org

Signed-off-by: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
---
 drivers/bus/fslmc/fslmc_bus.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index a2f482516..60c34098c 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -291,10 +291,13 @@ rte_fslmc_parse(const char *name, void *addr)
 		goto err_out;
 	}
 
-	if (addr)
+	if (addr) {
 		strcpy(addr, sep);
+		if (!sep_exists && sep)
+			free(sep);
+		return 0;
+	}
 
-	return 0;
 err_out:
 	if (!sep_exists && sep)
 		free(sep);
-- 
2.14.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-10-31 16:18 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-10  7:30 [dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue Agalya Babu RadhaKrishnan
2019-09-10  7:41 ` Babu Radhakrishnan, AgalyaX
2019-10-03  8:43   ` Sachin Saxena
2019-10-24 19:17     ` David Marchand
2019-10-31 11:16       ` Sachin Saxena
2019-10-03  8:40 ` Sachin Saxena
2019-10-31 16:18 ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).