DPDK patches and discussions
 help / color / mirror / Atom feed
From: Sachin Saxena <sachin.saxena@nxp.com>
To: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "reshma.pattan@intel.com" <reshma.pattan@intel.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	"jananeex.m.parthasarathy@intel.com"
	<jananeex.m.parthasarathy@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue
Date: Thu, 3 Oct 2019 08:40:02 +0000	[thread overview]
Message-ID: <VI1PR04MB4845FEC80072ED6DE80B3829E39F0@VI1PR04MB4845.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1568100655-20010-1-git-send-email-agalyax.babu.radhakrishnan@intel.com>

Acked-by: Sachin Saxena <sachin.saxena@nxp.com>

regards,
Sachin Saxena

> -----Original Message-----
> From: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
> Sent: Tuesday, September 10, 2019 1:01 PM
> To: dev@dpdk.org
> Cc: reshma.pattan@intel.com; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Sachin Saxena <sachin.saxena@nxp.com>;
> jananeex.m.parthasarathy@intel.com; Agalya Babu RadhaKrishnan
> <agalyax.babu.radhakrishnan@intel.com>; stable@dpdk.org
> Subject: [PATCH] bus/fslmc: fix for resource leak coverity issue
> Importance: High
> 
> From: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
> 
> 1 issue caught by 344967
> Leaked_storage: Variable sep going out of scope leaks the storage it points
> to.
> 
> When 'sep' is not null and sep_exist is 0, 'sep' is freed before going out of
> scope of the function irrespective of 'addr' exists or not.
> 
> Coverity Issue: 344967
> Fixes: e67a61614d0b ("bus/fslmc: support device iteration")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Agalya Babu RadhaKrishnan
> <agalyax.babu.radhakrishnan@intel.com>
> ---
>  drivers/bus/fslmc/fslmc_bus.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
> index a2f482516..60c34098c 100644
> --- a/drivers/bus/fslmc/fslmc_bus.c
> +++ b/drivers/bus/fslmc/fslmc_bus.c
> @@ -291,10 +291,13 @@ rte_fslmc_parse(const char *name, void *addr)
>  		goto err_out;
>  	}
> 
> -	if (addr)
> +	if (addr) {
>  		strcpy(addr, sep);
> +		if (!sep_exists && sep)
> +			free(sep);
> +		return 0;
> +	}
> 
> -	return 0;
>  err_out:
>  	if (!sep_exists && sep)
>  		free(sep);
> --
> 2.14.1


  parent reply	other threads:[~2019-10-03  8:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10  7:30 Agalya Babu RadhaKrishnan
2019-09-10  7:41 ` Babu Radhakrishnan, AgalyaX
2019-10-03  8:43   ` Sachin Saxena
2019-10-24 19:17     ` David Marchand
2019-10-31 11:16       ` Sachin Saxena
2019-10-03  8:40 ` Sachin Saxena [this message]
2019-10-31 16:18 ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB4845FEC80072ED6DE80B3829E39F0@VI1PR04MB4845.eurprd04.prod.outlook.com \
    --to=sachin.saxena@nxp.com \
    --cc=agalyax.babu.radhakrishnan@intel.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=jananeex.m.parthasarathy@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).