From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140041.outbound.protection.outlook.com [40.107.14.41]) by dpdk.org (Postfix) with ESMTP id A65271B419 for ; Tue, 16 Apr 2019 09:40:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a35+2csACnWZPQJEASAqUqbjjvPl6mc6pzKtg6yA7Yg=; b=VGMMCyKQ8pj1eW+CYADlCsKxx7nK+IP+zjslBKFAOMk2X4YYQCNSxZ4lI6990xhPYKbGZYrIsA3Ul5EqpRCPnG/wqkX/pDgvxlnSVgQLQeTP8ZUlQSt5lDLzHYIspr3JMTMZHzpAhj/tH4AMpNfnu7/S+8oGPZVHV5gKHZB2+wo= Received: from VI1PR04MB4893.eurprd04.prod.outlook.com (20.177.49.154) by VI1PR04MB3984.eurprd04.prod.outlook.com (10.171.182.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.19; Tue, 16 Apr 2019 07:40:03 +0000 Received: from VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7]) by VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7%3]) with mapi id 15.20.1792.018; Tue, 16 Apr 2019 07:40:03 +0000 From: Akhil Goyal To: "Trahe, Fiona" , Ayuj Verma , "Kusztal, ArkadiuszX" CC: "shallyv@marvell.com" , "ssahu@marvell.com" , "kkotamarthy@marvell.com" , "adesai@marvell.com" , "dev@dpdk.org" Thread-Topic: [PATCH v1] fix alphabetical ordering of headers Thread-Index: AdT0J3cZO8jfwYNvTVOtqMudxZdW/g== Date: Tue, 16 Apr 2019 07:40:03 +0000 Message-ID: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e1dbf55d-f135-4eb0-f1bc-08d6c23ebd00 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600140)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VI1PR04MB3984; x-ms-traffictypediagnostic: VI1PR04MB3984: x-microsoft-antispam-prvs: x-forefront-prvs: 000947967F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(396003)(39860400002)(136003)(346002)(189003)(199004)(7696005)(2906002)(14454004)(4744005)(6506007)(102836004)(486006)(105586002)(186003)(44832011)(14444005)(478600001)(476003)(106356001)(71200400001)(26005)(71190400001)(256004)(97736004)(4326008)(6436002)(3846002)(99286004)(54906003)(316002)(7736002)(305945005)(68736007)(33656002)(5660300002)(66066001)(229853002)(6116002)(110136005)(8676002)(8936002)(52536014)(9686003)(86362001)(25786009)(81156014)(6246003)(81166006)(74316002)(55016002)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB3984; H:VI1PR04MB4893.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: xrKDRfoKU80kyXC637SLpert06r34wd2KoHvvnI8zdIAzGTIHaj9KqUOzMtXIv4FrjKNPwZvDtg6si+8Q2VGKpAs1vvowA0+6Zc47HBQlYdMWolfelTjvdjEeHhT79q19SeeAPQhzSjv1uFpnm4tAUPtqJ02qv+Ht7CnUW8+mPNOcwCtCr0M26LzfzPiyTmn2KIPO/TQFhay/60FkglgMvkOgVr+wfRLgr53FTAeYUjYx7UE7j490uPTnSh8JfxttJuRx3B7oMyiNegg6PxHWwPNO20nStSZlphVBgqUKBQUJ7bn1uYWE7/HFyiw+Ag4zo6iE/DNnkN12J3JNJUcVIgCv5VjYuaZPHc1x3BrbsOgi5FariDO7tYamZeUI18EzLCvLKTgi/qKiHvspVDwn/oZhHYZpnZkODEprlqIduE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1dbf55d-f135-4eb0-f1bc-08d6c23ebd00 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2019 07:40:03.2469 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3984 Subject: Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2019 07:40:04 -0000 Hi Ayuj, > > rte_crypto_sym.h is included prior to rte_crypto_asym.h > > in rte_crypto.h, which breaks alphabetical order. > > > > include rte_crypto_sym.h in rte_crypto_asym.h fixes this. > [Fiona] I presume you tried just swapping the order and it broke? > If something in rte_crypto_asym.h depends on something from > rte_crypto_sym.h, it > probably shouldn't. What's the dependency and can/should it be moved to > rte_crypto.h? Could you please reply to Fiona's comment? Thanks, Akhil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1EBD6A00E6 for ; Tue, 16 Apr 2019 09:40:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 603B71B470; Tue, 16 Apr 2019 09:40:06 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140041.outbound.protection.outlook.com [40.107.14.41]) by dpdk.org (Postfix) with ESMTP id A65271B419 for ; Tue, 16 Apr 2019 09:40:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a35+2csACnWZPQJEASAqUqbjjvPl6mc6pzKtg6yA7Yg=; b=VGMMCyKQ8pj1eW+CYADlCsKxx7nK+IP+zjslBKFAOMk2X4YYQCNSxZ4lI6990xhPYKbGZYrIsA3Ul5EqpRCPnG/wqkX/pDgvxlnSVgQLQeTP8ZUlQSt5lDLzHYIspr3JMTMZHzpAhj/tH4AMpNfnu7/S+8oGPZVHV5gKHZB2+wo= Received: from VI1PR04MB4893.eurprd04.prod.outlook.com (20.177.49.154) by VI1PR04MB3984.eurprd04.prod.outlook.com (10.171.182.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.19; Tue, 16 Apr 2019 07:40:03 +0000 Received: from VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7]) by VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7%3]) with mapi id 15.20.1792.018; Tue, 16 Apr 2019 07:40:03 +0000 From: Akhil Goyal To: "Trahe, Fiona" , Ayuj Verma , "Kusztal, ArkadiuszX" CC: "shallyv@marvell.com" , "ssahu@marvell.com" , "kkotamarthy@marvell.com" , "adesai@marvell.com" , "dev@dpdk.org" Thread-Topic: [PATCH v1] fix alphabetical ordering of headers Thread-Index: AdT0J3cZO8jfwYNvTVOtqMudxZdW/g== Date: Tue, 16 Apr 2019 07:40:03 +0000 Message-ID: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e1dbf55d-f135-4eb0-f1bc-08d6c23ebd00 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600140)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VI1PR04MB3984; x-ms-traffictypediagnostic: VI1PR04MB3984: x-microsoft-antispam-prvs: x-forefront-prvs: 000947967F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(396003)(39860400002)(136003)(346002)(189003)(199004)(7696005)(2906002)(14454004)(4744005)(6506007)(102836004)(486006)(105586002)(186003)(44832011)(14444005)(478600001)(476003)(106356001)(71200400001)(26005)(71190400001)(256004)(97736004)(4326008)(6436002)(3846002)(99286004)(54906003)(316002)(7736002)(305945005)(68736007)(33656002)(5660300002)(66066001)(229853002)(6116002)(110136005)(8676002)(8936002)(52536014)(9686003)(86362001)(25786009)(81156014)(6246003)(81166006)(74316002)(55016002)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB3984; H:VI1PR04MB4893.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: xrKDRfoKU80kyXC637SLpert06r34wd2KoHvvnI8zdIAzGTIHaj9KqUOzMtXIv4FrjKNPwZvDtg6si+8Q2VGKpAs1vvowA0+6Zc47HBQlYdMWolfelTjvdjEeHhT79q19SeeAPQhzSjv1uFpnm4tAUPtqJ02qv+Ht7CnUW8+mPNOcwCtCr0M26LzfzPiyTmn2KIPO/TQFhay/60FkglgMvkOgVr+wfRLgr53FTAeYUjYx7UE7j490uPTnSh8JfxttJuRx3B7oMyiNegg6PxHWwPNO20nStSZlphVBgqUKBQUJ7bn1uYWE7/HFyiw+Ag4zo6iE/DNnkN12J3JNJUcVIgCv5VjYuaZPHc1x3BrbsOgi5FariDO7tYamZeUI18EzLCvLKTgi/qKiHvspVDwn/oZhHYZpnZkODEprlqIduE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1dbf55d-f135-4eb0-f1bc-08d6c23ebd00 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2019 07:40:03.2469 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3984 Subject: Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190416074003.nluzk2mNw8T3ZUsP9iJAUxmOl7MYg5YlxJFTmuBikq0@z> Hi Ayuj, > > rte_crypto_sym.h is included prior to rte_crypto_asym.h > > in rte_crypto.h, which breaks alphabetical order. > > > > include rte_crypto_sym.h in rte_crypto_asym.h fixes this. > [Fiona] I presume you tried just swapping the order and it broke? > If something in rte_crypto_asym.h depends on something from > rte_crypto_sym.h, it > probably shouldn't. What's the dependency and can/should it be moved to > rte_crypto.h? Could you please reply to Fiona's comment? Thanks, Akhil