From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150084.outbound.protection.outlook.com [40.107.15.84]) by dpdk.org (Postfix) with ESMTP id 3E7A41B20C; Mon, 22 Apr 2019 08:25:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hn/4HdPQCbQxG3xv2zzYbiLk0NiayMdX3uqO+Loy/Lk=; b=xEL7q8DdOhgZRWKPC+TS/XCsJFM7wiLOZXm91wgjSCQkB0TIr+tLQxQFTUVywYukNDOyzB5pBMHc2q+Uw2CBklNtuusRgklHmg2BUEApfwhcY5xmGff19BLC5Q3vdA/rK/PSqjPz3CjW4o1DvRJEABDa4YLcJlWmlDkqCvOvZjU= Received: from VI1PR04MB4893.eurprd04.prod.outlook.com (20.177.49.154) by VI1PR04MB5790.eurprd04.prod.outlook.com (20.178.127.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.16; Mon, 22 Apr 2019 06:25:22 +0000 Received: from VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7]) by VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7%3]) with mapi id 15.20.1813.017; Mon, 22 Apr 2019 06:25:22 +0000 From: Akhil Goyal To: "Iremonger, Bernard" , "dev@dpdk.org" , "Ananyev, Konstantin" CC: "stable@dpdk.org" Thread-Topic: [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto Thread-Index: AdT41A+tJGtpBFmpSYuowJ6OM0SgEA== Date: Mon, 22 Apr 2019 06:25:22 +0000 Message-ID: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b4b3e136-731f-4811-b4d5-08d6c6eb4c8b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VI1PR04MB5790; x-ms-traffictypediagnostic: VI1PR04MB5790: x-microsoft-antispam-prvs: x-forefront-prvs: 00159D1518 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(346002)(136003)(366004)(39860400002)(189003)(199004)(33656002)(7696005)(66066001)(2501003)(256004)(14444005)(44832011)(71200400001)(71190400001)(6246003)(25786009)(316002)(99286004)(9686003)(110136005)(102836004)(53936002)(4326008)(55016002)(6506007)(229853002)(52536014)(3846002)(476003)(6116002)(6436002)(2906002)(86362001)(7736002)(486006)(74316002)(305945005)(8676002)(186003)(81156014)(26005)(64756008)(478600001)(66556008)(66446008)(8936002)(68736007)(81166006)(14454004)(73956011)(66946007)(76116006)(97736004)(66476007)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5790; H:VI1PR04MB4893.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 7eAqUBnf4W/LVIYLO6InEQDxZFh3VZ83jgadPlqSzC1i7ttARRJ019hVtZT73VrND+uBOUC0xLikA/c3B/j9l7YZFxlLi5N7/hwZmBnu+aCwU+cyT4hSv65xm8VlKVE2q8P+4x+1BRlsDvgF3Ibkw8KkiJXtg6PkzdFB18pG0rR52EUv/zjwvpHh9kl/onLIQt4CALibmGu/C3T2Z8Rj52t3W0jZsoTyeV4v6Wlayz/oihZccW0sE2VH6wCULt8OuQRdXFGgWvFb/70Bc2Z8+9F271hNdv8AtdF6QfjPbIbZdkKgkPRLsMfain4ZfjcJIO0DjNpcC/3bac673L1oZ6aXTC64c/IaKho7xnZCF4X3jO2PihMSWuTlln3Ul5p6KPh4GBRSs/Z+wG7PZrG2jl4z/h/wCxxm6hoh8LhIDvc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4b3e136-731f-4811-b4d5-08d6c6eb4c8b X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2019 06:25:22.2451 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5790 Subject: Re: [dpdk-dev] [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2019 06:25:23 -0000 Hi Bernard, >=20 > Hi Akhil, >=20 > >=20 > > Subject: RE: [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet droppe= d > > for inline crypto >=20 > > > > + if (sa->type =3D=3D > > RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL) { > > > + ctx =3D (struct rte_security_ctx *) > > > + rte_eth_dev_get_sec_ctx(sa->portid); > > > > This is breaking the lookaside mode. Ctx was retrieved using the ipsec_= ctx- > > >tbl struct rte_security_ctx *ctx =3D (struct rte_security_ctx *) > > rte_cryptodev_get_sec_ctx( > > ipsec_ctx->tbl[cdev_id_qp].id); > > > > I am looking into it, but I don't have time left to get it integrated i= n RC2. So > > this has to be pushed to RC3 >=20 > >=20 > Unfortunately we do not have the HW to test this feature. > What HW are you using to test this? >=20 > Having looked at the code previously > ipsec_ctx->tbl[cdev_id_qp].id turned out to be the port_id. >=20 > So we had expected it to work. >=20 > We will need your help with this. I am looking into this. Will let you know when I get the fix. >=20 > Regards, >=20 > Bernard. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C779BA05D3 for ; Mon, 22 Apr 2019 08:25:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 972101B4A4; Mon, 22 Apr 2019 08:25:24 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150084.outbound.protection.outlook.com [40.107.15.84]) by dpdk.org (Postfix) with ESMTP id 3E7A41B20C; Mon, 22 Apr 2019 08:25:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hn/4HdPQCbQxG3xv2zzYbiLk0NiayMdX3uqO+Loy/Lk=; b=xEL7q8DdOhgZRWKPC+TS/XCsJFM7wiLOZXm91wgjSCQkB0TIr+tLQxQFTUVywYukNDOyzB5pBMHc2q+Uw2CBklNtuusRgklHmg2BUEApfwhcY5xmGff19BLC5Q3vdA/rK/PSqjPz3CjW4o1DvRJEABDa4YLcJlWmlDkqCvOvZjU= Received: from VI1PR04MB4893.eurprd04.prod.outlook.com (20.177.49.154) by VI1PR04MB5790.eurprd04.prod.outlook.com (20.178.127.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.16; Mon, 22 Apr 2019 06:25:22 +0000 Received: from VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7]) by VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7%3]) with mapi id 15.20.1813.017; Mon, 22 Apr 2019 06:25:22 +0000 From: Akhil Goyal To: "Iremonger, Bernard" , "dev@dpdk.org" , "Ananyev, Konstantin" CC: "stable@dpdk.org" Thread-Topic: [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto Thread-Index: AdT41A+tJGtpBFmpSYuowJ6OM0SgEA== Date: Mon, 22 Apr 2019 06:25:22 +0000 Message-ID: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b4b3e136-731f-4811-b4d5-08d6c6eb4c8b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VI1PR04MB5790; x-ms-traffictypediagnostic: VI1PR04MB5790: x-microsoft-antispam-prvs: x-forefront-prvs: 00159D1518 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(346002)(136003)(366004)(39860400002)(189003)(199004)(33656002)(7696005)(66066001)(2501003)(256004)(14444005)(44832011)(71200400001)(71190400001)(6246003)(25786009)(316002)(99286004)(9686003)(110136005)(102836004)(53936002)(4326008)(55016002)(6506007)(229853002)(52536014)(3846002)(476003)(6116002)(6436002)(2906002)(86362001)(7736002)(486006)(74316002)(305945005)(8676002)(186003)(81156014)(26005)(64756008)(478600001)(66556008)(66446008)(8936002)(68736007)(81166006)(14454004)(73956011)(66946007)(76116006)(97736004)(66476007)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5790; H:VI1PR04MB4893.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 7eAqUBnf4W/LVIYLO6InEQDxZFh3VZ83jgadPlqSzC1i7ttARRJ019hVtZT73VrND+uBOUC0xLikA/c3B/j9l7YZFxlLi5N7/hwZmBnu+aCwU+cyT4hSv65xm8VlKVE2q8P+4x+1BRlsDvgF3Ibkw8KkiJXtg6PkzdFB18pG0rR52EUv/zjwvpHh9kl/onLIQt4CALibmGu/C3T2Z8Rj52t3W0jZsoTyeV4v6Wlayz/oihZccW0sE2VH6wCULt8OuQRdXFGgWvFb/70Bc2Z8+9F271hNdv8AtdF6QfjPbIbZdkKgkPRLsMfain4ZfjcJIO0DjNpcC/3bac673L1oZ6aXTC64c/IaKho7xnZCF4X3jO2PihMSWuTlln3Ul5p6KPh4GBRSs/Z+wG7PZrG2jl4z/h/wCxxm6hoh8LhIDvc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4b3e136-731f-4811-b4d5-08d6c6eb4c8b X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2019 06:25:22.2451 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5790 Subject: Re: [dpdk-dev] [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190422062522.iX-VUM6IyZAdQeu7vlPpkj1p1QDZlJZYsJcz04IHj-M@z> Hi Bernard, >=20 > Hi Akhil, >=20 > >=20 > > Subject: RE: [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet droppe= d > > for inline crypto >=20 > > > > + if (sa->type =3D=3D > > RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL) { > > > + ctx =3D (struct rte_security_ctx *) > > > + rte_eth_dev_get_sec_ctx(sa->portid); > > > > This is breaking the lookaside mode. Ctx was retrieved using the ipsec_= ctx- > > >tbl struct rte_security_ctx *ctx =3D (struct rte_security_ctx *) > > rte_cryptodev_get_sec_ctx( > > ipsec_ctx->tbl[cdev_id_qp].id); > > > > I am looking into it, but I don't have time left to get it integrated i= n RC2. So > > this has to be pushed to RC3 >=20 > >=20 > Unfortunately we do not have the HW to test this feature. > What HW are you using to test this? >=20 > Having looked at the code previously > ipsec_ctx->tbl[cdev_id_qp].id turned out to be the port_id. >=20 > So we had expected it to work. >=20 > We will need your help with this. I am looking into this. Will let you know when I get the fix. >=20 > Regards, >=20 > Bernard.