From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50081.outbound.protection.outlook.com [40.107.5.81]) by dpdk.org (Postfix) with ESMTP id E5DE61B4E9; Tue, 16 Apr 2019 17:00:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=85d4IxrO7V0hSsyfjrgPbBozmJBWN2xxHFrkiaHDhIk=; b=wsPm8cb2wxub469vWw/eUQeIn+7SlHj0kENM2spjmOtqOY9s/IA5+WKtzMM0eZnxqyfADpG/hjUS4mlfLMbr7x34LgLYG2+cuKbwgIywL6mJtldmI65QDG2aGgpWBa4kV9ruGcpVQoFw5JZJTZZ+pfZIfP/utMoRYSgbTDD35vo= Received: from VI1PR04MB4893.eurprd04.prod.outlook.com (20.177.49.154) by VI1PR04MB4335.eurprd04.prod.outlook.com (52.134.122.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.19; Tue, 16 Apr 2019 15:00:22 +0000 Received: from VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7]) by VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7%3]) with mapi id 15.20.1792.018; Tue, 16 Apr 2019 15:00:22 +0000 From: Akhil Goyal To: Bruce Richardson , "dev@dpdk.org" CC: "stable@dpdk.org" , Declan Doherty , Fan Zhang Thread-Topic: [dpdk-dev] [PATCH] app/test-crypto-perf: fix missing bounds check on socket id Thread-Index: AQHU7e0D58JIUPap3ESls9ce5ZQBd6Y+2naggAATziA= Date: Tue, 16 Apr 2019 15:00:22 +0000 Message-ID: References: <20190408092514.36330-1-bruce.richardson@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f640f6be-9792-4410-f25e-08d6c27c4009 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600140)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VI1PR04MB4335; x-ms-traffictypediagnostic: VI1PR04MB4335: x-microsoft-antispam-prvs: x-forefront-prvs: 000947967F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(39860400002)(346002)(136003)(366004)(199004)(189003)(25786009)(446003)(476003)(7696005)(99286004)(14454004)(3846002)(86362001)(5660300002)(6246003)(53936002)(4326008)(229853002)(6116002)(97736004)(2906002)(11346002)(44832011)(6436002)(76176011)(110136005)(54906003)(316002)(52536014)(2940100002)(68736007)(2501003)(6506007)(81166006)(26005)(71190400001)(71200400001)(81156014)(8936002)(66066001)(256004)(186003)(93156006)(74316002)(33656002)(55016002)(305945005)(486006)(105586002)(4744005)(102836004)(478600001)(9686003)(7736002)(106356001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB4335; H:VI1PR04MB4893.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: WsJRn+ZXp0IfuGvSH+g257MPo8pXrD7ikMzCaZ7Gv7XJ38y8wO/rjOF96I/JLzj0hWTqRzwoPseoc2aD5MxRHYbRkICaBdgUQvMGMoH1s94qMkDwyQpNh5aLtw+U7luS3+0VyY3Z4HxImzQaBgGC4bkwpHrAuebVB27yFBidYNzEEb8942JRP00DhIu/ioBfK3Xjj5wOKfErh4me4psAOc8Swtm030wzEcT7OfBCEGyEiY7AemZFL1P7ErqKgfmJ/1huwObrPkIzJCuVLR3KH6MuYkk2oLP29onQnk/JPo/OCz4N+pJmaEOSbjEsabi2SASM5LCANhXOQM6zdzDkYS6Be7Aei7q2MOXUTdUcV/7nFOC6tqaOXvoA06stZ6XI1GaNYDDan+7GqcaqQpeKH9ZdHxcmXOOtmJ1ZiktlqmE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f640f6be-9792-4410-f25e-08d6c27c4009 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2019 15:00:22.3959 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4335 Subject: Re: [dpdk-dev] [PATCH] app/test-crypto-perf: fix missing bounds check on socket id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2019 15:00:24 -0000 > > The socket_id is used as an array index so should be within the range > > of zero to max numa nodes. Add a range check to ensure we don't get > > excessive values. > > > > Coverity issue: 336812 > > Coverity issue: 336829 > > Fixes: 2c59bd32b70d ("cryptodev: do not create session mempool internal= ly") > > CC: stable@dpdk.org > > CC: Declan Doherty > > CC: Fan Zhang > > > > Signed-off-by: Bruce Richardson >=20 > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 08F5FA00E6 for ; Tue, 16 Apr 2019 17:00:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AE5561B4F6; Tue, 16 Apr 2019 17:00:25 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50081.outbound.protection.outlook.com [40.107.5.81]) by dpdk.org (Postfix) with ESMTP id E5DE61B4E9; Tue, 16 Apr 2019 17:00:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=85d4IxrO7V0hSsyfjrgPbBozmJBWN2xxHFrkiaHDhIk=; b=wsPm8cb2wxub469vWw/eUQeIn+7SlHj0kENM2spjmOtqOY9s/IA5+WKtzMM0eZnxqyfADpG/hjUS4mlfLMbr7x34LgLYG2+cuKbwgIywL6mJtldmI65QDG2aGgpWBa4kV9ruGcpVQoFw5JZJTZZ+pfZIfP/utMoRYSgbTDD35vo= Received: from VI1PR04MB4893.eurprd04.prod.outlook.com (20.177.49.154) by VI1PR04MB4335.eurprd04.prod.outlook.com (52.134.122.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.19; Tue, 16 Apr 2019 15:00:22 +0000 Received: from VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7]) by VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7%3]) with mapi id 15.20.1792.018; Tue, 16 Apr 2019 15:00:22 +0000 From: Akhil Goyal To: Bruce Richardson , "dev@dpdk.org" CC: "stable@dpdk.org" , Declan Doherty , Fan Zhang Thread-Topic: [dpdk-dev] [PATCH] app/test-crypto-perf: fix missing bounds check on socket id Thread-Index: AQHU7e0D58JIUPap3ESls9ce5ZQBd6Y+2naggAATziA= Date: Tue, 16 Apr 2019 15:00:22 +0000 Message-ID: References: <20190408092514.36330-1-bruce.richardson@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f640f6be-9792-4410-f25e-08d6c27c4009 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600140)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VI1PR04MB4335; x-ms-traffictypediagnostic: VI1PR04MB4335: x-microsoft-antispam-prvs: x-forefront-prvs: 000947967F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(39860400002)(346002)(136003)(366004)(199004)(189003)(25786009)(446003)(476003)(7696005)(99286004)(14454004)(3846002)(86362001)(5660300002)(6246003)(53936002)(4326008)(229853002)(6116002)(97736004)(2906002)(11346002)(44832011)(6436002)(76176011)(110136005)(54906003)(316002)(52536014)(2940100002)(68736007)(2501003)(6506007)(81166006)(26005)(71190400001)(71200400001)(81156014)(8936002)(66066001)(256004)(186003)(93156006)(74316002)(33656002)(55016002)(305945005)(486006)(105586002)(4744005)(102836004)(478600001)(9686003)(7736002)(106356001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB4335; H:VI1PR04MB4893.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: WsJRn+ZXp0IfuGvSH+g257MPo8pXrD7ikMzCaZ7Gv7XJ38y8wO/rjOF96I/JLzj0hWTqRzwoPseoc2aD5MxRHYbRkICaBdgUQvMGMoH1s94qMkDwyQpNh5aLtw+U7luS3+0VyY3Z4HxImzQaBgGC4bkwpHrAuebVB27yFBidYNzEEb8942JRP00DhIu/ioBfK3Xjj5wOKfErh4me4psAOc8Swtm030wzEcT7OfBCEGyEiY7AemZFL1P7ErqKgfmJ/1huwObrPkIzJCuVLR3KH6MuYkk2oLP29onQnk/JPo/OCz4N+pJmaEOSbjEsabi2SASM5LCANhXOQM6zdzDkYS6Be7Aei7q2MOXUTdUcV/7nFOC6tqaOXvoA06stZ6XI1GaNYDDan+7GqcaqQpeKH9ZdHxcmXOOtmJ1ZiktlqmE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f640f6be-9792-4410-f25e-08d6c27c4009 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2019 15:00:22.3959 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4335 Subject: Re: [dpdk-dev] [PATCH] app/test-crypto-perf: fix missing bounds check on socket id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190416150022.GGbvIB219aVhi_EBxzj-0-F6otMqstACruHSnC7N0hI@z> > > The socket_id is used as an array index so should be within the range > > of zero to max numa nodes. Add a range check to ensure we don't get > > excessive values. > > > > Coverity issue: 336812 > > Coverity issue: 336829 > > Fixes: 2c59bd32b70d ("cryptodev: do not create session mempool internal= ly") > > CC: stable@dpdk.org > > CC: Declan Doherty > > CC: Fan Zhang > > > > Signed-off-by: Bruce Richardson >=20 > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.