From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0068.outbound.protection.outlook.com [104.47.2.68]) by dpdk.org (Postfix) with ESMTP id D80071C9A1 for ; Sun, 13 May 2018 09:47:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=cEEN7uABZYDKajU967+RojsSJ0zu9gUBCW7AGcJ284o=; b=ZHzP9+igBBa1FUj04jupBKo2ln3aOh8KQ2NHGqHFzfXRG6YRRBjGQ4wz4Q3VPXztKSL5fIJaicHaPGxDsBSZ6Hsz/TJmxvfR97oQ8H99T0wT+HO1QDCJxaHnvB7bxAEetowwJt389hcsVAAMepi3l7d+Veb5gDl7WESi00ajpfk= Received: from VI1PR0501MB2608.eurprd05.prod.outlook.com (10.168.137.20) by VI1PR0501MB2159.eurprd05.prod.outlook.com (10.167.196.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Sun, 13 May 2018 07:47:07 +0000 Received: from VI1PR0501MB2608.eurprd05.prod.outlook.com ([fe80::49ca:b540:8f36:c063]) by VI1PR0501MB2608.eurprd05.prod.outlook.com ([fe80::49ca:b540:8f36:c063%17]) with mapi id 15.20.0755.018; Sun, 13 May 2018 07:47:07 +0000 From: Matan Azrad To: Andy Green , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v5 13/16] net/vdev_netvsc: 3 x strncpy misuse Thread-Index: AQHT6ZOPwMtUjox+JU6nCkNq8hN76KQtRhcQ Date: Sun, 13 May 2018 07:47:07 +0000 Message-ID: References: <152608956198.121204.14844325841690943774.stgit@localhost.localdomain> <152608972963.121204.10182569039129005823.stgit@localhost.localdomain> In-Reply-To: <152608972963.121204.10182569039129005823.stgit@localhost.localdomain> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2159; 7:VR2xSXea84c5zUTmYu1S1Y8sKkuCtZFUY+9WMIDVrk8t0g6n0R9n3Pa9cFRXm5EBFuS+hVk2yTlzHhkSi9Vb8eajCwrSOhUpznjkOOWS9eQl4tiuclINxA/szkvUbpo16zKuFZLYas7ZEgmfkY/Cmq5YYl5OsHv2qMJfdA6mo9SWuPtnY6T+j2JouTtZcSzOSV8mdQYkk+Nm4xwalmx7oYs3lpT57JxqvQ8r2EkcOgwQ9c9HzpotcA8pAqUMbflx x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2159; x-ms-traffictypediagnostic: VI1PR0501MB2159: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:VI1PR0501MB2159; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2159; x-forefront-prvs: 0671F32598 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39380400002)(376002)(39860400002)(346002)(396003)(199004)(189003)(97736004)(99286004)(3280700002)(66066001)(2906002)(486006)(3660700001)(11346002)(74316002)(14454004)(2501003)(55016002)(7696005)(476003)(478600001)(5660300001)(5250100002)(86362001)(76176011)(68736007)(105586002)(6506007)(8936002)(53936002)(110136005)(106356001)(81166006)(25786009)(229853002)(6436002)(305945005)(316002)(7736002)(81156014)(6116002)(3846002)(26005)(446003)(9686003)(102836004)(186003)(59450400001)(6246003)(33656002)(2900100001)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2159; H:VI1PR0501MB2608.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: zp83fOP8t7r1GvDhwr1TRr+7+6xyPyp3Uqoc1V+ne13oJPIxPwv+mEY8ktaeZQcK1z246EXrD8S/J+1fGexaLddfdWkiU4pKnA8EcjoPu8jVBwWWSK5q9xOhsx7uYBtogydwRrAytwkUsKRWuGTUDE1mcDPgTTYQzfE3G/ejQ4qhAD6qFEaUecQAI4/Wd4br spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 89469357-61a8-4e35-b92d-08d5b8a5ba09 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89469357-61a8-4e35-b92d-08d5b8a5ba09 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2018 07:47:07.2013 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2159 Subject: Re: [dpdk-dev] [PATCH v5 13/16] net/vdev_netvsc: 3 x strncpy misuse X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 May 2018 07:47:10 -0000 SGkgQW5keQ0KDQpGcm9tOiBBbmR5IEdyZWVuDQo+IFNpZ25lZC1vZmYtYnk6IEFuZHkgR3JlZW4g PGFuZHlAd2FybWNhdC5jb20+DQo+IEZpeGVzOiBlN2RjNWQ3YmVjYzUgKCJuZXQvdmRldl9uZXR2 c2M6IGltcGxlbWVudCBjb3JlIGZ1bmN0aW9uYWxpdHkiKQ0KPiBDYzogc3RhYmxlQGRwZGsub3Jn DQoNCk5vIG5lZWQgdGhlIGZpeCBsaW5lLCBpdCBpcyBqdXN0IGNvbnZlcnNpb24uDQoNCkFjdHVh bGx5IHRoZSBzdHJsY3B5IHdhcyBpbnRyb2R1Y2VkIGxhdGVyIGFuZCB0aGUgbmV4dCBjb21taXQg c2hvdWxkIGhhdmUgaXQ6DQpjMDIyY2I0MDBlOTIgKCJjb252ZXJ0IHNucHJpbnRmIHRvIHN0cmxj cHkiKQ0KDQp3aGljaCBjYW1lIGFmdGVyIHRoZSB2ZGV2X25ldHZzYyBkcml2ZXIgaGFkIGJlZW4g aW50cm9kdWNlZC4NCg0KVGhlIHRpdGxlIGNhbiBiZSBhcyBhYm92ZTsNCm5ldC92ZGV2X25ldHZz YzogY29udmVydCBzbnByaW50ZiB0byBzdHJsY3B5DQoNClRoZSBib2R5IGNvdWxkIGJlOg0KDQpD b250aW51ZSBzbnByaW50ZiB0byBzdHJsY3B5IGNvbnZlcnNpb25zIHN0YXJ0ZWQgYnkgY29tbWl0 IGMwMjJjYjQwMGU5MiAoImNvbnZlcnQgc25wcmludGYgdG8gc3RybGNweSIpLg0KDQo+IEFja2Vk LWJ5OiBQYWJsbyBkZSBMYXJhIDxwYWJsby5kZS5sYXJhLmd1YXJjaEBpbnRlbC5jb20+DQo+IC0t LQ0KPiAgZHJpdmVycy9uZXQvdmRldl9uZXR2c2MvdmRldl9uZXR2c2MuYyB8ICAgIDcgKysrKy0t LQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkNCj4g DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC92ZGV2X25ldHZzYy92ZGV2X25ldHZzYy5jDQo+ IGIvZHJpdmVycy9uZXQvdmRldl9uZXR2c2MvdmRldl9uZXR2c2MuYw0KPiBpbmRleCBkY2EyNTc2 MWQuLmYxZDAzNjE1MiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9uZXQvdmRldl9uZXR2c2MvdmRl dl9uZXR2c2MuYw0KPiArKysgYi9kcml2ZXJzL25ldC92ZGV2X25ldHZzYy92ZGV2X25ldHZzYy5j DQo+IEBAIC0zNSw2ICszNSw3IEBADQo+ICAjaW5jbHVkZSA8cnRlX2h5cGVydmlzb3IuaD4NCj4g ICNpbmNsdWRlIDxydGVfa3ZhcmdzLmg+DQo+ICAjaW5jbHVkZSA8cnRlX2xvZy5oPg0KPiArI2lu Y2x1ZGUgPHJ0ZV9zdHJpbmdfZm5zLmg+DQo+IA0KPiAgI2RlZmluZSBWREVWX05FVFZTQ19EUklW RVIgbmV0X3ZkZXZfbmV0dnNjICAjZGVmaW5lDQo+IFZERVZfTkVUVlNDX0RSSVZFUl9OQU1FIFJU RV9TVFIoVkRFVl9ORVRWU0NfRFJJVkVSKSBAQCAtMTgyLDcNCj4gKzE4Myw3IEBAIHZkZXZfbmV0 dnNjX2ZvcmVhY2hfaWZhY2UoaW50ICgqZnVuYykoY29uc3Qgc3RydWN0IGlmX25hbWVpbmRleA0K PiAqaWZhY2UsDQo+ICAJCWlzX25ldHZzY19yZXQgPSB2ZGV2X25ldHZzY19pZmFjZV9pc19uZXR2 c2MoJmlmYWNlW2ldKSA/IDEgOiAwOw0KPiAgCQlpZiAoaXNfbmV0dnNjIF4gaXNfbmV0dnNjX3Jl dCkNCj4gIAkJCWNvbnRpbnVlOw0KPiAtCQlzdHJuY3B5KHJlcS5pZnJfbmFtZSwgaWZhY2VbaV0u aWZfbmFtZSwgc2l6ZW9mKHJlcS5pZnJfbmFtZSkpOw0KPiArCQlzdHJsY3B5KHJlcS5pZnJfbmFt ZSwgaWZhY2VbaV0uaWZfbmFtZSwgc2l6ZW9mKHJlcS5pZnJfbmFtZSkpOw0KPiAgCQlpZiAoaW9j dGwocywgU0lPQ0dJRkhXQUREUiwgJnJlcSkgPT0gLTEpIHsNCj4gIAkJCURSVl9MT0coV0FSTklO RywgImNhbm5vdCByZXRyaWV2ZSBpbmZvcm1hdGlvbg0KPiBhYm91dCINCj4gIAkJCQkJICIgaW50 ZXJmYWNlIFwiJXNcIjogJXMiLA0KPiBAQCAtMzg0LDcgKzM4NSw3IEBAIHZkZXZfbmV0dnNjX2Rl dmljZV9wcm9iZShjb25zdCBzdHJ1Y3QgaWZfbmFtZWluZGV4DQo+ICppZmFjZSwNCj4gIAkJRFJW X0xPRyhERUJVRywNCj4gIAkJCSJOZXRWU0MgaW50ZXJmYWNlIFwiJXNcIiAoaW5kZXggJXUpIHJl bmFtZWQgXCIlc1wiIiwNCj4gIAkJCWN0eC0+aWZfbmFtZSwgY3R4LT5pZl9pbmRleCwgaWZhY2Ut PmlmX25hbWUpOw0KPiAtCQlzdHJuY3B5KGN0eC0+aWZfbmFtZSwgaWZhY2UtPmlmX25hbWUsIHNp emVvZihjdHgtPmlmX25hbWUpKTsNCj4gKwkJc3RybGNweShjdHgtPmlmX25hbWUsIGlmYWNlLT5p Zl9uYW1lLCBzaXplb2YoY3R4LT5pZl9uYW1lKSk7DQo+ICAJCXJldHVybiAwOw0KPiAgCX0NCj4g IAlpZiAoIWlzX3NhbWVfZXRoZXJfYWRkcihldGhfYWRkciwgJmN0eC0+aWZfYWRkcikpIEBAIC01 ODIsNyArNTgzLDcNCj4gQEAgdmRldl9uZXR2c2NfbmV0dnNjX3Byb2JlKGNvbnN0IHN0cnVjdCBp Zl9uYW1laW5kZXggKmlmYWNlLA0KPiAgCQlnb3RvIGVycm9yOw0KPiAgCX0NCj4gIAljdHgtPmlk ID0gdmRldl9uZXR2c2NfY3R4X2NvdW50Ow0KPiAtCXN0cm5jcHkoY3R4LT5pZl9uYW1lLCBpZmFj ZS0+aWZfbmFtZSwgc2l6ZW9mKGN0eC0+aWZfbmFtZSkpOw0KPiArCXN0cmxjcHkoY3R4LT5pZl9u YW1lLCBpZmFjZS0+aWZfbmFtZSwgc2l6ZW9mKGN0eC0+aWZfbmFtZSkpOw0KPiAgCWN0eC0+aWZf aW5kZXggPSBpZmFjZS0+aWZfaW5kZXg7DQo+ICAJY3R4LT5pZl9hZGRyID0gKmV0aF9hZGRyOw0K PiAgCWN0eC0+cGlwZVswXSA9IC0xOw0KDQo=