From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40073.outbound.protection.outlook.com [40.107.4.73]) by dpdk.org (Postfix) with ESMTP id 69CDF34F3 for ; Tue, 13 Nov 2018 19:04:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n3Vn0C4tVl5mxkr1fvM2kIGqNRe7OmAU1D0JvJDXigU=; b=xbjHn5gRgax59HtmZ9f2f08Nl21e3KTravivfvytTZPAMtz1R0xLEeHPXfigxVoaIFTQVwId3dmmA+afUo+ezw02K/XggDt7qhr4bhTHuGBcZQBgYOHzYgwp0wqqLCQd1ETOr02apNlhrBPl9xI/xWDZScVllqQ3ptqJ0/9mTOs= Received: from VI1PR0502MB3743.eurprd05.prod.outlook.com (52.134.8.154) by VI1PR0502MB2925.eurprd05.prod.outlook.com (10.175.24.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.21; Tue, 13 Nov 2018 18:04:38 +0000 Received: from VI1PR0502MB3743.eurprd05.prod.outlook.com ([fe80::84d3:8812:d45c:98e4]) by VI1PR0502MB3743.eurprd05.prod.outlook.com ([fe80::84d3:8812:d45c:98e4%4]) with mapi id 15.20.1294.045; Tue, 13 Nov 2018 18:04:38 +0000 From: Ophir Munk To: Adrien Mazarguil , Ori Kam CC: Yongseok Koh , Andrew Rybchenko , Ferruh Yigit , "dev@dpdk.org" , Thomas Monjalon , Asaf Penso , Shahaf Shuler , Olga Shern Thread-Topic: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types Thread-Index: AQHUdnuTE9UKU0bjB02/QczzO0OvtKVEDEOAgAAxJTCAABurAIAADKLwgAAevoCAAQ4DkIAA8DCAgACWZaCAAz25AIADpSyAgAALOIA= Date: Tue, 13 Nov 2018 18:04:38 +0000 Message-ID: References: <1541582611-1609-1-git-send-email-ophirmu@mellanox.com> <20181107093109.GG4638@6wind.com> <20181107140604.GL4638@6wind.com> <20181107164118.GM4638@6wind.com> <20181113171519.GF17131@6wind.com> In-Reply-To: <20181113171519.GF17131@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0502MB2925; 6:N9pfSHlzQkwiADBb4QiQ6mrTDLN+72xZXLaFOT0qgMvXOfe+lVHBVEZwiSBMu7e1FOU8j+MYy67KdGy9Hhu94pPB0EwmiLLq+OEXnZE0IEKATvZBnY7bIfhLY0mvfrRuBVx4C5kmLA8RE52nc4yoLQY8XItq2Dnq8PJvdFuEHXbWRKRc42vax9jFwaZQR+eETJRGw5dfGpeNJ7x9on7QN9QSJ/G+ElXRr8pAMJFqrggeSLshflgqsulyirfRViRQY6N9Rss99wOwlHsrhi+ZR0Vt9xCe4O5epZL3s3xr1m+X5ZBiI56tIGkCJiGGVUWu0gwOQJLmhaGhAb/HcK8NYJKbA35/FRuKnH7BWY0UIE2vz6C5t5e5Te7atiyEunUtcMg9QJD4Hb9lkIJvnzUGBXb13kjzLM2r8ASiWV8hRSpXb8bOCiP85+h+OQGOwQd6pdb4YNs463ORGAsihZFC9w==; 5:mb+qTGq0wSd16S3/rqbXOqCDydg0YndPHgTZHOUZTajtn7zdzJxQzqNk24I7XwzRbXb6ayjCJerl5QU/oSs+HwOq2njIWKXk8O0YFGm1RBvor+2+MeGL8fbVyxgJu0D1Hr/Q/sNMrFWFkoJ9mZnk0HzNLqUD+vwPypyrp82NlNI=; 7:4X1IICXWzTdQynMFwlQBYYz+Eqw0ayrHhIWMbleVWgmoBSCVh37Ju9A+87QTAUuRgHEkCBK2V103oYJp2++TrA5y6eKzOUBO7Y0e61dry13/WJr8TIzsJQNd1AXwAE9SWgiKGNiZ7ynWyeQgWLRzQA== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 46892592-1611-40f5-6e7c-08d649927a49 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390060)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0502MB2925; x-ms-traffictypediagnostic: VI1PR0502MB2925: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(278428928389397)(45079756050767)(189930954265078)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231382)(944501410)(52105112)(3002001)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:VI1PR0502MB2925; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0502MB2925; x-forefront-prvs: 085551F5A8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(376002)(39860400002)(346002)(396003)(189003)(199004)(13464003)(86362001)(33656002)(575784001)(71200400001)(71190400001)(6246003)(107886003)(256004)(99286004)(7736002)(7696005)(74316002)(66066001)(4326008)(45080400002)(105586002)(106356001)(2906002)(76176011)(11346002)(2900100001)(486006)(6436002)(476003)(446003)(229853002)(26005)(6306002)(966005)(102836004)(9686003)(6116002)(14454004)(3846002)(6636002)(93886005)(68736007)(6506007)(110136005)(54906003)(53936002)(186003)(97736004)(53546011)(55016002)(8676002)(25786009)(5660300001)(8936002)(305945005)(81166006)(316002)(81156014)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0502MB2925; H:VI1PR0502MB3743.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 6aW7ifSGAuHRsOVxzvxsDupcs2oxdra25cdAIa4BR1fnWR9kFITc0eH0NnRPZ9UuXIdM1Vj7VQSnLtysjFqct9XCBlojYde/HjRC7iHMQDKfDn2djQPjET4nVkOhdfkDnnbw88R8n1hdnl541jXsKwfzlC8FPWJaNi1UBopfJVQGzuXfB+H+AeJuyNxDEIJiH26l69bLZ6G09ugCELJGMVBOy0qLpVdFtYzydDgFmpGUDCIilHG1eI//omcA3RZQMK1PJLwXts1xy6DynMvIwjKK9s7F6xiPAv/DWNeHjPHUroWWS+tJ1ceAPvSmCEc7x0qb1QKOrLZsAtvDnudivUFaRwYgNv616EXCrRNwlao= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46892592-1611-40f5-6e7c-08d649927a49 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2018 18:04:38.3783 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB2925 Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 18:04:41 -0000 > -----Original Message----- > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > Sent: Tuesday, November 13, 2018 7:15 PM > To: Ori Kam > Cc: Ophir Munk ; Yongseok Koh > ; Andrew Rybchenko > ; Ferruh Yigit ; > dev@dpdk.org; Thomas Monjalon ; Asaf Penso > ; Shahaf Shuler ; Olga > Shern > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and > types >=20 > Again a bit late to the party, please see below. >=20 > On Sun, Nov 11, 2018 at 09:35:22AM +0000, Ori Kam wrote: > > > -----Original Message----- > > > From: dev On Behalf Of Ophir Munk > > > Sent: Friday, November 9, 2018 10:14 AM > > > To: Yongseok Koh ; Adrien Mazarguil > > > ; Andrew Rybchenko > > > > > > Cc: Ferruh Yigit ; dev@dpdk.org; Thomas > > > Monjalon ; Asaf Penso ; > > > Shahaf Shuler ; Olga Shern > > > > > > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key > > > and types > > > > > > > -----Original Message----- > > > > From: Yongseok Koh > > > > Sent: Friday, November 09, 2018 1:07 AM > > > > To: Ophir Munk ; Adrien Mazarguil > > > > ; Andrew Rybchenko > > > > > > > > Cc: Ferruh Yigit ; dev@dpdk.org; Thomas > > > > Monjalon ; Asaf Penso > ; > > > > Shahaf Shuler ; Olga Shern > > > > > > > > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default > > > > key and types > > > > > > > > > > > > > - if (src.rss->key_len) { > > > > + if (src.rss->key && src.rss->key_len) { > > > > > > > > but looks like we should conclude this thread first? > > > > Or, does the fix make any sense regardless of having key_len=3D0 or > > > > key=3Dnull for default key? > > > > Having more sanity check is no harm usually... > > > > > > > > > > > > Thanks, > > > > Yongseok > > > > > > > > > > The setfault is the result of commit a4391f8bae ("app/testpmd: set > > > default RSS key as null"). > > > Reverting this commit should fix the segfault but it also means > > > there is no way to set default key (key=3DNULL) with testpmd. > > > Need to check if this is only a testpmd limitation and not all > > > applications limitation. > > > > > > We should decide how an application can set default RSS without > > > knowing anything about keys. > > > > > > > I agree with Adrian that the main criteria should be the length. > > Maybe the set default RSS in testpmd should get new parameter. >=20 > Since [1] was reverted and we seem to agree that a zero key_len should > trigger a PMD-specific default key, this can already be requested with > testpmd by overriding key_len, e.g.: >=20 > flow create 1 pattern eth / end actions rss key_len 0 / end >=20 Not all agree that zero key_len should trigger default key :) The suggestion is to require applications to set both key=3DNULL and key_le= n=3D=3D0. Individual PMDs will have the option to base default RSS on key_len, key or= both. > Using an empty string as the key would yield the same result but cannot b= e > expressed on the command line yet. Note that specifying a key automatical= ly > overrides key_len, so key_len must be forced to 0 last to get PMD default= s: >=20 > flow create 1 pattern eth / end actions rss key foo key_len 0 / end >=20 > Here key_len is set to testpmd's default size when parsing "rss", updated= to > 3 when parsing "key foo" and updated once again when parsing "key_len 0". >=20 > Lastly, while it would make sense for testpmd to use 0 as the default val= ue, > doing so yields inconsistent balancing results between vendors/devices as > they all come with a different key. Same reason as initializing the RSS t= ypes > field to the global rss_hf instead of 0. >=20 > [1] "app/testpmd: revert setting default RSS" >=20 > https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fmai > ls.dpdk.org%2Farchives%2Fdev%2F2018- > November%2F118786.html&data=3D02%7C01%7Cophirmu%40mellanox.c > om%7Ce765a4cb2c8b4bb1547808d6498ba2a5%7Ca652971c7d2e4d9ba6a4d > 149256f461b%7C0%7C0%7C636777261426945159&sdata=3Dk1NXLzaQeK > fp3yptZQsJd6w0NA%2FUVRb8rctLdkDPIv8%3D&reserved=3D0 >=20 > -- > Adrien Mazarguil > 6WIND